SilverStripe\Control\Tests\Middleware\CanonicalURLMiddlewareTest

Complexity

Total Complexity

5

Size/Duplication

Total Lines	91
Duplicated Lines	0 %

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	12	1
A	testMiddlewareDelegateIsReturnedWhenNoBasicAuthIsPresent()	0	12	1
A	testMiddlewareDelegateIsReturnedWhenBasicAuthRedirectIsDisabled()	0	14	1
A	testGetForceBasicAuthToSSL()	0	16	1
A	testHttpsIsForcedForBasicAuth()	0	19	1

<?php

namespace SilverStripe\Control\Tests\Middleware;

use SilverStripe\Control\HTTPRequest;
use SilverStripe\Control\HTTPResponse;
use SilverStripe\Control\Middleware\CanonicalURLMiddleware;
use SilverStripe\Dev\SapphireTest;

class CanonicalURLMiddlewareTest extends SapphireTest
{
    /**
     * Stub middleware class, partially mocked
     *
     * @var CanonicalURLMiddleware
     */
    protected $middleware;

    protected function setUp() : void
    {
        parent::setUp();

        /** @var CanonicalURLMiddleware $middleware */
        $this->middleware = $this->getMockBuilder(CanonicalURLMiddleware::class)

It seems like $this->getMockBuilder(SilverStripe\Control\Middleware\CanonicalURLMiddleware::class)->setMethods(array('getRedirect'))->getMock() of type PHPUnit\Framework\MockObject\MockObject is incompatible with the declared type SilverStripe\Control\Middleware\CanonicalURLMiddleware of property $middleware.

The function PHPUnit\Framework\MockObject\MockBuilder::setMethods() has been deprecated: https://github.com/sebastianbergmann/phpunit/pull/3687

            ->setMethods(['getRedirect'])
            ->getMock();

        $this->middleware->expects($this->any())->method('getRedirect')->willReturn(false);

        $this->middleware->setForceBasicAuthToSSL(true);
    }

    public function testHttpsIsForcedForBasicAuth()
    {
        $this->middleware->expects($this->once())->method('getRedirect');

The method expects() does not exist on SilverStripe\Control\Middleware\CanonicalURLMiddleware.

        $request = new HTTPRequest('GET', '/');
        $mockResponse = (new HTTPResponse)
            ->addHeader('WWW-Authenticate', 'basic')
            ->setStatusCode(401);

        $result = $this->middleware->process($request, function () use ($mockResponse) {
            return $mockResponse;
        });

        $this->assertNotSame($mockResponse, $result, 'New response is created and returned');
        $this->assertEquals(301, $result->getStatusCode(), 'Basic auth responses are redirected');
        $this->assertStringContainsString(
            'https://',
            $result->getHeader('Location'),
            'HTTPS is in the redirect location'
        );
    }

    public function testMiddlewareDelegateIsReturnedWhenBasicAuthRedirectIsDisabled()
    {
        $this->middleware->expects($this->once())->method('getRedirect');
        $this->middleware->setForceBasicAuthToSSL(false);

        $request = new HTTPRequest('GET', '/');
        $mockResponse = (new HTTPResponse)
            ->addHeader('WWW-Authenticate', 'basic')
            ->setStatusCode(401);

        $result = $this->middleware->process($request, function () use ($mockResponse) {
            return $mockResponse;
        });
        $this->assertSame($mockResponse, $result, 'Response returned verbatim with auto redirect disabled');
    }

    public function testMiddlewareDelegateIsReturnedWhenNoBasicAuthIsPresent()
    {
        $this->middleware->expects($this->once())->method('getRedirect');

        $request = new HTTPRequest('GET', '/');
        $mockResponse = (new HTTPResponse)->addHeader('Foo', 'bar');

        $result = $this->middleware->process($request, function () use ($mockResponse) {
            return $mockResponse;
        });

        $this->assertSame($mockResponse, $result, 'Non basic-auth responses are returned verbatim');
    }

    public function testGetForceBasicAuthToSSL()
    {
        $this->middleware->setForceBasicAuthToSSL(null);

        $this->middleware->setForceSSL(true);
        $this->assertTrue($this->middleware->getForceBasicAuthToSSL(), 'Default falls over to forceSSL');

        $this->middleware->setForceSSL(false);
        $this->assertFalse($this->middleware->getForceBasicAuthToSSL(), 'Default falls over to forceSSL');

        $this->middleware->setForceBasicAuthToSSL(true);
        $this->assertTrue($this->middleware->getForceBasicAuthToSSL(), 'Explicitly set is returned');

        $this->middleware->setForceBasicAuthToSSL(false);
        $this->middleware->setForceSSL(true);
        $this->assertFalse($this->middleware->getForceBasicAuthToSSL(), 'Explicitly set is returned');
    }
}