DebugViewTest::testDebugVariable() - Code Metrics - Inspection of "BUG Fix issue with DebugView failing on class name..." - silverstripe/silverstripe-framework - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — 4.0 (#7828)

by Damian

created 2018-02-04 21:48 UTC

DebugViewTest::testDebugVariable() A

↳ Parent: DebugViewTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	58
Code Lines	21

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	21
c	1
b	0
f	0
nc	1
nop	0
dl	0
loc	58
rs	9.639

How to fix Long Method

<?php

namespace SilverStripe\Dev\Tests;

use SilverStripe\Dev\DebugView;
use SilverStripe\Dev\SapphireTest;
use SilverStripe\Dev\Tests\DebugViewTest\ObjectWithDebug;

class DebugViewTest extends SapphireTest
{
    protected $caller = null;

    protected function setUp()
    {
        parent::setUp();

        $this->caller = [
            'line' => 17,
            'file' => __FILE__,
            'args' => [],
            'type' => '->',
            'class' => __CLASS__,
            'function' => __FUNCTION__,
        ];
    }

    public function testDebugVariable()
    {
        $view = new DebugView();
        $this->assertEquals(
            <<<EOS
<div style="background-color: white; text-align: left;">
<hr>
<h3>Debug <span style="font-size: 65%">(DebugViewTest.php:17 - SilverStripe\\Dev\\Tests\\DebugViewTest::setUp())</span>
</h3>
<pre style="font-family: Courier new, serif">string</pre>
</div>
EOS
            ,
            $view->debugVariable('string', $this->caller)
        );

        $this->assertEquals(
            <<<EOS
<div style="background-color: white; text-align: left;">
<hr>
<h3>Debug <span style="font-size: 65%">(DebugViewTest.php:17 - SilverStripe\\Dev\\Tests\\DebugViewTest::setUp())</span>
</h3>
<ul>
<li>key = <pre style="font-family: Courier new, serif">value</pre>
</li>
<li>another = <pre style="font-family: Courier new, serif">text</pre>
</li>
</ul>
</div>
EOS
            ,
            $view->debugVariable([ 'key' => 'value', 'another' => 'text' ], $this->caller)
        );

        $this->assertEquals(
            <<<EOS
<div style="background-color: white; text-align: left;">
<hr>
<h3>Debug <span style="font-size: 65%">(DebugViewTest.php:17 - SilverStripe\\Dev\\Tests\\DebugViewTest::setUp())</span>
</h3>
SilverStripe\\Dev\\Tests\\DebugViewTest\\ObjectWithDebug::debug() custom content</div>
EOS
            ,
            $view->debugVariable(new ObjectWithDebug(), $this->caller)
        );

        $this->assertEquals(
            <<<EOS
<div style="background-color: white; text-align: left;">
<hr>
<h3>Debug <span style="font-size: 65%">(DebugViewTest.php:17 - SilverStripe\\Dev\\Tests\\DebugViewTest::setUp())</span>
</h3>
<pre style="font-family: Courier new, serif">SilverStripe\\Dev\\Tests\\DebugViewTest\\ObjectWithDebug</pre>
</div>
EOS

            ,
            $view->debugVariable(ObjectWithDebug::class, $this->caller)
        );
    }
}


1			<?php
2
3			namespace SilverStripe\Dev\Tests;
4
5			use SilverStripe\Dev\DebugView;
6			use SilverStripe\Dev\SapphireTest;
7			use SilverStripe\Dev\Tests\DebugViewTest\ObjectWithDebug;
8
9			class DebugViewTest extends SapphireTest
10			{
11			protected $caller = null;
12
13			protected function setUp()
14			{
15			parent::setUp();
16
17			$this->caller = [
18			'line' => 17,
19			'file' => __FILE__,
20			'args' => [],
21			'type' => '->',
22			'class' => __CLASS__,
23			'function' => __FUNCTION__,
24			];
25			}
26
27			public function testDebugVariable()
28			{
29			$view = new DebugView();
30			$this->assertEquals(
31			<<<EOS
32			<div style="background-color: white; text-align: left;">
33			<hr>
34			<h3>Debug <span style="font-size: 65%">(DebugViewTest.php:17 - SilverStripe\\Dev\\Tests\\DebugViewTest::setUp())</span>
35			</h3>
36			<pre style="font-family: Courier new, serif">string</pre>
37			</div>
38			EOS
39			,
40			$view->debugVariable('string', $this->caller)
41			);
42
43			$this->assertEquals(
44			<<<EOS
45			<div style="background-color: white; text-align: left;">
46			<hr>
47			<h3>Debug <span style="font-size: 65%">(DebugViewTest.php:17 - SilverStripe\\Dev\\Tests\\DebugViewTest::setUp())</span>
48			</h3>
49			<ul>
50			<li>key = <pre style="font-family: Courier new, serif">value</pre>
51			</li>
52			<li>another = <pre style="font-family: Courier new, serif">text</pre>
53			</li>
54			</ul>
55			</div>
56			EOS
57			,
58			$view->debugVariable([ 'key' => 'value', 'another' => 'text' ], $this->caller)
59			);
60
61			$this->assertEquals(
62			<<<EOS
63			<div style="background-color: white; text-align: left;">
64			<hr>
65			<h3>Debug <span style="font-size: 65%">(DebugViewTest.php:17 - SilverStripe\\Dev\\Tests\\DebugViewTest::setUp())</span>
66			</h3>
67			SilverStripe\\Dev\\Tests\\DebugViewTest\\ObjectWithDebug::debug() custom content</div>
68			EOS
69			,
70			$view->debugVariable(new ObjectWithDebug(), $this->caller)
71			);
72
73			$this->assertEquals(
74			<<<EOS
75			<div style="background-color: white; text-align: left;">
76			<hr>
77			<h3>Debug <span style="font-size: 65%">(DebugViewTest.php:17 - SilverStripe\\Dev\\Tests\\DebugViewTest::setUp())</span>
78			</h3>
79			<pre style="font-family: Courier new, serif">SilverStripe\\Dev\\Tests\\DebugViewTest\\ObjectWithDebug</pre>
80			</div>
81			EOS
82
83			,
84			$view->debugVariable(ObjectWithDebug::class, $this->caller)
85			);
86			}
87			}
88

silverstripe / silverstripe-framework

Pull Request — 4.0 (#7828)

DebugViewTest::testDebugVariable() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like