Completed
Push — master ( f57d6b...d38db3 )
by Ingo
11:07
created
forms/FormAction.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
 
94 94
 	/**
95 95
 	 * @param array $properties
96
-	 * @return string
96
+	 * @return DBHTMLText
97 97
 	 */
98 98
 	public function Field($properties = array()) {
99 99
 		$properties = array_merge(
@@ -158,6 +158,7 @@  discard block
 block discarded – undo
158 158
 	 * Enable or disable the rendering of this action as a <button />
159 159
 	 *
160 160
 	 * @param boolean
161
+	 * @param boolean $bool
161 162
 	 * @return $this
162 163
 	 */
163 164
 	public function setUseButtonTag($bool) {
Please login to merge, or discard this patch.
forms/HiddenField.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@
 block discarded – undo
12 12
 
13 13
 	/**
14 14
 	 * @param array $properties
15
-	 * @return string
15
+	 * @return DBHTMLText
16 16
 	 */
17 17
 	public function FieldHolder($properties = array()) {
18 18
 		return $this->Field($properties);
Please login to merge, or discard this patch.
forms/LookupField.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
 	 *
25 25
 	 * @param array $properties
26 26
 	 *
27
-	 * @return string
27
+	 * @return SilverStripe\ORM\FieldType\DBHTMLText
28 28
 	 */
29 29
 	public function Field($properties = array()) {
30 30
 		$source = ArrayLib::flatten($this->getSource());
Please login to merge, or discard this patch.
forms/TreeDropdownField.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
 	 *
81 81
 	 * @param string $name the field name
82 82
 	 * @param string $title the field label
83
-	 * @param string|array $sourceObject The object-type to list in the tree. This could
83
+	 * @param string $sourceObject The object-type to list in the tree. This could
84 84
 	 * be one of the following:
85 85
 	 * - A DataObject class name with the {@link Hierarchy} extension.
86 86
 	 * - An array of key/value pairs, like a {@link DropdownField} source. In
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
216 216
 
217 217
 	/**
218 218
 	 * @param array $properties
219
-	 * @return string
219
+	 * @return DBHTMLText
220 220
 	 */
221 221
 	public function Field($properties = array()) {
222 222
 		Requirements::add_i18n_javascript(FRAMEWORK_DIR . '/client/lang');
Please login to merge, or discard this patch.
forms/UploadField.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -285,7 +285,7 @@  discard block
 block discarded – undo
285 285
 	/**
286 286
 	 * Determine if the target folder for new uploads in is visible the field UI.
287 287
 	 *
288
-	 * @return boolean
288
+	 * @return boolean|string
289 289
 	 */
290 290
 	public function canPreviewFolder() {
291 291
 		if(!$this->isActive()) return false;
@@ -638,7 +638,7 @@  discard block
 block discarded – undo
638 638
 	/**
639 639
 	 * Determine if the user has permission to upload.
640 640
 	 *
641
-	 * @return boolean
641
+	 * @return boolean|string
642 642
 	 */
643 643
 	public function canUpload() {
644 644
 		if(!$this->isActive()) return false;
@@ -662,7 +662,7 @@  discard block
 block discarded – undo
662 662
 	 * Determine if the user has permission to attach existing files
663 663
 	 * By default returns true if the user has the CMS_ACCESS_AssetAdmin permission
664 664
 	 *
665
-	 * @return boolean
665
+	 * @return boolean|string
666 666
 	 */
667 667
 	public function canAttachExisting() {
668 668
 		if(!$this->isActive()) return false;
@@ -1094,7 +1094,7 @@  discard block
 block discarded – undo
1094 1094
 
1095 1095
 	/**
1096 1096
 	 * @param SS_HTTPRequest $request
1097
-	 * @return UploadField_ItemHandler
1097
+	 * @return UploadField_SelectHandler
1098 1098
 	 */
1099 1099
 	public function handleSelect(SS_HTTPRequest $request) {
1100 1100
 		if(!$this->canAttachExisting()) return $this->httpError(403);
@@ -1457,7 +1457,7 @@  discard block
 block discarded – undo
1457 1457
 	 * Action to handle editing of a single file
1458 1458
 	 *
1459 1459
 	 * @param SS_HTTPRequest $request
1460
-	 * @return ViewableData_Customised
1460
+	 * @return DBHTMLText
1461 1461
 	 */
1462 1462
 	public function edit(SS_HTTPRequest $request) {
1463 1463
 		// Check form field state
Please login to merge, or discard this patch.
ORM/Connect/DBSchemaManager.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -475,7 +475,7 @@
 block discarded – undo
475 475
 	/**
476 476
 	 * Given an index spec determines the index type
477 477
 	 *
478
-	 * @param array|string $spec
478
+	 * @param string $spec
479 479
 	 * @return string
480 480
 	 */
481 481
 	protected function determineIndexType($spec) {
Please login to merge, or discard this patch.
thirdparty/jsmin/jsmin.php 1 patch
Doc Comments   +14 added lines patch added patch discarded remove patch
@@ -59,6 +59,9 @@  discard block
 block discarded – undo
59 59
 
60 60
   // -- Public Static Methods --------------------------------------------------
61 61
 
62
+  /**
63
+   * @param string $js
64
+   */
62 65
   public static function minify($js) {
63 66
     $jsmin = new JSMin($js);
64 67
     return $jsmin->min();
@@ -82,6 +85,10 @@  discard block
 block discarded – undo
82 85
      action treats a string as a single character. Wow!
83 86
      action recognizes a regular expression if it is preceded by ( or , or =.
84 87
   */
88
+
89
+  /**
90
+   * @param integer $d
91
+   */
85 92
   protected function action($d) {
86 93
     switch($d) {
87 94
       case 1:
@@ -160,6 +167,9 @@  discard block
 block discarded – undo
160 167
     }
161 168
   }
162 169
 
170
+  /**
171
+   * @return string
172
+   */
163 173
   protected function get() {
164 174
     $c = $this->lookAhead;
165 175
     $this->lookAhead = null;
@@ -187,6 +197,10 @@  discard block
 block discarded – undo
187 197
   /* isAlphanum -- return true if the character is a letter, digit, underscore,
188 198
         dollar sign, or non-ASCII character.
189 199
   */
200
+
201
+  /**
202
+   * @param string $c
203
+   */
190 204
   protected function isAlphaNum($c) {
191 205
     return ord($c) > 126 || $c === '\\' || preg_match('/^[\w\$]$/', $c) === 1;
192 206
   }
Please login to merge, or discard this patch.
forms/ListboxField.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
 	 *
25 25
 	 * @param array $properties
26 26
 	 *
27
-	 * @return string
27
+	 * @return SilverStripe\ORM\FieldType\DBHTMLText
28 28
 	 */
29 29
 	public function Field($properties = array()) {
30 30
 		$source = ArrayLib::flatten($this->getSource());
Please login to merge, or discard this patch.
view/SSViewer.php 1 patch
Doc Comments   +14 added lines, -5 removed lines patch added patch discarded remove patch
@@ -369,7 +369,6 @@  discard block
 block discarded – undo
369 369
 	/**
370 370
 	 * Returns the modulus of the numerical position of the item in the data set.
371 371
 	 * The count starts from $startIndex, which defaults to 1.
372
-	 * @param int $Mod The number to perform Mod operation to.
373 372
 	 * @param int $startIndex Number to start count from.
374 373
 	 * @return int
375 374
 	 */
@@ -443,6 +442,10 @@  discard block
 block discarded – undo
443 442
 		$this->underlay = $underlay ? $underlay : array();
444 443
 	}
445 444
 
445
+	/**
446
+	 * @param string $interfaceToQuery
447
+	 * @param string $variableMethod
448
+	 */
446 449
 	protected function createCallableArray(&$extraArray, $interfaceToQuery, $variableMethod, $createObject = false) {
447 450
 		$implementers = ClassInfo::implementorsOf($interfaceToQuery);
448 451
 		if($implementers) foreach($implementers as $implementer) {
@@ -843,7 +846,7 @@  discard block
 block discarded – undo
843 846
 	 *
844 847
 	 * @param $className string - valid class name
845 848
 	 * @param $suffix string
846
-	 * @param $baseClass string
849
+	 * @param string $baseClass string
847 850
 	 *
848 851
 	 * @return array
849 852
 	 */
@@ -873,7 +876,7 @@  discard block
 block discarded – undo
873 876
 	}
874 877
 
875 878
 	/**
876
-	 * @param string|array $templateList If passed as a string with .ss extension, used as the "main" template.
879
+	 * @param string|array $templates If passed as a string with .ss extension, used as the "main" template.
877 880
 	 *  If passed as an array, it can be used for template inheritance (first found template "wins").
878 881
 	 *  Usually the array values are PHP class names, which directly correlate to template names.
879 882
 	 *  <code>
@@ -1227,7 +1230,7 @@  discard block
 block discarded – undo
1227 1230
 	 * @param string $template Template name
1228 1231
 	 * @param mixed $data Data context
1229 1232
 	 * @param array $arguments Additional arguments
1230
-	 * @return string Evaluated result
1233
+	 * @return DBHTMLText Evaluated result
1231 1234
 	 */
1232 1235
 	public static function execute_template($template, $data, $arguments = null, $scope = null) {
1233 1236
 		$v = new SSViewer($template);
@@ -1253,6 +1256,9 @@  discard block
 block discarded – undo
1253 1256
 		return $v->process($data, $arguments);
1254 1257
 	}
1255 1258
 
1259
+	/**
1260
+	 * @param string $content
1261
+	 */
1256 1262
 	public function parseTemplateContent($content, $template="") {
1257 1263
 		return $this->getParser()->compileString(
1258 1264
 			$content,
@@ -1282,7 +1288,7 @@  discard block
 block discarded – undo
1282 1288
 	 * Return an appropriate base tag for the given template.
1283 1289
 	 * It will be closed on an XHTML document, and unclosed on an HTML document.
1284 1290
 	 *
1285
-	 * @param $contentGeneratedSoFar The content of the template generated so far; it should contain
1291
+	 * @param string $contentGeneratedSoFar The content of the template generated so far; it should contain
1286 1292
 	 * the DOCTYPE declaration.
1287 1293
 	 */
1288 1294
 	public static function get_base_tag($contentGeneratedSoFar) {
@@ -1323,6 +1329,9 @@  discard block
 block discarded – undo
1323 1329
 	 */
1324 1330
 	protected $cacheTemplate;
1325 1331
 
1332
+	/**
1333
+	 * @param string $content
1334
+	 */
1326 1335
 	public function __construct($content, TemplateParser $parser = null) {
1327 1336
 		if ($parser) {
1328 1337
 			$this->setParser($parser);
Please login to merge, or discard this patch.