Completed
Pull Request — 3.6 (#8821)
by Maxime
07:49
created
model/queries/SQLConditionalExpression.php 1 patch
Doc Comments   -4 removed lines patch added patch discarded remove patch
@@ -374,7 +374,6 @@  discard block
 block discarded – undo
374 374
 	 * @see SQLConditionalExpression::addWhere() for syntax examples
375 375
 	 *
376 376
 	 * @param mixed $where Predicate(s) to set, as escaped SQL statements or paramaterised queries
377
-	 * @param mixed $where,... Unlimited additional predicates
378 377
 	 * @return self Self reference
379 378
 	 */
380 379
 	public function setWhere($where) {
@@ -460,7 +459,6 @@  discard block
 block discarded – undo
460 459
 	 * </code>
461 460
 	 *
462 461
 	 * @param mixed $where Predicate(s) to set, as escaped SQL statements or paramaterised queries
463
-	 * @param mixed $where,... Unlimited additional predicates
464 462
 	 * @return self Self reference
465 463
 	 */
466 464
 	public function addWhere($where) {
@@ -476,7 +474,6 @@  discard block
 block discarded – undo
476 474
 	 * @see SQLConditionalExpression::addWhere()
477 475
 	 *
478 476
 	 * @param mixed $filters Predicate(s) to set, as escaped SQL statements or paramaterised queries
479
-	 * @param mixed $filters,... Unlimited additional predicates
480 477
 	 * @return self Self reference
481 478
 	 */
482 479
 	public function setWhereAny($filters) {
@@ -490,7 +487,6 @@  discard block
 block discarded – undo
490 487
 	 * @see SQLConditionalExpression::addWhere()
491 488
 	 *
492 489
 	 * @param mixed $filters Predicate(s) to set, as escaped SQL statements or paramaterised queries
493
-	 * @param mixed $filters,... Unlimited additional predicates
494 490
 	 * @return self Self reference
495 491
 	 */
496 492
 	public function addWhereAny($filters) {
Please login to merge, or discard this patch.
model/queries/SQLExpression.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -125,7 +125,6 @@
 block discarded – undo
125 125
 	 * Copies the query parameters contained in this object to another
126 126
 	 * SQLExpression
127 127
 	 *
128
-	 * @param SQLExpression $expression The object to copy properties to
129 128
 	 */
130 129
 	protected function copyTo(SQLExpression $object) {
131 130
 		$target = array_keys(get_object_vars($object));
Please login to merge, or discard this patch.
model/queries/SQLSelect.php 1 patch
Doc Comments   +1 added lines, -4 removed lines patch added patch discarded remove patch
@@ -115,7 +115,6 @@  discard block
 block discarded – undo
115 115
 	 * </code>
116 116
 	 *
117 117
 	 * @param string|array $fields Field names should be ANSI SQL quoted. Array keys should be unquoted.
118
-	 * @param boolean $clear Clear existing select fields?
119 118
 	 * @return $this Self reference
120 119
 	 */
121 120
 	public function setSelect($fields) {
@@ -352,7 +351,7 @@  discard block
 block discarded – undo
352 351
 	 *
353 352
 	 * @param string $value
354 353
 	 * @param string $defaultDirection
355
-	 * @return array A two element array: array($column, $direction)
354
+	 * @return string[] A two element array: array($column, $direction)
356 355
 	 */
357 356
 	private function getDirectionFromString($value, $defaultDirection = null) {
358 357
 		if(preg_match('/^(.*)(asc|desc)$/i', $value, $matches)) {
@@ -447,7 +446,6 @@  discard block
 block discarded – undo
447 446
 	 * @see SQLSelect::addWhere() for syntax examples
448 447
 	 *
449 448
 	 * @param mixed $having Predicate(s) to set, as escaped SQL statements or paramaterised queries
450
-	 * @param mixed $having,... Unlimited additional predicates
451 449
 	 * @return self Self reference
452 450
 	 */
453 451
 	public function setHaving($having) {
@@ -462,7 +460,6 @@  discard block
 block discarded – undo
462 460
 	 * @see SQLSelect::addWhere() for syntax examples
463 461
 	 *
464 462
 	 * @param mixed $having Predicate(s) to set, as escaped SQL statements or paramaterised queries
465
-	 * @param mixed $having,... Unlimited additional predicates
466 463
 	 * @return self Self reference
467 464
 	 */
468 465
 	public function addHaving($having) {
Please login to merge, or discard this patch.
parsers/BBCodeParser.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -165,7 +165,7 @@
 block discarded – undo
165 165
 	 * Main BBCode parser method. This takes plain jane content and
166 166
 	 * runs it through so many filters
167 167
 	 *
168
-	 * @return Text
168
+	 * @return string
169 169
 	 */
170 170
 	public function parse() {
171 171
 		$this->content = str_replace(array('&', '<', '>'), array('&amp;', '&lt;', '&gt;'), $this->content);
Please login to merge, or discard this patch.
parsers/HTML/HTMLBBCodeParser.php 1 patch
Doc Comments   +7 added lines, -2 removed lines patch added patch discarded remove patch
@@ -177,6 +177,10 @@  discard block
 block discarded – undo
177 177
 		$this->addFilters($this->_options['filters']);
178 178
 	}
179 179
 
180
+	/**
181
+	 * @param string $class
182
+	 * @param string $var
183
+	 */
180 184
 	static function &getStaticProperty($class, $var)
181 185
 	{
182 186
 		static $properties;
@@ -406,6 +410,7 @@  discard block
 block discarded – undo
406 410
 	 * array as an associative array.
407 411
 	 *
408 412
 	 * @param    string          string to build tag from
413
+	 * @param string $str
409 414
 	 * @return   array           tag in array format
410 415
 	 * @access   private
411 416
 	 * @see      _buildTagArray()
@@ -840,7 +845,7 @@  discard block
 block discarded – undo
840 845
 	/**
841 846
 	 * Quick method to do setText(), parse() and getParsed at once
842 847
 	 *
843
-	 * @return   none
848
+	 * @return   string
844 849
 	 * @access   public
845 850
 	 * @see      parse()
846 851
 	 * @see      $_text
@@ -856,7 +861,7 @@  discard block
 block discarded – undo
856 861
 	/**
857 862
 	 * Quick static method to do setText(), parse() and getParsed at once
858 863
 	 *
859
-	 * @return   none
864
+	 * @return   string
860 865
 	 * @access   public
861 866
 	 * @see      parse()
862 867
 	 * @see      $_text
Please login to merge, or discard this patch.
security/Authenticator.php 1 patch
Doc Comments   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
 	/**
44 44
 	 * Method that creates the login form for this authentication method
45 45
 	 *
46
-	 * @param Controller The parent controller, necessary to create the
46
+	 * @param Controller Controller parent controller, necessary to create the
47 47
 	 *                   appropriate form action tag
48 48
 	 * @return Form Returns the login form to use with this authentication
49 49
 	 *              method
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
 	 * Remove a previously registered authenticator
122 122
 	 *
123 123
 	 * @param string $authenticator Name of the authenticator class to register
124
-	 * @return bool Returns TRUE on success, FALSE otherwise.
124
+	 * @return boolean|null Returns TRUE on success, FALSE otherwise.
125 125
 	 */
126 126
 	public static function unregister_authenticator($authenticator) {
127 127
 		if(call_user_func(array($authenticator, 'on_unregister')) === true) {
@@ -164,6 +164,7 @@  discard block
 block discarded – undo
164 164
 	 * Set a default authenticator (shows first in tabs)
165 165
 	 *
166 166
 	 * @param string
167
+	 * @param string $authenticator
167 168
 	 */
168 169
 	public static function set_default_authenticator($authenticator) {
169 170
 		self::$default_authenticator = $authenticator;
Please login to merge, or discard this patch.
security/CMSSecurity.php 1 patch
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -42,6 +42,9 @@  discard block
 block discarded – undo
42 42
 		);
43 43
 	}
44 44
 
45
+	/**
46
+	 * @param string $action
47
+	 */
45 48
 	public function Link($action = null) {
46 49
 		return Controller::join_links(Director::baseURL(), "CMSSecurity", $action);
47 50
 	}
@@ -57,6 +60,9 @@  discard block
 block discarded – undo
57 60
 		}
58 61
 	}
59 62
 
63
+	/**
64
+	 * @param string $title
65
+	 */
60 66
 	public function getResponseController($title) {
61 67
 		// Use $this to prevent use of Page to render underlying templates
62 68
 		return $this;
@@ -172,6 +178,9 @@  discard block
 block discarded – undo
172 178
 		user_error('Passed invalid authentication method', E_USER_ERROR);
173 179
 	}
174 180
 
181
+	/**
182
+	 * @param string $action
183
+	 */
175 184
 	public function getTemplatesFor($action) {
176 185
 		return array("CMSSecurity_{$action}", "CMSSecurity")
177 186
 			+ parent::getTemplatesFor($action);
Please login to merge, or discard this patch.
security/Group.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -331,6 +331,7 @@
 block discarded – undo
331 331
 	 * Overloaded to ensure the code is always descent.
332 332
 	 *
333 333
 	 * @param string
334
+	 * @param string $val
334 335
 	 */
335 336
 	public function setCode($val){
336 337
 		$this->setField("Code", Convert::raw2url($val));
Please login to merge, or discard this patch.
security/Member.php 1 patch
Doc Comments   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -585,6 +585,8 @@  discard block
 block discarded – undo
585 585
 
586 586
 	/**
587 587
 	 * Utility for generating secure password hashes for this member.
588
+	 * @param string $string
589
+	 * @return string
588 590
 	 */
589 591
 	public function encryptWithUserSettings($string) {
590 592
 		if (!$string) return null;
@@ -735,7 +737,7 @@  discard block
 block discarded – undo
735 737
 	/**
736 738
 	 * Returns the current logged in user
737 739
 	 *
738
-	 * @return Member|null
740
+	 * @return DataObject|null
739 741
 	 */
740 742
 	public static function currentUser() {
741 743
 		$id = Member::currentUserID();
Please login to merge, or discard this patch.