Completed
Pull Request — 3.7 (#8242)
by Sam
09:16
created
parsers/BBCodeParser.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -165,7 +165,7 @@
 block discarded – undo
165 165
 	 * Main BBCode parser method. This takes plain jane content and
166 166
 	 * runs it through so many filters
167 167
 	 *
168
-	 * @return Text
168
+	 * @return string
169 169
 	 */
170 170
 	public function parse() {
171 171
 		$this->content = str_replace(array('&', '<', '>'), array('&amp;', '&lt;', '&gt;'), $this->content);
Please login to merge, or discard this patch.
parsers/HTML/HTMLBBCodeParser.php 1 patch
Doc Comments   +7 added lines, -2 removed lines patch added patch discarded remove patch
@@ -177,6 +177,10 @@  discard block
 block discarded – undo
177 177
 		$this->addFilters($this->_options['filters']);
178 178
 	}
179 179
 
180
+	/**
181
+	 * @param string $class
182
+	 * @param string $var
183
+	 */
180 184
 	static function &getStaticProperty($class, $var)
181 185
 	{
182 186
 		static $properties;
@@ -406,6 +410,7 @@  discard block
 block discarded – undo
406 410
 	 * array as an associative array.
407 411
 	 *
408 412
 	 * @param    string          string to build tag from
413
+	 * @param string $str
409 414
 	 * @return   array           tag in array format
410 415
 	 * @access   private
411 416
 	 * @see      _buildTagArray()
@@ -840,7 +845,7 @@  discard block
 block discarded – undo
840 845
 	/**
841 846
 	 * Quick method to do setText(), parse() and getParsed at once
842 847
 	 *
843
-	 * @return   none
848
+	 * @return   string
844 849
 	 * @access   public
845 850
 	 * @see      parse()
846 851
 	 * @see      $_text
@@ -856,7 +861,7 @@  discard block
 block discarded – undo
856 861
 	/**
857 862
 	 * Quick static method to do setText(), parse() and getParsed at once
858 863
 	 *
859
-	 * @return   none
864
+	 * @return   string
860 865
 	 * @access   public
861 866
 	 * @see      parse()
862 867
 	 * @see      $_text
Please login to merge, or discard this patch.
security/Authenticator.php 1 patch
Doc Comments   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
 	/**
44 44
 	 * Method that creates the login form for this authentication method
45 45
 	 *
46
-	 * @param Controller The parent controller, necessary to create the
46
+	 * @param Controller Controller parent controller, necessary to create the
47 47
 	 *                   appropriate form action tag
48 48
 	 * @return Form Returns the login form to use with this authentication
49 49
 	 *              method
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
 	 * Remove a previously registered authenticator
122 122
 	 *
123 123
 	 * @param string $authenticator Name of the authenticator class to register
124
-	 * @return bool Returns TRUE on success, FALSE otherwise.
124
+	 * @return boolean|null Returns TRUE on success, FALSE otherwise.
125 125
 	 */
126 126
 	public static function unregister_authenticator($authenticator) {
127 127
 		if(call_user_func(array($authenticator, 'on_unregister')) === true) {
@@ -164,6 +164,7 @@  discard block
 block discarded – undo
164 164
 	 * Set a default authenticator (shows first in tabs)
165 165
 	 *
166 166
 	 * @param string
167
+	 * @param string $authenticator
167 168
 	 */
168 169
 	public static function set_default_authenticator($authenticator) {
169 170
 		self::$default_authenticator = $authenticator;
Please login to merge, or discard this patch.
security/Group.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -331,6 +331,7 @@
 block discarded – undo
331 331
 	 * Overloaded to ensure the code is always descent.
332 332
 	 *
333 333
 	 * @param string
334
+	 * @param string $val
334 335
 	 */
335 336
 	public function setCode($val){
336 337
 		$this->setField("Code", Convert::raw2url($val));
Please login to merge, or discard this patch.
security/Member.php 1 patch
Doc Comments   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -585,6 +585,8 @@  discard block
 block discarded – undo
585 585
 
586 586
 	/**
587 587
 	 * Utility for generating secure password hashes for this member.
588
+	 * @param string $string
589
+	 * @return string
588 590
 	 */
589 591
 	public function encryptWithUserSettings($string) {
590 592
 		if (!$string) return null;
@@ -735,7 +737,7 @@  discard block
 block discarded – undo
735 737
 	/**
736 738
 	 * Returns the current logged in user
737 739
 	 *
738
-	 * @return Member|null
740
+	 * @return DataObject|null
739 741
 	 */
740 742
 	public static function currentUser() {
741 743
 		$id = Member::currentUserID();
Please login to merge, or discard this patch.
security/MemberPassword.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -32,6 +32,7 @@
 block discarded – undo
32 32
 	/**
33 33
 	 * Log a password change from the given member.
34 34
 	 * Call MemberPassword::log($this) from within Member whenever the password is changed.
35
+	 * @param Member $member
35 36
 	 */
36 37
 	public static function log($member) {
37 38
 		$record = new MemberPassword();
Please login to merge, or discard this patch.
security/PasswordValidator.php 1 patch
Doc Comments   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -28,6 +28,7 @@  discard block
 block discarded – undo
28 28
 
29 29
 	/**
30 30
 	 * Minimum password length
31
+	 * @param integer $minLength
31 32
 	 */
32 33
 	public function minLength($minLength) {
33 34
 		$this->minLength = $minLength;
@@ -39,8 +40,8 @@  discard block
 block discarded – undo
39 40
 	 *
40 41
 	 * Eg: $this->characterStrength(3, array("lowercase", "uppercase", "digits", "punctuation"))
41 42
 	 *
42
-	 * @param $minScore The minimum number of character tests that must pass
43
-	 * @param $testNames The names of the tests to perform
43
+	 * @param integer $minScore The minimum number of character tests that must pass
44
+	 * @param string[] $testNames The names of the tests to perform
44 45
 	 */
45 46
 	public function characterStrength($minScore, $testNames) {
46 47
 		$this->minScore = $minScore;
@@ -50,6 +51,7 @@  discard block
 block discarded – undo
50 51
 
51 52
 	/**
52 53
 	 * Check a number of previous passwords that the user has used, and don't let them change to that.
54
+	 * @param integer $count
53 55
 	 */
54 56
 	public function checkHistoricalPasswords($count) {
55 57
 		$this->historicalPasswordCount = $count;
Please login to merge, or discard this patch.
security/Permission.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -652,7 +652,7 @@  discard block
 block discarded – undo
652 652
 	 * Recursively traverse the nested list of declared permissions and create
653 653
 	 * a linear list.
654 654
 	 *
655
-	 * @param aeeay $declared Nested structure of permissions.
655
+	 * @param boolean $declared Nested structure of permissions.
656 656
 	 * @param $list List of permissions in the structure. The result will be
657 657
 	 *              written to this array.
658 658
 	 */
@@ -740,7 +740,7 @@  discard block
 block discarded – undo
740 740
 	/**
741 741
 	 * Get permissions
742 742
 	 *
743
-	 * @return array Associative array of permissions in this permission
743
+	 * @return string Associative array of permissions in this permission
744 744
 	 *               group. The array indicies are the permission codes as
745 745
 	 *               used in {@link Permission::check()}. The value is
746 746
 	 *               suitable for using in an interface.
Please login to merge, or discard this patch.
tasks/EncryptAllPasswordsTask.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -66,6 +66,7 @@
 block discarded – undo
66 66
 
67 67
 	/**
68 68
 	 * @todo This should really be taken care of by TestRunner
69
+	 * @param string $msg
69 70
 	 */
70 71
 	protected function debugMessage($msg) {
71 72
 		if(class_exists('SapphireTest', false) && !SapphireTest::is_running_test()) {
Please login to merge, or discard this patch.