Completed
Pull Request — 3.7 (#8242)
by Sam
09:16
created
model/connect/Database.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -385,6 +385,7 @@  discard block
 block discarded – undo
385 385
 	 * - minutes
386 386
 	 * - seconds
387 387
 	 * This includes the singular forms as well
388
+	 * @param string $date
388 389
 	 * @return string SQL datetime expression to query for a datetime (YYYY-MM-DD hh:mm:ss) which is the result of
389 390
 	 *                the addition
390 391
 	 */
@@ -398,6 +399,7 @@  discard block
 block discarded – undo
398 399
 	 *                       e.g. '"SiteTree"."Created"'
399 400
 	 * @param string $date2 to be substracted of $date1, can be either 'now', literal datetime
400 401
 	 *                      like '1973-10-14 10:30:00' or field name, e.g. '"SiteTree"."Created"'
402
+	 * @param string $date1
401 403
 	 * @return string SQL datetime expression to query for the interval between $date1 and $date2 in seconds which
402 404
 	 *                is the result of the substraction
403 405
 	 */
@@ -625,7 +627,7 @@  discard block
 block discarded – undo
625 627
 	 * @param boolean $create Flag indicating whether the database should be created
626 628
 	 * if it doesn't exist. If $create is false and the database doesn't exist
627 629
 	 * then an error will be raised
628
-	 * @param int|boolean $errorLevel The level of error reporting to enable for the query, or false if no error
630
+	 * @param boolean $errorLevel The level of error reporting to enable for the query, or false if no error
629 631
 	 * should be raised
630 632
 	 * @return boolean Flag indicating success
631 633
 	 */
@@ -785,6 +787,7 @@  discard block
 block discarded – undo
785 787
 
786 788
 	/**
787 789
 	 * @deprecated since version 4.0 Use DB::field_list instead
790
+	 * @param string $table
788 791
 	 */
789 792
 	public function fieldList($table) {
790 793
 		Deprecation::notice('4.0', 'Use DB::field_list instead');
Please login to merge, or discard this patch.
model/Image.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -589,7 +589,7 @@  discard block
 block discarded – undo
589 589
 	/**
590 590
 	 * Resize this image for the CMS. Use in templates with $CMSThumbnail
591 591
 	 *
592
-	 * @return Image_Cached|null
592
+	 * @return Image|null
593 593
 	 */
594 594
 	public function CMSThumbnail() {
595 595
 		return $this->Pad($this->stat('cms_thumbnail_width'),$this->stat('cms_thumbnail_height'));
@@ -631,7 +631,7 @@  discard block
 block discarded – undo
631 631
 	/**
632 632
 	 * Resize this image for use as a thumbnail in a strip. Use in templates with $StripThumbnail.
633 633
 	 *
634
-	 * @return Image_Cached|null
634
+	 * @return Image|null
635 635
 	 */
636 636
 	public function StripThumbnail() {
637 637
 		return $this->Fill($this->stat('strip_thumbnail_width'),$this->stat('strip_thumbnail_height'));
@@ -868,7 +868,7 @@  discard block
 block discarded – undo
868 868
 	/**
869 869
 	 * Generate patterns that will help to match filenames of cached images
870 870
 	 * @param string $filename Filename of source image
871
-	 * @return array
871
+	 * @return string
872 872
 	 */
873 873
 	private function getFilenamePatterns($filename) {
874 874
 		$methodNames = $this->allMethodNames(true);
@@ -1024,7 +1024,7 @@  discard block
 block discarded – undo
1024 1024
 
1025 1025
 	/**
1026 1026
 	 * Get the orientation of this image.
1027
-	 * @return ORIENTATION_SQUARE | ORIENTATION_PORTRAIT | ORIENTATION_LANDSCAPE
1027
+	 * @return integer | ORIENTATION_PORTRAIT | ORIENTATION_LANDSCAPE
1028 1028
 	 */
1029 1029
 	public function getOrientation() {
1030 1030
 		$width = $this->getWidth();
Please login to merge, or discard this patch.
oembed/Oembed.php 1 patch
Doc Comments   +6 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,6 +46,7 @@  discard block
 block discarded – undo
46 46
 	 *
47 47
 	 * @param $url Human-readable URL.
48 48
 	 * @returns string/bool URL of an endpoint, or false if no matching provider exists.
49
+	 * @return string
49 50
 	 */
50 51
 	protected static function find_endpoint($url) {
51 52
 		foreach(self::get_providers() as $scheme=>$endpoint) {
@@ -117,7 +118,7 @@  discard block
 block discarded – undo
117 118
 	 * Given a response body, determine if there is an autodiscover url
118 119
 	 *
119 120
 	 * @param string $body
120
-	 * @return bool|string
121
+	 * @return string|false
121 122
 	 */
122 123
 	public static function autodiscover_from_body($body) {
123 124
 		// Look within the body for an oembed link.
@@ -259,6 +260,9 @@  discard block
 block discarded – undo
259 260
 		parent::__construct();
260 261
 	}
261 262
 
263
+	/**
264
+	 * @return string
265
+	 */
262 266
 	public function getOembedURL() {
263 267
 		return $this->url;
264 268
 	}
@@ -343,6 +347,7 @@  discard block
 block discarded – undo
343 347
 
344 348
 	/**
345 349
 	 * Wrap the check for looking into Oembed JSON within $this->data.
350
+	 * @param string $field
346 351
 	 */
347 352
 	public function hasField($field) {
348 353
 		$this->loadData();
Please login to merge, or discard this patch.
thirdparty/Zend/Cache/Backend/Xcache.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -140,7 +140,7 @@
 block discarded – undo
140 140
      * @param  string $mode clean mode
141 141
      * @param  array  $tags array of tags
142 142
      * @throws Zend_Cache_Exception
143
-     * @return boolean true if no problem
143
+     * @return boolean|null true if no problem
144 144
      */
145 145
     public function clean($mode = Zend_Cache::CLEANING_MODE_ALL, $tags = array())
146 146
     {
Please login to merge, or discard this patch.
control/ContentNegotiator.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -97,6 +97,7 @@
 block discarded – undo
97 97
 	/**
98 98
 	 * Returns true if negotation is enabled for the given response.
99 99
 	 * By default, negotiation is only enabled for pages that have the xml header.
100
+	 * @param SS_HTTPResponse $response
100 101
 	 */
101 102
 	public static function enabled_for($response) {
102 103
 		$contentType = $response->getHeader("Content-Type");
Please login to merge, or discard this patch.
dev/Debug.php 1 patch
Doc Comments   +14 added lines, -7 removed lines patch added patch discarded remove patch
@@ -226,6 +226,12 @@  discard block
 block discarded – undo
226 226
 		set_exception_handler('exceptionHandler');
227 227
 	}
228 228
 
229
+	/**
230
+	 * @param integer $errno
231
+	 * @param string $errstr
232
+	 * @param string $errfile
233
+	 * @param integer $errline
234
+	 */
229 235
 	public static function noticeHandler($errno, $errstr, $errfile, $errline, $errcontext) {
230 236
 		if(error_reporting() == 0) return;
231 237
 		ini_set('display_errors', 0);
@@ -252,10 +258,10 @@  discard block
 block discarded – undo
252 258
 	/**
253 259
 	 * Handle a non-fatal warning error thrown by PHP interpreter.
254 260
 	 *
255
-	 * @param unknown_type $errno
256
-	 * @param unknown_type $errstr
257
-	 * @param unknown_type $errfile
258
-	 * @param unknown_type $errline
261
+	 * @param integer $errno
262
+	 * @param string $errstr
263
+	 * @param string $errfile
264
+	 * @param integer $errline
259 265
 	 * @param unknown_type $errcontext
260 266
 	 */
261 267
 	public static function warningHandler($errno, $errstr, $errfile, $errline, $errcontext) {
@@ -286,8 +292,8 @@  discard block
 block discarded – undo
286 292
 	 *
287 293
 	 * Runtime execution dies immediately once the error is generated.
288 294
 	 *
289
-	 * @param unknown_type $errno
290
-	 * @param unknown_type $errstr
295
+	 * @param integer $errno
296
+	 * @param string $errstr
291 297
 	 * @param unknown_type $errfile
292 298
 	 * @param unknown_type $errline
293 299
 	 * @param unknown_type $errcontext
@@ -327,7 +333,7 @@  discard block
 block discarded – undo
327 333
 	 *                                     or "tech-speak". Used in the HTTP Header and ajax responses.
328 334
 	 * @param string $friendlyErrorDetail Detailed user-focused message. Is just used if no {@link ErrorPage} is found
329 335
 	 *                                    for this specific status code.
330
-	 * @return string HTML error message for non-ajax requests, plaintext for ajax-request.
336
+	 * @return boolean HTML error message for non-ajax requests, plaintext for ajax-request.
331 337
 	 */
332 338
 	public static function friendlyError($statusCode=500, $friendlyErrorMessage=null, $friendlyErrorDetail=null) {
333 339
 		// Ensure the error message complies with the HTTP 1.1 spec
@@ -399,6 +405,7 @@  discard block
 block discarded – undo
399 405
 	 * @param unknown_type $errfile
400 406
 	 * @param unknown_type $errline
401 407
 	 * @param unknown_type $errcontext
408
+	 * @param string $errtype
402 409
 	 */
403 410
 	public static function showError($errno, $errstr, $errfile, $errline, $errcontext, $errtype) {
404 411
 		if(!headers_sent()) {
Please login to merge, or discard this patch.
dev/FixtureFactory.php 1 patch
Doc Comments   +5 added lines, -4 removed lines patch added patch discarded remove patch
@@ -117,6 +117,7 @@  discard block
 block discarded – undo
117 117
 	/**
118 118
 	 * Return all of the IDs in the fixture of a particular class name.
119 119
 	 *
120
+	 * @param string $class
120 121
 	 * @return A map of fixture-identifier => object-id
121 122
 	 */
122 123
 	public function getIds($class) {
@@ -131,6 +132,7 @@  discard block
 block discarded – undo
131 132
 	 * @param String
132 133
 	 * @param String $identifier
133 134
 	 * @param Int $databaseId
135
+	 * @param string $class
134 136
 	 */
135 137
 	public function setId($class, $identifier, $databaseId) {
136 138
 		$this->fixtures[$class][$identifier] = $databaseId;
@@ -140,8 +142,8 @@  discard block
 block discarded – undo
140 142
 	/**
141 143
 	 * Get an object from the fixture.
142 144
 	 *
143
-	 * @param $class The data class, as specified in your fixture file.  Parent classes won't work
144
-	 * @param $identifier The identifier string, as provided in your fixture file
145
+	 * @param string $class The data class, as specified in your fixture file.  Parent classes won't work
146
+	 * @param string $identifier The identifier string, as provided in your fixture file
145 147
 	 */
146 148
 	public function get($class, $identifier) {
147 149
 		$id = $this->getId($class, $identifier);
@@ -161,7 +163,7 @@  discard block
 block discarded – undo
161 163
 	 * or {@link createRaw()}, both from the internal fixture mapping and the database.
162 164
 	 * If the $class argument is set, limit clearing to items of this class.
163 165
 	 *
164
-	 * @param String $class
166
+	 * @param string $limitToClass
165 167
 	 */
166 168
 	public function clear($limitToClass = null) {
167 169
 		$classes = ($limitToClass) ? array($limitToClass) : array_keys($this->fixtures);
@@ -202,7 +204,6 @@  discard block
 block discarded – undo
202 204
 	 * Parse a value from a fixture file.  If it starts with =>
203 205
 	 * it will get an ID from the fixture dictionary
204 206
 	 *
205
-	 * @param String $fieldVal
206 207
 	 * @return String Fixture database ID, or the original value
207 208
 	 */
208 209
 	protected function parseValue($value) {
Please login to merge, or discard this patch.
filesystem/Folder.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@
 block discarded – undo
42 42
 	 *
43 43
 	 * @param $folderPath string Absolute or relative path to the file.
44 44
 	 *  If path is relative, its interpreted relative to the "assets/" directory.
45
-	 * @return Folder|null
45
+	 * @return null|DataObject
46 46
 	 */
47 47
 	public static function find_or_make($folderPath) {
48 48
 		// Create assets directory, if it is missing
Please login to merge, or discard this patch.
i18n/i18nTextCollector.php 1 patch
Doc Comments   +6 added lines, -1 removed lines patch added patch discarded remove patch
@@ -709,7 +709,8 @@  discard block
 block discarded – undo
709 709
 	 * Input for langArrayCodeForEntitySpec() should be suitable for insertion
710 710
 	 * into single-quoted strings, so needs to be escaped already.
711 711
 	 *
712
-	 * @param string $entity The entity name, e.g. CMSMain.BUTTONSAVE
712
+	 * @param string $entitySpec The entity name, e.g. CMSMain.BUTTONSAVE
713
+	 * @param string $locale
713 714
 	 */
714 715
 	public function langArrayCodeForEntitySpec($entityFullName, $entitySpec, $locale) {
715 716
 		$php = '';
@@ -772,6 +773,9 @@  discard block
 block discarded – undo
772 773
 		return true;
773 774
 	}
774 775
 
776
+	/**
777
+	 * @param string $locale
778
+	 */
775 779
 	public function getYaml($entities, $locale) {
776 780
 		// Use the Zend copy of this script to prevent class conflicts when RailsYaml is included
777 781
 		require_once 'thirdparty/zend_translate_railsyaml/library/Translate/Adapter/thirdparty/sfYaml/lib'
@@ -846,6 +850,7 @@  discard block
 block discarded – undo
846 850
 
847 851
 	/**
848 852
 	 * Parses a template and returns any translatable entities
853
+	 * @param string $template
849 854
 	 */
850 855
 	public static function GetTranslatables($template) {
851 856
 		self::$entities = array();
Please login to merge, or discard this patch.