Completed
Pull Request — 3 (#8026)
by Damian
08:28
created
security/CMSSecurity.php 1 patch
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -42,6 +42,9 @@  discard block
 block discarded – undo
42 42
 		);
43 43
 	}
44 44
 
45
+	/**
46
+	 * @param string $action
47
+	 */
45 48
 	public function Link($action = null) {
46 49
 		$link = Controller::join_links(Director::baseURL(), "CMSSecurity", $action);
47 50
 		// Give extensions the chance to modify by reference
@@ -60,6 +63,9 @@  discard block
 block discarded – undo
60 63
 		}
61 64
 	}
62 65
 
66
+	/**
67
+	 * @param string $title
68
+	 */
63 69
 	public function getResponseController($title) {
64 70
 		// Use $this to prevent use of Page to render underlying templates
65 71
 		return $this;
@@ -175,6 +181,9 @@  discard block
 block discarded – undo
175 181
 		user_error('Passed invalid authentication method', E_USER_ERROR);
176 182
 	}
177 183
 
184
+	/**
185
+	 * @param string $action
186
+	 */
178 187
 	public function getTemplatesFor($action) {
179 188
 		return array("CMSSecurity_{$action}", "CMSSecurity")
180 189
 			+ parent::getTemplatesFor($action);
Please login to merge, or discard this patch.
control/RequestHandler.php 1 patch
Doc Comments   +6 added lines, -1 removed lines patch added patch discarded remove patch
@@ -129,6 +129,7 @@  discard block
 block discarded – undo
129 129
 
130 130
 	/**
131 131
 	 * Set the DataModel for this request.
132
+	 * @param DataModel $model
132 133
 	 */
133 134
 	public function setDataModel($model) {
134 135
 		$this->model = $model;
@@ -246,6 +247,9 @@  discard block
 block discarded – undo
246 247
 		return $this;
247 248
 	}
248 249
 
250
+	/**
251
+	 * @param SS_HTTPRequest $request
252
+	 */
249 253
 	protected function findAction($request) {
250 254
 		$handlerClass = ($this->class) ? $this->class : get_class($this);
251 255
 
@@ -392,6 +396,7 @@  discard block
 block discarded – undo
392 396
 
393 397
 	/**
394 398
 	 * Return the class that defines the given action, so that we know where to check allowed_actions.
399
+	 * @return string|null
395 400
 	 */
396 401
 	protected function definingClassForAction($actionOrigCasing) {
397 402
 		$action = strtolower($actionOrigCasing);
@@ -500,6 +505,7 @@  discard block
 block discarded – undo
500 505
 	 * or {@link handleRequest()}, but in some based we want to set it manually.
501 506
 	 *
502 507
 	 * @param SS_HTTPRequest
508
+	 * @param SS_HTTPRequest $request
503 509
 	 */
504 510
 	public function setRequest($request) {
505 511
 		$this->request = $request;
@@ -508,7 +514,6 @@  discard block
 block discarded – undo
508 514
 	/**
509 515
 	 * Returns a link to this controller.  Overload with your own Link rules if they exist.
510 516
 	 *
511
-	 * @param string $action Optional action (soft-supported via func_get_args)
512 517
 	 * @return string
513 518
 	 */
514 519
 	public function Link() {
Please login to merge, or discard this patch.