silverstripe /
silverstripe-framework
| Total Complexity | 89 |
| Total Lines | 665 |
| Duplicated Lines | 0 % |
| Changes | 0 | ||
Complex classes like Group often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Group, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 56 | class Group extends DataObject |
||
| 57 | { |
||
| 58 | |||
| 59 | private static $db = [ |
||
| 60 | "Title" => "Varchar(255)", |
||
| 61 | "Description" => "Text", |
||
| 62 | "Code" => "Varchar(255)", |
||
| 63 | "Locked" => "Boolean", |
||
| 64 | "Sort" => "Int", |
||
| 65 | "HtmlEditorConfig" => "Text" |
||
| 66 | ]; |
||
| 67 | |||
| 68 | private static $has_one = [ |
||
| 69 | "Parent" => Group::class, |
||
| 70 | ]; |
||
| 71 | |||
| 72 | private static $has_many = [ |
||
| 73 | "Permissions" => Permission::class, |
||
| 74 | "Groups" => Group::class, |
||
| 75 | ]; |
||
| 76 | |||
| 77 | private static $many_many = [ |
||
| 78 | "Members" => Member::class, |
||
| 79 | "Roles" => PermissionRole::class, |
||
| 80 | ]; |
||
| 81 | |||
| 82 | private static $extensions = [ |
||
| 83 | Hierarchy::class, |
||
| 84 | ]; |
||
| 85 | |||
| 86 | private static $table_name = "Group"; |
||
| 87 | |||
| 88 | public function getAllChildren() |
||
| 89 | { |
||
| 90 | $doSet = new ArrayList(); |
||
| 91 | |||
| 92 | $children = Group::get()->filter("ParentID", $this->ID); |
||
| 93 | /** @var Group $child */ |
||
| 94 | foreach ($children as $child) { |
||
| 95 | $doSet->push($child); |
||
| 96 | $doSet->merge($child->getAllChildren()); |
||
| 97 | } |
||
| 98 | |||
| 99 | return $doSet; |
||
| 100 | } |
||
| 101 | |||
| 102 | private function getDecodedBreadcrumbs() |
||
| 103 | { |
||
| 104 | $list = Group::get()->exclude('ID', $this->ID); |
||
| 105 | $groups = ArrayList::create(); |
||
| 106 | foreach ($list as $group) { |
||
| 107 | $groups->push(['ID' => $group->ID, 'Title' => $group->getBreadcrumbs(' » ')]); |
||
| 108 | } |
||
| 109 | return $groups; |
||
| 110 | } |
||
| 111 | |||
| 112 | /** |
||
| 113 | * Caution: Only call on instances, not through a singleton. |
||
| 114 | * The "root group" fields will be created through {@link SecurityAdmin->EditForm()}. |
||
| 115 | * |
||
| 116 | * @skipUpgrade |
||
| 117 | * @return FieldList |
||
| 118 | */ |
||
| 119 | public function getCMSFields() |
||
| 282 | } |
||
| 283 | |||
| 284 | /** |
||
| 285 | * @param bool $includerelations Indicate if the labels returned include relation fields |
||
| 286 | * @return array |
||
| 287 | * @skipUpgrade |
||
| 288 | */ |
||
| 289 | public function fieldLabels($includerelations = true) |
||
| 290 | { |
||
| 291 | $labels = parent::fieldLabels($includerelations); |
||
| 292 | $labels['Title'] = _t(__CLASS__ . '.GROUPNAME', 'Group name'); |
||
| 293 | $labels['Description'] = _t('SilverStripe\\Security\\Group.Description', 'Description'); |
||
| 294 | $labels['Code'] = _t('SilverStripe\\Security\\Group.Code', 'Group Code', 'Programmatical code identifying a group'); |
||
| 295 | $labels['Locked'] = _t('SilverStripe\\Security\\Group.Locked', 'Locked?', 'Group is locked in the security administration area'); |
||
| 296 | $labels['Sort'] = _t('SilverStripe\\Security\\Group.Sort', 'Sort Order'); |
||
| 297 | if ($includerelations) { |
||
| 298 | $labels['Parent'] = _t('SilverStripe\\Security\\Group.Parent', 'Parent Group', 'One group has one parent group'); |
||
| 299 | $labels['Permissions'] = _t('SilverStripe\\Security\\Group.has_many_Permissions', 'Permissions', 'One group has many permissions'); |
||
| 300 | $labels['Members'] = _t('SilverStripe\\Security\\Group.many_many_Members', 'Members', 'One group has many members'); |
||
| 301 | } |
||
| 302 | |||
| 303 | return $labels; |
||
| 304 | } |
||
| 305 | |||
| 306 | /** |
||
| 307 | * Get many-many relation to {@link Member}, |
||
| 308 | * including all members which are "inherited" from children groups of this record. |
||
| 309 | * See {@link DirectMembers()} for retrieving members without any inheritance. |
||
| 310 | * |
||
| 311 | * @param string $filter |
||
| 312 | * @return ManyManyList |
||
| 313 | */ |
||
| 314 | public function Members($filter = '') |
||
| 315 | { |
||
| 316 | // First get direct members as a base result |
||
| 317 | $result = $this->DirectMembers(); |
||
| 318 | |||
| 319 | // Unsaved group cannot have child groups because its ID is still 0. |
||
| 320 | if (!$this->exists()) { |
||
| 321 | return $result; |
||
| 322 | } |
||
| 323 | |||
| 324 | // Remove the default foreign key filter in prep for re-applying a filter containing all children groups. |
||
| 325 | // Filters are conjunctive in DataQuery by default, so this filter would otherwise overrule any less specific |
||
| 326 | // ones. |
||
| 327 | if (!($result instanceof UnsavedRelationList)) { |
||
| 328 | $result = $result->alterDataQuery(function ($query) { |
||
| 329 | /** @var DataQuery $query */ |
||
| 330 | $query->removeFilterOn('Group_Members'); |
||
| 331 | }); |
||
| 332 | } |
||
| 333 | |||
| 334 | // Now set all children groups as a new foreign key |
||
| 335 | $familyIDs = $this->collateFamilyIDs(); |
||
| 336 | $result = $result->forForeignID($familyIDs); |
||
| 337 | |||
| 338 | return $result->where($filter); |
||
| 339 | } |
||
| 340 | |||
| 341 | /** |
||
| 342 | * Return only the members directly added to this group |
||
| 343 | */ |
||
| 344 | public function DirectMembers() |
||
| 345 | { |
||
| 346 | return $this->getManyManyComponents('Members'); |
||
| 347 | } |
||
| 348 | |||
| 349 | /** |
||
| 350 | * Return a set of this record's "family" of IDs - the IDs of |
||
| 351 | * this record and all its descendants. |
||
| 352 | * |
||
| 353 | * @return array |
||
| 354 | */ |
||
| 355 | public function collateFamilyIDs() |
||
| 356 | { |
||
| 357 | if (!$this->exists()) { |
||
| 358 | throw new \InvalidArgumentException("Cannot call collateFamilyIDs on unsaved Group."); |
||
| 359 | } |
||
| 360 | |||
| 361 | $familyIDs = []; |
||
| 362 | $chunkToAdd = [$this->ID]; |
||
| 363 | |||
| 364 | while ($chunkToAdd) { |
||
| 365 | $familyIDs = array_merge($familyIDs, $chunkToAdd); |
||
| 366 | |||
| 367 | // Get the children of *all* the groups identified in the previous chunk. |
||
| 368 | // This minimises the number of SQL queries necessary |
||
| 369 | $chunkToAdd = Group::get()->filter("ParentID", $chunkToAdd)->column('ID'); |
||
| 370 | } |
||
| 371 | |||
| 372 | return $familyIDs; |
||
| 373 | } |
||
| 374 | |||
| 375 | /** |
||
| 376 | * Returns an array of the IDs of this group and all its parents |
||
| 377 | * |
||
| 378 | * @return array |
||
| 379 | */ |
||
| 380 | public function collateAncestorIDs() |
||
| 381 | { |
||
| 382 | $parent = $this; |
||
| 383 | $items = []; |
||
| 384 | while ($parent instanceof Group) { |
||
| 385 | $items[] = $parent->ID; |
||
| 386 | $parent = $parent->getParent(); |
||
| 387 | } |
||
| 388 | return $items; |
||
| 389 | } |
||
| 390 | |||
| 391 | /** |
||
| 392 | * Check if the group is a child of the given group or any parent groups |
||
| 393 | * |
||
| 394 | * @param string|int|Group $group Group instance, Group Code or ID |
||
| 395 | * @return bool Returns TRUE if the Group is a child of the given group, otherwise FALSE |
||
| 396 | */ |
||
| 397 | public function inGroup($group) |
||
| 398 | { |
||
| 399 | return in_array($this->identifierToGroupID($group), $this->collateAncestorIDs()); |
||
| 400 | } |
||
| 401 | |||
| 402 | /** |
||
| 403 | * Check if the group is a child of the given groups or any parent groups |
||
| 404 | * |
||
| 405 | * @param (string|int|Group)[] $groups |
||
| 406 | * @param bool $requireAll set to TRUE if must be in ALL groups, or FALSE if must be in ANY |
||
| 407 | * @return bool Returns TRUE if the Group is a child of any of the given groups, otherwise FALSE |
||
| 408 | */ |
||
| 409 | public function inGroups($groups, $requireAll = false) |
||
| 429 | } |
||
| 430 | |||
| 431 | /** |
||
| 432 | * Turn a string|int|Group into a GroupID |
||
| 433 | * |
||
| 434 | * @param string|int|Group $groupID Group instance, Group Code or ID |
||
| 435 | * @return int|null the Group ID or NULL if not found |
||
| 436 | */ |
||
| 437 | protected function identifierToGroupID($groupID) |
||
| 438 | { |
||
| 439 | if (is_numeric($groupID) && Group::get()->byID($groupID)) { |
||
| 440 | return $groupID; |
||
| 441 | } elseif (is_string($groupID) && $groupByCode = Group::get()->filter(['Code' => $groupID])->first()) { |
||
| 442 | return $groupByCode->ID; |
||
| 443 | } elseif ($groupID instanceof Group && $groupID->exists()) { |
||
| 444 | return $groupID->ID; |
||
| 445 | } |
||
| 446 | return null; |
||
| 447 | } |
||
| 448 | |||
| 449 | /** |
||
| 450 | * This isn't a descendant of SiteTree, but needs this in case |
||
| 451 | * the group is "reorganised"; |
||
| 452 | */ |
||
| 453 | public function cmsCleanup_parentChanged() |
||
| 454 | { |
||
| 455 | } |
||
| 456 | |||
| 457 | /** |
||
| 458 | * Override this so groups are ordered in the CMS |
||
| 459 | */ |
||
| 460 | public function stageChildren() |
||
| 461 | { |
||
| 462 | return Group::get() |
||
| 463 | ->filter("ParentID", $this->ID) |
||
| 464 | ->exclude("ID", $this->ID) |
||
| 465 | ->sort('"Sort"'); |
||
| 466 | } |
||
| 467 | |||
| 468 | /** |
||
| 469 | * @return string |
||
| 470 | */ |
||
| 471 | public function getTreeTitle() |
||
| 472 | { |
||
| 473 | $title = htmlspecialchars($this->Title, ENT_QUOTES); |
||
| 474 | $this->extend('updateTreeTitle', $title); |
||
| 475 | return $title; |
||
| 476 | } |
||
| 477 | |||
| 478 | /** |
||
| 479 | * Overloaded to ensure the code is always descent. |
||
| 480 | * |
||
| 481 | * @param string $val |
||
| 482 | */ |
||
| 483 | public function setCode($val) |
||
| 486 | } |
||
| 487 | |||
| 488 | public function validate() |
||
| 489 | { |
||
| 490 | $result = parent::validate(); |
||
| 491 | |||
| 492 | // Check if the new group hierarchy would add certain "privileged permissions", |
||
| 493 | // and require an admin to perform this change in case it does. |
||
| 494 | // This prevents "sub-admin" users with group editing permissions to increase their privileges. |
||
| 495 | if ($this->Parent()->exists() && !Permission::check('ADMIN')) { |
||
| 496 | $inheritedCodes = Permission::get() |
||
| 497 | ->filter('GroupID', $this->Parent()->collateAncestorIDs()) |
||
| 498 | ->column('Code'); |
||
| 499 | $privilegedCodes = Permission::config()->get('privileged_permissions'); |
||
| 500 | if (array_intersect($inheritedCodes, $privilegedCodes)) { |
||
| 501 | $result->addError( |
||
| 502 | _t( |
||
| 503 | 'SilverStripe\\Security\\Group.HierarchyPermsError', |
||
| 504 | 'Can\'t assign parent group "{group}" with privileged permissions (requires ADMIN access)', |
||
| 505 | ['group' => $this->Parent()->Title] |
||
| 506 | ) |
||
| 507 | ); |
||
| 508 | } |
||
| 509 | } |
||
| 510 | |||
| 511 | $currentGroups = Group::get() |
||
| 512 | ->filter('ID:not', $this->ID) |
||
| 513 | ->map('Code', 'Title') |
||
| 514 | ->toArray(); |
||
| 515 | |||
| 516 | if (in_array($this->Title, $currentGroups)) { |
||
| 517 | $result->addError( |
||
| 518 | _t( |
||
| 519 | 'SilverStripe\\Security\\Group.ValidationIdentifierAlreadyExists', |
||
| 520 | 'A Group ({group}) already exists with the same {identifier}', |
||
| 521 | ['group' => $this->Title, 'identifier' => 'Title'] |
||
| 522 | ) |
||
| 523 | ); |
||
| 524 | } |
||
| 525 | |||
| 526 | return $result; |
||
| 527 | } |
||
| 528 | |||
| 529 | public function getCMSCompositeValidator(): CompositeValidator |
||
| 530 | { |
||
| 531 | $validator = parent::getCMSCompositeValidator(); |
||
| 532 | |||
| 533 | $validator->addValidator(RequiredFields::create([ |
||
| 534 | 'Title' |
||
| 535 | ])); |
||
| 536 | |||
| 537 | return $validator; |
||
| 538 | } |
||
| 539 | |||
| 540 | public function onBeforeWrite() |
||
| 541 | { |
||
| 542 | parent::onBeforeWrite(); |
||
| 543 | |||
| 544 | // Only set code property when the group has a custom title, and no code exists. |
||
| 545 | // The "Code" attribute is usually treated as a more permanent identifier than database IDs |
||
| 546 | // in custom application logic, so can't be changed after its first set. |
||
| 547 | if (!$this->Code && $this->Title != _t(__CLASS__ . '.NEWGROUP', "New Group")) { |
||
| 548 | $this->setCode($this->Title); |
||
| 549 | } |
||
| 550 | |||
| 551 | // Make sure the code for this group is unique. |
||
| 552 | // TODO in a future major version we should move this to validate() and throw a |
||
| 553 | // validation error for duplicates. |
||
| 554 | $currentGroups = Group::get() |
||
| 555 | ->exclude('ID', $this->ID) |
||
| 556 | ->map('Code', 'Title') |
||
| 557 | ->toArray(); |
||
| 558 | $code = $this->Code; |
||
| 559 | $count = 2; |
||
| 560 | while (isset($currentGroups[$code])) { |
||
| 561 | $code = $this->Code . '-' . $count; |
||
| 562 | $count++; |
||
| 563 | } |
||
| 564 | $this->setField("Code", $code); |
||
| 565 | } |
||
| 566 | |||
| 567 | public function onBeforeDelete() |
||
| 579 | } |
||
| 580 | } |
||
| 581 | |||
| 582 | /** |
||
| 583 | * Checks for permission-code CMS_ACCESS_SecurityAdmin. |
||
| 584 | * If the group has ADMIN permissions, it requires the user to have ADMIN permissions as well. |
||
| 585 | * |
||
| 586 | * @param Member $member Member |
||
| 587 | * @return boolean |
||
| 588 | */ |
||
| 589 | public function canEdit($member = null) |
||
| 590 | { |
||
| 591 | if (!$member) { |
||
| 592 | $member = Security::getCurrentUser(); |
||
| 593 | } |
||
| 594 | |||
| 595 | // extended access checks |
||
| 596 | $results = $this->extend('canEdit', $member); |
||
| 597 | if ($results && is_array($results)) { |
||
| 598 | if (!min($results)) { |
||
| 599 | return false; |
||
| 600 | } |
||
| 601 | } |
||
| 602 | |||
| 603 | if (// either we have an ADMIN |
||
| 604 | (bool)Permission::checkMember($member, "ADMIN") |
||
| 605 | || ( |
||
| 606 | // or a privileged CMS user and a group without ADMIN permissions. |
||
| 607 | // without this check, a user would be able to add himself to an administrators group |
||
| 608 | // with just access to the "Security" admin interface |
||
| 609 | Permission::checkMember($member, "CMS_ACCESS_SecurityAdmin") && |
||
| 610 | !Permission::get()->filter(['GroupID' => $this->ID, 'Code' => 'ADMIN'])->exists() |
||
| 611 | ) |
||
| 612 | ) { |
||
| 613 | return true; |
||
| 614 | } |
||
| 615 | |||
| 616 | return false; |
||
| 617 | } |
||
| 618 | |||
| 619 | /** |
||
| 620 | * Checks for permission-code CMS_ACCESS_SecurityAdmin. |
||
| 621 | * |
||
| 622 | * @param Member $member |
||
| 623 | * @return boolean |
||
| 624 | */ |
||
| 625 | public function canView($member = null) |
||
| 626 | { |
||
| 627 | if (!$member) { |
||
| 628 | $member = Security::getCurrentUser(); |
||
| 629 | } |
||
| 630 | |||
| 631 | // extended access checks |
||
| 632 | $results = $this->extend('canView', $member); |
||
| 633 | if ($results && is_array($results)) { |
||
| 634 | if (!min($results)) { |
||
| 635 | return false; |
||
| 636 | } |
||
| 637 | } |
||
| 638 | |||
| 639 | // user needs access to CMS_ACCESS_SecurityAdmin |
||
| 640 | if (Permission::checkMember($member, "CMS_ACCESS_SecurityAdmin")) { |
||
| 641 | return true; |
||
| 642 | } |
||
| 643 | |||
| 644 | return false; |
||
| 645 | } |
||
| 646 | |||
| 647 | public function canDelete($member = null) |
||
| 648 | { |
||
| 649 | if (!$member) { |
||
| 650 | $member = Security::getCurrentUser(); |
||
| 651 | } |
||
| 652 | |||
| 653 | // extended access checks |
||
| 654 | $results = $this->extend('canDelete', $member); |
||
| 655 | if ($results && is_array($results)) { |
||
| 656 | if (!min($results)) { |
||
| 657 | return false; |
||
| 658 | } |
||
| 659 | } |
||
| 660 | |||
| 661 | return $this->canEdit($member); |
||
| 662 | } |
||
| 663 | |||
| 664 | /** |
||
| 665 | * Returns all of the children for the CMS Tree. |
||
| 666 | * Filters to only those groups that the current user can edit |
||
| 667 | * |
||
| 668 | * @return ArrayList |
||
| 669 | */ |
||
| 670 | public function AllChildrenIncludingDeleted() |
||
| 671 | { |
||
| 672 | $children = parent::AllChildrenIncludingDeleted(); |
||
| 673 | |||
| 674 | $filteredChildren = new ArrayList(); |
||
| 675 | |||
| 676 | if ($children) { |
||
| 677 | foreach ($children as $child) { |
||
| 678 | /** @var DataObject $child */ |
||
| 679 | if ($child->canView()) { |
||
| 680 | $filteredChildren->push($child); |
||
| 681 | } |
||
| 682 | } |
||
| 683 | } |
||
| 684 | |||
| 685 | return $filteredChildren; |
||
| 686 | } |
||
| 687 | |||
| 688 | /** |
||
| 689 | * Add default records to database. |
||
| 690 | * |
||
| 691 | * This function is called whenever the database is built, after the |
||
| 692 | * database tables have all been created. |
||
| 693 | */ |
||
| 694 | public function requireDefaultRecords() |
||
| 721 | } |
||
| 722 | |||
| 723 | // Members are populated through Member->requireDefaultRecords() |
||
| 724 | } |
||
| 725 | } |
||
| 726 |
Loading history...
The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g.
excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths