SilverStripe\ORM\DataObject

Complexity

Total Complexity

499

Size/Duplication

Total Lines	3721
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	38

Importance

Changes

0

113 Methods

Rating	Name	Duplication	Size	Complexity
A	getSchema()	0	4	1
F	__construct()	0	85	18
A	setDataModel()	0	5	1
A	destroy()	0	6	1
A	duplicate()	0	15	2
C	duplicateManyManyRelations()	0	27	7
B	duplicateRelations()	0	15	5
A	getObsoleteClassName()	0	8	2
A	getClassName()	0	8	2
A	setClassName()	0	12	3
A	newClassInstance()	0	20	3
C	defineMethods()	0	44	13
A	exists()	0	4	2
B	isEmpty()	0	19	5
A	i18n_pluralise()	0	9	1
A	singular_name()	0	9	2
A	i18n_singular_name()	0	6	1
A	plural_name()	0	13	3
A	i18n_plural_name()	0	7	1
A	getTitle()	0	12	3
A	data()	0	4	1
A	toMap()	0	5	1
A	getQueriedDatabaseFields()	0	4	1
C	update()	0	49	10
A	castedUpdate()	0	7	2
C	merge()	0	71	21
B	forceChange()	0	28	5
A	validate()	0	6	1
A	doValidate()	0	5	1
A	onBeforeWrite()	0	7	1
A	onAfterWrite()	0	5	1
A	onBeforeDelete()	0	7	1
A	onAfterDelete()	0	4	1
C	populateDefaults()	0	37	11
B	validateWrite()	0	22	4
A	preWrite()	0	17	3
A	updateChanges()	0	11	3
C	prepareManipulationTable()	0	48	11
A	writeBaseRecord()	0	15	2
A	writeManipulation()	0	20	3
C	write()	0	50	8
A	writeRelations()	0	14	4
A	writeComponents()	0	14	4
B	delete()	0	31	4
A	delete_by_id()	0	9	2
A	getClassAncestry()	0	4	1
C	getComponent()	0	72	12
B	getComponents()	0	40	6
C	getRelationClass()	0	33	7
A	getRelationType()	0	11	4
D	inferReciprocalComponent()	0	107	15
B	getManyManyComponents()	0	54	6
A	hasOne()	0	4	1
A	belongsTo()	0	9	4
A	hasMany()	0	9	4
A	manyManyExtraFields()	0	4	1
A	manyMany()	0	7	1
A	database_extensions()	0	10	2
A	getDefaultSearchContext()	0	8	1
C	scaffoldSearchFields()	0	56	11
A	scaffoldFormFields()	0	22	1
A	beforeUpdateCMSFields()	0	4	1
A	getCMSFields()	0	13	1
A	getCMSActions()	0	6	1
A	getFrontEndFields()	0	7	1
B	getField()	0	20	6
C	loadLazyFields()	0	76	18
D	getChangedFields()	0	47	17
A	isChanged()	0	10	3
C	setField()	0	52	13
A	setCastedField()	0	14	3
A	castingHelper()	0	20	4
B	hasField()	0	10	5
A	hasDatabaseField()	0	5	1
C	can()	0	62	13
A	extendedCan()	0	16	4
A	canView()	0	8	2
A	canEdit()	0	8	2
A	canDelete()	0	8	2
A	canCreate()	0	8	2
A	debug()	0	11	3
B	dbObject()	0	26	4
B	relObject()	0	30	5
D	relField()	0	36	9
C	getReverseAssociation()	0	23	7
C	get()	0	43	12
D	get_one()	0	27	10
A	flushCache()	0	19	4
B	flush_and_destroy_cache()	0	15	6
A	reset()	0	9	1
A	get_by_id()	0	10	2
A	baseTable()	0	4	1
A	baseClass()	0	4	1
A	getSourceQueryParams()	0	4	1
A	getInheritableQueryParams()	0	6	1
A	setSourceQueryParams()	0	4	1
A	setSourceQueryParam()	0	4	1
A	getSourceQueryParam()	0	7	2
B	databaseIndexes()	0	26	6
B	requireTable()	0	67	7
A	requireDefaultRecords()	0	19	4
D	searchableFields()	0	77	15
C	fieldLabels()	0	40	8
A	fieldLabel()	0	5	2
D	summaryFields()	0	44	12
A	defaultSearchFilters()	0	17	4
A	isInDB()	0	4	2
A	disable_subclass_access()	0	4	1
A	enable_subclass_access()	0	4	1
A	provideI18nEntities()	0	19	1
A	hasValue()	0	10	3
A	getJoin()	0	4	1
A	setJoin()	0	13	3

<?php

namespace SilverStripe\ORM;

use SilverStripe\Core\ClassInfo;
use SilverStripe\Core\Config\Config;
use SilverStripe\Core\Object;
use SilverStripe\Core\Injector\Injector;
use SilverStripe\Dev\Deprecation;
use SilverStripe\Dev\Debug;
use SilverStripe\Control\HTTP;
use SilverStripe\Forms\FieldList;
use SilverStripe\Forms\FormField;
use SilverStripe\Forms\FormScaffolder;
use SilverStripe\i18n\i18n;
use SilverStripe\i18n\i18nEntityProvider;
use SilverStripe\ORM\Filters\SearchFilter;
use SilverStripe\ORM\Search\SearchContext;
use SilverStripe\ORM\Queries\SQLInsert;
use SilverStripe\ORM\Queries\SQLDelete;
use SilverStripe\ORM\Queries\SQLSelect;
use SilverStripe\ORM\FieldType\DBField;
use SilverStripe\ORM\FieldType\DBDatetime;
use SilverStripe\ORM\FieldType\DBComposite;
use SilverStripe\ORM\FieldType\DBClassName;
use SilverStripe\Security\Member;
use SilverStripe\Security\Permission;
use SilverStripe\View\ViewableData;
use LogicException;
use InvalidArgumentException;
use BadMethodCallException;
use Exception;

/**
 * A single database record & abstract class for the data-access-model.
 *
 * <h2>Extensions</h2>
 *
 * See {@link Extension} and {@link DataExtension}.
 *
 * <h2>Permission Control</h2>
 *
 * Object-level access control by {@link Permission}. Permission codes are arbitrary
 * strings which can be selected on a group-by-group basis.
 *
 * <code>
 * class Article extends DataObject implements PermissionProvider {
 *  static $api_access = true;
 *
 *  function canView($member = false) {
 *    return Permission::check('ARTICLE_VIEW');
 *  }
 *  function canEdit($member = false) {
 *    return Permission::check('ARTICLE_EDIT');
 *  }
 *  function canDelete() {
 *    return Permission::check('ARTICLE_DELETE');
 *  }
 *  function canCreate() {
 *    return Permission::check('ARTICLE_CREATE');
 *  }
 *  function providePermissions() {
 *    return array(
 *      'ARTICLE_VIEW' => 'Read an article object',
 *      'ARTICLE_EDIT' => 'Edit an article object',
 *      'ARTICLE_DELETE' => 'Delete an article object',
 *      'ARTICLE_CREATE' => 'Create an article object',
 *    );
 *  }
 * }
 * </code>
 *
 * Object-level access control by {@link Group} membership:
 * <code>
 * class Article extends DataObject {
 *   static $api_access = true;
 *
 *   function canView($member = false) {
 *     if(!$member) $member = Member::currentUser();
 *     return $member->inGroup('Subscribers');
 *   }
 *   function canEdit($member = false) {
 *     if(!$member) $member = Member::currentUser();
 *     return $member->inGroup('Editors');
 *   }
 *
 *   // ...
 * }
 * </code>
 *
 * If any public method on this class is prefixed with an underscore,
 * the results are cached in memory through {@link cachedCall()}.
 *
 *
 * @todo Add instance specific removeExtension() which undos loadExtraStatics()
 *  and defineMethods()
 *
 * @property integer ID ID of the DataObject, 0 if the DataObject doesn't exist in database.
 * @property string ClassName Class name of the DataObject
 * @property string LastEdited Date and time of DataObject's last modification.
 * @property string Created Date and time of DataObject creation.
 */
class DataObject extends ViewableData implements DataObjectInterface, i18nEntityProvider
{

    /**
     * Human-readable singular name.
     * @var string
     * @config
     */
    private static $singular_name = null;

    /**
     * Human-readable plural name
     * @var string
     * @config
     */
    private static $plural_name = null;

    /**
     * Allow API access to this object?
     * @todo Define the options that can be set here
     * @config
     */
    private static $api_access = false;

    /**
     * Allows specification of a default value for the ClassName field.
     * Configure this value only in subclasses of DataObject.
     *
     * @config
     * @var string
     */
    private static $default_classname = null;

    /**
     * True if this DataObject has been destroyed.
     * @var boolean
     */
    public $destroyed = false;

    /**
     * The DataModel from this this object comes
     */
    protected $model;

    /**
     * Data stored in this objects database record. An array indexed by fieldname.
     *
     * Use {@link toMap()} if you want an array representation
     * of this object, as the $record array might contain lazy loaded field aliases.
     *
     * @var array
     */
    protected $record;

    /**
     * If selected through a many_many through relation, this is the instance of the through record
     *
     * @var DataObject
     */
    protected $joinRecord;

    /**
     * Represents a field that hasn't changed (before === after, thus before == after)
     */
    const CHANGE_NONE = 0;

    /**
     * Represents a field that has changed type, although not the loosely defined value.
     * (before !== after && before == after)
     * E.g. change 1 to true or "true" to true, but not true to 0.
     * Value changes are by nature also considered strict changes.
     */
    const CHANGE_STRICT = 1;

    /**
     * Represents a field that has changed the loosely defined value
     * (before != after, thus, before !== after))
     * E.g. change false to true, but not false to 0
     */
    const CHANGE_VALUE = 2;

    /**
     * An array indexed by fieldname, true if the field has been changed.
     * Use {@link getChangedFields()} and {@link isChanged()} to inspect
     * the changed state.
     *
     * @var array
     */
    private $changed;

    /**
     * The database record (in the same format as $record), before
     * any changes.
     * @var array
     */
    protected $original;

    /**
     * Used by onBeforeDelete() to ensure child classes call parent::onBeforeDelete()
     * @var boolean
     */
    protected $brokenOnDelete = false;

    /**
     * Used by onBeforeWrite() to ensure child classes call parent::onBeforeWrite()
     * @var boolean
     */
    protected $brokenOnWrite = false;

    /**
     * @config
     * @var boolean Should dataobjects be validated before they are written?
     * Caution: Validation can contain safeguards against invalid/malicious data,
     * and check permission levels (e.g. on {@link Group}). Therefore it is recommended
     * to only disable validation for very specific use cases.
     */
    private static $validation_enabled = true;

    /**
     * Static caches used by relevant functions.
     *
     * @var array
     */
    protected static $_cache_get_one;

    /**
     * Cache of field labels
     *
     * @var array
     */
    protected static $_cache_field_labels = array();

    /**
     * Base fields which are not defined in static $db
     *
     * @config
     * @var array
     */
    private static $fixed_fields = array(
        'ID' => 'PrimaryKey',
        'ClassName' => 'DBClassName',
        'LastEdited' => 'DBDatetime',
        'Created' => 'DBDatetime',
    );

    /**
     * Core dataobject extensions
     *
     * @config
     * @var array
     */
    private static $extensions = array(
        'AssetControl' => 'SilverStripe\\Assets\\AssetControlExtension'
    );

    /**
     * Override table name for this class. If ignored will default to FQN of class.
     * This option is not inheritable, and must be set on each class.
     * If left blank naming will default to the legacy (3.x) behaviour.
     *
     * @var string
     */
    private static $table_name = null;

    /**
     * Non-static relationship cache, indexed by component name.
     *
     * @var DataObject[]
     */
    protected $components;

    /**
     * Non-static cache of has_many and many_many relations that can't be written until this object is saved.
     *
     * @var UnsavedRelationList[]
     */
    protected $unsavedRelations;

    /**
     * Get schema object
     *
     * @return DataObjectSchema
     */
    public static function getSchema()
    {
        return Injector::inst()->get(DataObjectSchema::class);
    }

    /**
     * Construct a new DataObject.
     *
     * @param array|null $record This will be null for a new database record.  Alternatively, you can pass an array of
     * field values.  Normally this constructor is only used by the internal systems that get objects from the database.
     * @param boolean $isSingleton This this to true if this is a singleton() object, a stub for calling methods.
     *                             Singletons don't have their defaults set.
     * @param DataModel $model
     * @param array $queryParams List of DataQuery params necessary to lazy load, or load related objects.
     */
    public function __construct($record = null, $isSingleton = false, $model = null, $queryParams = array())
    {
        parent::__construct();

        // Set query params on the DataObject to tell the lazy loading mechanism the context the object creation context
        $this->setSourceQueryParams($queryParams);

        // Set the fields data.
        if (!$record) {
            $record = array(
                'ID' => 0,
                'ClassName' => static::class,
                'RecordClassName' => static::class
            );
        }

        if (!is_array($record) && !is_a($record, "stdClass")) {
            if (is_object($record)) {
                $passed = "an object of type '".get_class($record)."'";
            } else {
                $passed = "The value '$record'";
            }

            user_error(
                "DataObject::__construct passed $passed.  It's supposed to be passed an array,"
                . " taken straight from the database.  Perhaps you should use DataList::create()->First(); instead?",
                E_USER_WARNING
            );
            $record = null;
        }

        if (is_a($record, "stdClass")) {
            $record = (array)$record;
        }

        // Set $this->record to $record, but ignore NULLs
        $this->record = array();
        foreach ($record as $k => $v) {

The expression $record of type null|array is not guaranteed to be traversable. How about adding an additional type check?

            // Ensure that ID is stored as a number and not a string
            // To do: this kind of clean-up should be done on all numeric fields, in some relatively
            // performant manner
            if ($v !== null) {
                if ($k == 'ID' && is_numeric($v)) {
                    $this->record[$k] = (int)$v;
                } else {
                    $this->record[$k] = $v;
                }
            }
        }

        // Identify fields that should be lazy loaded, but only on existing records
        if (!empty($record['ID'])) {
            // Get all field specs scoped to class for later lazy loading
            $fields = static::getSchema()->fieldSpecs(
                static::class,
                DataObjectSchema::INCLUDE_CLASS | DataObjectSchema::DB_ONLY
            );
            foreach ($fields as $field => $fieldSpec) {
                $fieldClass = strtok($fieldSpec, ".");
                if (!array_key_exists($field, $record)) {
                    $this->record[$field.'_Lazy'] = $fieldClass;
                }
            }
        }

        $this->original = $this->record;

        // Keep track of the modification date of all the data sourced to make this page
        // From this we create a Last-Modified HTTP header
        if (isset($record['LastEdited'])) {
            HTTP::register_modification_date($record['LastEdited']);
        }

        // this must be called before populateDefaults(), as field getters on a DataObject
        // may call getComponent() and others, which rely on $this->model being set.
        $this->model = $model ? $model : DataModel::inst();

        // Must be called after parent constructor
        if (!$isSingleton && (!isset($this->record['ID']) || !$this->record['ID'])) {
            $this->populateDefaults();
        }

        // prevent populateDefaults() and setField() from marking overwritten defaults as changed
        $this->changed = array();
    }

    /**
     * Set the DataModel
     * @param DataModel $model
     * @return DataObject $this
     */
    public function setDataModel(DataModel $model)
    {
        $this->model = $model;
        return $this;
    }

    /**
     * Destroy all of this objects dependant objects and local caches.
     * You'll need to call this to get the memory of an object that has components or extensions freed.
     */
    public function destroy()
    {
        //$this->destroyed = true;

50% of this comment could be valid code. Did you maybe forget this after debugging?

        gc_collect_cycles();
        $this->flushCache(false);
    }

    /**
     * Create a duplicate of this node.
     * Note: now also duplicates relations.
     *
     * @param bool $doWrite Perform a write() operation before returning the object.
     * If this is true, it will create the duplicate in the database.
     * @return DataObject A duplicate of this node. The exact type will be the type of this node.
     */
    public function duplicate($doWrite = true)
    {
        /** @var static $clone */
        $clone = Injector::inst()->create(static::class, $this->toMap(), false, $this->model);
        $clone->ID = 0;

        $clone->invokeWithExtensions('onBeforeDuplicate', $this, $doWrite);
        if ($doWrite) {
            $clone->write();
            $this->duplicateManyManyRelations($this, $clone);
        }
        $clone->invokeWithExtensions('onAfterDuplicate', $this, $doWrite);

        return $clone;
    }

    /**
     * Copies the many_many and belongs_many_many relations from one object to another instance of the name of object
     * The destinationObject must be written to the database already and have an ID. Writing is performed
     * automatically when adding the new relations.
     *
     * @param DataObject $sourceObject the source object to duplicate from
     * @param DataObject $destinationObject the destination object to populate with the duplicated relations
     * @return DataObject with the new many_many relations copied in
     */
    protected function duplicateManyManyRelations($sourceObject, $destinationObject)
    {
        if (!$destinationObject || $destinationObject->ID < 1) {
            user_error(
                "Can't duplicate relations for an object that has not been written to the database",
                E_USER_ERROR
            );
        }

        //duplicate complex relations
        // DO NOT copy has_many relations, because copying the relation would result in us changing the has_one
        // relation on the other side of this relation to point at the copy and no longer the original (being a
        // has_one, it can only point at one thing at a time). So, all relations except has_many can and are copied
        if ($sourceObject->hasOne()) {
            foreach ($sourceObject->hasOne() as $name => $type) {

The expression $sourceObject->hasOne() of type string|array is not guaranteed to be traversable. How about adding an additional type check?

                $this->duplicateRelations($sourceObject, $destinationObject, $name);
            }
        }
        if ($sourceObject->manyMany()) {
            foreach ($sourceObject->manyMany() as $name => $type) {
                        //many_many include belongs_many_many
                $this->duplicateRelations($sourceObject, $destinationObject, $name);
            }
        }

        return $destinationObject;
    }

    /**
     * Helper function to duplicate relations from one object to another
     * @param DataObject $sourceObject the source object to duplicate from
     * @param DataObject $destinationObject the destination object to populate with the duplicated relations
     * @param string $name the name of the relation to duplicate (e.g. members)
     */
    private function duplicateRelations($sourceObject, $destinationObject, $name)
    {
        $relations = $sourceObject->$name();
        if ($relations) {
            if ($relations instanceof RelationList) {   //many-to-something relation
                if ($relations->count() > 0) {  //with more than one thing it is related to
                    foreach ($relations as $relation) {
                        $destinationObject->$name()->add($relation);
                    }
                }
            } else {    //one-to-one relation
                $destinationObject->{"{$name}ID"} = $relations->ID;
            }
        }
    }

    /**
     * Return obsolete class name, if this is no longer a valid class
     *
     * @return string
     */
    public function getObsoleteClassName()
    {
        $className = $this->getField("ClassName");
        if (!ClassInfo::exists($className)) {
            return $className;
        }
        return null;
    }

    /**
     * Gets name of this class
     *
     * @return string
     */
    public function getClassName()
    {
        $className = $this->getField("ClassName");
        if (!ClassInfo::exists($className)) {
            return static::class;
        }
        return $className;
    }

    /**
     * Set the ClassName attribute. {@link $class} is also updated.
     * Warning: This will produce an inconsistent record, as the object
     * instance will not automatically switch to the new subclass.
     * Please use {@link newClassInstance()} for this purpose,
     * or destroy and reinstanciate the record.
     *
     * @param string $className The new ClassName attribute (a subclass of {@link DataObject})
     * @return $this
     */
    public function setClassName($className)
    {
        $className = trim($className);
        if (!$className || !is_subclass_of($className, self::class)) {
            return $this;
        }

        $this->class = $className;
        $this->setField("ClassName", $className);
        $this->setField('RecordClassName', $className);
        return $this;
    }

    /**
     * Create a new instance of a different class from this object's record.
     * This is useful when dynamically changing the type of an instance. Specifically,
     * it ensures that the instance of the class is a match for the className of the
     * record. Don't set the {@link DataObject->class} or {@link DataObject->ClassName}
     * property manually before calling this method, as it will confuse change detection.
     *
     * If the new class is different to the original class, defaults are populated again
     * because this will only occur automatically on instantiation of a DataObject if
     * there is no record, or the record has no ID. In this case, we do have an ID but
     * we still need to repopulate the defaults.
     *
     * @param string $newClassName The name of the new class
     *
     * @return DataObject The new instance of the new class, The exact type will be of the class name provided.
     */
    public function newClassInstance($newClassName)
    {
        if (!is_subclass_of($newClassName, self::class)) {
            throw new InvalidArgumentException("$newClassName is not a valid subclass of DataObject");
        }

        $originalClass = $this->ClassName;

        /** @var DataObject $newInstance */
        $newInstance = Injector::inst()->create($newClassName, $this->record, false, $this->model);

        // Modify ClassName
        if ($newClassName != $originalClass) {
            $newInstance->setClassName($newClassName);
            $newInstance->populateDefaults();
            $newInstance->forceChange();
        }

        return $newInstance;
    }

    /**
     * Adds methods from the extensions.
     * Called by Object::__construct() once per class.
     */
    public function defineMethods()
    {
        parent::defineMethods();

        // Define the extra db fields - this is only necessary for extensions added in the
        // class definition.  Object::add_extension() will call this at definition time for
        // those objects, which is a better mechanism.  Perhaps extensions defined inside the
        // class def can somehow be applied at definiton time also?
        if ($this->extension_instances) {

The expression $this->extension_instances of type SilverStripe\Core\Extension[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            foreach ($this->extension_instances as $i => $instance) {
                if (!$instance->class) {
                    $class = get_class($instance);
                    user_error("DataObject::defineMethods(): Please ensure {$class}::__construct() calls"
                    . " parent::__construct()", E_USER_ERROR);
                }
            }
        }

        if (static::class === self::class) {
             return;
        }

        // Set up accessors for joined items
        if ($manyMany = $this->manyMany()) {
            foreach ($manyMany as $relationship => $class) {
                $this->addWrapperMethod($relationship, 'getManyManyComponents');
            }
        }
        if ($hasMany = $this->hasMany()) {
            foreach ($hasMany as $relationship => $class) {

The expression $hasMany of type string|array is not guaranteed to be traversable. How about adding an additional type check?

                $this->addWrapperMethod($relationship, 'getComponents');
            }
        }
        if ($hasOne = $this->hasOne()) {
            foreach ($hasOne as $relationship => $class) {

The expression $hasOne of type string|array is not guaranteed to be traversable. How about adding an additional type check?

                $this->addWrapperMethod($relationship, 'getComponent');
            }
        }
        if ($belongsTo = $this->belongsTo()) {
            foreach (array_keys($belongsTo) as $relationship) {
                $this->addWrapperMethod($relationship, 'getComponent');
            }
        }
    }

    /**
     * Returns true if this object "exists", i.e., has a sensible value.
     * The default behaviour for a DataObject is to return true if
     * the object exists in the database, you can override this in subclasses.
     *
     * @return boolean true if this object exists
     */
    public function exists()
    {
        return (isset($this->record['ID']) && $this->record['ID'] > 0);
    }

    /**
     * Returns TRUE if all values (other than "ID") are
     * considered empty (by weak boolean comparison).
     *
     * @return boolean
     */
    public function isEmpty()
    {
        $fixed = $this->config()->fixed_fields;

The property fixed_fields does not exist on object<SilverStripe\Core\Config\Config_ForClass>. Since you implemented __set, maybe consider adding a @property annotation.

        foreach ($this->toMap() as $field => $value) {
            // only look at custom fields
            if (isset($fixed[$field])) {
                continue;
            }

            $dbObject = $this->dbObject($field);

Are you sure the assignment to $dbObject is correct as $this->dbObject($field) (which targets SilverStripe\ORM\DataObject::dbObject()) seems to always return null.

            if (!$dbObject) {
                continue;
            }
            if ($dbObject->exists()) {
                return false;
            }
        }
        return true;
    }

    /**
     * Pluralise this item given a specific count.
     *
     * E.g. "0 Pages", "1 File", "3 Images"
     *
     * @param string $count
     * @param bool $prependNumber Include number in result. Defaults to true.
     * @return string
     */
    public function i18n_pluralise($count, $prependNumber = true)
    {
        return i18n::pluralise(
            $this->i18n_singular_name(),
            $this->i18n_plural_name(),
            $count,
            $prependNumber
        );
    }

    /**
     * Get the user friendly singular name of this DataObject.
     * If the name is not defined (by redefining $singular_name in the subclass),
     * this returns the class name.
     *
     * @return string User friendly singular name of this DataObject
     */
    public function singular_name()
    {
        if (!$name = $this->stat('singular_name')) {
            $reflection = new \ReflectionClass($this);
            $name = ucwords(trim(strtolower(preg_replace('/_?([A-Z])/', ' $1', $reflection->getShortName()))));
        }

        return $name;
    }

    /**
     * Get the translated user friendly singular name of this DataObject
     * same as singular_name() but runs it through the translating function
     *
     * Translating string is in the form:
     *     $this->class.SINGULARNAME
     * Example:
     *     Page.SINGULARNAME
     *
     * @return string User friendly translated singular name of this DataObject
     */
    public function i18n_singular_name()
    {
        // @todo Update localisation to FQN for all classes
        $reflection = new \ReflectionClass($this);
        return _t($reflection->getShortName().'.SINGULARNAME', $this->singular_name());
    }

    /**
     * Get the user friendly plural name of this DataObject
     * If the name is not defined (by renaming $plural_name in the subclass),
     * this returns a pluralised version of the class name.
     *
     * @return string User friendly plural name of this DataObject
     */
    public function plural_name()
    {
        if ($name = $this->stat('plural_name')) {
            return $name;
        } else {
            $name = $this->singular_name();
            //if the penultimate character is not a vowel, replace "y" with "ies"
            if (preg_match('/[^aeiou]y$/i', $name)) {
                $name = substr($name, 0, -1) . 'ie';
            }
            return ucfirst($name . 's');
        }
    }

    /**
     * Get the translated user friendly plural name of this DataObject
     * Same as plural_name but runs it through the translation function
     * Translation string is in the form:
     *      $this->class.PLURALNAME
     * Example:
     *      Page.PLURALNAME
     *
     * @return string User friendly translated plural name of this DataObject
     */
    public function i18n_plural_name()
    {
        // @todo Update localisation to FQN for all classes
        $name = $this->plural_name();
        $reflection = new \ReflectionClass($this);
        return _t($reflection->getShortName().'.PLURALNAME', $name);
    }

    /**
     * Standard implementation of a title/label for a specific
     * record. Tries to find properties 'Title' or 'Name',
     * and falls back to the 'ID'. Useful to provide
     * user-friendly identification of a record, e.g. in errormessages
     * or UI-selections.
     *
     * Overload this method to have a more specialized implementation,
     * e.g. for an Address record this could be:
     * <code>
     * function getTitle() {
     *   return "{$this->StreetNumber} {$this->StreetName} {$this->City}";
     * }
     * </code>
     *
     * @return string
     */
    public function getTitle()
    {
        $schema = static::getSchema();
        if ($schema->fieldSpec($this, 'Title')) {

The expression $schema->fieldSpec($this, 'Title') of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            return $this->getField('Title');
        }
        if ($schema->fieldSpec($this, 'Name')) {

The expression $schema->fieldSpec($this, 'Name') of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            return $this->getField('Name');
        }

        return "#{$this->ID}";
    }

    /**
     * Returns the associated database record - in this case, the object itself.
     * This is included so that you can call $dataOrController->data() and get a DataObject all the time.
     *
     * @return DataObject Associated database record
     */
    public function data()
    {
        return $this;
    }

    /**
     * Convert this object to a map.
     *
     * @return array The data as a map.
     */
    public function toMap()
    {
        $this->loadLazyFields();
        return $this->record;
    }

    /**
     * Return all currently fetched database fields.
     *
     * This function is similar to toMap() but doesn't trigger the lazy-loading of all unfetched fields.
     * Obviously, this makes it a lot faster.
     *
     * @return array The data as a map.
     */
    public function getQueriedDatabaseFields()
    {
        return $this->record;
    }

    /**
     * Update a number of fields on this object, given a map of the desired changes.
     *
     * The field names can be simple names, or you can use a dot syntax to access $has_one relations.
     * For example, array("Author.FirstName" => "Jim") will set $this->Author()->FirstName to "Jim".
     *
     * update() doesn't write the main object, but if you use the dot syntax, it will write()
     * the related objects that it alters.
     *
     * @param array $data A map of field name to data values to update.
     * @return DataObject $this
     */
    public function update($data)
    {
        foreach ($data as $k => $v) {
            // Implement dot syntax for updates
            if (strpos($k, '.') !== false) {
                $relations = explode('.', $k);
                $fieldName = array_pop($relations);
                $relObj = $this;
                $relation = null;
                foreach ($relations as $i => $relation) {
                    // no support for has_many or many_many relationships,
                    // as the updater wouldn't know which object to write to (or create)
                    if ($relObj->$relation() instanceof DataObject) {
                        $parentObj = $relObj;
                        $relObj = $relObj->$relation();
                        // If the intermediate relationship objects have been created, then write them
                        if ($i<sizeof($relation)-1 && !$relObj->ID || (!$relObj->ID && $parentObj != $this)) {
                            $relObj->write();
                            $relatedFieldName = $relation."ID";
                            $parentObj->$relatedFieldName = $relObj->ID;
                            $parentObj->write();
                        }
                    } else {
                        user_error(
                            "DataObject::update(): Can't traverse relationship '$relation'," .
                            "it has to be a has_one relationship or return a single DataObject",
                            E_USER_NOTICE
                        );
                        // unset relation object so we don't write properties to the wrong object
                        $relObj = null;
                        break;
                    }
                }

                if ($relObj) {
                    $relObj->$fieldName = $v;
                    $relObj->write();
                    $relatedFieldName = $relation."ID";
                    $this->$relatedFieldName = $relObj->ID;
                    $relObj->flushCache();
                } else {
                    user_error("Couldn't follow dot syntax '$k' on '$this->class' object", E_USER_WARNING);
                }
            } else {
                $this->$k = $v;
            }
        }
        return $this;
    }

    /**
     * Pass changes as a map, and try to
     * get automatic casting for these fields.
     * Doesn't write to the database. To write the data,
     * use the write() method.
     *
     * @param array $data A map of field name to data values to update.
     * @return DataObject $this
     */
    public function castedUpdate($data)
    {
        foreach ($data as $k => $v) {
            $this->setCastedField($k, $v);
        }
        return $this;
    }

    /**
     * Merges data and relations from another object of same class,
     * without conflict resolution. Allows to specify which
     * dataset takes priority in case its not empty.
     * has_one-relations are just transferred with priority 'right'.
     * has_many and many_many-relations are added regardless of priority.
     *
     * Caution: has_many/many_many relations are moved rather than duplicated,
     * meaning they are not connected to the merged object any longer.
     * Caution: Just saves updated has_many/many_many relations to the database,
     * doesn't write the updated object itself (just writes the object-properties).
     * Caution: Does not delete the merged object.
     * Caution: Does now overwrite Created date on the original object.
     *
     * @param DataObject $rightObj
     * @param string $priority left|right Determines who wins in case of a conflict (optional)
     * @param bool $includeRelations Merge any existing relations (optional)
     * @param bool $overwriteWithEmpty Overwrite existing left values with empty right values.
     *                            Only applicable with $priority='right'. (optional)
     * @return Boolean
     */
    public function merge($rightObj, $priority = 'right', $includeRelations = true, $overwriteWithEmpty = false)
    {
        $leftObj = $this;

        if ($leftObj->ClassName != $rightObj->ClassName) {
            // we can't merge similiar subclasses because they might have additional relations
            user_error("DataObject->merge(): Invalid object class '{$rightObj->ClassName}'
			(expected '{$leftObj->ClassName}').", E_USER_WARNING);
            return false;
        }

        if (!$rightObj->ID) {
            user_error("DataObject->merge(): Please write your merged-in object to the database before merging,
				to make sure all relations are transferred properly.').", E_USER_WARNING);
            return false;
        }

        // makes sure we don't merge data like ID or ClassName
        $rightData = DataObject::getSchema()->fieldSpecs(get_class($rightObj));

As per coding style, self should be used for accessing local static members.

        foreach ($rightData as $key => $rightSpec) {
            // Don't merge ID
            if ($key === 'ID') {
                continue;
            }

            // Only merge relations if allowed
            if ($rightSpec === 'ForeignKey' && !$includeRelations) {
                continue;
            }

            // don't merge conflicting values if priority is 'left'
            if ($priority == 'left' && $leftObj->{$key} !== $rightObj->{$key}) {
                continue;
            }

            // don't overwrite existing left values with empty right values (if $overwriteWithEmpty is set)
            if ($priority == 'right' && !$overwriteWithEmpty && empty($rightObj->{$key})) {
                continue;
            }

            // TODO remove redundant merge of has_one fields
            $leftObj->{$key} = $rightObj->{$key};
        }

        // merge relations
        if ($includeRelations) {
            if ($manyMany = $this->manyMany()) {
                foreach ($manyMany as $relationship => $class) {
                    $leftComponents = $leftObj->getManyManyComponents($relationship);
                    $rightComponents = $rightObj->getManyManyComponents($relationship);
                    if ($rightComponents && $rightComponents->exists()) {
                        $leftComponents->addMany($rightComponents->column('ID'));
                    }
                    $leftComponents->write();
                }
            }

            if ($hasMany = $this->hasMany()) {
                foreach ($hasMany as $relationship => $class) {

The expression $hasMany of type string|array is not guaranteed to be traversable. How about adding an additional type check?

                    $leftComponents = $leftObj->getComponents($relationship);
                    $rightComponents = $rightObj->getComponents($relationship);
                    if ($rightComponents && $rightComponents->exists()) {
                        $leftComponents->addMany($rightComponents->column('ID'));
                    }
                    $leftComponents->write();
                }
            }
        }

        return true;
    }

    /**
     * Forces the record to think that all its data has changed.
     * Doesn't write to the database. Only sets fields as changed
     * if they are not already marked as changed.
     *
     * @return $this
     */
    public function forceChange()
    {
        // Ensure lazy fields loaded
        $this->loadLazyFields();
        $fields = static::getSchema()->fieldSpecs(static::class);

        // $this->record might not contain the blank values so we loop on $this->inheritedDatabaseFields() as well
        $fieldNames = array_unique(array_merge(
            array_keys($this->record),
            array_keys($fields)
        ));

        foreach ($fieldNames as $fieldName) {
            if (!isset($this->changed[$fieldName])) {
                $this->changed[$fieldName] = self::CHANGE_STRICT;
            }
            // Populate the null values in record so that they actually get written
            if (!isset($this->record[$fieldName])) {
                $this->record[$fieldName] = null;
            }
        }

        // @todo Find better way to allow versioned to write a new version after forceChange
        if ($this->isChanged('Version')) {
            unset($this->changed['Version']);
        }
        return $this;
    }

    /**
     * Validate the current object.
     *
     * By default, there is no validation - objects are always valid!  However, you can overload this method in your
     * DataObject sub-classes to specify custom validation, or use the hook through DataExtension.
     *
     * Invalid objects won't be able to be written - a warning will be thrown and no write will occur.  onBeforeWrite()
     * and onAfterWrite() won't get called either.
     *
     * It is expected that you call validate() in your own application to test that an object is valid before
     * attempting a write, and respond appropriately if it isn't.
     *
     * @see {@link ValidationResult}
     * @return ValidationResult
     */
    public function validate()
    {
        $result = ValidationResult::create();
        $this->extend('validate', $result);
        return $result;
    }

    /**
     * Public accessor for {@see DataObject::validate()}
     *
     * @return ValidationResult
     */
    public function doValidate()
    {
        Deprecation::notice('5.0', 'Use validate');
        return $this->validate();
    }

    /**
     * Event handler called before writing to the database.
     * You can overload this to clean up or otherwise process data before writing it to the
     * database.  Don't forget to call parent::onBeforeWrite(), though!
     *
     * This called after {@link $this->validate()}, so you can be sure that your data is valid.
     *
     * @uses DataExtension->onBeforeWrite()
     */
    protected function onBeforeWrite()
    {
        $this->brokenOnWrite = false;

        $dummy = null;
        $this->extend('onBeforeWrite', $dummy);
    }

    /**
     * Event handler called after writing to the database.
     * You can overload this to act upon changes made to the data after it is written.
     * $this->changed will have a record
     * database.  Don't forget to call parent::onAfterWrite(), though!
     *
     * @uses DataExtension->onAfterWrite()
     */
    protected function onAfterWrite()
    {
        $dummy = null;
        $this->extend('onAfterWrite', $dummy);
    }

    /**
     * Event handler called before deleting from the database.
     * You can overload this to clean up or otherwise process data before delete this
     * record.  Don't forget to call parent::onBeforeDelete(), though!
     *
     * @uses DataExtension->onBeforeDelete()
     */
    protected function onBeforeDelete()
    {
        $this->brokenOnDelete = false;

        $dummy = null;
        $this->extend('onBeforeDelete', $dummy);
    }

    protected function onAfterDelete()
    {
        $this->extend('onAfterDelete');
    }

    /**
     * Load the default values in from the self::$defaults array.
     * Will traverse the defaults of the current class and all its parent classes.
     * Called by the constructor when creating new records.
     *
     * @uses DataExtension->populateDefaults()
     * @return DataObject $this
     */
    public function populateDefaults()
    {
        $classes = array_reverse(ClassInfo::ancestry($this));

        foreach ($classes as $class) {
            $defaults = Config::inst()->get($class, 'defaults', Config::UNINHERITED);

            if ($defaults && !is_array($defaults)) {
                user_error(
                    "Bad '$this->class' defaults given: " . var_export($defaults, true),
                    E_USER_WARNING
                );
                $defaults = null;
            }

            if ($defaults) {
                foreach ($defaults as $fieldName => $fieldValue) {
                                // SRM 2007-03-06: Stricter check
                    if (!isset($this->$fieldName) || $this->$fieldName === null) {
                        $this->$fieldName = $fieldValue;
                    }
                                // Set many-many defaults with an array of ids
                    if (is_array($fieldValue) && $this->getSchema()->manyManyComponent(static::class, $fieldName)) {
                        /** @var ManyManyList $manyManyJoin */
                        $manyManyJoin = $this->$fieldName();
                        $manyManyJoin->setByIDList($fieldValue);
                    }
                }
            }
            if ($class == self::class) {
                break;
            }
        }

        $this->extend('populateDefaults');
        return $this;
    }

    /**
     * Determine validation of this object prior to write
     *
     * @return ValidationException Exception generated by this write, or null if valid
     */
    protected function validateWrite()
    {
        if ($this->ObsoleteClassName) {

The property ObsoleteClassName does not seem to exist. Did you mean ClassName?

            return new ValidationException(
                "Object is of class '{$this->ObsoleteClassName}' which doesn't exist - ".

The property ObsoleteClassName does not seem to exist. Did you mean ClassName?

                "you need to change the ClassName before you can write it",
                E_USER_WARNING
            );
        }

        if ($this->config()->get('validation_enabled')) {
            $result = $this->validate();
            if (!$result->valid()) {
                return new ValidationException(
                    $result,
                    $result->message(),
                    E_USER_WARNING
                );
            }
        }
        return null;
    }

    /**
     * Prepare an object prior to write
     *
     * @throws ValidationException
     */
    protected function preWrite()
    {
        // Validate this object
        if ($writeException = $this->validateWrite()) {
            // Used by DODs to clean up after themselves, eg, Versioned
            $this->invokeWithExtensions('onAfterSkippedWrite');
            throw $writeException;
        }

        // Check onBeforeWrite
        $this->brokenOnWrite = true;
        $this->onBeforeWrite();
        if ($this->brokenOnWrite) {
            user_error("$this->class has a broken onBeforeWrite() function."
                . " Make sure that you call parent::onBeforeWrite().", E_USER_ERROR);
        }
    }

    /**
     * Detects and updates all changes made to this object
     *
     * @param bool $forceChanges If set to true, force all fields to be treated as changed
     * @return bool True if any changes are detected
     */
    protected function updateChanges($forceChanges = false)
    {
        if ($forceChanges) {
            // Force changes, but only for loaded fields
            foreach ($this->record as $field => $value) {
                $this->changed[$field] = static::CHANGE_VALUE;
            }
            return true;
        }
        return $this->isChanged();
    }

    /**
     * Writes a subset of changes for a specific table to the given manipulation
     *
     * @param string $baseTable Base table
     * @param string $now Timestamp to use for the current time
     * @param bool $isNewRecord Whether this should be treated as a new record write
     * @param array $manipulation Manipulation to write to
     * @param string $class Class of table to manipulate
     */
    protected function prepareManipulationTable($baseTable, $now, $isNewRecord, &$manipulation, $class)
    {
        $schema = $this->getSchema();
        $table = $schema->tableName($class);
        $manipulation[$table] = array();

        // Extract records for this table
        foreach ($this->record as $fieldName => $fieldValue) {
            // we're not attempting to reset the BaseTable->ID
            // Ignore unchanged fields or attempts to reset the BaseTable->ID
            if (empty($this->changed[$fieldName]) || ($table === $baseTable && $fieldName === 'ID')) {
                continue;
            }

            // Ensure this field pertains to this table
            $specification = $schema->fieldSpec($class, $fieldName, DataObjectSchema::DB_ONLY | DataObjectSchema::UNINHERITED);
            if (!$specification) {

The expression $specification of type string|null is loosely compared to false; this is ambiguous if the string can be empty. You might want to explicitly use === null instead.

                continue;
            }

            // if database column doesn't correlate to a DBField instance...
            $fieldObj = $this->dbObject($fieldName);
            if (!$fieldObj) {
                $fieldObj = DBField::create_field('Varchar', $fieldValue, $fieldName);
            }

            // Write to manipulation
            $fieldObj->writeToManipulation($manipulation[$table]);
        }

        // Ensure update of Created and LastEdited columns
        if ($baseTable === $table) {
            $manipulation[$table]['fields']['LastEdited'] = $now;
            if ($isNewRecord) {
                $manipulation[$table]['fields']['Created']
                    = empty($this->record['Created'])
                        ? $now
                        : $this->record['Created'];
                $manipulation[$table]['fields']['ClassName'] = $this->class;
            }
        }

        // Inserts done one the base table are performed in another step, so the manipulation should instead
        // attempt an update, as though it were a normal update.
        $manipulation[$table]['command'] = $isNewRecord ? 'insert' : 'update';
        $manipulation[$table]['id'] = $this->record['ID'];
        $manipulation[$table]['class'] = $class;
    }

    /**
     * Ensures that a blank base record exists with the basic fixed fields for this dataobject
     *
     * Does nothing if an ID is already assigned for this record
     *
     * @param string $baseTable Base table
     * @param string $now Timestamp to use for the current time
     */
    protected function writeBaseRecord($baseTable, $now)
    {
        // Generate new ID if not specified
        if ($this->isInDB()) {
            return;
        }

        // Perform an insert on the base table
        $insert = new SQLInsert('"'.$baseTable.'"');
        $insert
            ->assign('"Created"', $now)
            ->execute();
        $this->changed['ID'] = self::CHANGE_VALUE;
        $this->record['ID'] = DB::get_generated_id($baseTable);
    }

    /**
     * Generate and write the database manipulation for all changed fields
     *
     * @param string $baseTable Base table
     * @param string $now Timestamp to use for the current time
     * @param bool $isNewRecord If this is a new record
     */
    protected function writeManipulation($baseTable, $now, $isNewRecord)
    {
        // Generate database manipulations for each class
        $manipulation = array();
        foreach (ClassInfo::ancestry(static::class, true) as $class) {
            $this->prepareManipulationTable($baseTable, $now, $isNewRecord, $manipulation, $class);
        }

        // Allow extensions to extend this manipulation
        $this->extend('augmentWrite', $manipulation);

        // New records have their insert into the base data table done first, so that they can pass the
        // generated ID on to the rest of the manipulation
        if ($isNewRecord) {
            $manipulation[$baseTable]['command'] = 'update';
        }

        // Perform the manipulation
        DB::manipulate($manipulation);
    }

    /**
     * Writes all changes to this object to the database.
     *  - It will insert a record whenever ID isn't set, otherwise update.
     *  - All relevant tables will be updated.
     *  - $this->onBeforeWrite() gets called beforehand.
     *  - Extensions such as Versioned will ammend the database-write to ensure that a version is saved.
     *
     *  @uses DataExtension->augmentWrite()
     *
     * @param boolean $showDebug Show debugging information
     * @param boolean $forceInsert Run INSERT command rather than UPDATE, even if record already exists
     * @param boolean $forceWrite Write to database even if there are no changes
     * @param boolean $writeComponents Call write() on all associated component instances which were previously
     *                                 retrieved through {@link getComponent()}, {@link getComponents()} or
     *                                 {@link getManyManyComponents()} (Default: false)
     * @return int The ID of the record
     * @throws ValidationException Exception that can be caught and handled by the calling function
     */
    public function write($showDebug = false, $forceInsert = false, $forceWrite = false, $writeComponents = false)
    {
        $now = DBDatetime::now()->Rfc2822();

        // Execute pre-write tasks
        $this->preWrite();

        // Check if we are doing an update or an insert
        $isNewRecord = !$this->isInDB() || $forceInsert;

        // Check changes exist, abort if there are none
        $hasChanges = $this->updateChanges($isNewRecord);
        if ($hasChanges || $forceWrite || $isNewRecord) {
            // New records have their insert into the base data table done first, so that they can pass the
            // generated primary key on to the rest of the manipulation
            $baseTable = $this->baseTable();
            $this->writeBaseRecord($baseTable, $now);

            // Write the DB manipulation for all changed fields
            $this->writeManipulation($baseTable, $now, $isNewRecord);

            // If there's any relations that couldn't be saved before, save them now (we have an ID here)
            $this->writeRelations();
            $this->onAfterWrite();
            $this->changed = array();
        } else {
            if ($showDebug) {
                Debug::message("no changes for DataObject");
            }

            // Used by DODs to clean up after themselves, eg, Versioned
            $this->invokeWithExtensions('onAfterSkippedWrite');
        }

        // Ensure Created and LastEdited are populated
        if (!isset($this->record['Created'])) {
            $this->record['Created'] = $now;
        }
        $this->record['LastEdited'] = $now;

        // Write relations as necessary
        if ($writeComponents) {
            $this->writeComponents(true);
        }

        // Clears the cache for this object so get_one returns the correct object.
        $this->flushCache();

        return $this->record['ID'];
    }

    /**
     * Writes cached relation lists to the database, if possible
     */
    public function writeRelations()
    {
        if (!$this->isInDB()) {
            return;
        }

        // If there's any relations that couldn't be saved before, save them now (we have an ID here)
        if ($this->unsavedRelations) {

The expression $this->unsavedRelations of type SilverStripe\ORM\UnsavedRelationList[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            foreach ($this->unsavedRelations as $name => $list) {
                $list->changeToList($this->$name());
            }
            $this->unsavedRelations = array();
        }
    }

    /**
     * Write the cached components to the database. Cached components could refer to two different instances of the
     * same record.
     *
     * @param bool $recursive Recursively write components
     * @return DataObject $this
     */
    public function writeComponents($recursive = false)
    {
        if ($this->components) {

The expression $this->components of type SilverStripe\ORM\DataObject[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            foreach ($this->components as $component) {
                $component->write(false, false, false, $recursive);
            }
        }

        if ($join = $this->getJoin()) {
            $join->write(false, false, false, $recursive);
        }

        return $this;
    }

    /**
     * Delete this data object.
     * $this->onBeforeDelete() gets called.
     * Note that in Versioned objects, both Stage and Live will be deleted.
     *  @uses DataExtension->augmentSQL()
     */
    public function delete()
    {
        $this->brokenOnDelete = true;
        $this->onBeforeDelete();
        if ($this->brokenOnDelete) {
            user_error("$this->class has a broken onBeforeDelete() function."
                . " Make sure that you call parent::onBeforeDelete().", E_USER_ERROR);
        }

        // Deleting a record without an ID shouldn't do anything
        if (!$this->ID) {
            throw new LogicException("DataObject::delete() called on a DataObject without an ID");
        }

        // TODO: This is quite ugly.  To improve:
        //  - move the details of the delete code in the DataQuery system
        //  - update the code to just delete the base table, and rely on cascading deletes in the DB to do the rest
        //    obviously, that means getting requireTable() to configure cascading deletes ;-)
        $srcQuery = DataList::create($this->class, $this->model)->where("ID = $this->ID")->dataQuery()->query();
        foreach ($srcQuery->queriedTables() as $table) {
            $delete = new SQLDelete("\"$table\"", array('"ID"' => $this->ID));
            $delete->execute();
        }
        // Remove this item out of any caches
        $this->flushCache();

        $this->onAfterDelete();

        $this->OldID = $this->ID;

The property OldID does not exist on object<SilverStripe\ORM\DataObject>. Since you implemented __set, maybe consider adding a @property annotation.

        $this->ID = 0;
    }

    /**
     * Delete the record with the given ID.
     *
     * @param string $className The class name of the record to be deleted
     * @param int $id ID of record to be deleted
     */
    public static function delete_by_id($className, $id)
    {
        $obj = DataObject::get_by_id($className, $id);

As per coding style, self should be used for accessing local static members.

        if ($obj) {
            $obj->delete();
        } else {
            user_error("$className object #$id wasn't found when calling DataObject::delete_by_id", E_USER_WARNING);
        }
    }

    /**
     * Get the class ancestry, including the current class name.
     * The ancestry will be returned as an array of class names, where the 0th element
     * will be the class that inherits directly from DataObject, and the last element
     * will be the current class.
     *
     * @return array Class ancestry
     */
    public function getClassAncestry()
    {
        return ClassInfo::ancestry(static::class);
    }

    /**
     * Return a component object from a one to one relationship, as a DataObject.
     * If no component is available, an 'empty component' will be returned for
     * non-polymorphic relations, or for polymorphic relations with a class set.
     *
     * @param string $componentName Name of the component
     * @return DataObject The component object. It's exact type will be that of the component.
     * @throws Exception
     */
    public function getComponent($componentName)
    {
        if (isset($this->components[$componentName])) {
            return $this->components[$componentName];
        }

        $schema = static::getSchema();
        if ($class = $schema->hasOneComponent(static::class, $componentName)) {
            $joinField = $componentName . 'ID';
            $joinID    = $this->getField($joinField);

            // Extract class name for polymorphic relations
            if ($class === self::class) {
                $class = $this->getField($componentName . 'Class');
                if (empty($class)) {
                    return null;
                }
            }

            if ($joinID) {
                // Ensure that the selected object originates from the same stage, subsite, etc
                $component = DataObject::get($class)

As per coding style, self should be used for accessing local static members.

                    ->filter('ID', $joinID)
                    ->setDataQueryParam($this->getInheritableQueryParams())
                    ->first();
            }

            if (empty($component)) {
                $component = $this->model->$class->newObject();
            }
        } elseif ($class = $schema->belongsToComponent(static::class, $componentName)) {
            $joinField = $schema->getRemoteJoinField(static::class, $componentName, 'belongs_to', $polymorphic);
            $joinID = $this->ID;

            if ($joinID) {
                // Prepare filter for appropriate join type
                if ($polymorphic) {
                    $filter = array(
                        "{$joinField}ID" => $joinID,
                        "{$joinField}Class" => $this->class
                    );
                } else {
                    $filter = array(
                        $joinField => $joinID
                    );
                }

                // Ensure that the selected object originates from the same stage, subsite, etc
                $component = DataObject::get($class)

As per coding style, self should be used for accessing local static members.

                    ->filter($filter)
                    ->setDataQueryParam($this->getInheritableQueryParams())
                    ->first();
            }

            if (empty($component)) {
                $component = $this->model->$class->newObject();
                if ($polymorphic) {
                    $component->{$joinField.'ID'} = $this->ID;
                    $component->{$joinField.'Class'} = $this->class;
                } else {
                    $component->$joinField = $this->ID;
                }
            }
        } else {
            throw new InvalidArgumentException(
                "DataObject->getComponent(): Could not find component '$componentName'."
            );
        }

        $this->components[$componentName] = $component;
        return $component;
    }

    /**
     * Returns a one-to-many relation as a HasManyList
     *
     * @param string $componentName Name of the component
     * @return HasManyList|UnsavedRelationList The components of the one-to-many relationship.
     */
    public function getComponents($componentName)
    {
        $result = null;

        $schema = $this->getSchema();
        $componentClass = $schema->hasManyComponent(static::class, $componentName);
        if (!$componentClass) {

The expression $componentClass of type string|null is loosely compared to false; this is ambiguous if the string can be empty. You might want to explicitly use === null instead.

            throw new InvalidArgumentException(sprintf(
                "DataObject::getComponents(): Unknown 1-to-many component '%s' on class '%s'",
                $componentName,
                $this->class
            ));
        }

        // If we haven't been written yet, we can't save these relations, so use a list that handles this case
        if (!$this->ID) {
            if (!isset($this->unsavedRelations[$componentName])) {
                $this->unsavedRelations[$componentName] =
                    new UnsavedRelationList($this->class, $componentName, $componentClass);
            }
            return $this->unsavedRelations[$componentName];
        }

        // Determine type and nature of foreign relation
        $joinField = $schema->getRemoteJoinField(static::class, $componentName, 'has_many', $polymorphic);
        /** @var HasManyList $result */
        if ($polymorphic) {
            $result = PolymorphicHasManyList::create($componentClass, $joinField, $this->class);
        } else {
            $result = HasManyList::create($componentClass, $joinField);
        }

        if ($this->model) {
            $result->setDataModel($this->model);
        }

        return $result
            ->setDataQueryParam($this->getInheritableQueryParams())
            ->forForeignID($this->ID);
    }

    /**
     * Find the foreign class of a relation on this DataObject, regardless of the relation type.
     *
     * @param string $relationName Relation name.
     * @return string Class name, or null if not found.
     */
    public function getRelationClass($relationName)
    {
        // Parse many_many
        $manyManyComponent = $this->getSchema()->manyManyComponent(static::class, $relationName);
        if ($manyManyComponent) {
            list(
                $relationClass, $parentClass, $componentClass,

The assignment to $relationClass is unused. Consider omitting it like so list($first,,$third).

The assignment to $parentClass is unused. Consider omitting it like so list($first,,$third).

                $parentField, $childField, $tableOrClass

The assignment to $parentField is unused. Consider omitting it like so list($first,,$third).

The assignment to $childField is unused. Consider omitting it like so list($first,,$third).

The assignment to $tableOrClass is unused. Consider omitting it like so list($first,,$third).

            ) = $manyManyComponent;
            return $componentClass;
        }

        // Go through all relationship configuration fields.
        $candidates = array_merge(
            ($relations = Config::inst()->get($this->class, 'has_one')) ? $relations : array(),
            ($relations = Config::inst()->get($this->class, 'has_many')) ? $relations : array(),
            ($relations = Config::inst()->get($this->class, 'belongs_to')) ? $relations : array()
        );

        if (isset($candidates[$relationName])) {
            $remoteClass = $candidates[$relationName];

            // If dot notation is present, extract just the first part that contains the class.
            if (($fieldPos = strpos($remoteClass, '.'))!==false) {
                return substr($remoteClass, 0, $fieldPos);
            }

            // Otherwise just return the class
            return $remoteClass;
        }

        return null;
    }

    /**
     * Given a relation name, determine the relation type
     *
     * @param string $component Name of component
     * @return string has_one, has_many, many_many, belongs_many_many or belongs_to
     */
    public function getRelationType($component)
    {
        $types = array('has_one', 'has_many', 'many_many', 'belongs_many_many', 'belongs_to');
        foreach ($types as $type) {
            $relations = Config::inst()->get($this->class, $type);
            if ($relations && isset($relations[$component])) {
                return $type;
            }
        }
        return null;
    }

    /**
     * Given a relation declared on a remote class, generate a substitute component for the opposite
     * side of the relation.
     *
     * Notes on behaviour:
     *  - This can still be used on components that are defined on both sides, but do not need to be.
     *  - All has_ones on remote class will be treated as local has_many, even if they are belongs_to
     *  - Cannot be used on polymorphic relationships
     *  - Cannot be used on unsaved objects.
     *
     * @param string $remoteClass
     * @param string $remoteRelation
     * @return DataList|DataObject The component, either as a list or single object
     * @throws BadMethodCallException
     * @throws InvalidArgumentException
     */
    public function inferReciprocalComponent($remoteClass, $remoteRelation)
    {
        $remote = DataObject::singleton($remoteClass);

As per coding style, self should be used for accessing local static members.

        $class = $remote->getRelationClass($remoteRelation);
        $schema = static::getSchema();

        // Validate arguments
        if (!$this->isInDB()) {
            throw new BadMethodCallException(__METHOD__ . " cannot be called on unsaved objects");
        }
        if (empty($class)) {
            throw new InvalidArgumentException(sprintf(
                "%s invoked with invalid relation %s.%s",
                __METHOD__,
                $remoteClass,
                $remoteRelation
            ));
        }
        if ($class === self::class) {
            throw new InvalidArgumentException(sprintf(
                "%s cannot generate opposite component of relation %s.%s as it is polymorphic. " .
                "This method does not support polymorphic relationships",
                __METHOD__,
                $remoteClass,
                $remoteRelation
            ));
        }
        if (!is_a($this, $class, true)) {
            throw new InvalidArgumentException(sprintf(
                "Relation %s on %s does not refer to objects of type %s",
                $remoteRelation,
                $remoteClass,
                static::class
            ));
        }

        // Check the relation type to mock
        $relationType = $remote->getRelationType($remoteRelation);
        switch ($relationType) {
            case 'has_one': {

case statements should be defined using a colon.

                // Mock has_many
                $joinField = "{$remoteRelation}ID";
                $componentClass = $schema->classForField($remoteClass, $joinField);
                $result = HasManyList::create($componentClass, $joinField);
                if ($this->model) {
                    $result->setDataModel($this->model);
                }
                return $result
                    ->setDataQueryParam($this->getInheritableQueryParams())
                    ->forForeignID($this->ID);
            }
            case 'belongs_to':
            case 'has_many': {

case statements should be defined using a colon.

                // These relations must have a has_one on the other end, so find it
                $joinField = $schema->getRemoteJoinField($remoteClass, $remoteRelation, $relationType, $polymorphic);
                if ($polymorphic) {
                    throw new InvalidArgumentException(sprintf(
                        "%s cannot generate opposite component of relation %s.%s, as the other end appears" .
                        "to be a has_one polymorphic. This method does not support polymorphic relationships",
                        __METHOD__,
                        $remoteClass,
                        $remoteRelation
                    ));
                }
                $joinID = $this->getField($joinField);
                if (empty($joinID)) {
                    return null;
                }
                // Get object by joined ID
                return DataObject::get($remoteClass)

As per coding style, self should be used for accessing local static members.

                    ->filter('ID', $joinID)
                    ->setDataQueryParam($this->getInheritableQueryParams())
                    ->first();
            }
            case 'many_many':
            case 'belongs_many_many': {

case statements should be defined using a colon.

                // Get components and extra fields from parent
                list($relationClass, $componentClass, $parentClass, $componentField, $parentField, $table)

The assignment to $parentClass is unused. Consider omitting it like so list($first,,$third).

                    = $remote->getSchema()->manyManyComponent($remoteClass, $remoteRelation);
                $extraFields = $schema->manyManyExtraFieldsForComponent($remoteClass, $remoteRelation) ?: array();

                // Reverse parent and component fields and create an inverse ManyManyList
                /** @var RelationList $result */
                $result = Injector::inst()->create(
                    $relationClass,
                    $componentClass,
                    $table,
                    $componentField,
                    $parentField,
                    $extraFields
                );
                if ($this->model) {
                    $result->setDataModel($this->model);
                }
                $this->extend('updateManyManyComponents', $result);

                // If this is called on a singleton, then we return an 'orphaned relation' that can have the
                // foreignID set elsewhere.
                return $result
                    ->setDataQueryParam($this->getInheritableQueryParams())
                    ->forForeignID($this->ID);
            }
            default: {

DEFAULT statements must be defined using a colon

                return null;
            }
        }
    }

    /**
     * Returns a many-to-many component, as a ManyManyList.
     * @param string $componentName Name of the many-many component
     * @return RelationList|UnsavedRelationList The set of components
     */
    public function getManyManyComponents($componentName)
    {
        $schema = static::getSchema();
        $manyManyComponent = $schema->manyManyComponent(static::class, $componentName);
        if (!$manyManyComponent) {
            throw new InvalidArgumentException(sprintf(
                "DataObject::getComponents(): Unknown many-to-many component '%s' on class '%s'",
                $componentName,
                $this->class
            ));
        }

        list($relationClass, $parentClass, $componentClass, $parentField, $componentField, $tableOrClass)
            = $manyManyComponent;

        // If we haven't been written yet, we can't save these relations, so use a list that handles this case
        if (!$this->ID) {
            if (!isset($this->unsavedRelations[$componentName])) {
                $this->unsavedRelations[$componentName] =
                    new UnsavedRelationList($parentClass, $componentName, $componentClass);
            }
            return $this->unsavedRelations[$componentName];
        }

        $extraFields = $schema->manyManyExtraFieldsForComponent(static::class, $componentName) ?: array();
        /** @var RelationList $result */
        $result = Injector::inst()->create(
            $relationClass,
            $componentClass,
            $tableOrClass,
            $componentField,
            $parentField,
            $extraFields
        );


        // Store component data in query meta-data
        $result = $result->alterDataQuery(function ($query) use ($extraFields) {
            /** @var DataQuery $query */
            $query->setQueryParam('Component.ExtraFields', $extraFields);
        });

        if ($this->model) {
            $result->setDataModel($this->model);
        }

        $this->extend('updateManyManyComponents', $result);

        // If this is called on a singleton, then we return an 'orphaned relation' that can have the
        // foreignID set elsewhere.
        return $result
            ->setDataQueryParam($this->getInheritableQueryParams())
            ->forForeignID($this->ID);
    }

    /**
     * Return the class of a one-to-one component.  If $component is null, return all of the one-to-one components and
     * their classes. If the selected has_one is a polymorphic field then 'DataObject' will be returned for the type.
     *
     * @return string|array The class of the one-to-one component, or an array of all one-to-one components and
     *                          their classes.
     */
    public function hasOne()
    {
        return (array)Config::inst()->get($this->class, 'has_one', Config::INHERITED);
    }

    /**
     * Returns the class of a remote belongs_to relationship. If no component is specified a map of all components and
     * their class name will be returned.
     *
     * @param bool $classOnly If this is TRUE, than any has_many relationships in the form "ClassName.Field" will have
     *        the field data stripped off. It defaults to TRUE.
     * @return string|array
     */
    public function belongsTo($classOnly = true)
    {
        $belongsTo = (array)Config::inst()->get($this->class, 'belongs_to', Config::INHERITED);
        if ($belongsTo && $classOnly) {

The expression $belongsTo of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            return preg_replace('/(.+)?\..+/', '$1', $belongsTo);
        } else {
            return $belongsTo ? $belongsTo : array();
        }
    }

    /**
     * Gets the class of a one-to-many relationship. If no $component is specified then an array of all the one-to-many
     * relationships and their classes will be returned.
     *
     * @param bool $classOnly If this is TRUE, than any has_many relationships in the form "ClassName.Field" will have
     *        the field data stripped off. It defaults to TRUE.
     * @return string|array|false
     */
    public function hasMany($classOnly = true)
    {
        $hasMany = (array)Config::inst()->get($this->class, 'has_many', Config::INHERITED);
        if ($hasMany && $classOnly) {

The expression $hasMany of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            return preg_replace('/(.+)?\..+/', '$1', $hasMany);
        } else {
            return $hasMany ? $hasMany : array();
        }
    }

    /**
     * Return the many-to-many extra fields specification.
     *
     * If you don't specify a component name, it returns all
     * extra fields for all components available.
     *
     * @return array|null
     */
    public function manyManyExtraFields()
    {
        return Config::inst()->get($this->class, 'many_many_extraFields', Config::INHERITED);
    }

    /**
     * Return information about a many-to-many component.
     * The return value is an array of (parentclass, childclass).  If $component is null, then all many-many
     * components are returned.
     *
     * @see DataObjectSchema::manyManyComponent()
     * @return array|null An array of (parentclass, childclass), or an array of all many-many components
     */
    public function manyMany()
    {
        $manyManys = (array)Config::inst()->get($this->class, 'many_many', Config::INHERITED);
        $belongsManyManys = (array)Config::inst()->get($this->class, 'belongs_many_many', Config::INHERITED);
        $items = array_merge($manyManys, $belongsManyManys);
        return $items;
    }

    /**
     * This returns an array (if it exists) describing the database extensions that are required, or false if none
     *
     * This is experimental, and is currently only a Postgres-specific enhancement.
     *
     * @param string $class
     * @return array|false
     */
    public function database_extensions($class)
    {
        $extensions = Config::inst()->get($class, 'database_extensions', Config::UNINHERITED);

        if ($extensions) {
            return $extensions;
        } else {
            return false;
        }
    }

    /**
     * Generates a SearchContext to be used for building and processing
     * a generic search form for properties on this object.
     *
     * @return SearchContext
     */
    public function getDefaultSearchContext()
    {
        return new SearchContext(
            $this->class,
            $this->scaffoldSearchFields(),
            $this->defaultSearchFilters()
        );
    }

    /**
     * Determine which properties on the DataObject are
     * searchable, and map them to their default {@link FormField}
     * representations. Used for scaffolding a searchform for {@link ModelAdmin}.
     *
     * Some additional logic is included for switching field labels, based on
     * how generic or specific the field type is.
     *
     * Used by {@link SearchContext}.
     *
     * @param array $_params
     *   'fieldClasses': Associative array of field names as keys and FormField classes as values
     *   'restrictFields': Numeric array of a field name whitelist
     * @return FieldList
     */
    public function scaffoldSearchFields($_params = null)
    {
        $params = array_merge(
            array(
                'fieldClasses' => false,
                'restrictFields' => false
            ),
            (array)$_params
        );
        $fields = new FieldList();
        foreach ($this->searchableFields() as $fieldName => $spec) {
            if ($params['restrictFields'] && !in_array($fieldName, $params['restrictFields'])) {
                continue;
            }

            // If a custom fieldclass is provided as a string, use it
            $field = null;
            if ($params['fieldClasses'] && isset($params['fieldClasses'][$fieldName])) {
                $fieldClass = $params['fieldClasses'][$fieldName];
                $field = new $fieldClass($fieldName);
            // If we explicitly set a field, then construct that
            } elseif (isset($spec['field'])) {
                // If it's a string, use it as a class name and construct
                if (is_string($spec['field'])) {
                    $fieldClass = $spec['field'];
                    $field = new $fieldClass($fieldName);

                // If it's a FormField object, then just use that object directly.
                } elseif ($spec['field'] instanceof FormField) {
                    $field = $spec['field'];

                // Otherwise we have a bug
                } else {
                    user_error("Bad value for searchable_fields, 'field' value: "
                        . var_export($spec['field'], true), E_USER_WARNING);
                }

            // Otherwise, use the database field's scaffolder
            } else {
                $field = $this->relObject($fieldName)->scaffoldSearchField();
            }

            // Allow fields to opt out of search
            if (!$field) {
                continue;
            }

            if (strstr($fieldName, '.')) {
                $field->setName(str_replace('.', '__', $fieldName));
            }
            $field->setTitle($spec['title']);

            $fields->push($field);
        }
        return $fields;
    }

    /**
     * Scaffold a simple edit form for all properties on this dataobject,
     * based on default {@link FormField} mapping in {@link DBField::scaffoldFormField()}.
     * Field labels/titles will be auto generated from {@link DataObject::fieldLabels()}.
     *
     * @uses FormScaffolder
     *
     * @param array $_params Associative array passing through properties to {@link FormScaffolder}.
     * @return FieldList
     */
    public function scaffoldFormFields($_params = null)
    {
        $params = array_merge(
            array(
                'tabbed' => false,
                'includeRelations' => false,
                'restrictFields' => false,
                'fieldClasses' => false,
                'ajaxSafe' => false
            ),
            (array)$_params
        );

        $fs = new FormScaffolder($this);
        $fs->tabbed = $params['tabbed'];
        $fs->includeRelations = $params['includeRelations'];
        $fs->restrictFields = $params['restrictFields'];

It seems like $params['restrictFields'] of type false is incompatible with the declared type array of property $restrictFields.

        $fs->fieldClasses = $params['fieldClasses'];

It seems like $params['fieldClasses'] of type false is incompatible with the declared type array of property $fieldClasses.

        $fs->ajaxSafe = $params['ajaxSafe'];

        return $fs->getFieldList();
    }

    /**
     * Allows user code to hook into DataObject::getCMSFields prior to updateCMSFields
     * being called on extensions
     *
     * @param callable $callback The callback to execute
     */
    protected function beforeUpdateCMSFields($callback)
    {
        $this->beforeExtending('updateCMSFields', $callback);
    }

    /**
     * Centerpiece of every data administration interface in Silverstripe,
     * which returns a {@link FieldList} suitable for a {@link Form} object.
     * If not overloaded, we're using {@link scaffoldFormFields()} to automatically
     * generate this set. To customize, overload this method in a subclass
     * or extended onto it by using {@link DataExtension->updateCMSFields()}.
     *
     * <code>
     * class MyCustomClass extends DataObject {
     *  static $db = array('CustomProperty'=>'Boolean');
     *
     *  function getCMSFields() {
     *    $fields = parent::getCMSFields();
     *    $fields->addFieldToTab('Root.Content',new CheckboxField('CustomProperty'));
     *    return $fields;
     *  }
     * }
     * </code>
     *
     * @see Good example of complex FormField building: SiteTree::getCMSFields()
     *
     * @return FieldList Returns a TabSet for usage within the CMS - don't use for frontend forms.
     */
    public function getCMSFields()
    {
        $tabbedFields = $this->scaffoldFormFields(array(
            // Don't allow has_many/many_many relationship editing before the record is first saved
            'includeRelations' => ($this->ID > 0),
            'tabbed' => true,
            'ajaxSafe' => true
        ));

        $this->extend('updateCMSFields', $tabbedFields);

        return $tabbedFields;
    }

    /**
     * need to be overload by solid dataobject, so that the customised actions of that dataobject,
     * including that dataobject's extensions customised actions could be added to the EditForm.
     *
     * @return FieldList an Empty FieldList(); need to be overload by solid subclass
     */
    public function getCMSActions()
    {
        $actions = new FieldList();
        $this->extend('updateCMSActions', $actions);
        return $actions;
    }


    /**
     * Used for simple frontend forms without relation editing
     * or {@link TabSet} behaviour. Uses {@link scaffoldFormFields()}
     * by default. To customize, either overload this method in your
     * subclass, or extend it by {@link DataExtension->updateFrontEndFields()}.
     *
     * @todo Decide on naming for "website|frontend|site|page" and stick with it in the API
     *
     * @param array $params See {@link scaffoldFormFields()}
     * @return FieldList Always returns a simple field collection without TabSet.
     */
    public function getFrontEndFields($params = null)
    {
        $untabbedFields = $this->scaffoldFormFields($params);
        $this->extend('updateFrontEndFields', $untabbedFields);

        return $untabbedFields;
    }

    /**
     * Gets the value of a field.
     * Called by {@link __get()} and any getFieldName() methods you might create.
     *
     * @param string $field The name of the field
     * @return mixed The field value
     */
    public function getField($field)
    {
        // If we already have an object in $this->record, then we should just return that
        if (isset($this->record[$field]) && is_object($this->record[$field])) {
            return $this->record[$field];
        }

        // Do we have a field that needs to be lazy loaded?
        if (isset($this->record[$field.'_Lazy'])) {
            $tableClass = $this->record[$field.'_Lazy'];
            $this->loadLazyFields($tableClass);
        }

        // In case of complex fields, return the DBField object
        if (static::getSchema()->compositeField(static::class, $field)) {

The expression static::getSchema()->compositeField(static::class, $field) of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            $this->record[$field] = $this->dbObject($field);
        }

        return isset($this->record[$field]) ? $this->record[$field] : null;
    }

    /**
     * Loads all the stub fields that an initial lazy load didn't load fully.
     *
     * @param string $class Class to load the values from. Others are joined as required.
     * Not specifying a tableClass will load all lazy fields from all tables.
     * @return bool Flag if lazy loading succeeded
     */
    protected function loadLazyFields($class = null)
    {
        if (!$this->isInDB() || !is_numeric($this->ID)) {
            return false;
        }

        if (!$class) {

The expression $class of type string|null is loosely compared to false; this is ambiguous if the string can be empty. You might want to explicitly use === null instead.

            $loaded = array();

            foreach ($this->record as $key => $value) {
                if (strlen($key) > 5 && substr($key, -5) == '_Lazy' && !array_key_exists($value, $loaded)) {
                    $this->loadLazyFields($value);
                    $loaded[$value] = $value;
                }
            }

            return false;
        }

        $dataQuery = new DataQuery($class);

        // Reset query parameter context to that of this DataObject
        if ($params = $this->getSourceQueryParams()) {
            foreach ($params as $key => $value) {
                $dataQuery->setQueryParam($key, $value);
            }
        }

        // Limit query to the current record, unless it has the Versioned extension,
        // in which case it requires special handling through augmentLoadLazyFields()
        $schema = static::getSchema();
        $baseIDColumn = $schema->sqlColumnForField($this, 'ID');
        $dataQuery->where([
            $baseIDColumn => $this->record['ID']
        ])->limit(1);

        $columns = array();

        // Add SQL for fields, both simple & multi-value
        // TODO: This is copy & pasted from buildSQL(), it could be moved into a method
        $databaseFields = $schema->databaseFields($class, false);
        foreach ($databaseFields as $k => $v) {
            if (!isset($this->record[$k]) || $this->record[$k] === null) {
                $columns[] = $k;
            }
        }

        if ($columns) {

The expression $columns of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $query = $dataQuery->query();
            $this->extend('augmentLoadLazyFields', $query, $dataQuery, $this);
            $this->extend('augmentSQL', $query, $dataQuery);

            $dataQuery->setQueriedColumns($columns);
            $newData = $dataQuery->execute()->record();

            // Load the data into record
            if ($newData) {
                foreach ($newData as $k => $v) {
                    if (in_array($k, $columns)) {
                        $this->record[$k] = $v;
                        $this->original[$k] = $v;
                        unset($this->record[$k . '_Lazy']);
                    }
                }

            // No data means that the query returned nothing; assign 'null' to all the requested fields
            } else {
                foreach ($columns as $k) {
                    $this->record[$k] = null;
                    $this->original[$k] = null;
                    unset($this->record[$k . '_Lazy']);
                }
            }
        }
        return true;
    }

    /**
     * Return the fields that have changed.
     *
     * The change level affects what the functions defines as "changed":
     * - Level CHANGE_STRICT (integer 1) will return strict changes, even !== ones.
     * - Level CHANGE_VALUE (integer 2) is more lenient, it will only return real data changes,
     *   for example a change from 0 to null would not be included.
     *
     * Example return:
     * <code>
     * array(
     *   'Title' = array('before' => 'Home', 'after' => 'Home-Changed', 'level' => DataObject::CHANGE_VALUE)
     * )
     * </code>
     *
     * @param boolean|array $databaseFieldsOnly Filter to determine which fields to return. Set to true
     * to return all database fields, or an array for an explicit filter. false returns all fields.
     * @param int $changeLevel The strictness of what is defined as change. Defaults to strict
     * @return array
     */
    public function getChangedFields($databaseFieldsOnly = false, $changeLevel = self::CHANGE_STRICT)
    {
        $changedFields = array();

        // Update the changed array with references to changed obj-fields
        foreach ($this->record as $k => $v) {
            // Prevents DBComposite infinite looping on isChanged
            if (is_array($databaseFieldsOnly) && !in_array($k, $databaseFieldsOnly)) {
                continue;
            }
            if (is_object($v) && method_exists($v, 'isChanged') && $v->isChanged()) {
                $this->changed[$k] = self::CHANGE_VALUE;
            }
        }

        if (is_array($databaseFieldsOnly)) {
            $fields = array_intersect_key((array)$this->changed, array_flip($databaseFieldsOnly));
        } elseif ($databaseFieldsOnly) {
            $fieldsSpecs = static::getSchema()->fieldSpecs(static::class);
            $fields = array_intersect_key((array)$this->changed, $fieldsSpecs);
        } else {
            $fields = $this->changed;
        }

        // Filter the list to those of a certain change level
        if ($changeLevel > self::CHANGE_STRICT) {
            if ($fields) {

The expression $fields of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

                foreach ($fields as $name => $level) {
                    if ($level < $changeLevel) {
                        unset($fields[$name]);
                    }
                }
            }
        }

        if ($fields) {

The expression $fields of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            foreach ($fields as $name => $level) {
                $changedFields[$name] = array(
                'before' => array_key_exists($name, $this->original) ? $this->original[$name] : null,
                'after' => array_key_exists($name, $this->record) ? $this->record[$name] : null,
                'level' => $level
                            );
            }
        }

        return $changedFields;
    }

    /**
     * Uses {@link getChangedFields()} to determine if fields have been changed
     * since loading them from the database.
     *
     * @param string $fieldName Name of the database field to check, will check for any if not given
     * @param int $changeLevel See {@link getChangedFields()}
     * @return boolean
     */
    public function isChanged($fieldName = null, $changeLevel = self::CHANGE_STRICT)
    {
        $fields = $fieldName ? array($fieldName) : true;
        $changed = $this->getChangedFields($fields, $changeLevel);
        if (!isset($fieldName)) {
            return !empty($changed);
        } else {
            return array_key_exists($fieldName, $changed);
        }
    }

    /**
     * Set the value of the field
     * Called by {@link __set()} and any setFieldName() methods you might create.
     *
     * @param string $fieldName Name of the field
     * @param mixed $val New field value
     * @return $this
     */
    public function setField($fieldName, $val)
    {
        $this->objCacheClear();
        //if it's a has_one component, destroy the cache
        if (substr($fieldName, -2) == 'ID') {
            unset($this->components[substr($fieldName, 0, -2)]);
        }

        // If we've just lazy-loaded the column, then we need to populate the $original array
        if (isset($this->record[$fieldName.'_Lazy'])) {
            $tableClass = $this->record[$fieldName.'_Lazy'];
            $this->loadLazyFields($tableClass);
        }

        // Situation 1: Passing an DBField
        if ($val instanceof DBField) {
            $val->setName($fieldName);
            $val->saveInto($this);

            // Situation 1a: Composite fields should remain bound in case they are
            // later referenced to update the parent dataobject
            if ($val instanceof DBComposite) {
                $val->bindTo($this);
                $this->record[$fieldName] = $val;
            }
        // Situation 2: Passing a literal or non-DBField object
        } else {
            // If this is a proper database field, we shouldn't be getting non-DBField objects
            if (is_object($val) && static::getSchema()->fieldSpec(static::class, $fieldName)) {

The expression static::getSchema()->fieldSpec(static::class, $fieldName) of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

                throw new InvalidArgumentException('DataObject::setField: passed an object that is not a DBField');
            }

            // if a field is not existing or has strictly changed
            if (!isset($this->record[$fieldName]) || $this->record[$fieldName] !== $val) {
                // TODO Add check for php-level defaults which are not set in the db
                // TODO Add check for hidden input-fields (readonly) which are not set in the db
                // At the very least, the type has changed
                $this->changed[$fieldName] = self::CHANGE_STRICT;

                if ((!isset($this->record[$fieldName]) && $val)
                    || (isset($this->record[$fieldName]) && $this->record[$fieldName] != $val)
                ) {
                    // Value has changed as well, not just the type
                    $this->changed[$fieldName] = self::CHANGE_VALUE;
                }

                // Value is always saved back when strict check succeeds.
                $this->record[$fieldName] = $val;
            }
        }
        return $this;
    }

    /**
     * Set the value of the field, using a casting object.
     * This is useful when you aren't sure that a date is in SQL format, for example.
     * setCastedField() can also be used, by forms, to set related data.  For example, uploaded images
     * can be saved into the Image table.
     *
     * @param string $fieldName Name of the field
     * @param mixed $value New field value
     * @return $this
     */
    public function setCastedField($fieldName, $value)
    {
        if (!$fieldName) {
            user_error("DataObject::setCastedField: Called without a fieldName", E_USER_ERROR);
        }
        $fieldObj = $this->dbObject($fieldName);
        if ($fieldObj) {
            $fieldObj->setValue($value);
            $fieldObj->saveInto($this);
        } else {
            $this->$fieldName = $value;
        }
        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function castingHelper($field)
    {
        $fieldSpec = static::getSchema()->fieldSpec(static::class, $field);
        if ($fieldSpec) {

The expression $fieldSpec of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            return $fieldSpec;
        }

        // many_many_extraFields aren't presented by db(), so we check if the source query params
        // provide us with meta-data for a many_many relation we can inspect for extra fields.
        $queryParams = $this->getSourceQueryParams();
        if (!empty($queryParams['Component.ExtraFields'])) {
            $extraFields = $queryParams['Component.ExtraFields'];

            if (isset($extraFields[$field])) {
                return $extraFields[$field];
            }
        }

        return parent::castingHelper($field);
    }

    /**
     * Returns true if the given field exists in a database column on any of
     * the objects tables and optionally look up a dynamic getter with
     * get<fieldName>().
     *
     * @param string $field Name of the field
     * @return boolean True if the given field exists
     */
    public function hasField($field)
    {
        $schema = static::getSchema();
        return (
            array_key_exists($field, $this->record)
            || $schema->fieldSpec(static::class, $field)

The expression $schema->fieldSpec(static::class, $field) of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            || (substr($field, -2) == 'ID') && $schema->hasOneComponent(static::class, substr($field, 0, -2))

The expression $schema->hasOneComponent(static::class, substr($field, 0, -2)) of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            || $this->hasMethod("get{$field}")
        );
    }

    /**
     * Returns true if the given field exists as a database column
     *
     * @param string $field Name of the field
     *
     * @return boolean
     */
    public function hasDatabaseField($field)
    {
        $spec = static::getSchema()->fieldSpec(static::class, $field, DataObjectSchema::DB_ONLY);
        return !empty($spec);
    }

    /**
     * Returns true if the member is allowed to do the given action.
     * See {@link extendedCan()} for a more versatile tri-state permission control.
     *
     * @param string $perm The permission to be checked, such as 'View'.
     * @param Member $member The member whose permissions need checking.  Defaults to the currently logged
     * in user.
     * @param array $context Additional $context to pass to extendedCan()
     *
     * @return boolean True if the the member is allowed to do the given action
     */
    public function can($perm, $member = null, $context = array())
    {
        if (!isset($member)) {
            $member = Member::currentUser();
        }
        if (Permission::checkMember($member, "ADMIN")) {
            return true;
        }

        if ($this->getSchema()->manyManyComponent(static::class, 'Can' . $perm)) {
            if ($this->ParentID && $this->SecurityType == 'Inherit') {
                if (!($p = $this->Parent)) {

The property Parent does not exist on object<SilverStripe\ORM\DataObject>. Since you implemented __set, maybe consider adding a @property annotation.

                    return false;
                }
                return $this->Parent->can($perm, $member);
            } else {
                $permissionCache = $this->uninherited('permissionCache');
                $memberID = $member ? $member->ID : 'none';

                if (!isset($permissionCache[$memberID][$perm])) {
                    if ($member->ID) {
                        $groups = $member->Groups();
                    }

                    $groupList = implode(', ', $groups->column("ID"));

The variable $groups does not seem to be defined for all execution paths leading up to this point.

                    // TODO Fix relation table hardcoding
                    $query = new SQLSelect(
                        "\"Page_Can$perm\".PageID",
                        array("\"Page_Can$perm\""),
                        "GroupID IN ($groupList)"
                    );

                    $permissionCache[$memberID][$perm] = $query->execute()->column();

                    if ($perm == "View") {
                        // TODO Fix relation table hardcoding
                        $query = new SQLSelect("\"SiteTree\".\"ID\"", array(
                            "\"SiteTree\"",
                            "LEFT JOIN \"Page_CanView\" ON \"Page_CanView\".\"PageID\" = \"SiteTree\".\"ID\""
                            ), "\"Page_CanView\".\"PageID\" IS NULL");

                            $unsecuredPages = $query->execute()->column();
                        if ($permissionCache[$memberID][$perm]) {
                            $permissionCache[$memberID][$perm]
                            = array_merge($permissionCache[$memberID][$perm], $unsecuredPages);
                        } else {
                            $permissionCache[$memberID][$perm] = $unsecuredPages;
                        }
                    }

                    Config::inst()->update($this->class, 'permissionCache', $permissionCache);
                }

                if ($permissionCache[$memberID][$perm]) {
                    return in_array($this->ID, $permissionCache[$memberID][$perm]);
                }
            }
        } else {
            return parent::can($perm, $member);

It seems like you code against a specific sub-type and not the parent class SilverStripe\View\ViewableData as the method can() does only exist in the following sub-classes of SilverStripe\View\ViewableData: FormFactoryTest_TestController, FormFactoryTest_TestObject, SilverStripe\Admin\AdminRootController, SilverStripe\Admin\CMSProfileController, SilverStripe\Admin\CampaignAdmin, SilverStripe\Admin\LeftAndMain, SilverStripe\Admin\ModelAdmin, SilverStripe\Admin\SecurityAdmin, SilverStripe\Admin\Tests\CMSMenuTest\CustomTitle, SilverStripe\Admin\Tests\CMSMenuTest\LeftAndMainController, SilverStripe\Admin\Tests\CampaignAdminTest\InvalidChangeSet, SilverStripe\Admin\Tests\LeftAndMainTest\TestController, SilverStripe\Admin\Tests\LeftAndMainTest\TestObject, SilverStripe\Admin\Tests\ModelAdminTest\Contact, SilverStripe\Admin\Tests\ModelAdminTest\ContactAdmin, SilverStripe\Admin\Tests\ModelAdminTest\Player, SilverStripe\Admin\Tests\ModelAdminTest\PlayerAdmin, SilverStripe\Assets\File, SilverStripe\Assets\Folder, SilverStripe\Assets\Image, SilverStripe\Assets\Storage\ProtectedFileController, SilverStripe\Assets\Tests\AssetControlExtensionTest\ArchivedObject, SilverStripe\Assets\Tests\AssetControlExtensionTest\TestObject, SilverStripe\Assets\Tests\AssetControlExtensionTest\VersionedObject, SilverStripe\Assets\Tests\FileTest\MyCustomFile, SilverStripe\Assets\Upload, SilverStripe\Control\CliController, SilverStripe\Control\Controller, SilverStripe\Control\Tests\ControllerTest\AccessBaseController, SilverStripe\Control\Tests\ControllerTest\AccessSecuredController, SilverStripe\Control\Tests\ControllerTest\AccessWildcardSecuredController, SilverStripe\Control\Tests\ControllerTest\ContainerController, SilverStripe\Control\Tests\ControllerTest\HasAction, SilverStripe\Control\Tests\ControllerTest\HasAction_Unsecured, SilverStripe\Control\Tests\ControllerTest\IndexSecuredController, SilverStripe\Control\Tests\ControllerTest\SubController, SilverStripe\Control\Tests\ControllerTest\TestController, SilverStripe\Control\Tests\ControllerTest\UnsecuredController, SilverStripe\Control\Tests\DirectorTest\TestController, SilverStripe\Control\Tests\FakeController, SilverStripe\Control\Tests\RequestHandlingTest\AllowedController, SilverStripe\Control\Tests\RequestHandlingTest\ControllerFormWithAllowedActions, SilverStripe\Control\Tests\RequestHandlingTest\FieldController, SilverStripe\Control\Tests\RequestHandlingTest\FormActionController, SilverStripe\Control\Tests\RequestHandlingTest\TestController, SilverStripe\Core\Tests\ClassInfoTest\BaseClass, SilverStripe\Core\Tests\ClassInfoTest\BaseDataClass, SilverStripe\Core\Tests\ClassInfoTest\ChildClass, SilverStripe\Core\Tests\ClassInfoTest\GrandChildClass, SilverStripe\Core\Tests\ClassInfoTest\HasFields, SilverStripe\Core\Tests\ClassInfoTest\NoFields, SilverStripe\Core\Tests\ClassInfoTest\WithCustomTable, SilverStripe\Core\Tests\ClassInfoTest\WithRelation, SilverStripe\Dev\DevBuildController, SilverStripe\Dev\DevelopmentAdmin, SilverStripe\Dev\InstallerTest, SilverStripe\Dev\SapphireInfo, SilverStripe\Dev\SapphireREPL, SilverStripe\Dev\TaskRunner, SilverStripe\Dev\Tests\BulkLoaderResultTest\Player, SilverStripe\Dev\Tests\CsvBulkLoaderTest\Player, SilverStripe\Dev\Tests\CsvBulkLoaderTest\PlayerContract, SilverStripe\Dev\Tests\CsvBulkLoaderTest\Team, SilverStripe\Dev\Tests\DevAdminControllerTest\Controller1, SilverStripe\Dev\Tests\FixtureBlueprintTest\Article, SilverStripe\Dev\Tests\FixtureBlueprintTest\TestPage, SilverStripe\Dev\Tests\FixtureBlueprintTest\TestSiteTree, SilverStripe\Dev\Tests\FixtureFactoryTest\DataObjectRelation, SilverStripe\Dev\Tests\FixtureFactoryTest\TestDataObject, SilverStripe\Dev\Tests\YamlFixtureTest\DataObjectRelation, SilverStripe\Dev\Tests\YamlFixtureTest\TestDataObject, SilverStripe\Forms\Tests\AssetFieldTest\TestController, SilverStripe\Forms\Tests\AssetFieldTest\TestObject, SilverStripe\Forms\Tests\CheckboxFieldtest\Article, SilverStripe\Forms\Tests\CheckboxSetFieldTest\Article, SilverStripe\Forms\Tests\CheckboxSetFieldTest\Tag, SilverStripe\Forms\Tests\DBFileTest\ImageOnly, SilverStripe\Forms\Tests\DBFileTest\Subclass, SilverStripe\Forms\Tests\DBFileTest\TestObject, SilverStripe\Forms\Tests\DatetimeFieldTest\Model, SilverStripe\Forms\Tests\EmailFieldTest\TestController, SilverStripe\Forms\Tests\FormScaffolderTest\Article, SilverStripe\Forms\Tests\FormScaffolderTest\Author, SilverStripe\Forms\Tests\FormScaffolderTest\Tag, SilverStripe\Forms\Tests\FormTest\ControllerWithSecurityToken, SilverStripe\Forms\Tests\FormTest\ControllerWithStrictPostCheck, SilverStripe\Forms\Tests\FormTest\Player, SilverStripe\Forms\Tests\FormTest\Team, SilverStripe\Forms\Tests\FormTest\TestController, SilverStripe\Forms\Tests\GridField\GridFieldAddExistingAutocompleterTest\TestController, SilverStripe\Forms\Tests\GridField\GridFieldDetailFormTest\Category, SilverStripe\Forms\Tests\GridField\GridFieldDetailFormTest\CategoryController, SilverStripe\Forms\Tests\GridField\GridFieldDetailFormTest\GroupController, SilverStripe\Forms\Tests\GridField\GridFieldDetailFormTest\PeopleGroup, SilverStripe\Forms\Tests\GridField\GridFieldDetailFormTest\Person, SilverStripe\Forms\Tests\GridField\GridFieldDetailFormTest\TestController, SilverStripe\Forms\Tests\GridField\GridFieldExportButtonTest\NoView, SilverStripe\Forms\Tests\GridField\GridFieldExportButtonTest\Team, SilverStripe\Forms\Tests\GridField\GridFieldPrintButtonTest\TestObject, SilverStripe\Forms\Tests\GridField\GridFieldSortableHeaderTest\Cheerleader, SilverStripe\Forms\Tests\GridField\GridFieldSortableHeaderTest\CheerleaderHat, SilverStripe\Forms\Tests\GridField\GridFieldSortableHeaderTest\Mom, SilverStripe\Forms\Tests\GridField\GridFieldSortableHeaderTest\Team, SilverStripe\Forms\Tests\GridField\GridFieldSortableHeaderTest\TeamGroup, SilverStripe\Forms\Tests\GridField\GridFieldTest\Cheerleader, SilverStripe\Forms\Tests\GridField\GridFieldTest\Permissions, SilverStripe\Forms\Tests\GridField\GridFieldTest\Player, SilverStripe\Forms\Tests\GridField\GridFieldTest\Team, SilverStripe\Forms\Tests\GridField\GridField_URLHandlerTest\TestController, SilverStripe\Forms\Tests\HTMLEditor\HTMLEditorFieldTest\TestObject, SilverStripe\Forms\Tests\ListboxFieldTest\Article, SilverStripe\Forms\Tests\ListboxFieldTest\Tag, SilverStripe\Forms\Tests\ListboxFieldTest\TestObject, SilverStripe\Forms\Tests\MoneyFieldTest\CustomSetter_Object, SilverStripe\Forms\Tests\MoneyFieldTest\TestObject, SilverStripe\Forms\Tests\NumericFieldTest\TestObject, SilverStripe\Forms\Tests\UploadFieldTest\ExtendedFile, SilverStripe\Forms\Tests\UploadFieldTest\TestController, SilverStripe\Forms\Tests\UploadFieldTest\TestRecord, SilverStripe\Framework\Tests\ClassI, SilverStripe\ORM\DataObject, SilverStripe\ORM\DatabaseAdmin, SilverStripe\ORM\Tests\ChangeSetItemTest\VersionedObject, SilverStripe\ORM\Tests\ChangeSetTest\BaseObject, SilverStripe\ORM\Tests\ChangeSetTest\EndObject, SilverStripe\ORM\Tests\ChangeSetTest\EndObjectChild, SilverStripe\ORM\Tests\ChangeSetTest\MidObject, SilverStripe\ORM\Tests\ComponentSetTest\Player, SilverStripe\ORM\Tests\ComponentSetTest\Team, SilverStripe\ORM\Tests\DBClassNameTest\CustomDefault, SilverStripe\ORM\Tests\DBClassNameTest\CustomDefaultSubclass, SilverStripe\ORM\Tests\DBClassNameTest\ObjectSubClass, SilverStripe\ORM\Tests\DBClassNameTest\ObjectSubSubClass, SilverStripe\ORM\Tests\DBClassNameTest\OtherClass, SilverStripe\ORM\Tests\DBClassNameTest\TestObject, SilverStripe\ORM\Tests\DBCompositeTest\SubclassedDBFieldObject, SilverStripe\ORM\Tests\DBCompositeTest\TestObject, SilverStripe\ORM\Tests\DBMoneyTest\TestObject, SilverStripe\ORM\Tests\DBMoneyTest\TestObjectSubclass, SilverStripe\ORM\Tests\DataDifferencerTest\HasOneRelationObject, SilverStripe\ORM\Tests\DataDifferencerTest\TestObject, SilverStripe\ORM\Tests\DataExtensionTest\CMSFieldsBase, SilverStripe\ORM\Tests\DataExtensionTest\CMSFieldsChild, SilverStripe\ORM\Tests\DataExtensionTest\CMSFieldsGrandChild, SilverStripe\ORM\Tests\DataExtensionTest\MyObject, SilverStripe\ORM\Tests\DataExtensionTest\Player, SilverStripe\ORM\Tests\DataExtensionTest\RelatedObject, SilverStripe\ORM\Tests\DataExtensionTest\TestMember, SilverStripe\ORM\Tests\DataObjectDuplicationTest\Class1, SilverStripe\ORM\Tests\DataObjectDuplicationTest\Class2, SilverStripe\ORM\Tests\DataObjectDuplicationTest\Class3, SilverStripe\ORM\Tests\DataObjectLazyLoadingTest\VersionedObject, SilverStripe\ORM\Tests\DataObjectLazyLoadingTest\VersionedSubObject, SilverStripe\ORM\Tests\DataObjectSchemaGenerationTest\TestIndexObject, SilverStripe\ORM\Tests\DataObjectSchemaGenerationTest\TestObject, SilverStripe\ORM\Tests\DataObjectSchemaTest\BaseClass, SilverStripe\ORM\Tests\DataObjectSchemaTest\BaseDataClass, SilverStripe\ORM\Tests\DataObjectSchemaTest\ChildClass, SilverStripe\ORM\Tests\DataObjectSchemaTest\GrandChildClass, SilverStripe\ORM\Tests\DataObjectSchemaTest\HasFields, SilverStripe\ORM\Tests\DataObjectSchemaTest\NoFields, SilverStripe\ORM\Tests\DataObjectSchemaTest\WithCustomTable, SilverStripe\ORM\Tests\DataObjectSchemaTest\WithRelation, SilverStripe\ORM\Tests\DataObjectTest\Bogey, SilverStripe\ORM\Tests\DataObjectTest\CEO, SilverStripe\ORM\Tests\DataObjectTest\Company, SilverStripe\ORM\Tests\DataObjectTest\EquipmentCompany, SilverStripe\ORM\Tests\DataObjectTest\ExtendedTeamComment, SilverStripe\ORM\Tests\DataObjectTest\Fan, SilverStripe\ORM\Tests\DataObjectTest\FieldlessSubTable, SilverStripe\ORM\Tests\DataObjectTest\FieldlessTable, SilverStripe\ORM\Tests\DataObjectTest\Fixture, SilverStripe\ORM\Tests\DataObjectTest\OtherSubclassWithSameField, SilverStripe\ORM\Tests\DataObjectTest\Play, SilverStripe\ORM\Tests\DataObjectTest\Player, SilverStripe\ORM\Tests\DataObjectTest\Ploy, SilverStripe\ORM\Tests\DataObjectTest\Sortable, SilverStripe\ORM\Tests\DataObjectTest\Staff, SilverStripe\ORM\Tests\DataObjectTest\SubEquipmentCompany, SilverStripe\ORM\Tests\DataObjectTest\SubTeam, SilverStripe\ORM\Tests\DataObjectTest\Team, SilverStripe\ORM\Tests\DataObjectTest\TeamComment, SilverStripe\ORM\Tests\DataObjectTest\ValidatedObject, SilverStripe\ORM\Tests\DataQueryTest\ObjectA, SilverStripe\ORM\Tests\DataQueryTest\ObjectB, SilverStripe\ORM\Tests\DataQueryTest\ObjectC, SilverStripe\ORM\Tests\DataQueryTest\ObjectD, SilverStripe\ORM\Tests\DataQueryTest\ObjectE, SilverStripe\ORM\Tests\DataQueryTest\ObjectF, SilverStripe\ORM\Tests\DataQueryTest\ObjectG, SilverStripe\ORM\Tests\DatabaseTest\MyObject, SilverStripe\ORM\Tests\DecimalTest\TestObject, SilverStripe\ORM\Tests\Filters\FulltextFilterTest\TestObject, SilverStripe\ORM\Tests\Filters\SearchFilterApplyRelationTest\HasManyChild, SilverStripe\ORM\Tests\Filters\SearchFilterApplyRelationTest\HasManyGrandChild, SilverStripe\ORM\Tests\Filters\SearchFilterApplyRelationTest\HasManyParent, SilverStripe\ORM\Tests\Filters\SearchFilterApplyRelationTest\HasOneChild, SilverStripe\ORM\Tests\Filters\SearchFilterApplyRelationTest\HasOneGrandChild, SilverStripe\ORM\Tests\Filters\SearchFilterApplyRelationTest\HasOneParent, SilverStripe\ORM\Tests\Filters\SearchFilterApplyRelationTest\ManyManyChild, SilverStripe\ORM\Tests\Filters\SearchFilterApplyRelationTest\ManyManyGrandChild, SilverStripe\ORM\Tests\Filters\SearchFilterApplyRelationTest\ManyManyParent, SilverStripe\ORM\Tests\Filters\SearchFilterApplyRelationTest\TestObject, SilverStripe\ORM\Tests\HierarchyTest\HideTestObject, SilverStripe\ORM\Tests\HierarchyTest\HideTestSubObject, SilverStripe\ORM\Tests\HierarchyTest\TestObject, SilverStripe\ORM\Tests\ManyManyListTest\Category, SilverStripe\ORM\Tests\ManyManyListTest\ExtraFieldsObject, SilverStripe\ORM\Tests\ManyManyListTest\IndirectPrimary, SilverStripe\ORM\Tests\ManyManyListTest\Product, SilverStripe\ORM\Tests\ManyManyListTest\Secondary, SilverStripe\ORM\Tests\ManyManyListTest\SecondarySub, SilverStripe\ORM\Tests\ManyManyThroughListTest\Item, SilverStripe\ORM\Tests\ManyManyThroughListTest\JoinObject, SilverStripe\ORM\Tests\ManyManyThroughListTest\TestObject, SilverStripe\ORM\Tests\ManyManyThroughListTest\VersionedItem, SilverStripe\ORM\Tests\ManyManyThroughListTest\VersionedJoinObject, SilverStripe\ORM\Tests\ManyManyThroughListTest\VersionedObject, SilverStripe\ORM\Tests\MySQLDatabaseTest\Data, SilverStripe\ORM\Tests\SQLInsertTest\SQLInsertTestBase, SilverStripe\ORM\Tests\SQLSelectTest\TestBase, SilverStripe\ORM\Tests\SQLSelectTest\TestChild, SilverStripe\ORM\Tests\SQLSelectTest\TestObject, SilverStripe\ORM\Tests\SQLUpdateTest\TestBase, SilverStripe\ORM\Tests\SQLUpdateTest\TestChild, SilverStripe\ORM\Tests\Search\SearchContextTest\Action, SilverStripe\ORM\Tests\Search\SearchContextTest\AllFilterTypes, SilverStripe\ORM\Tests\Search\SearchContextTest\Book, SilverStripe\ORM\Tests\Search\SearchContextTest\Company, SilverStripe\ORM\Tests\Search\SearchContextTest\Deadline, SilverStripe\ORM\Tests\Search\SearchContextTest\Person, SilverStripe\ORM\Tests\Search\SearchContextTest\Project, SilverStripe\ORM\Tests\TransactionTest\TestObject, SilverStripe\ORM\Tests\UnsavedRelationListTest\TestObject, SilverStripe\ORM\Tests\VersionableExtensionsTest\TestObject, SilverStripe\ORM\Tests\VersionedOwnershipTest\Attachment, SilverStripe\ORM\Tests\VersionedOwnershipTest\Banner, SilverStripe\ORM\Tests\VersionedOwnershipTest\CustomRelation, SilverStripe\ORM\Tests\VersionedOwnershipTest\Image, SilverStripe\ORM\Tests\VersionedOwnershipTest\Related, SilverStripe\ORM\Tests\VersionedOwnershipTest\RelatedMany, SilverStripe\ORM\Tests\VersionedOwnershipTest\Subclass, SilverStripe\ORM\Tests\VersionedOwnershipTest\TestObject, SilverStripe\ORM\Tests\VersionedOwnershipTest\TestPage, SilverStripe\ORM\Tests\VersionedTest\AnotherSubclass, SilverStripe\ORM\Tests\VersionedTest\CustomTable, SilverStripe\ORM\Tests\VersionedTest\PublicStage, SilverStripe\ORM\Tests\VersionedTest\PublicViaExtension, SilverStripe\ORM\Tests\VersionedTest\RelatedWithoutversion, SilverStripe\ORM\Tests\VersionedTest\SingleStage, SilverStripe\ORM\Tests\VersionedTest\Subclass, SilverStripe\ORM\Tests\VersionedTest\TestObject, SilverStripe\ORM\Tests\VersionedTest\UnversionedWithField, SilverStripe\ORM\Tests\VersionedTest\WithIndexes, SilverStripe\ORM\Versioning\ChangeSet, SilverStripe\ORM\Versioning\ChangeSetItem, SilverStripe\Security\CMSSecurity, SilverStripe\Security\Group, SilverStripe\Security\LoginAttempt, SilverStripe\Security\Member, SilverStripe\Security\MemberPassword, SilverStripe\Security\Permission, SilverStripe\Security\PermissionRole, SilverStripe\Security\PermissionRoleCode, SilverStripe\Security\RememberLoginHash, SilverStripe\Security\Security, SilverStripe\Security\Tests\BasicAuthTest\ControllerSecuredWithPermission, SilverStripe\Security\Tests\BasicAuthTest\ControllerSecuredWithoutPermission, SilverStripe\Security\Tests\GroupTest\TestMember, SilverStripe\Security\Tests\SecurityTest\NullController, SilverStripe\Security\Tests\SecurityTest\SecuredController, SilverStripe\View\Tests\SSViewerCacheBlockTest\TestModel, SilverStripe\View\Tests\SSViewerCacheBlockTest\VersionedModel, SilverStripe\View\Tests\SSViewerTest\SSViewerTestModel, SilverStripe\View\Tests\SSViewerTest\SSViewerTestModel_Controller, SilverStripe\View\Tests\SSViewerTest\TestObject, SilverStripe\i18n\Tests\i18nTest\MyObject, SilverStripe\i18n\Tests\i18nTest\MySubObject, SilverStripe\i18n\Tests\i18nTest\TestDataObject, i18nTestModule. Maybe you want to instanceof check for one of these explicitly?

        }
    }

    /**
     * Process tri-state responses from permission-alterting extensions.  The extensions are
     * expected to return one of three values:
     *
     *  - false: Disallow this permission, regardless of what other extensions say
     *  - true: Allow this permission, as long as no other extensions return false
     *  - NULL: Don't affect the outcome
     *
     * This method itself returns a tri-state value, and is designed to be used like this:
     *
     * <code>
     * $extended = $this->extendedCan('canDoSomething', $member);
     * if($extended !== null) return $extended;
     * else return $normalValue;
     * </code>
     *
     * @param string $methodName Method on the same object, e.g. {@link canEdit()}
     * @param Member|int $member
     * @param array $context Optional context
     * @return boolean|null
     */
    public function extendedCan($methodName, $member, $context = array())
    {
        $results = $this->extend($methodName, $member, $context);
        if ($results && is_array($results)) {

The expression $results of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            // Remove NULLs
            $results = array_filter($results, function ($v) {
                return !is_null($v);
            });
            // If there are any non-NULL responses, then return the lowest one of them.
            // If any explicitly deny the permission, then we don't get access
            if ($results) {

The expression $results of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

                return min($results);
            }
        }
        return null;
    }

    /**
     * @param Member $member
     * @return boolean
     */
    public function canView($member = null)
    {
        $extended = $this->extendedCan(__FUNCTION__, $member);

It seems like $member defined by parameter $member on line 2643 can be null; however, SilverStripe\ORM\DataObject::extendedCan() does not accept null, maybe add an additional type check?

        if ($extended !== null) {
            return $extended;
        }
        return Permission::check('ADMIN', 'any', $member);
    }

    /**
     * @param Member $member
     * @return boolean
     */
    public function canEdit($member = null)
    {
        $extended = $this->extendedCan(__FUNCTION__, $member);

It seems like $member defined by parameter $member on line 2656 can be null; however, SilverStripe\ORM\DataObject::extendedCan() does not accept null, maybe add an additional type check?

        if ($extended !== null) {
            return $extended;
        }
        return Permission::check('ADMIN', 'any', $member);
    }

    /**
     * @param Member $member
     * @return boolean
     */
    public function canDelete($member = null)
    {
        $extended = $this->extendedCan(__FUNCTION__, $member);

It seems like $member defined by parameter $member on line 2669 can be null; however, SilverStripe\ORM\DataObject::extendedCan() does not accept null, maybe add an additional type check?

        if ($extended !== null) {
            return $extended;
        }
        return Permission::check('ADMIN', 'any', $member);
    }

    /**
     * @param Member $member
     * @param array $context Additional context-specific data which might
     * affect whether (or where) this object could be created.
     * @return boolean
     */
    public function canCreate($member = null, $context = array())
    {
        $extended = $this->extendedCan(__FUNCTION__, $member, $context);

It seems like $member defined by parameter $member on line 2684 can be null; however, SilverStripe\ORM\DataObject::extendedCan() does not accept null, maybe add an additional type check?

        if ($extended !== null) {
            return $extended;
        }
        return Permission::check('ADMIN', 'any', $member);
    }

    /**
     * Debugging used by Debug::show()
     *
     * @return string HTML data representing this object
     */
    public function debug()
    {
        $val = "<h3>Database record: $this->class</h3>\n<ul>\n";
        if ($this->record) {

The expression $this->record of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            foreach ($this->record as $fieldName => $fieldVal) {
                $val .= "\t<li>$fieldName: " . Debug::text($fieldVal) . "</li>\n";
            }
        }
        $val .= "</ul>\n";
        return $val;
    }

    /**
     * Return the DBField object that represents the given field.
     * This works similarly to obj() with 2 key differences:
     *   - it still returns an object even when the field has no value.
     *   - it only matches fields and not methods
     *   - it matches foreign keys generated by has_one relationships, eg, "ParentID"
     *
     * @param string $fieldName Name of the field
     * @return DBField The field as a DBField object
     */
    public function dbObject($fieldName)
    {
        // Check for field in DB
        $schema = static::getSchema();
        $helper = $schema->fieldSpec(static::class, $fieldName, DataObjectSchema::INCLUDE_CLASS);
        if (!$helper) {

The expression $helper of type string|null is loosely compared to false; this is ambiguous if the string can be empty. You might want to explicitly use === null instead.

            return null;
        }

        $value = isset($this->record[$fieldName])
            ? $this->record[$fieldName]
            : null;

        // If we have a DBField object in $this->record, then return that
        if ($value instanceof DBField) {
            return $value;
        }

        list($class, $spec) = explode('.', $helper);
        /** @var DBField $obj */
        $table = $schema->tableName($class);
        $obj = Object::create_from_string($spec, $fieldName);
        $obj->setTable($table);
        $obj->setValue($value, $this, false);
        return $obj;
    }

    /**
     * Traverses to a DBField referenced by relationships between data objects.
     *
     * The path to the related field is specified with dot separated syntax
     * (eg: Parent.Child.Child.FieldName).
     *
     * @param string $fieldPath
     *
     * @return mixed DBField of the field on the object or a DataList instance.
     */
    public function relObject($fieldPath)
    {
        $object = null;

        if (strpos($fieldPath, '.') !== false) {
            $parts = explode('.', $fieldPath);
            $fieldName = array_pop($parts);

            // Traverse dot syntax
            $component = $this;

            foreach ($parts as $relation) {
                if ($component instanceof SS_List) {
                    if (method_exists($component, $relation)) {
                        $component = $component->$relation();
                    } else {
                        $component = $component->relation($relation);
                    }
                } else {
                    $component = $component->$relation();
                }
            }

            $object = $component->dbObject($fieldName);
        } else {
            $object = $this->dbObject($fieldPath);
        }

        return $object;
    }

    /**
     * Traverses to a field referenced by relationships between data objects, returning the value
     * The path to the related field is specified with dot separated syntax (eg: Parent.Child.Child.FieldName)
     *
     * @param $fieldName string
     * @return string | null - will return null on a missing value
     */
    public function relField($fieldName)
    {
        $component = $this;

        // We're dealing with relations here so we traverse the dot syntax
        if (strpos($fieldName, '.') !== false) {
            $relations = explode('.', $fieldName);
            $fieldName = array_pop($relations);
            foreach ($relations as $relation) {
                // Inspect $component for element $relation
                if ($component->hasMethod($relation)) {
                    // Check nested method
                    $component = $component->$relation();
                } elseif ($component instanceof SS_List) {
                    // Select adjacent relation from DataList
                    $component = $component->relation($relation);
                } elseif ($component instanceof DataObject
                    && ($dbObject = $component->dbObject($relation))
                ) {
                    // Select db object
                    $component = $dbObject;
                } else {
                    user_error("$relation is not a relation/field on ".get_class($component), E_USER_ERROR);
                }
            }
        }

        // Bail if the component is null
        if (!$component) {
            return null;
        }
        if ($component->hasMethod($fieldName)) {
            return $component->$fieldName();
        }
        return $component->$fieldName;
    }

    /**
     * Temporary hack to return an association name, based on class, to get around the mangle
     * of having to deal with reverse lookup of relationships to determine autogenerated foreign keys.
     *
     * @param string $className
     * @return string
     */
    public function getReverseAssociation($className)
    {
        if (is_array($this->manyMany())) {
            $many_many = array_flip($this->manyMany());
            if (array_key_exists($className, $many_many)) {
                return $many_many[$className];
            }
        }
        if (is_array($this->hasMany())) {
            $has_many = array_flip($this->hasMany());
            if (array_key_exists($className, $has_many)) {
                return $has_many[$className];
            }
        }
        if (is_array($this->hasOne())) {
            $has_one = array_flip($this->hasOne());
            if (array_key_exists($className, $has_one)) {
                return $has_one[$className];
            }
        }

        return false;
    }

    /**
     * Return all objects matching the filter
     * sub-classes are automatically selected and included
     *
     * @param string $callerClass The class of objects to be returned
     * @param string|array $filter A filter to be inserted into the WHERE clause.
     * Supports parameterised queries. See SQLSelect::addWhere() for syntax examples.
     * @param string|array $sort A sort expression to be inserted into the ORDER
     * BY clause.  If omitted, self::$default_sort will be used.
     * @param string $join Deprecated 3.0 Join clause. Use leftJoin($table, $joinClause) instead.
     * @param string|array $limit A limit expression to be inserted into the LIMIT clause.
     * @param string $containerClass The container class to return the results in.
     *
     * @todo $containerClass is Ignored, why?
     *
     * @return DataList The objects matching the filter, in the class specified by $containerClass
     */
    public static function get(
        $callerClass = null,
        $filter = "",
        $sort = "",
        $join = "",
        $limit = null,
        $containerClass = DataList::class
    ) {

        if ($callerClass == null) {

It seems like you are loosely comparing $callerClass of type string|null against null; this is ambiguous if the string can be empty. Consider using a strict comparison === instead.

            $callerClass = get_called_class();
            if ($callerClass == self::class) {
                throw new \InvalidArgumentException('Call <classname>::get() instead of DataObject::get()');
            }

            if ($filter || $sort || $join || $limit || ($containerClass != DataList::class)) {
                throw new \InvalidArgumentException('If calling <classname>::get() then you shouldn\'t pass any other'
                    . ' arguments');
            }

            $result = DataList::create(get_called_class());
            $result->setDataModel(DataModel::inst());
            return $result;
        }

        if ($join) {
            throw new \InvalidArgumentException(
                'The $join argument has been removed. Use leftJoin($table, $joinClause) instead.'
            );
        }

        $result = DataList::create($callerClass)->where($filter)->sort($sort);

        if ($limit && strpos($limit, ',') !== false) {
            $limitArguments = explode(',', $limit);
            $result = $result->limit($limitArguments[1], $limitArguments[0]);
        } elseif ($limit) {
            $result = $result->limit($limit);
        }

        $result->setDataModel(DataModel::inst());
        return $result;
    }


    /**
     * Return the first item matching the given query.
     * All calls to get_one() are cached.
     *
     * @param string $callerClass The class of objects to be returned
     * @param string|array $filter A filter to be inserted into the WHERE clause.
     * Supports parameterised queries. See SQLSelect::addWhere() for syntax examples.
     * @param boolean $cache Use caching
     * @param string $orderby A sort expression to be inserted into the ORDER BY clause.
     *
     * @return DataObject The first item matching the query
     */
    public static function get_one($callerClass, $filter = "", $cache = true, $orderby = "")
    {
        $SNG = singleton($callerClass);

        $cacheComponents = array($filter, $orderby, $SNG->extend('cacheKeyComponent'));
        $cacheKey = md5(var_export($cacheComponents, true));

        // Flush destroyed items out of the cache
        if ($cache && isset(self::$_cache_get_one[$callerClass][$cacheKey])
                && self::$_cache_get_one[$callerClass][$cacheKey] instanceof DataObject
                && self::$_cache_get_one[$callerClass][$cacheKey]->destroyed) {
            self::$_cache_get_one[$callerClass][$cacheKey] = false;
        }
        $item = null;
        if (!$cache || !isset(self::$_cache_get_one[$callerClass][$cacheKey])) {
            $dl = DataObject::get($callerClass)->where($filter)->sort($orderby);

As per coding style, self should be used for accessing local static members.

            $item = $dl->first();

            if ($cache) {
                self::$_cache_get_one[$callerClass][$cacheKey] = $item;
                if (!self::$_cache_get_one[$callerClass][$cacheKey]) {
                    self::$_cache_get_one[$callerClass][$cacheKey] = false;
                }
            }
        }
        return $cache ? self::$_cache_get_one[$callerClass][$cacheKey] : $item;
    }

    /**
     * Flush the cached results for all relations (has_one, has_many, many_many)
     * Also clears any cached aggregate data.
     *
     * @param boolean $persistent When true will also clear persistent data stored in the Cache system.
     *                            When false will just clear session-local cached data
     * @return DataObject $this
     */
    public function flushCache($persistent = true)

The parameter $persistent is not used and could be removed.

    {
        if ($this->class == self::class) {
            self::$_cache_get_one = array();
            return $this;
        }

        $classes = ClassInfo::ancestry($this->class);
        foreach ($classes as $class) {
            if (isset(self::$_cache_get_one[$class])) {
                unset(self::$_cache_get_one[$class]);
            }
        }

        $this->extend('flushCache');

        $this->components = array();
        return $this;
    }

    /**
     * Flush the get_one global cache and destroy associated objects.
     */
    public static function flush_and_destroy_cache()
    {
        if (self::$_cache_get_one) {

The expression self::$_cache_get_one of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            foreach (self::$_cache_get_one as $class => $items) {
                if (is_array($items)) {
                    foreach ($items as $item) {
                        if ($item) {
                            $item->destroy();
                        }
                    }
                }
            }
        }
        self::$_cache_get_one = array();
    }

    /**
     * Reset all global caches associated with DataObject.
     */
    public static function reset()
    {
        // @todo Decouple these
        DBClassName::clear_classname_cache();
        ClassInfo::reset_db_cache();
        static::getSchema()->reset();
        self::$_cache_get_one = array();
        self::$_cache_field_labels = array();
    }

    /**
     * Return the given element, searching by ID
     *
     * @param string $callerClass The class of the object to be returned
     * @param int $id The id of the element
     * @param boolean $cache See {@link get_one()}
     *
     * @return DataObject The element
     */
    public static function get_by_id($callerClass, $id, $cache = true)
    {
        if (!is_numeric($id)) {
            user_error("DataObject::get_by_id passed a non-numeric ID #$id", E_USER_WARNING);
        }

        // Pass to get_one
        $column = static::getSchema()->sqlColumnForField($callerClass, 'ID');
        return DataObject::get_one($callerClass, array($column => $id), $cache);

As per coding style, self should be used for accessing local static members.

    }

    /**
     * Get the name of the base table for this object
     *
     * @return string
     */
    public function baseTable()
    {
        return static::getSchema()->baseDataTable($this);
    }

    /**
     * Get the base class for this object
     *
     * @return string
     */
    public function baseClass()
    {
        return static::getSchema()->baseDataClass($this);
    }

    /**
     * @var array Parameters used in the query that built this object.
     * This can be used by decorators (e.g. lazy loading) to
     * run additional queries using the same context.
     */
    protected $sourceQueryParams;

    /**
     * @see $sourceQueryParams
     * @return array
     */
    public function getSourceQueryParams()
    {
        return $this->sourceQueryParams;
    }

    /**
     * Get list of parameters that should be inherited to relations on this object
     *
     * @return array
     */
    public function getInheritableQueryParams()
    {
        $params = $this->getSourceQueryParams();
        $this->extend('updateInheritableQueryParams', $params);
        return $params;
    }

    /**
     * @see $sourceQueryParams
     * @param array
     */
    public function setSourceQueryParams($array)
    {
        $this->sourceQueryParams = $array;
    }

    /**
     * @see $sourceQueryParams
     * @param string $key
     * @param string $value
     */
    public function setSourceQueryParam($key, $value)
    {
        $this->sourceQueryParams[$key] = $value;
    }

    /**
     * @see $sourceQueryParams
     * @param string $key
     * @return string
     */
    public function getSourceQueryParam($key)
    {
        if (isset($this->sourceQueryParams[$key])) {
            return $this->sourceQueryParams[$key];
        }
        return null;
    }

    //-------------------------------------------------------------------------------------------//

    /**
     * Return the database indexes on this table.
     * This array is indexed by the name of the field with the index, and
     * the value is the type of index.
     */
    public function databaseIndexes()
    {
        $has_one = $this->uninherited('has_one');
        $classIndexes = $this->uninherited('indexes');
        //$fileIndexes = $this->uninherited('fileIndexes', true);

65% of this comment could be valid code. Did you maybe forget this after debugging?

        $indexes = array();

        if ($has_one) {
            foreach ($has_one as $relationshipName => $fieldType) {
                $indexes[$relationshipName . 'ID'] = true;
            }
        }

        if ($classIndexes) {
            foreach ($classIndexes as $indexName => $indexType) {
                $indexes[$indexName] = $indexType;
            }
        }

        if (get_parent_class($this) == self::class) {
            $indexes['ClassName'] = true;
        }

        return $indexes;
    }

    /**
     * Check the database schema and update it as necessary.
     *
     * @uses DataExtension->augmentDatabase()
     */
    public function requireTable()
    {
        // Only build the table if we've actually got fields
        $schema = static::getSchema();
        $fields = $schema->databaseFields(static::class, false);
        $table = $schema->tableName(static::class);
        $extensions = self::database_extensions(static::class);

        $indexes = $this->databaseIndexes();

        if (empty($table)) {
            throw new LogicException(
                "Class " . static::class . " not loaded by manifest, or no database table configured"
            );
        }

        if ($fields) {

The expression $fields of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $hasAutoIncPK = get_parent_class($this) === self::class;
            DB::require_table(
                $table,
                $fields,
                $indexes,
                $hasAutoIncPK,
                $this->stat('create_table_options'),
                $extensions

It seems like $extensions defined by self::database_extensions(static::class) on line 3170 can also be of type false; however, SilverStripe\ORM\DB::require_table() does only seem to accept array|null, did you maybe forget to handle an error condition?

            );
        } else {
            DB::dont_require_table($table);
        }

        // Build any child tables for many_many items
        if ($manyMany = $this->uninherited('many_many')) {
            $extras = $this->uninherited('many_many_extraFields');
            foreach ($manyMany as $component => $spec) {
                // Get many_many spec
                $manyManyComponent = $schema->manyManyComponent(static::class, $component);
                list(
                    $relationClass, $parentClass, $componentClass,

The assignment to $componentClass is unused. Consider omitting it like so list($first,,$third).

The assignment to $relationClass is unused. Consider omitting it like so list($first,,$third).

The assignment to $parentClass is unused. Consider omitting it like so list($first,,$third).

                    $parentField, $childField, $tableOrClass
                ) = $manyManyComponent;

                // Skip if backed by actual class
                if (class_exists($tableOrClass)) {
                    continue;
                }

                // Build fields
                $manymanyFields = array(
                    $parentField => "Int",
                    $childField => "Int",
                );
                if (isset($extras[$component])) {
                    $manymanyFields = array_merge($manymanyFields, $extras[$component]);
                }

                // Build index list
                $manymanyIndexes = array(
                    $parentField => true,
                    $childField => true,
                );
                DB::require_table($tableOrClass, $manymanyFields, $manymanyIndexes, true, null, $extensions);

It seems like $extensions defined by self::database_extensions(static::class) on line 3170 can also be of type false; however, SilverStripe\ORM\DB::require_table() does only seem to accept array|null, did you maybe forget to handle an error condition?

            }
        }

        // Let any extentions make their own database fields
        $this->extend('augmentDatabase', $dummy);
    }

    /**
     * Add default records to database. This function is called whenever the
     * database is built, after the database tables have all been created. Overload
     * this to add default records when the database is built, but make sure you
     * call parent::requireDefaultRecords().
     *
     * @uses DataExtension->requireDefaultRecords()
     */
    public function requireDefaultRecords()
    {
        $defaultRecords = $this->config()->get('default_records', Config::UNINHERITED);

        if (!empty($defaultRecords)) {
            $hasData = DataObject::get_one($this->class);

As per coding style, self should be used for accessing local static members.

            if (!$hasData) {
                $className = $this->class;
                foreach ($defaultRecords as $record) {
                    $obj = $this->model->$className->newObject($record);
                    $obj->write();
                }
                DB::alteration_message("Added default records to $className table", "created");
            }
        }

        // Let any extentions make their own database default data
        $this->extend('requireDefaultRecords', $dummy);
    }

    /**
     * Get the default searchable fields for this object, as defined in the
     * $searchable_fields list. If searchable fields are not defined on the
     * data object, uses a default selection of summary fields.
     *
     * @return array
     */
    public function searchableFields()
    {
        // can have mixed format, need to make consistent in most verbose form
        $fields = $this->stat('searchable_fields');
        $labels = $this->fieldLabels();

        // fallback to summary fields (unless empty array is explicitly specified)
        if (! $fields && ! is_array($fields)) {
            $summaryFields = array_keys($this->summaryFields());
            $fields = array();

            // remove the custom getters as the search should not include them
            $schema = static::getSchema();
            if ($summaryFields) {

The expression $summaryFields of type array<integer|string> is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

                foreach ($summaryFields as $key => $name) {
                    $spec = $name;

                    // Extract field name in case this is a method called on a field (e.g. "Date.Nice")
                    if (($fieldPos = strpos($name, '.')) !== false) {
                        $name = substr($name, 0, $fieldPos);
                    }

                    if ($schema->fieldSpec($this, $name)) {
                        $fields[] = $name;
                    } elseif ($this->relObject($spec)) {
                        $fields[] = $spec;
                    }
                }
            }
        }

        // we need to make sure the format is unified before
        // augmenting fields, so extensions can apply consistent checks
        // but also after augmenting fields, because the extension
        // might use the shorthand notation as well

        // rewrite array, if it is using shorthand syntax
        $rewrite = array();
        foreach ($fields as $name => $specOrName) {
            $identifer = (is_int($name)) ? $specOrName : $name;

            if (is_int($name)) {
                // Format: array('MyFieldName')

58% of this comment could be valid code. Did you maybe forget this after debugging?

                $rewrite[$identifer] = array();
            } elseif (is_array($specOrName)) {
                // Format: array('MyFieldName' => array(

46% of this comment could be valid code. Did you maybe forget this after debugging?

                //   'filter => 'ExactMatchFilter',
                //   'field' => 'NumericField', // optional

50% of this comment could be valid code. Did you maybe forget this after debugging?

                //   'title' => 'My Title', // optional

50% of this comment could be valid code. Did you maybe forget this after debugging?

                // ))
                $rewrite[$identifer] = array_merge(
                    array('filter' => $this->relObject($identifer)->stat('default_search_filter_class')),
                    (array)$specOrName
                );
            } else {
                // Format: array('MyFieldName' => 'ExactMatchFilter')

55% of this comment could be valid code. Did you maybe forget this after debugging?

                $rewrite[$identifer] = array(
                    'filter' => $specOrName,
                );
            }
            if (!isset($rewrite[$identifer]['title'])) {
                $rewrite[$identifer]['title'] = (isset($labels[$identifer]))
                    ? $labels[$identifer] : FormField::name_to_label($identifer);
            }
            if (!isset($rewrite[$identifer]['filter'])) {
                /** @skipUpgrade */
                $rewrite[$identifer]['filter'] = 'PartialMatchFilter';
            }
        }

        $fields = $rewrite;

        // apply DataExtensions if present
        $this->extend('updateSearchableFields', $fields);

        return $fields;
    }

    /**
     * Get any user defined searchable fields labels that
     * exist. Allows overriding of default field names in the form
     * interface actually presented to the user.
     *
     * The reason for keeping this separate from searchable_fields,
     * which would be a logical place for this functionality, is to
     * avoid bloating and complicating the configuration array. Currently
     * much of this system is based on sensible defaults, and this property
     * would generally only be set in the case of more complex relationships
     * between data object being required in the search interface.
     *
     * Generates labels based on name of the field itself, if no static property
     * {@link self::field_labels} exists.
     *
     * @uses $field_labels
     * @uses FormField::name_to_label()
     *
     * @param boolean $includerelations a boolean value to indicate if the labels returned include relation fields
     *
     * @return array|string Array of all element labels if no argument given, otherwise the label of the field
     */
    public function fieldLabels($includerelations = true)
    {
        $cacheKey = $this->class . '_' . $includerelations;

        if (!isset(self::$_cache_field_labels[$cacheKey])) {
            $customLabels = $this->stat('field_labels');
            $autoLabels = array();

            // get all translated static properties as defined in i18nCollectStatics()
            $ancestry = ClassInfo::ancestry($this->class);
            $ancestry = array_reverse($ancestry);
            if ($ancestry) {

The expression $ancestry of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

                foreach ($ancestry as $ancestorClass) {
                    if ($ancestorClass === ViewableData::class) {
                        break;
                    }
                    $types = array(
                    'db'        => (array)Config::inst()->get($ancestorClass, 'db', Config::UNINHERITED)
                                    );
                    if ($includerelations) {
                        $types['has_one'] = (array)Config::inst()->get($ancestorClass, 'has_one', Config::UNINHERITED);
                        $types['has_many'] = (array)Config::inst()->get($ancestorClass, 'has_many', Config::UNINHERITED);
                        $types['many_many'] = (array)Config::inst()->get($ancestorClass, 'many_many', Config::UNINHERITED);
                        $types['belongs_many_many'] = (array)Config::inst()->get($ancestorClass, 'belongs_many_many', Config::UNINHERITED);
                    }
                    foreach ($types as $type => $attrs) {
                        foreach ($attrs as $name => $spec) {
                            $autoLabels[$name] = _t("{$ancestorClass}.{$type}_{$name}", FormField::name_to_label($name));
                        }
                    }
                }
            }

            $labels = array_merge((array)$autoLabels, (array)$customLabels);
            $this->extend('updateFieldLabels', $labels);
            self::$_cache_field_labels[$cacheKey] = $labels;
        }

        return self::$_cache_field_labels[$cacheKey];
    }

    /**
     * Get a human-readable label for a single field,
     * see {@link fieldLabels()} for more details.
     *
     * @uses fieldLabels()
     * @uses FormField::name_to_label()
     *
     * @param string $name Name of the field
     * @return string Label of the field
     */
    public function fieldLabel($name)
    {
        $labels = $this->fieldLabels();
        return (isset($labels[$name])) ? $labels[$name] : FormField::name_to_label($name);
    }

    /**
     * Get the default summary fields for this object.
     *
     * @todo use the translation apparatus to return a default field selection for the language
     *
     * @return array
     */
    public function summaryFields()
    {
        $fields = $this->stat('summary_fields');

        // if fields were passed in numeric array,
        // convert to an associative array
        if ($fields && array_key_exists(0, $fields)) {
            $fields = array_combine(array_values($fields), array_values($fields));
        }

        if (!$fields) {
            $fields = array();
            // try to scaffold a couple of usual suspects
            if ($this->hasField('Name')) {
                $fields['Name'] = 'Name';
            }
            if (static::getSchema()->fieldSpec($this, 'Title')) {

The expression static::getSchema()->fieldSpec($this, 'Title') of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

                $fields['Title'] = 'Title';
            }
            if ($this->hasField('Description')) {
                $fields['Description'] = 'Description';
            }
            if ($this->hasField('FirstName')) {
                $fields['FirstName'] = 'First Name';
            }
        }
        $this->extend("updateSummaryFields", $fields);

        // Final fail-over, just list ID field
        if (!$fields) {
            $fields['ID'] = 'ID';
        }

        // Localize fields (if possible)
        foreach ($this->fieldLabels(false) as $name => $label) {

The expression $this->fieldLabels(false) of type array|string is not guaranteed to be traversable. How about adding an additional type check?

            // only attempt to localize if the label definition is the same as the field name.
            // this will preserve any custom labels set in the summary_fields configuration
            if (isset($fields[$name]) && $name === $fields[$name]) {
                $fields[$name] = $label;
            }
        }

        return $fields;
    }

    /**
     * Defines a default list of filters for the search context.
     *
     * If a filter class mapping is defined on the data object,
     * it is constructed here. Otherwise, the default filter specified in
     * {@link DBField} is used.
     *
     * @todo error handling/type checking for valid FormField and SearchFilter subclasses?
     *
     * @return array
     */
    public function defaultSearchFilters()
    {
        $filters = array();

        foreach ($this->searchableFields() as $name => $spec) {
            if (empty($spec['filter'])) {
                /** @skipUpgrade */
                $filters[$name] = 'PartialMatchFilter';
            } elseif ($spec['filter'] instanceof SearchFilter) {
                $filters[$name] = $spec['filter'];
            } else {
                $filters[$name] = Injector::inst()->create($spec['filter'], $name);
            }
        }

        return $filters;
    }

    /**
     * @return boolean True if the object is in the database
     */
    public function isInDB()
    {
        return is_numeric($this->ID) && $this->ID > 0;
    }

    /*
	 * @ignore
	 */
    private static $subclass_access = true;

    /**
     * Temporarily disable subclass access in data object qeur
     */
    public static function disable_subclass_access()
    {
        self::$subclass_access = false;
    }
    public static function enable_subclass_access()
    {
        self::$subclass_access = true;
    }

    //-------------------------------------------------------------------------------------------//

    /**
     * Database field definitions.
     * This is a map from field names to field type. The field
     * type should be a class that extends .
     * @var array
     * @config
     */
    private static $db = null;

    /**
     * Use a casting object for a field. This is a map from
     * field name to class name of the casting object.
     *
     * @var array
     */
    private static $casting = array(
        "Title" => 'Text',
    );

    /**
     * Specify custom options for a CREATE TABLE call.
     * Can be used to specify a custom storage engine for specific database table.
     * All options have to be keyed for a specific database implementation,
     * identified by their class name (extending from {@link SS_Database}).
     *
     * <code>
     * array(
     *  'MySQLDatabase' => 'ENGINE=MyISAM'
     * )
     * </code>
     *
     * Caution: This API is experimental, and might not be
     * included in the next major release. Please use with care.
     *
     * @var array
     * @config
     */
    private static $create_table_options = array(
        'SilverStripe\ORM\Connect\MySQLDatabase' => 'ENGINE=InnoDB'
    );

    /**
     * If a field is in this array, then create a database index
     * on that field. This is a map from fieldname to index type.
     * See {@link SS_Database->requireIndex()} and custom subclasses for details on the array notation.
     *
     * @var array
     * @config
     */
    private static $indexes = null;

    /**
     * Inserts standard column-values when a DataObject
     * is instanciated. Does not insert default records {@see $default_records}.
     * This is a map from fieldname to default value.
     *
     *  - If you would like to change a default value in a sub-class, just specify it.
     *  - If you would like to disable the default value given by a parent class, set the default value to 0,'',
     *    or false in your subclass.  Setting it to null won't work.
     *
     * @var array
     * @config
     */
    private static $defaults = null;

    /**
     * Multidimensional array which inserts default data into the database
     * on a db/build-call as long as the database-table is empty. Please use this only
     * for simple constructs, not for SiteTree-Objects etc. which need special
     * behaviour such as publishing and ParentNodes.
     *
     * Example:
     * array(
     *  array('Title' => "DefaultPage1", 'PageTitle' => 'page1'),
     *  array('Title' => "DefaultPage2")
     * ).
     *
     * @var array
     * @config
     */
    private static $default_records = null;

    /**
     * One-to-zero relationship defintion. This is a map of component name to data type. In order to turn this into a
     * true one-to-one relationship you can add a {@link DataObject::$belongs_to} relationship on the child class.
     *
     * Note that you cannot have a has_one and belongs_to relationship with the same name.
     *
     *  @var array
     * @config
     */
    private static $has_one = null;

    /**
     * A meta-relationship that allows you to define the reverse side of a {@link DataObject::$has_one}.
     *
     * This does not actually create any data structures, but allows you to query the other object in a one-to-one
     * relationship from the child object. If you have multiple belongs_to links to another object you can use the
     * syntax "ClassName.HasOneName" to specify which foreign has_one key on the other object to use.
     *
     * Note that you cannot have a has_one and belongs_to relationship with the same name.
     *
     * @var array
     * @config
     */
    private static $belongs_to;

    /**
     * This defines a one-to-many relationship. It is a map of component name to the remote data class.
     *
     * This relationship type does not actually create a data structure itself - you need to define a matching $has_one
     * relationship on the child class. Also, if the $has_one relationship on the child class has multiple links to this
     * class you can use the syntax "ClassName.HasOneRelationshipName" in the remote data class definition to show
     * which foreign key to use.
     *
     * @var array
     * @config
     */
    private static $has_many = null;

    /**
     * many-many relationship definitions.
     * This is a map from component name to data type.
     * @var array
     * @config
     */
    private static $many_many = null;

    /**
     * Extra fields to include on the connecting many-many table.
     * This is a map from field name to field type.
     *
     * Example code:
     * <code>
     * public static $many_many_extraFields = array(
     *  'Members' => array(
     *          'Role' => 'Varchar(100)'
     *      )
     * );
     * </code>
     *
     * @var array
     * @config
     */
    private static $many_many_extraFields = null;

    /**
     * The inverse side of a many-many relationship.
     * This is a map from component name to data type.
     * @var array
     * @config
     */
    private static $belongs_many_many = null;

    /**
     * The default sort expression. This will be inserted in the ORDER BY
     * clause of a SQL query if no other sort expression is provided.
     * @var string
     * @config
     */
    private static $default_sort = null;

    /**
     * Default list of fields that can be scaffolded by the ModelAdmin
     * search interface.
     *
     * Overriding the default filter, with a custom defined filter:
     * <code>
     *  static $searchable_fields = array(
     *     "Name" => "PartialMatchFilter"
     *  );
     * </code>
     *
     * Overriding the default form fields, with a custom defined field.
     * The 'filter' parameter will be generated from {@link DBField::$default_search_filter_class}.
     * The 'title' parameter will be generated from {@link DataObject->fieldLabels()}.
     * <code>
     *  static $searchable_fields = array(
     *    "Name" => array(
     *      "field" => "TextField"
     *    )
     *  );
     * </code>
     *
     * Overriding the default form field, filter and title:
     * <code>
     *  static $searchable_fields = array(
     *    "Organisation.ZipCode" => array(
     *      "field" => "TextField",
     *      "filter" => "PartialMatchFilter",
     *      "title" => 'Organisation ZIP'
     *    )
     *  );
     * </code>
     * @config
     */
    private static $searchable_fields = null;

    /**
     * User defined labels for searchable_fields, used to override
     * default display in the search form.
     * @config
     */
    private static $field_labels = null;

    /**
     * Provides a default list of fields to be used by a 'summary'
     * view of this object.
     * @config
     */
    private static $summary_fields = null;

    /**
     * Collect all static properties on the object
     * which contain natural language, and need to be translated.
     * The full entity name is composed from the class name and a custom identifier.
     *
     * @return array A numerical array which contains one or more entities in array-form.
     * Each numeric entity array contains the "arguments" for a _t() call as array values:
     * $entity, $string, $priority, $context.
     */
    public function provideI18nEntities()
    {
        $entities = array();

        $entities["{$this->class}.SINGULARNAME"] = array(
            $this->singular_name(),

            'Singular name of the object, used in dropdowns and to generally identify a single object in the interface'
        );

        $entities["{$this->class}.PLURALNAME"] = array(
            $this->plural_name(),

            'Pural name of the object, used in dropdowns and to generally identify a collection of this object in the'
            . ' interface'
        );

        return $entities;
    }

    /**
     * Returns true if the given method/parameter has a value
     * (Uses the DBField::hasValue if the parameter is a database field)
     *
     * @param string $field The field name
     * @param array $arguments
     * @param bool $cache
     * @return boolean
     */
    public function hasValue($field, $arguments = null, $cache = true)
    {
        // has_one fields should not use dbObject to check if a value is given
        $hasOne = static::getSchema()->hasOneComponent(static::class, $field);
        if (!$hasOne && ($obj = $this->dbObject($field))) {

The expression $hasOne of type string|null is loosely compared to false; this is ambiguous if the string can be empty. You might want to explicitly use === null instead.

            return $obj->exists();
        } else {
            return parent::hasValue($field, $arguments, $cache);

It seems like $arguments defined by parameter $arguments on line 3782 can also be of type null; however, SilverStripe\View\ViewableData::hasValue() does only seem to accept array, maybe add an additional type check?

        }
    }

    /**
     * If selected through a many_many through relation, this is the instance of the joined record
     *
     * @return DataObject
     */
    public function getJoin()
    {
        return $this->joinRecord;
    }

    /**
     * Set joining object
     *
     * @param DataObject $object
     * @param string $alias Alias
     * @return $this
     */
    public function setJoin(DataObject $object, $alias = null)
    {
        $this->joinRecord = $object;
        if ($alias) {

The expression $alias of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            if (static::getSchema()->fieldSpec(static::class, $alias)) {

The expression static::getSchema()->fieldSpec(static::class, $alias) of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

                throw new InvalidArgumentException(
                    "Joined record $alias cannot also be a db field"
                );
            }
            $this->record[$alias] = $object;
        }
        return $this;
    }
}