Completed
Pull Request — 3.2 (#5154)
by Jono
10:52
created
forms/gridfield/GridFieldSortableHeader.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,6 +29,7 @@  discard block
 block discarded – undo
29 29
 	 *
30 30
 	 * By default, this is set to true so that it's clearer what's happening, but the predefined
31 31
 	 * {@link GridFieldConfig} subclasses set this to false for flexibility.
32
+	 * @param boolean $throwExceptionOnBadDataType
32 33
 	 */
33 34
 	public function setThrowExceptionOnBadDataType($throwExceptionOnBadDataType) {
34 35
 		$this->throwExceptionOnBadDataType = $throwExceptionOnBadDataType;
@@ -61,7 +62,7 @@  discard block
 block discarded – undo
61 62
 	 * Specify sortings with fieldname as the key, and actual fieldname to sort as value.
62 63
 	 * Example: array("MyCustomTitle"=>"Title", "MyCustomBooleanField" => "ActualBooleanField")
63 64
 	 *
64
-	 * @param array $casting
65
+	 * @param array $sorting
65 66
 	 */
66 67
 	public function setFieldSorting($sorting) {
67 68
 		$this->fieldSorting = $sorting;
Please login to merge, or discard this patch.
forms/gridfield/GridState.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -24,8 +24,7 @@
 block discarded – undo
24 24
 
25 25
 	/**
26 26
 	 *
27
-	 * @param GridField $name
28
-	 * @param string $data - json encoded string
27
+	 * @param GridField $grid
29 28
 	 */
30 29
 	public function __construct($grid, $value = null) {
31 30
 		$this->grid = $grid;
Please login to merge, or discard this patch.
forms/HiddenField.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -10,7 +10,7 @@
 block discarded – undo
10 10
 	/**
11 11
 	 * @param array $properties
12 12
 	 *
13
-	 * @return HTMLText
13
+	 * @return string
14 14
 	 */
15 15
 	public function FieldHolder($properties = array()) {
16 16
 		return $this->Field($properties);
Please login to merge, or discard this patch.
forms/HtmlEditorSanitiser.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
 	/**
40 40
 	 * Given a TinyMCE pattern (close to unix glob style), create a regex that does the match
41 41
 	 *
42
-	 * @param $str - The TinyMCE pattern
42
+	 * @param string|null $str - The TinyMCE pattern
43 43
 	 * @return string - The equivalent regex
44 44
 	 */
45 45
 	protected function patternToRegex($str) {
@@ -180,6 +180,7 @@  discard block
 block discarded – undo
180 180
 	/**
181 181
 	 * Given an attribute name, return the rule structure for that attribute
182 182
 	 * @param string $name - The attribute name
183
+	 * @param stdClass $elementRule
183 184
 	 * @return stdClass - The attribute rule
184 185
 	 */
185 186
 	protected function getRuleForAttribute($elementRule, $name) {
Please login to merge, or discard this patch.
forms/InlineFormAction.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@
 block discarded – undo
14 14
 
15 15
 	/**
16 16
 	 * Create a new action button.
17
-	 * @param action The method to call when the button is clicked
17
+	 * @param action string method to call when the button is clicked
18 18
 	 * @param title The label on the button
19 19
 	 * @param extraClass A CSS class to apply to the button in addition to 'action'
20 20
 	 */
Please login to merge, or discard this patch.
forms/MoneyField.php 1 patch
Doc Comments   +8 added lines patch added patch discarded remove patch
@@ -32,6 +32,10 @@  discard block
 block discarded – undo
32 32
 	 */
33 33
 	protected $fieldCurrency = null;
34 34
 
35
+	/**
36
+	 * @param string $name
37
+	 * @param string $title
38
+	 */
35 39
 	public function __construct($name, $title = null, $value = "") {
36 40
 		// naming with underscores to prevent values from actually being saved somewhere
37 41
 		$this->fieldAmount = new NumericField("{$name}[Amount]", _t('MoneyField.FIELDLABELAMOUNT', 'Amount'));
@@ -135,6 +139,7 @@  discard block
 block discarded – undo
135 139
 	/**
136 140
 	 * @todo Implement removal of readonly state with $bool=false
137 141
 	 * @todo Set readonly state whenever field is recreated, e.g. in setAllowedCurrencies()
142
+	 * @param boolean $bool
138 143
 	 */
139 144
 	public function setReadonly($bool) {
140 145
 		parent::setReadonly($bool);
@@ -175,6 +180,9 @@  discard block
 block discarded – undo
175 180
 		return $this->allowedCurrencies;
176 181
 	}
177 182
 
183
+	/**
184
+	 * @param string $locale
185
+	 */
178 186
 	public function setLocale($locale) {
179 187
 		$this->_locale = $locale;
180 188
 		return $this;
Please login to merge, or discard this patch.
forms/NestedForm.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -11,7 +11,7 @@
 block discarded – undo
11 11
 
12 12
 	/**
13 13
 	 * Represent the given form in a tabular style
14
-	 * @param form The form to decorate.
14
+	 * @param form Form form to decorate.
15 15
 	 */
16 16
 	public function __construct(Form $form) {
17 17
 		$this->form = $form;
Please login to merge, or discard this patch.
forms/PhoneNumberField.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
 
30 30
 	/**
31 31
 	 * @param array $properties
32
-	 * @return FieldGroup|HTMLText
32
+	 * @return FieldGroup
33 33
 	 */
34 34
 	public function Field($properties = array()) {
35 35
 		$fields = new FieldGroup( $this->name );
@@ -73,6 +73,9 @@  discard block
 block discarded – undo
73 73
 		return $this;
74 74
 	}
75 75
 
76
+	/**
77
+	 * @return string
78
+	 */
76 79
 	public static function joinPhoneNumber( $value ) {
77 80
 		if( is_array( $value ) ) {
78 81
 			$completeNumber = '';
Please login to merge, or discard this patch.
forms/RequiredFields.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -176,6 +176,7 @@
 block discarded – undo
176 176
 	 * Add {@link RequiredField} objects together
177 177
 	 *
178 178
 	 * @param RequiredFields
179
+	 * @param RequiredFields $requiredFields
179 180
 	 *
180 181
 	 * @return RequiredFields
181 182
 	 */
Please login to merge, or discard this patch.