Completed
Pull Request — master (#5433)
by Sam
19:38
created
tests/security/SecurityTest.php 1 patch
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
 	 *
133 133
 	 * @param string $url
134 134
 	 * @param int $limit Max number of requests
135
-	 * @return SS_HTTPResponse
135
+	 * @return SilverStripe\Control\SS_HTTPResponse|null
136 136
 	 */
137 137
 	protected function getRecursive($url, $limit = 10) {
138 138
 		$this->cssParser = null;
@@ -589,6 +589,8 @@  discard block
 block discarded – undo
589 589
 	/**
590 590
 	 * Execute a log-in form using Director::test().
591 591
 	 * Helper method for the tests above
592
+	 * @param string $email
593
+	 * @param string $password
592 594
 	 */
593 595
 	public function doTestLoginForm($email, $password, $backURL = 'test/link') {
594 596
 		$this->get(Config::inst()->get('Security', 'logout_url'));
@@ -609,6 +611,8 @@  discard block
 block discarded – undo
609 611
 
610 612
 	/**
611 613
 	 * Helper method to execute a change password form
614
+	 * @param string $oldPassword
615
+	 * @param string $newPassword
612 616
 	 */
613 617
 	public function doTestChangepasswordForm($oldPassword, $newPassword) {
614 618
 		return $this->submitForm(
Please login to merge, or discard this patch.
view/Requirements.php 1 patch
Doc Comments   +5 added lines, -3 removed lines patch added patch discarded remove patch
@@ -68,6 +68,7 @@  discard block
 block discarded – undo
68 68
 	 * while automatically busting this cache every time the file is changed.
69 69
 	 *
70 70
 	 * @param bool
71
+	 * @param boolean $var
71 72
 	 */
72 73
 	public static function set_suffix_requirements($var) {
73 74
 		self::backend()->setSuffixRequirements($var);
@@ -276,7 +277,7 @@  discard block
 block discarded – undo
276 277
 	 * Attach requirements inclusion to X-Include-JS and X-Include-CSS headers on the given
277 278
 	 * HTTP Response
278 279
 	 *
279
-	 * @param SS_HTTPResponse $response
280
+	 * @param HTTPResponse $response
280 281
 	 */
281 282
 	public static function include_in_response(HTTPResponse $response) {
282 283
 		self::backend()->includeInResponse($response);
@@ -339,7 +340,7 @@  discard block
 block discarded – undo
339 340
 	 * </code>
340 341
 	 *
341 342
 	 * @param string $combinedFileName Filename of the combined file relative to docroot
342
-	 * @param array  $files            Array of filenames relative to docroot
343
+	 * @param string[]  $files            Array of filenames relative to docroot
343 344
 	 * @param string $media
344 345
 	 *
345 346
 	 * @return bool|void
@@ -764,6 +765,7 @@  discard block
 block discarded – undo
764 765
 	 * Forces the JavaScript requirements to the end of the body, right before the closing tag
765 766
 	 *
766 767
 	 * @param bool
768
+	 * @param boolean $var
767 769
 	 * @return $this
768 770
 	 */
769 771
 	public function setForceJSToBottom($var) {
@@ -1263,7 +1265,7 @@  discard block
 block discarded – undo
1263 1265
 	 * Attach requirements inclusion to X-Include-JS and X-Include-CSS headers on the given
1264 1266
 	 * HTTP Response
1265 1267
 	 *
1266
-	 * @param SS_HTTPResponse $response
1268
+	 * @param HTTPResponse $response
1267 1269
 	 */
1268 1270
 	public function includeInResponse(HTTPResponse $response) {
1269 1271
 		$this->processCombinedFiles();
Please login to merge, or discard this patch.