Completed
Pull Request — master (#5433)
by Sam
19:38
created
thirdparty/Zend/Translate/Adapter/Tbx.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
      * @param  string  $locale    Locale/Language to add data for, identical with locale identifier,
49 49
      *                            see Zend_Locale for more information
50 50
      * @param  string  $filename  XMLTM file to add, full path must be given for access
51
-     * @param  array   $option    OPTIONAL Options to use
51
+     * @param  array   $options    OPTIONAL Options to use
52 52
      * @throws Zend_Translation_Exception
53 53
      * @return array
54 54
      */
@@ -116,6 +116,9 @@  discard block
 block discarded – undo
116 116
         }
117 117
     }
118 118
 
119
+    /**
120
+     * @param string $filename
121
+     */
119 122
     private function _findEncoding($filename)
120 123
     {
121 124
         $file = file_get_contents($filename, null, null, 0, 100);
Please login to merge, or discard this patch.
thirdparty/Zend/Translate/Adapter/Xliff.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
      * @param  string  $locale    Locale/Language to add data for, identical with locale identifier,
49 49
      *                            see Zend_Locale for more information
50 50
      * @param  string  $filename  XMLTM file to add, full path must be given for access
51
-     * @param  array   $option    OPTIONAL Options to use
51
+     * @param  array   $options    OPTIONAL Options to use
52 52
      * @throws Zend_Translation_Exception
53 53
      * @return array
54 54
      */
@@ -116,6 +116,9 @@  discard block
 block discarded – undo
116 116
         }
117 117
     }
118 118
 
119
+    /**
120
+     * @param string $filename
121
+     */
119 122
     private function _findEncoding($filename)
120 123
     {
121 124
         $file = file_get_contents($filename, null, null, 0, 100);
Please login to merge, or discard this patch.
core/ClassInfo.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -38,6 +38,7 @@  discard block
 block discarded – undo
38 38
 
39 39
 	/**
40 40
 	 * @todo Move this to SS_Database or DB
41
+	 * @param string $class
41 42
 	 */
42 43
 	public static function hasTable($class) {
43 44
 		// Cache the list of all table names to reduce on DB traffic
@@ -219,6 +220,7 @@  discard block
 block discarded – undo
219 220
 
220 221
 	/**
221 222
 	 * Returns true if the given class implements the given interface
223
+	 * @param string $interfaceName
222 224
 	 */
223 225
 	public static function classImplements($className, $interfaceName) {
224 226
 		return in_array($className, self::implementorsOf($interfaceName));
@@ -269,6 +271,9 @@  discard block
 block discarded – undo
269 271
 
270 272
 	private static $method_from_cache = array();
271 273
 
274
+	/**
275
+	 * @param string $method
276
+	 */
272 277
 	public static function has_method_from($class, $method, $compclass) {
273 278
 		$lClass = strtolower($class);
274 279
 		$lMethod = strtolower($method);
Please login to merge, or discard this patch.
thirdparty/Zend/Cache/Backend/File.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -732,6 +732,9 @@  discard block
 block discarded – undo
732 732
         return $result;
733 733
     }
734 734
 
735
+    /**
736
+     * @param string $mode
737
+     */
735 738
     protected function _get($dir, $mode, $tags = array())
736 739
     {
737 740
         if (!is_dir($dir)) {
@@ -819,6 +822,7 @@  discard block
 block discarded – undo
819 822
     /**
820 823
      * Compute & return the expire time
821 824
      *
825
+     * @param integer $lifetime
822 826
      * @return int expire time (unix timestamp)
823 827
      */
824 828
     protected function _expireTime($lifetime)
Please login to merge, or discard this patch.
forms/DatetimeField.php 1 patch
Doc Comments   +19 added lines, -4 removed lines patch added patch discarded remove patch
@@ -59,6 +59,10 @@  discard block
 block discarded – undo
59 59
 	 */
60 60
 	protected $config;
61 61
 
62
+	/**
63
+	 * @param string $name
64
+	 * @param string $title
65
+	 */
62 66
 	public function __construct($name, $title = null, $value = ""){
63 67
 		$this->config = $this->config()->default_config;
64 68
 
@@ -71,6 +75,9 @@  discard block
 block discarded – undo
71 75
 		parent::__construct($name, $title, $value);
72 76
 	}
73 77
 
78
+	/**
79
+	 * @param Form $form
80
+	 */
74 81
 	public function setForm($form) {
75 82
 		parent::setForm($form);
76 83
 
@@ -81,6 +88,9 @@  discard block
 block discarded – undo
81 88
 		return $this;
82 89
 	}
83 90
 
91
+	/**
92
+	 * @param string $name
93
+	 */
84 94
 	public function setName($name) {
85 95
 		parent::setName($name);
86 96
 
@@ -93,7 +103,7 @@  discard block
 block discarded – undo
93 103
 
94 104
 	/**
95 105
 	 * @param array $properties
96
-	 * @return HTMLText
106
+	 * @return string
97 107
 	 */
98 108
 	public function FieldHolder($properties = array()) {
99 109
 		$config = array(
@@ -108,7 +118,7 @@  discard block
 block discarded – undo
108 118
 
109 119
 	/**
110 120
 	 * @param array $properties
111
-	 * @return HTMLText
121
+	 * @return DBField
112 122
 	 */
113 123
 	public function Field($properties = array()) {
114 124
 		Requirements::css(FRAMEWORK_DIR . '/css/DatetimeField.css');
@@ -243,6 +253,7 @@  discard block
 block discarded – undo
243 253
 
244 254
 	/**
245 255
 	 * @param FormField
256
+	 * @param DateField $field
246 257
 	 */
247 258
 	public function setDateField($field) {
248 259
 		$expected = $this->getName() . '[date]';
@@ -268,6 +279,7 @@  discard block
 block discarded – undo
268 279
 
269 280
 	/**
270 281
 	 * @param FormField
282
+	 * @param TimeField $field
271 283
 	 */
272 284
 	public function setTimeField($field) {
273 285
 		$expected = $this->getName() . '[time]';
@@ -306,7 +318,7 @@  discard block
 block discarded – undo
306 318
 	 * to set field-specific config options.
307 319
 	 *
308 320
 	 * @param string $name
309
-	 * @param mixed $val
321
+	 * @param string $val
310 322
 	 */
311 323
 	public function setConfig($name, $val) {
312 324
 		$this->config[$name] = $val;
@@ -324,7 +336,7 @@  discard block
 block discarded – undo
324 336
 	 * to get field-specific config options.
325 337
 	 *
326 338
 	 * @param String $name Optional, returns the whole configuration array if empty
327
-	 * @return mixed
339
+	 * @return string|null
328 340
 	 */
329 341
 	public function getConfig($name = null) {
330 342
 		if($name) {
@@ -334,6 +346,9 @@  discard block
 block discarded – undo
334 346
 		}
335 347
 	}
336 348
 
349
+	/**
350
+	 * @param RequiredFields $validator
351
+	 */
337 352
 	public function validate($validator) {
338 353
 		$dateValid = $this->dateField->validate($validator);
339 354
 		$timeValid = $this->timeField->validate($validator);
Please login to merge, or discard this patch.
forms/gridfield/GridFieldEditButton.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
 	 * Which columns are handled by this component
56 56
 	 *
57 57
 	 * @param GridField $gridField
58
-	 * @return array
58
+	 * @return string[]
59 59
 	 */
60 60
 	public function getColumnsHandled($gridField) {
61 61
 		return array('Actions');
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
 	 * @param DataObject $record
77 77
 	 * @param string $columnName
78 78
 	 *
79
-	 * @return string - the HTML for the column
79
+	 * @return DBField - the HTML for the column
80 80
 	 */
81 81
 	public function getColumnContent($gridField, $record, $columnName) {
82 82
 		// No permission checks, handled through GridFieldDetailForm,
Please login to merge, or discard this patch.
forms/InlineFormAction.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@  discard block
 block discarded – undo
17 17
 
18 18
 	/**
19 19
 	 * Create a new action button.
20
-	 * @param action The method to call when the button is clicked
20
+	 * @param action string method to call when the button is clicked
21 21
 	 * @param title The label on the button
22 22
 	 * @param extraClass A CSS class to apply to the button in addition to 'action'
23 23
 	 */
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
 
33 33
 	/**
34 34
 	 * @param array $properties
35
-	 * @return HTMLText
35
+	 * @return DBField
36 36
 	 */
37 37
 	public function Field($properties = array()) {
38 38
 		if($this->includeDefaultJS) {
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
 
79 79
 	/**
80 80
 	 * @param array $properties
81
-	 * @return HTMLText
81
+	 * @return DBField
82 82
 	 */
83 83
 	public function Field($properties = array()) {
84 84
 		return DBField::create_field('HTMLText',
Please login to merge, or discard this patch.
security/PermissionCheckboxSetField.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@
 block discarded – undo
76 76
 
77 77
 	/**
78 78
 	 * @param array $properties
79
-	 * @return HTMLText
79
+	 * @return DBField
80 80
 	 */
81 81
 	public function Field($properties = array()) {
82 82
 		Requirements::css(FRAMEWORK_DIR . '/css/CheckboxSetField.css');
Please login to merge, or discard this patch.
security/Security.php 1 patch
Doc Comments   +5 added lines, -6 removed lines patch added patch discarded remove patch
@@ -465,7 +465,7 @@  discard block
 block discarded – undo
465 465
 	 * Combine the given forms into a formset with a tabbed interface
466 466
 	 *
467 467
 	 * @param array $forms List of LoginForm instances
468
-	 * @return string
468
+	 * @return DBField
469 469
 	 */
470 470
 	protected function generateLoginFormSet($forms) {
471 471
 		$viewData = new ArrayData(array(
@@ -645,7 +645,6 @@  discard block
 block discarded – undo
645 645
 	 * - t: plaintext token
646 646
 	 *
647 647
 	 * @param Member $member Member object associated with this link.
648
-	 * @param string $autoLoginHash The auto login token.
649 648
 	 */
650 649
 	public static function getPasswordResetLink($member, $autologinToken) {
651 650
 		$autologinToken = urldecode($autologinToken);
@@ -736,7 +735,7 @@  discard block
 block discarded – undo
736 735
 	/**
737 736
 	 * Factory method for the lost password form
738 737
 	 *
739
-	 * @return Form Returns the lost password form
738
+	 * @return Security Returns the lost password form
740 739
 	 */
741 740
 	public function ChangePasswordForm() {
742 741
 		return Object::create('ChangePasswordForm', $this, 'ChangePasswordForm');
@@ -746,7 +745,7 @@  discard block
 block discarded – undo
746 745
 	 * Gets the template for an include used for security.
747 746
 	 * For use in any subclass.
748 747
 	 *
749
-	 * @return string|array Returns the template(s) for rendering
748
+	 * @return string[] Returns the template(s) for rendering
750 749
 	 */
751 750
 	public function getIncludeTemplate($name) {
752 751
 		return array('Security_' . $name);
@@ -920,7 +919,7 @@  discard block
 block discarded – undo
920 919
 	 * @deprecated 4.0 Use the "Security.password_encryption_algorithm" config setting instead
921 920
 	 * @param string $algorithm One of the available password encryption
922 921
 	 *  algorithms determined by {@link Security::get_encryption_algorithms()}
923
-	 * @return bool Returns TRUE if the passed algorithm was valid, otherwise FALSE.
922
+	 * @return boolean|null Returns TRUE if the passed algorithm was valid, otherwise FALSE.
924 923
 	 */
925 924
 	public static function set_password_encryption_algorithm($algorithm) {
926 925
 		Deprecation::notice('4.0', 'Use the "Security.password_encryption_algorithm" config setting instead');
@@ -1075,7 +1074,7 @@  discard block
 block discarded – undo
1075 1074
 	/**
1076 1075
 	 * Set to true to ignore access to disallowed actions, rather than returning permission failure
1077 1076
 	 * Note that this is just a flag that other code needs to check with Security::ignore_disallowed_actions()
1078
-	 * @param $flag True or false
1077
+	 * @param boolean $flag True or false
1079 1078
 	 */
1080 1079
 	public static function set_ignore_disallowed_actions($flag) {
1081 1080
 		self::$ignore_disallowed_actions = $flag;
Please login to merge, or discard this patch.