silverstripe / silverstripe-framework

src/Core/Manifest/ClassManifest.php

Doc Comments +1 added lines, -1 removed lines

@@ -259,7 +259,7 @@
      * Returns an array containing all the descendants (direct and indirect)
      * of a class.
      *
-     * @param  string|object $class
+     * @param  string $class
      * @return array
      */
     public function getDescendantsOf($class)

src/Core/Startup/ErrorControlChain.php

Doc Comments +2 added lines, -2 removed lines

@@ -106,7 +106,7 @@ 
     /**
      * Get value of display_errors ini value
      *
-     * @return mixed
+     * @return string
      */
     protected function getDisplayErrors()
     {
@@ -117,7 +117,7 @@ 
      * Add this callback to the chain of callbacks to call along with the state
      * that $error must be in this point in the chain for the callback to be called
      *
-     * @param $callback - The callback to call
+     * @param callable $callback - The callback to call
      * @param $onErrorState - false if only call if no errors yet, true if only call if already errors, null for either
      * @return $this
      */

src/Core/Startup/ParameterConfirmationToken.php

Doc Comments +4 added lines, -1 removed lines

@@ -38,6 +38,9 @@ 
      */
     protected $token = null;
 
+    /**
+     * @param string $token
+     */
     protected function pathForToken($token)
     {
         return TEMP_FOLDER.'/token_'.preg_replace('/[^a-z0-9]+/', '', $token);
@@ -247,7 +250,7 @@ 
      * Given a list of token names, suppress all tokens that have not been validated, and
      * return the non-validated token with the highest priority
      *
-     * @param array $keys List of token keys in ascending priority (low to high)
+     * @param string[] $keys List of token keys in ascending priority (low to high)
      * @return ParameterConfirmationToken The token container for the unvalidated $key given with the highest priority
      */
     public static function prepare_tokens($keys)

src/Dev/Backtrace.php

Doc Comments +1 added lines, -1 removed lines

@@ -132,7 +132,7 @@
      * @param mixed $returnVal
      * @param bool $ignoreAjax
      * @param array $ignoredFunctions
-     * @return mixed
+     * @return string|null
      */
     public static function backtrace($returnVal = false, $ignoreAjax = false, $ignoredFunctions = null)
     {

src/Dev/BulkLoader_Result.php

Doc Comments +6 added lines, -6 removed lines

@@ -132,8 +132,8 @@ 
     }
 
     /**
-     * @param $obj DataObject
-     * @param $message string
+     * @param DataObject $obj DataObject
+     * @param string $message string
      */
     public function addCreated($obj, $message = null)
     {
@@ -146,8 +146,8 @@ 
     }
 
     /**
-     * @param $obj DataObject
-     * @param $message string
+     * @param DataObject $obj DataObject
+     * @param string $message string
      */
     public function addUpdated($obj, $message = null)
     {
@@ -160,8 +160,8 @@ 
     }
 
     /**
-     * @param $obj DataObject
-     * @param $message string
+     * @param DataObject|null $obj DataObject
+     * @param string $message string
      */
     public function addDeleted($obj, $message = null)
     {

src/Dev/CsvBulkLoader.php

Doc Comments +1 added lines, -1 removed lines

@@ -100,7 +100,7 @@
      * @param string $path Path to large file to split
      * @param int $lines Number of lines per file
      *
-     * @return array List of file paths
+     * @return string[] List of file paths
      */
     protected function splitFile($path, $lines = null)
     {

src/Dev/FixtureBlueprint.php

Doc Comments +6 added lines

@@ -304,6 +304,9 @@ 
         return $this;
     }
 
+    /**
+     * @param string $type
+     */
     protected function invokeCallbacks($type, $args = array())
     {
         foreach ($this->callbacks[$type] as $callback) {
@@ -346,6 +349,9 @@ 
         $obj->$name = $this->parseValue($value, $fixtures);
     }
 
+    /**
+     * @param string $fieldName
+     */
     protected function overrideField($obj, $fieldName, $value, $fixtures = null)
     {
         $class = get_class($obj);

src/Dev/SapphireTestReporter.php

Doc Comments +4 added lines, -1 removed lines

@@ -368,7 +368,7 @@ 
      *
      * @param PHPUnit_Framework_Test $test current test that is being run
      * @param Exception $e PHPUnit error
-     * @return array
+     * @return string
      */
     private function getTestException(PHPUnit_Framework_Test $test, Exception $e)
     {
@@ -483,6 +483,9 @@ 
         echo "</div>";
     }
 
+    /**
+     * @param string $name
+     */
     protected function testNameToPhrase($name)
     {
         return ucfirst(preg_replace("/([a-z])([A-Z])/", "$1 $2", $name));

src/Forms/CompositeField.php

Doc Comments +14 added lines

@@ -261,6 +261,9 @@ 
 
 
 
+    /**
+     * @param boolean $disabled
+     */
     public function setDisabled($disabled)
     {
         parent::setDisabled($disabled);
@@ -270,6 +273,9 @@ 
         return $this;
     }
 
+    /**
+     * @param boolean $readonly
+     */
     public function setReadonly($readonly)
     {
         parent::setReadonly($readonly);
@@ -362,6 +368,10 @@ 
         $this->children->removeByName($fieldName, $dataFieldOnly);
     }
 
+    /**
+     * @param string $fieldName
+     * @param FormField $newField
+     */
     public function replaceField($fieldName, $newField)
     {
         return $this->children->replaceField($fieldName, $newField);
@@ -437,6 +447,9 @@ 
         return $clone;
     }
 
+    /**
+     * @return boolean
+     */
     public function IsReadonly()
     {
         return $this->readonly;
@@ -447,6 +460,7 @@ 
      * the children collection. Doesn't work recursively.
      *
      * @param string|FormField
+     * @param string $field
      * @return int Position in children collection (first position starts with 0). Returns FALSE if the field can't
      *             be found.
      */