SilverStripe\ORM\Tests\ManyManyThroughListTest\PolyItem

Complexity

Total Complexity

4

Size/Duplication

Total Lines	24
Duplicated Lines	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	Objects()	0	6	4

<?php

namespace SilverStripe\ORM\Tests\ManyManyThroughListTest;

use Generator;
use SilverStripe\Dev\TestOnly;
use SilverStripe\ORM\DataObject;

class PolyItem extends DataObject implements TestOnly
{
    private static $table_name = 'ManyManyThroughListTest_PolyItem';

The private property $table_name is not used, and could be removed.

    private static $db = [

The private property $db is not used, and could be removed.

        'Title' => 'Varchar'
    ];

    private static $has_many = [

The private property $has_many is not used, and could be removed.

        'JoinObject' => PolyJoinObject::class . '.Items',
    ];

    /**
     * Placeholder for missing belongs_many_many for polymorphic relation
     *
     * @todo Make this work for belongs_many_many
     * @return Generator|DataObject[]
     */
    public function Objects()
    {
        foreach ($this->JoinObject() as $object) {

The method JoinObject() does not exist on SilverStripe\ORM\Tests\ManyManyThroughListTest\PolyItem. Since you implemented __call, consider adding a @method annotation.

            $objectParent = $object->Parent();
            if ($objectParent && $objectParent->exists()) {
                yield $objectParent;
            }
        }
    }
}