silverstripe / silverstripe-framework

src/Security/PasswordEncryptor_Blowfish.php

Doc Comments +5 added lines

@@ -165,6 +165,11 @@
         return sprintf('%02d', self::$cost) . '$' . substr($generator->randomToken('sha1'), 0, 22);
     }
 
+    /**
+     * @param string|false $hash
+     * @param string $password
+     * @param string $salt
+     */
     public function check($hash, $password, $salt = null, $member = null)
     {
         if (strpos($hash, '$2y$') === 0) {

src/Forms/FormRequestHandler.php

Doc Comments +1 added lines, -1 removed lines

@@ -390,7 +390,7 @@
     /**
      * Fields can have action to, let's check if anyone of the responds to $funcname them
      *
-     * @param SS_List|array $fields
+     * @param FieldList $fields
      * @param callable $funcName
      * @return FormField
      */

src/Core/Cache/DefaultCacheFactory.php

Doc Comments +2 added lines, -2 removed lines

@@ -78,7 +78,7 @@ 
     /**
      * Determine if apcu is supported
      *
-     * @return bool
+     * @return boolean|null
      */
     protected function isAPCUSupported()
     {
@@ -92,7 +92,7 @@ 
     /**
      * Determine if PHP files is supported
      *
-     * @return bool
+     * @return boolean|null
      */
     protected function isPHPFilesSupported()
     {

src/Core/Convert.php

Doc Comments +3 added lines, -2 removed lines

@@ -203,7 +203,7 @@ 
      * table, or column name. Supports encoding of multi identfiers separated by
      * a delimiter (e.g. ".")
      *
-     * @param string|array $identifier The identifier to escape. E.g. 'SiteTree.Title' or list of identifiers
+     * @param string $identifier The identifier to escape. E.g. 'SiteTree.Title' or list of identifiers
      * to be joined via the separator.
      * @param string $separator The string that delimits subsequent identifiers
      * @return string The escaped identifier. E.g. '"SiteTree"."Title"'
@@ -304,6 +304,7 @@ 
      * call this function directly, Please use {@link Convert::xml2array()}
      *
      * @param SimpleXMLElement
+     * @param SimpleXMLElement $xml
      *
      * @return mixed
      */
@@ -517,7 +518,7 @@ 
      * - IDField => idField
      * - iDField => iDField
      *
-     * @param $str
+     * @param string $str
      * @return string
      */
     public static function upperCamelToLowerCamel($str)

src/Dev/BulkLoader.php

Doc Comments +4 added lines

@@ -140,6 +140,10 @@
 	 *
 	 * @return BulkLoader_Result See {@link self::processAll()}
 	 */
+
+    /**
+     * @param string $filepath
+     */
     public function load($filepath)
     {
         increase_time_limit_to(3600);

src/Forms/HTMLEditor/HTMLEditorConfig.php

Doc Comments +1 added lines, -1 removed lines

@@ -151,7 +151,7 @@
      * Get the current value of an option
      *
      * @param string $key The key of the option to get
-     * @return mixed The value of the specified option
+     * @return string The value of the specified option
      */
     abstract public function getOption($key);
 

src/Forms/LiteralField.php

Doc Comments +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
 
     /**
      * @param string $name
-     * @param string|FormField $content
+     * @param string $content
      */
     public function __construct($name, $content)
     {

src/i18n/i18n.php

Doc Comments +1 added lines, -6 removed lines

@@ -141,12 +141,7 @@
      * @param string $entity Entity that identifies the string. It must be in the form
      * "Namespace.Entity" where Namespace will be usually the class name where this
      * string is used and Entity identifies the string inside the namespace.
-     * @param mixed $arg,... Additional arguments are parsed as such:
-     *  - Next string argument is a default. Pass in a `|` pipe-delimited value with `{count}`
-     *    to do pluralisation.
-     *  - Any other string argument after default is context for i18nTextCollector
-     *  - Any array argument in any order is an injection parameter list. Pass in a `count`
-     *    injection parameter to pluralise.
+     * @param string $arg
      * @return string
      */
     public static function _t($entity, $arg = null)

src/ORM/Filters/SearchFilter.php

Doc Comments +3 added lines, -3 removed lines

@@ -74,7 +74,7 @@ 
      *  column. Can contain a relation name in dot notation, which will automatically join
      *  the necessary tables (e.g. "Comments.Name" to join the "Comments" has-many relationship and
      *  search the "Name" column when applying this filter to a SiteTree class).
-     * @param mixed $value
+     * @param string $value
      * @param array $modifiers
      */
     public function __construct($fullName = null, $value = false, array $modifiers = array())
@@ -188,7 +188,7 @@ 
     /**
      * Gets supported modifiers for this filter
      *
-     * @return array
+     * @return string[]
      */
     public function getSupportedModifiers()
     {
@@ -428,7 +428,7 @@ 
     /**
      * Determines case sensitivity based on {@link getModifiers()}.
      *
-     * @return Mixed TRUE or FALSE to enforce sensitivity, NULL to use field collation.
+     * @return boolean|null TRUE or FALSE to enforce sensitivity, NULL to use field collation.
      */
     protected function getCaseSensitive()
     {