Completed
Pull Request — master (#6899)
by Daniel
23:28 queued 11:37
created
tests/behat/src/CmsUiContext.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -479,6 +479,7 @@
 block discarded – undo
479 479
      *
480 480
      * @When /^(?:|I )fill in the "(?P<field>(?:[^"]|\\")*)" dropdown with "(?P<value>(?:[^"]|\\")*)"$/
481 481
      * @When /^(?:|I )fill in "(?P<value>(?:[^"]|\\")*)" for the "(?P<field>(?:[^"]|\\")*)" dropdown$/
482
+     * @param string $field
482 483
      */
483 484
     public function theIFillInTheDropdownWith($field, $value)
484 485
     {
Please login to merge, or discard this patch.
src/Forms/DatetimeField.php 1 patch
Doc Comments   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
     }
136 136
 
137 137
     /**
138
-     * @param $bool
138
+     * @param boolean $bool
139 139
      * @return $this
140 140
      */
141 141
     public function setHTML5($bool)
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
      * Assign value posted from form submission, based on {@link $datetimeFormat}.
149 149
      * When $html5=true, this needs to be normalised ISO format (with "T" separator).
150 150
      *
151
-     * @param mixed $value
151
+     * @param string $value
152 152
      * @param mixed $data
153 153
      * @return $this
154 154
      */
@@ -314,7 +314,7 @@  discard block
 block discarded – undo
314 314
      * When $html5=true, assign value from ISO 8601 normalised string (with a "T" separator).
315 315
      * Falls back to an ISO 8601 string (with a whitespace separator).
316 316
      *
317
-     * @param mixed $value
317
+     * @param string $value
318 318
      * @param mixed $data
319 319
      * @return $this
320 320
      */
@@ -489,6 +489,9 @@  discard block
 block discarded – undo
489 489
         return $this;
490 490
     }
491 491
 
492
+    /**
493
+     * @param boolean $bool
494
+     */
492 495
     public function setReadonly($bool)
493 496
     {
494 497
         parent::setReadonly($bool);
Please login to merge, or discard this patch.
src/Forms/CompositeField.php 1 patch
Doc Comments   +11 added lines patch added patch discarded remove patch
@@ -270,6 +270,9 @@  discard block
 block discarded – undo
270 270
 
271 271
 
272 272
 
273
+    /**
274
+     * @param boolean $disabled
275
+     */
273 276
     public function setDisabled($disabled)
274 277
     {
275 278
         parent::setDisabled($disabled);
@@ -279,6 +282,9 @@  discard block
 block discarded – undo
279 282
         return $this;
280 283
     }
281 284
 
285
+    /**
286
+     * @param boolean $readonly
287
+     */
282 288
     public function setReadonly($readonly)
283 289
     {
284 290
         parent::setReadonly($readonly);
@@ -371,6 +377,10 @@  discard block
 block discarded – undo
371 377
         $this->children->removeByName($fieldName, $dataFieldOnly);
372 378
     }
373 379
 
380
+    /**
381
+     * @param string $fieldName
382
+     * @param FormField $newField
383
+     */
374 384
     public function replaceField($fieldName, $newField)
375 385
     {
376 386
         return $this->children->replaceField($fieldName, $newField);
@@ -456,6 +466,7 @@  discard block
 block discarded – undo
456 466
      * the children collection. Doesn't work recursively.
457 467
      *
458 468
      * @param string|FormField
469
+     * @param string $field
459 470
      * @return int Position in children collection (first position starts with 0). Returns FALSE if the field can't
460 471
      *             be found.
461 472
      */
Please login to merge, or discard this patch.
tests/php/Forms/GridField/GridFieldAddNewButtonTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -88,6 +88,9 @@
 block discarded – undo
88 88
         $this->mockButtonFragments($list, null);
89 89
     }
90 90
 
91
+    /**
92
+     * @param \SilverStripe\ORM\DataObject $parent
93
+     */
91 94
     protected function mockButtonFragments(SS_List $list, $parent = null)
92 95
     {
93 96
         $form = Form::create(
Please login to merge, or discard this patch.
src/Dev/SapphireTest.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -673,10 +673,10 @@  discard block
 block discarded – undo
673 673
     /**
674 674
      * Assert that the matching email was sent since the last call to clearEmails()
675 675
      * All of the parameters can either be a string, or, if they start with "/", a PREG-compatible regular expression.
676
-     * @param $to
676
+     * @param string $to
677 677
      * @param $from
678
-     * @param $subject
679
-     * @param $content
678
+     * @param string $subject
679
+     * @param string $content
680 680
      * @return array Contains the keys: 'type', 'to', 'from', 'subject', 'content', 'plainContent', 'attachedFiles',
681 681
      *               'customHeaders', 'htmlContent', inlineImages'
682 682
      */
@@ -909,7 +909,7 @@  discard block
 block discarded – undo
909 909
      * @param string $expectedSQL
910 910
      * @param string $actualSQL
911 911
      * @param string $message
912
-     * @param float|int $delta
912
+     * @param integer $delta
913 913
      * @param integer $maxDepth
914 914
      * @param boolean $canonicalize
915 915
      * @param boolean $ignoreCase
@@ -1200,7 +1200,7 @@  discard block
 block discarded – undo
1200 1200
      * Create a member and group with the given permission code, and log in with it.
1201 1201
      * Returns the member ID.
1202 1202
      *
1203
-     * @param string|array $permCode Either a permission, or list of permissions
1203
+     * @param string $permCode Either a permission, or list of permissions
1204 1204
      * @return int Member ID
1205 1205
      */
1206 1206
     public function logInWithPermission($permCode = "ADMIN")
Please login to merge, or discard this patch.