Completed
Pull Request — 3.1 (#5200)
by Daniel
12:18
created
forms/gridfield/GridFieldFilterHeader.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -23,6 +23,7 @@
 block discarded – undo
23 23
 	 *
24 24
 	 * By default, this is set to true so that it's clearer what's happening, but the predefined
25 25
 	 * {@link GridFieldConfig} subclasses set this to false for flexibility.
26
+	 * @param boolean $throwExceptionOnBadDataType
26 27
 	 */
27 28
 	public function setThrowExceptionOnBadDataType($throwExceptionOnBadDataType) {
28 29
 		$this->throwExceptionOnBadDataType = $throwExceptionOnBadDataType;
Please login to merge, or discard this patch.
forms/gridfield/GridFieldPageCount.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@
 block discarded – undo
23 23
 	protected $itemClass = 'GridFieldPageCount';
24 24
 
25 25
 	/**
26
-	 * @param string $targetFrament The fragment indicating the placement of this page count
26
+	 * @param string $targetFragment The fragment indicating the placement of this page count
27 27
 	 */
28 28
 	public function __construct($targetFragment = 'before') {
29 29
 		$this->targetFragment = $targetFragment;
Please login to merge, or discard this patch.
forms/gridfield/GridFieldPaginator.php 1 patch
Doc Comments   +2 added lines patch added patch discarded remove patch
@@ -50,6 +50,7 @@  discard block
 block discarded – undo
50 50
 	 *
51 51
 	 * By default, this is set to true so that it's clearer what's happening, but the predefined
52 52
 	 * {@link GridFieldConfig} subclasses set this to false for flexibility.
53
+	 * @param boolean $throwExceptionOnBadDataType
53 54
 	 */
54 55
 	public function setThrowExceptionOnBadDataType($throwExceptionOnBadDataType) {
55 56
 		$this->throwExceptionOnBadDataType = $throwExceptionOnBadDataType;
@@ -65,6 +66,7 @@  discard block
 block discarded – undo
65 66
 	/**
66 67
 	 * Check that this dataList is of the right data type.
67 68
 	 * Returns false if it's a bad data type, and if appropriate, throws an exception.
69
+	 * @param SS_List $dataList
68 70
 	 */
69 71
 	protected function checkDataType($dataList) {
70 72
 		if($dataList instanceof SS_Limitable) {
Please login to merge, or discard this patch.
forms/gridfield/GridFieldPrintButton.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 	 *
67 67
 	 * @param GridField
68 68
 	 *
69
-	 * @return array
69
+	 * @return string[]
70 70
 	 */
71 71
 	public function getActions($gridField) {
72 72
 		return array('print');
@@ -100,6 +100,7 @@  discard block
 block discarded – undo
100 100
 
101 101
 	/**
102 102
 	 * Handle the print, for both the action button and the URL
103
+ 	 * @param GridField $gridField
103 104
  	 */
104 105
 	public function handlePrint($gridField, $request = null) {
105 106
 		set_time_limit(60);
Please login to merge, or discard this patch.
forms/gridfield/GridFieldSortableHeader.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,6 +29,7 @@  discard block
 block discarded – undo
29 29
 	 *
30 30
 	 * By default, this is set to true so that it's clearer what's happening, but the predefined
31 31
 	 * {@link GridFieldConfig} subclasses set this to false for flexibility.
32
+	 * @param boolean $throwExceptionOnBadDataType
32 33
 	 */
33 34
 	public function setThrowExceptionOnBadDataType($throwExceptionOnBadDataType) {
34 35
 		$this->throwExceptionOnBadDataType = $throwExceptionOnBadDataType;
@@ -61,7 +62,7 @@  discard block
 block discarded – undo
61 62
 	 * Specify sortings with fieldname as the key, and actual fieldname to sort as value.
62 63
 	 * Example: array("MyCustomTitle"=>"Title", "MyCustomBooleanField" => "ActualBooleanField")
63 64
 	 *
64
-	 * @param array $casting
65
+	 * @param array $sorting
65 66
 	 */
66 67
 	public function setFieldSorting($sorting) {
67 68
 		$this->fieldSorting = $sorting;
Please login to merge, or discard this patch.
forms/HtmlEditorSanitiser.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
 	/**
40 40
 	 * Given a TinyMCE pattern (close to unix glob style), create a regex that does the match
41 41
 	 *
42
-	 * @param $str - The TinyMCE pattern
42
+	 * @param string|null $str - The TinyMCE pattern
43 43
 	 * @return string - The equivalent regex
44 44
 	 */
45 45
 	protected function patternToRegex($str) {
@@ -180,6 +180,7 @@  discard block
 block discarded – undo
180 180
 	/**
181 181
 	 * Given an attribute name, return the rule structure for that attribute
182 182
 	 * @param string $name - The attribute name
183
+	 * @param stdClass $elementRule
183 184
 	 * @return stdClass - The attribute rule
184 185
 	 */
185 186
 	protected function getRuleForAttribute($elementRule, $name) {
Please login to merge, or discard this patch.
forms/MoneyField.php 1 patch
Doc Comments   +8 added lines patch added patch discarded remove patch
@@ -32,6 +32,10 @@  discard block
 block discarded – undo
32 32
 	 */
33 33
 	protected $fieldCurrency = null;
34 34
 
35
+	/**
36
+	 * @param string $name
37
+	 * @param string $title
38
+	 */
35 39
 	public function __construct($name, $title = null, $value = "") {
36 40
 		// naming with underscores to prevent values from actually being saved somewhere
37 41
 		$this->fieldAmount = new NumericField("{$name}[Amount]", _t('MoneyField.FIELDLABELAMOUNT', 'Amount'));
@@ -135,6 +139,7 @@  discard block
 block discarded – undo
135 139
 	/**
136 140
 	 * @todo Implement removal of readonly state with $bool=false
137 141
 	 * @todo Set readonly state whenever field is recreated, e.g. in setAllowedCurrencies()
142
+	 * @param boolean $bool
138 143
 	 */
139 144
 	public function setReadonly($bool) {
140 145
 		parent::setReadonly($bool);
@@ -175,6 +180,9 @@  discard block
 block discarded – undo
175 180
 		return $this->allowedCurrencies;
176 181
 	}
177 182
 
183
+	/**
184
+	 * @param string $locale
185
+	 */
178 186
 	public function setLocale($locale) {
179 187
 		$this->_locale = $locale;
180 188
 		return $this;
Please login to merge, or discard this patch.
forms/NestedForm.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -11,7 +11,7 @@
 block discarded – undo
11 11
 
12 12
 	/**
13 13
 	 * Represent the given form in a tabular style
14
-	 * @param form The form to decorate.
14
+	 * @param form Form form to decorate.
15 15
 	 */
16 16
 	public function __construct(Form $form) {
17 17
 		$this->form = $form;
Please login to merge, or discard this patch.
forms/OptionsetField.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -103,7 +103,7 @@
 block discarded – undo
103 103
 	 * Mark certain elements as disabled,
104 104
 	 * regardless of the {@link setDisabled()} settings.
105 105
 	 *
106
-	 * @param array $items Collection of array keys, as defined in the $source array
106
+	 * @param integer[] $items Collection of array keys, as defined in the $source array
107 107
 	 */
108 108
 	public function setDisabledItems($items) {
109 109
 		$this->disabledItems = $items;
Please login to merge, or discard this patch.