Completed
Pull Request — 3.1 (#5200)
by Daniel
12:18
created
filesystem/FileNameFilter.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -99,7 +99,7 @@
 block discarded – undo
99 99
 	protected $transliterator;
100 100
 
101 101
 	/**
102
-	 * @return SS_Transliterator|NULL
102
+	 * @return SS_Transliterator
103 103
 	 */
104 104
 	public function getTransliterator() {
105 105
 		if($this->transliterator === null && $this->config()->default_use_transliterator) {
Please login to merge, or discard this patch.
filesystem/Folder.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@
 block discarded – undo
45 45
 	 * Find the given folder or create it as a database record
46 46
 	 *
47 47
 	 * @param string $folderPath Directory path relative to assets root
48
-	 * @return Folder|null
48
+	 * @return null|DataObject
49 49
 	 */
50 50
 	public static function find_or_make($folderPath) {
51 51
 		// replace leading and trailing slashes
Please login to merge, or discard this patch.
forms/CheckboxSetField.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -169,7 +169,7 @@
 block discarded – undo
169 169
 	 * Note: Items marked as disabled through {@link setDisabledItems()} can still be
170 170
 	 * selected by default through this method.
171 171
 	 *
172
-	 * @param Array $items Collection of array keys, as defined in the $source array
172
+	 * @param integer[] $items Collection of array keys, as defined in the $source array
173 173
 	 */
174 174
 	public function setDefaultItems($items) {
175 175
 		$this->defaultItems = $items;
Please login to merge, or discard this patch.
forms/FieldList.php 1 patch
Doc Comments   +10 added lines, -2 removed lines patch added patch discarded remove patch
@@ -118,6 +118,7 @@  discard block
 block discarded – undo
118 118
 	 *                        or TabSet.Tab.Subtab.
119 119
 	 * This function will create any missing tabs.
120 120
 	 * @param array $fields An array of {@link FormField} objects.
121
+	 * @param string $insertBefore
121 122
 	 */
122 123
 	public function addFieldsToTab($tabName, $fields, $insertBefore = null) {
123 124
 		$this->flushFieldsCache();
@@ -157,7 +158,7 @@  discard block
 block discarded – undo
157 158
 	 * Removes a number of fields from a Tab/TabSet within this FieldList.
158 159
 	 *
159 160
 	 * @param string $tabName The name of the Tab or TabSet field
160
-	 * @param array $fields A list of fields, e.g. array('Name', 'Email')
161
+	 * @param string[] $fields A list of fields, e.g. array('Name', 'Email')
161 162
 	 */
162 163
 	public function removeFieldsFromTab($tabName, $fields) {
163 164
 		$this->flushFieldsCache();
@@ -426,6 +427,7 @@  discard block
 block discarded – undo
426 427
 
427 428
 	/**
428 429
 	 * Handler method called before the FieldList is going to be manipulated.
430
+	 * @param FormField $item
429 431
 	 */
430 432
 	protected function onBeforeInsert($item) {
431 433
 		$this->flushFieldsCache();
@@ -498,6 +500,7 @@  discard block
 block discarded – undo
498 500
 	 * Transform this FieldList with a given tranform method,
499 501
 	 * e.g. $this->transform(new ReadonlyTransformation())
500 502
 	 *
503
+	 * @param ReadonlyTransformation $trans
501 504
 	 * @return FieldList
502 505
 	 */
503 506
 	public function transform($trans) {
@@ -517,6 +520,9 @@  discard block
 block discarded – undo
517 520
 		else return $this;
518 521
 	}
519 522
 
523
+	/**
524
+	 * @param CompositeField $field
525
+	 */
520 526
 	public function setContainerField($field) {
521 527
 		$this->containerField = $field;
522 528
 		return $this;
@@ -535,6 +541,7 @@  discard block
 block discarded – undo
535 541
 	 * Transform the named field into a readonly feld.
536 542
 	 *
537 543
 	 * @param string|FormField
544
+	 * @param string $field
538 545
 	 */
539 546
 	public function makeFieldReadonly($field) {
540 547
 		$fieldName = ($field instanceof FormField) ? $field->getName() : $field;
@@ -584,6 +591,7 @@  discard block
 block discarded – undo
584 591
 	 * the children collection. Doesn't work recursively.
585 592
 	 *
586 593
 	 * @param string|FormField
594
+	 * @param string $field
587 595
 	 * @return int Position in children collection (first position starts with 0). Returns FALSE if the field can't
588 596
 	 *             be found.
589 597
 	 */
@@ -631,7 +639,7 @@  discard block
 block discarded – undo
631 639
 	 * Support function for backwards compatibility purposes.
632 640
 	 * Caution: Volatile API, might be removed in 3.1 or later.
633 641
 	 *
634
-	 * @param  String $tabname Path to a tab, e.g. "Root.Content.Main"
642
+	 * @param  String $name Path to a tab, e.g. "Root.Content.Main"
635 643
 	 * @return String Rewritten path, based on {@link tabPathRewrites}
636 644
 	 */
637 645
 	protected function rewriteTabPath($name) {
Please login to merge, or discard this patch.
forms/FormScaffolder.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,6 @@
 block discarded – undo
49 49
 
50 50
 	/**
51 51
 	 * @param DataObject $obj
52
-	 * @param array $params
53 52
 	 */
54 53
 	public function __construct($obj) {
55 54
 		$this->obj = $obj;
Please login to merge, or discard this patch.
forms/gridfield/GridField.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
 	 *
198 198
 	 * @todo refactor this into GridFieldComponent
199 199
 	 *
200
-	 * @param mixed $value
200
+	 * @param string $value
201 201
 	 * @param string|array $castingDefinition
202 202
 	 *
203 203
 	 * @return mixed
@@ -569,7 +569,7 @@  discard block
 block discarded – undo
569 569
 	 * @param int $index
570 570
 	 * @param DataObject $record
571 571
 	 *
572
-	 * @return array
572
+	 * @return string[]
573 573
 	 */
574 574
 	protected function newRowClasses($total, $index, $record) {
575 575
 		$classes = array('ss-gridfield-item');
Please login to merge, or discard this patch.
forms/gridfield/GridFieldAddExistingAutocompleter.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -129,7 +129,7 @@
 block discarded – undo
129 129
 	/**
130 130
 	 *
131 131
 	 * @param GridField $gridField
132
-	 * @return array
132
+	 * @return string[]
133 133
 	 */
134 134
 	public function getActions($gridField) {
135 135
 		return array('addto');
Please login to merge, or discard this patch.
forms/gridfield/GridFieldComponent.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -33,6 +33,7 @@  discard block
 block discarded – undo
33 33
 	 * If you attempt to return HTML for a fragment that doesn't exist, an
34 34
 	 * exception will be thrown when the {@link GridField} is rendered.
35 35
 	 *
36
+	 * @param GridField $gridField
36 37
 	 * @return array
37 38
 	 */
38 39
 	public function getHTMLFragments($gridField);
@@ -57,6 +58,7 @@  discard block
 block discarded – undo
57 58
 	 * @param GridField $gridField
58 59
 	 * @param arary $columns List of columns
59 60
 	 * @param array - List reference of all column names.
61
+	 * @return void
60 62
 	 */
61 63
 	public function augmentColumns($gridField, &$columns);
62 64
 
@@ -139,6 +141,7 @@  discard block
 block discarded – undo
139 141
 	 * @param String Action identifier, see {@link getActions()}.
140 142
 	 * @param Array Arguments relevant for this
141 143
 	 * @param Array All form data
144
+	 * @param string $actionName
142 145
 	 */
143 146
 	public function handleAction(GridField $gridField, $actionName, $arguments, $data);
144 147
 }
@@ -189,6 +192,7 @@  discard block
 block discarded – undo
189 192
 	 *
190 193
 	 * Handler methods will be called on the component, rather than the
191 194
 	 * {@link GridField}.
195
+	 * @param GridField $gridField
192 196
 	 */
193 197
 	public function getURLHandlers($gridField);
194 198
 }
@@ -205,7 +209,6 @@  discard block
 block discarded – undo
205 209
 	/**
206 210
 	 * Called when a grid field is saved - i.e. the form is submitted.
207 211
 	 *
208
-	 * @param GridField $field
209 212
 	 * @param DataObjectInterface $record
210 213
 	 */
211 214
 	public function handleSave(GridField $grid, DataObjectInterface $record);
Please login to merge, or discard this patch.
forms/gridfield/GridFieldDataColumns.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -70,6 +70,7 @@  discard block
 block discarded – undo
70 70
 	/**
71 71
 	 * Get the DisplayFields
72 72
 	 *
73
+	 * @param GridField $gridField
73 74
 	 * @return array
74 75
 	 * @see GridFieldDataColumns::setDisplayFields
75 76
 	 */
@@ -174,7 +175,7 @@  discard block
 block discarded – undo
174 175
 	 * e.g. to set a title for a search column header.
175 176
 	 *
176 177
 	 * @param GridField $gridField
177
-	 * @param string $columnName
178
+	 * @param string $column
178 179
 	 * @return array - Map of arbitrary metadata identifiers to their values.
179 180
 	 */
180 181
 	public function getColumnMetadata($gridField, $column) {
Please login to merge, or discard this patch.