Completed
Pull Request — 3.1 (#5200)
by Daniel
12:18
created
forms/Form.php 1 patch
Doc Comments   +7 added lines, -2 removed lines patch added patch discarded remove patch
@@ -496,7 +496,7 @@  discard block
 block discarded – undo
496 496
 	/**
497 497
 	 * Fields can have action to, let's check if anyone of the responds to $funcname them
498 498
 	 *
499
-	 * @param SS_List|array $fields
499
+	 * @param FieldList|null $fields
500 500
 	 * @param callable $funcName
501 501
 	 * @return FormField
502 502
 	 */
@@ -755,6 +755,7 @@  discard block
 block discarded – undo
755 755
 	}
756 756
 
757 757
 	/**
758
+	 * @param string $name
758 759
 	 * @return string $name
759 760
 	 */
760 761
 	public function getAttribute($name) {
@@ -788,6 +789,7 @@  discard block
 block discarded – undo
788 789
 	 *
789 790
 	 * @param array Custom attributes to process. Falls back to {@link getAttributes()}.
790 791
 	 * If at least one argument is passed as a string, all arguments act as excludes by name.
792
+	 * @param string $attrs
791 793
 	 *
792 794
 	 * @return string HTML attributes, ready for insertion into an HTML tag
793 795
 	 */
@@ -963,7 +965,7 @@  discard block
 block discarded – undo
963 965
 	 * If set to false (the default), then the form method is only used to construct the default
964 966
 	 * form.
965 967
 	 *
966
-	 * @param $bool boolean
968
+	 * @param boolean $bool boolean
967 969
 	 * @return $this
968 970
 	 */
969 971
 	public function setStrictFormMethodCheck($bool) {
@@ -1707,6 +1709,9 @@  discard block
 block discarded – undo
1707 1709
 class Form_FieldMap extends ViewableData {
1708 1710
 	protected $form;
1709 1711
 
1712
+	/**
1713
+	 * @param Form $form
1714
+	 */
1710 1715
 	public function __construct($form) {
1711 1716
 		$this->form = $form;
1712 1717
 		parent::__construct();
Please login to merge, or discard this patch.
forms/FormAction.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -89,6 +89,7 @@
 block discarded – undo
89 89
 	 * Determines if the field should render open or closed by default.
90 90
 	 * 
91 91
 	 * @param boolean
92
+	 * @param boolean $bool
92 93
 	 */
93 94
 	public function startClosed($bool) {
94 95
 		($bool) ? $this->addExtraClass('startClosed') : $this->removeExtraClass('startClosed');
Please login to merge, or discard this patch.
forms/gridfield/GridFieldConfig.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,6 @@  discard block
 block discarded – undo
27 27
 	protected $components = null;
28 28
 	
29 29
 	/**
30
-	 * @param mixed $arguments,... arguments to pass to the constructor
31 30
 	 * @return GridFieldConfig
32 31
 	 */
33 32
 	public static function create() {
@@ -87,6 +86,7 @@  discard block
 block discarded – undo
87 86
 	
88 87
 	/**
89 88
 	 * @param String Class name or interface
89
+	 * @param string $type
90 90
 	 * @return GridFieldConfig $this
91 91
 	 */
92 92
 	public function removeComponentsByType($type) {
@@ -125,6 +125,7 @@  discard block
 block discarded – undo
125 125
 	 * Returns the first available component with the given class or interface.
126 126
 	 * 
127 127
 	 * @param String ClassName
128
+	 * @param string $type
128 129
 	 * @return GridFieldComponent
129 130
 	 */
130 131
 	public function getComponentByType($type) {
Please login to merge, or discard this patch.
forms/gridfield/GridFieldDeleteAction.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
 	 * Which columns are handled by this component
81 81
 	 * 
82 82
 	 * @param type $gridField
83
-	 * @return type 
83
+	 * @return string[] 
84 84
 	 */
85 85
 	public function getColumnsHandled($gridField) {
86 86
 		return array('Actions');
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
90 90
 	 * Which GridField actions are this component handling
91 91
 	 *
92 92
 	 * @param GridField $gridField
93
-	 * @return array 
93
+	 * @return string[] 
94 94
 	 */
95 95
 	public function getActions($gridField) {
96 96
 		return array('deleterecord', 'unlinkrelation');
Please login to merge, or discard this patch.
forms/gridfield/GridFieldEditButton.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
 	 * Which columns are handled by this component
56 56
 	 * 
57 57
 	 * @param type $gridField
58
-	 * @return type 
58
+	 * @return string[] 
59 59
 	 */
60 60
 	public function getColumnsHandled($gridField) {
61 61
 		return array('Actions');
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
 	 * @param DataObject $record
77 77
 	 * @param string $columnName
78 78
 	 *
79
-	 * @return string - the HTML for the column 
79
+	 * @return HTMLText - the HTML for the column 
80 80
 	 */
81 81
 	public function getColumnContent($gridField, $record, $columnName) {
82 82
 		// No permission checks, handled through GridFieldDetailForm,
Please login to merge, or discard this patch.
forms/gridfield/GridState.php 1 patch
Doc Comments   +2 added lines, -3 removed lines patch added patch discarded remove patch
@@ -24,8 +24,7 @@  discard block
 block discarded – undo
24 24
 	
25 25
 	/**
26 26
 	 *
27
-	 * @param GridField $name
28
-	 * @param string $data - json encoded string
27
+	 * @param GridField $grid
29 28
 	 */
30 29
 	public function __construct($grid, $value = null) {
31 30
 		$this->grid = $grid;
@@ -108,7 +107,7 @@  discard block
 block discarded – undo
108 107
 
109 108
 	/**
110 109
 	 *
111
-	 * @return type 
110
+	 * @return string 
112 111
 	 */
113 112
 	public function __toString() {
114 113
 		return $this->Value();
Please login to merge, or discard this patch.
forms/HtmlEditorField.php 1 patch
Doc Comments   +12 added lines, -2 removed lines patch added patch discarded remove patch
@@ -57,6 +57,7 @@  discard block
 block discarded – undo
57 57
 	
58 58
 	/**
59 59
 	 * @see TextareaField::__construct()
60
+	 * @param string $name
60 61
 	 */
61 62
 	public function __construct($name, $title = null, $value = '') {
62 63
 		parent::__construct($name, $title, $value);
@@ -234,7 +235,7 @@  discard block
 block discarded – undo
234 235
 	/**
235 236
 	 * Searches the SiteTree for display in the dropdown
236 237
 	 *  
237
-	 * @return callback
238
+	 * @return DataList
238 239
 	 */	
239 240
 	public function siteTreeSearchCallback($sourceObject, $labelField, $search) {
240 241
 		return DataObject::get($sourceObject, "\"MenuTitle\" LIKE '%$search%' OR \"Title\" LIKE '%$search%'");
@@ -529,7 +530,7 @@  discard block
 block discarded – undo
529 530
 	/**
530 531
 	 * Find all anchors available on the given page.
531 532
 	 *
532
-	 * @return array
533
+	 * @return string
533 534
 	 */
534 535
 	public function getanchors() {
535 536
 		$id = (int)$this->request->getVar('PageID');
@@ -567,6 +568,7 @@  discard block
 block discarded – undo
567 568
 	 * not the "master record" in the database - hence there's no form or saving logic.
568 569
 	 * 
569 570
 	 * @param String Relative or absolute URL to file
571
+	 * @param HtmlEditorField_File $file
570 572
 	 * @return FieldList
571 573
 	 */
572 574
 	protected function getFieldsForFile($url, $file) {
@@ -588,6 +590,7 @@  discard block
 block discarded – undo
588 590
 	}
589 591
 
590 592
 	/**
593
+	 * @param HtmlEditorField_Embed $file
591 594
 	 * @return FieldList
592 595
 	 */
593 596
 	protected function getFieldsForOembed($url, $file) {
@@ -797,6 +800,7 @@  discard block
 block discarded – undo
797 800
 
798 801
 	/**
799 802
 	 * @param Int
803
+	 * @param integer $parentID
800 804
 	 * @return DataList
801 805
 	 */
802 806
 	protected function getFiles($parentID = null) {
@@ -923,6 +927,9 @@  discard block
 block discarded – undo
923 927
 
924 928
 	protected $oembed;
925 929
 
930
+	/**
931
+	 * @param DataObject $file
932
+	 */
926 933
 	public function __construct($url, $file = null) {
927 934
 		parent::__construct($url, $file);
928 935
 		$this->oembed = Oembed::get_oembed_from_url($url);
@@ -1015,6 +1022,9 @@  discard block
 block discarded – undo
1015 1022
 
1016 1023
 	protected $height;
1017 1024
 
1025
+	/**
1026
+	 * @param DataObject $file
1027
+	 */
1018 1028
 	public function __construct($url, $file = null) {
1019 1029
 		parent::__construct($url, $file);
1020 1030
 
Please login to merge, or discard this patch.
forms/ListboxField.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -204,6 +204,7 @@
 block discarded – undo
204 204
 
205 205
 	/**
206 206
 	 * Load a value into this CheckboxSetField
207
+	 * @param DataObject $obj
207 208
 	 */
208 209
 	public function setValue($val, $obj = null) {
209 210
 		// If we're not passed a value directly, 
Please login to merge, or discard this patch.
forms/LookupField.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -95,7 +95,7 @@
 block discarded – undo
95 95
 	/**
96 96
 	 * Override parent behavior by not merging arrays.
97 97
 	 *
98
-	 * @return array
98
+	 * @return boolean
99 99
 	 */
100 100
 	public function getSource() {
101 101
 		return $this->source;
Please login to merge, or discard this patch.