Completed
Push — pulls/3/auto-index-sort ( 612f1d...cde0ad )
by Daniel
08:43
created
tests/core/manifest/ConfigManifestTest.php 1 patch
Doc Comments   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -10,7 +10,7 @@  discard block
 block discarded – undo
10 10
 
11 11
 	/**
12 12
 	 * This is a helper method for getting a new manifest
13
-	 * @param $name
13
+	 * @param string $name
14 14
 	 * @return any
15 15
 	 */
16 16
 	protected function getConfigFixtureValue($name) {
@@ -20,6 +20,7 @@  discard block
 block discarded – undo
20 20
 
21 21
 	/**
22 22
 	 * This is a helper method for displaying a relevant message about a parsing failure
23
+	 * @param string $path
23 24
 	 */
24 25
 	protected function getParsedAsMessage($path) {
25 26
 		return sprintf('Reference path "%s" failed to parse correctly', $path);
@@ -41,7 +42,7 @@  discard block
 block discarded – undo
41 42
 
42 43
 	/**
43 44
 	 * A helper method to return a mock of the manifest in order to test expectations and reduce dependency
44
-	 * @param $methods
45
+	 * @param string[] $methods
45 46
 	 * @return SS_ConfigManifest
46 47
 	 */
47 48
 	protected function getManifestMock($methods) {
Please login to merge, or discard this patch.
tests/core/manifest/ManifestFileFinderTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -14,6 +14,10 @@
 block discarded – undo
14 14
 		parent::__construct();
15 15
 	}
16 16
 
17
+	/**
18
+	 * @param ManifestFileFinder $finder
19
+	 * @param string[] $expect
20
+	 */
17 21
 	public function assertFinderFinds($finder, $expect, $message = null) {
18 22
 		$found = $finder->find($this->base);
19 23
 
Please login to merge, or discard this patch.
tests/core/manifest/TemplateLoaderTest.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -174,12 +174,18 @@
 block discarded – undo
174 174
 		$this->loader->pushManifest($this->manifest);
175 175
 	}
176 176
 
177
+	/**
178
+	 * @param string[] $templates
179
+	 */
177 180
 	protected function createTestTemplates($templates) {
178 181
 		foreach ($templates as $template) {
179 182
 			file_put_contents($template, '');
180 183
 		}
181 184
 	}
182 185
 
186
+	/**
187
+	 * @param string[] $templates
188
+	 */
183 189
 	protected function removeTestTemplates($templates) {
184 190
 		foreach ($templates as $template) {
185 191
 			unlink($template);
Please login to merge, or discard this patch.
tests/core/startup/ParameterConfirmationTokenTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -23,6 +23,9 @@
 block discarded – undo
23 23
 
24 24
 class ParameterConfirmationTokenTest extends SapphireTest {
25 25
 
26
+	/**
27
+	 * @param string $part
28
+	 */
26 29
 	private function addPart($answer, $slash, $part) {
27 30
 		$bare = str_replace('/', '', $part);
28 31
 
Please login to merge, or discard this patch.
tests/dev/CsvBulkLoaderTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -222,6 +222,9 @@
 block discarded – undo
222 222
 	}
223 223
 
224 224
 
225
+	/**
226
+	 * @param resource $file
227
+	 */
225 228
 	protected function getLineCount(&$file) {
226 229
 		$i = 0;
227 230
 		while(fgets($file) !== false) $i++;
Please login to merge, or discard this patch.
tests/dev/DevAdminControllerTest.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -47,6 +47,9 @@  discard block
 block discarded – undo
47 47
 
48 48
 
49 49
 
50
+	/**
51
+	 * @param string $url
52
+	 */
50 53
 	protected function getCapture($url){
51 54
 		$this->logInWithPermission('ADMIN');
52 55
 
@@ -58,6 +61,9 @@  discard block
 block discarded – undo
58 61
 		return $r;
59 62
 	}
60 63
 
64
+	/**
65
+	 * @param string $url
66
+	 */
61 67
 	protected function getAndCheckForError($url){
62 68
 		$this->logInWithPermission('ADMIN');
63 69
 
Please login to merge, or discard this patch.
tests/filesystem/FileFinderTest.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -98,6 +98,11 @@
 block discarded – undo
98 98
 			'The finder respects the max depth setting.');
99 99
 	}
100 100
 
101
+	/**
102
+	 * @param SS_FileFinder $finder
103
+	 * @param string[] $expect
104
+	 * @param string $message
105
+	 */
101 106
 	public function assertFinderFinds($finder, $expect, $message = null) {
102 107
 		$found = $finder->find($this->base);
103 108
 
Please login to merge, or discard this patch.
tests/forms/EmailFieldTest.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -23,6 +23,11 @@
 block discarded – undo
23 23
 		$this->internalCheck("domain.but.no.user", "Invalid, no user part", false);
24 24
 	}
25 25
 
26
+	/**
27
+	 * @param string $email
28
+	 * @param string $checkText
29
+	 * @param boolean $expectSuccess
30
+	 */
26 31
 	public function internalCheck($email, $checkText, $expectSuccess) {
27 32
 		$field = new EmailField("MyEmail");
28 33
 		$field->setValue($email);
Please login to merge, or discard this patch.
tests/forms/gridfield/GridField_URLHandlerTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -111,6 +111,9 @@
 block discarded – undo
111 111
 
112 112
 	protected $id;
113 113
 
114
+	/**
115
+	 * @param string $link
116
+	 */
114 117
 	public function __construct($gridField, $id, $link) {
115 118
 		$this->gridField = $gridField;
116 119
 		$this->id = $id;
Please login to merge, or discard this patch.