Completed
Push — pulls/3/auto-index-sort ( 612f1d...cde0ad )
by Daniel
08:43
created
model/DataQuery.php 1 patch
Doc Comments   +9 added lines, -2 removed lines patch added patch discarded remove patch
@@ -44,6 +44,7 @@  discard block
 block discarded – undo
44 44
 	 * Create a new DataQuery.
45 45
 	 *
46 46
 	 * @param string The name of the DataObject class that you wish to query
47
+	 * @param string $dataClass
47 48
 	 */
48 49
 	public function __construct($dataClass) {
49 50
 		$this->dataClass = $dataClass;
@@ -175,7 +176,7 @@  discard block
 block discarded – undo
175 176
 	/**
176 177
 	 * Ensure that the query is ready to execute.
177 178
 	 *
178
-	 * @param array|null $queriedColumns Any columns to filter the query by
179
+	 * @param string[] $queriedColumns Any columns to filter the query by
179 180
 	 * @return SQLQuery The finalised sql query
180 181
 	 */
181 182
 	public function getFinalisedQuery($queriedColumns = null) {
@@ -693,7 +694,7 @@  discard block
 block discarded – undo
693 694
 	 * mappings to the query object state. This has to be called
694 695
 	 * in any overloaded {@link SearchFilter->apply()} methods manually.
695 696
 	 *
696
-	 * @param string|array $relation The array/dot-syntax relation to follow
697
+	 * @param string $relation The array/dot-syntax relation to follow
697 698
 	 * @return string The model class of the related item
698 699
 	 */
699 700
 	public function applyRelation($relation) {
@@ -935,6 +936,9 @@  discard block
 block discarded – undo
935 936
 	 */
936 937
 	protected $whereQuery;
937 938
 
939
+	/**
940
+	 * @param string $connective
941
+	 */
938 942
 	public function __construct(DataQuery $base, $connective) {
939 943
 		$this->dataClass = $base->dataClass;
940 944
 		$this->query = $base->query;
@@ -944,6 +948,9 @@  discard block
 block discarded – undo
944 948
 		$base->where($this);
945 949
 	}
946 950
 
951
+	/**
952
+	 * @param string $filter
953
+	 */
947 954
 	public function where($filter) {
948 955
 		if($filter) {
949 956
 			$this->whereQuery->addWhere($filter);
Please login to merge, or discard this patch.
security/MemberAuthenticator.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
 	 * @param Form $form Optional: If passed, better error messages can be
146 146
 	 *                             produced by using
147 147
 	 *                             {@link Form::sessionMessage()}
148
-	 * @return bool|Member Returns FALSE if authentication fails, otherwise
148
+	 * @return Member|null Returns FALSE if authentication fails, otherwise
149 149
 	 *                     the member object
150 150
 	 * @see Security::setDefaultAdmin()
151 151
 	 */
@@ -186,7 +186,7 @@  discard block
 block discarded – undo
186 186
 	/**
187 187
 	 * Method that creates the login form for this authentication method
188 188
 	 *
189
-	 * @param Controller The parent controller, necessary to create the
189
+	 * @param Controller Controller parent controller, necessary to create the
190 190
 	 *                   appropriate form action tag
191 191
 	 * @return MemberLoginForm Returns the login form to use with this authentication
192 192
 	 *              method
Please login to merge, or discard this patch.