PermissionTest::testPermissionAreInheritedFromOneRole() - Code Metrics - Inspection of "ENH Replace record in Permission Table if GroupID..." - silverstripe/silverstripe-framework - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Pull Request — 4 (#10330)

unknown
created 2022-05-23 02:53 UTC
testPermissionAreInheritedFromOneRole() A

↳ Parent: PermissionTest
Complexity

Conditions	1
Paths	1
Size

Total Lines	6
Code Lines	4
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	1
eloc	4
nc	1
nop	0
dl	0
loc	6
rs	10
c	0
b	0
f	0
<?php

namespace SilverStripe\Security\Tests;

use SilverStripe\Security\Permission;
use SilverStripe\Security\Group;
use SilverStripe\Security\Member;
use SilverStripe\Security\PermissionCheckboxSetField;
use SilverStripe\Core\Config\Config;
use SilverStripe\Dev\SapphireTest;

/**
 * @skipUpgrade
 */
class PermissionTest extends SapphireTest
{

    protected static $fixture_file = 'PermissionTest.yml';

    public function testGetCodesGrouped()
    {
        $codes = Permission::get_codes();
        $this->assertArrayNotHasKey('SITETREE_VIEW_ALL', $codes);
    }

    public function testGetCodesUngrouped()
    {
        $codes = Permission::get_codes(false);
        $this->assertArrayHasKey('SITETREE_VIEW_ALL', $codes);
    }

    public function testDirectlyAppliedPermissions()
    {
        $member = $this->objFromFixture(Member::class, 'author');
        $this->assertTrue(Permission::checkMember($member, "SITETREE_VIEW_ALL"));
    }

    public function testCMSAccess()
    {
        $members = Member::get()->byIDs($this->allFixtureIDs(Member::class));
        foreach ($members as $member) {
            $this->assertTrue(Permission::checkMember($member, 'CMS_ACCESS'));
            $this->assertTrue(Permission::checkMember($member, ['CMS_ACCESS', 'CMS_ACCESS_Security']));
            $this->assertTrue(Permission::checkMember($member, ['CMS_ACCESS_Security', 'CMS_ACCESS']));
        }

        $member = new Member();
        $member->update(
            [
            'FirstName' => 'No CMS',
            'Surname' => 'Access',
            'Email' => '[email protected]',
            ]
        );
        $member->write();
        $this->assertFalse(Permission::checkMember($member, 'CMS_ACCESS'));
        $this->assertFalse(Permission::checkMember($member, ['CMS_ACCESS', 'CMS_ACCESS_Security']));
        $this->assertFalse(Permission::checkMember($member, ['CMS_ACCESS_Security', 'CMS_ACCESS']));
    }

    public function testLeftAndMainAccessAll()
    {
        //add user and group
        $member = $this->objFromFixture(Member::class, 'leftandmain');

        $this->assertTrue(Permission::checkMember($member, "CMS_ACCESS_MyAdmin"));
        $this->assertTrue(Permission::checkMember($member, "CMS_ACCESS_AssetAdmin"));
        $this->assertTrue(Permission::checkMember($member, "CMS_ACCESS_SecurityAdmin"));
    }

    public function testPermissionAreInheritedFromOneRole()
    {
        $member = $this->objFromFixture(Member::class, 'author');
        $this->assertTrue(Permission::checkMember($member, "CMS_ACCESS_MyAdmin"));
        $this->assertTrue(Permission::checkMember($member, "CMS_ACCESS_AssetAdmin"));
        $this->assertFalse(Permission::checkMember($member, "CMS_ACCESS_SecurityAdmin"));
    }

    public function testPermissionAreInheritedFromMultipleRoles()
    {
        $member = $this->objFromFixture(Member::class, 'access');
        $this->assertTrue(Permission::checkMember($member, "CMS_ACCESS_MyAdmin"));
        $this->assertTrue(Permission::checkMember($member, "CMS_ACCESS_AssetAdmin"));
        $this->assertTrue(Permission::checkMember($member, "CMS_ACCESS_SecurityAdmin"));
        $this->assertTrue(Permission::checkMember($member, "EDIT_PERMISSIONS"));
        $this->assertFalse(Permission::checkMember($member, "SITETREE_VIEW_ALL"));
    }

    public function testPermissionsForMember()
    {
        $member = $this->objFromFixture(Member::class, 'access');
        $permissions = Permission::permissions_for_member($member->ID);
        $this->assertEquals(4, count($permissions ?? []));
        $this->assertTrue(in_array('CMS_ACCESS_MyAdmin', $permissions ?? []));
        $this->assertTrue(in_array('CMS_ACCESS_AssetAdmin', $permissions ?? []));
        $this->assertTrue(in_array('CMS_ACCESS_SecurityAdmin', $permissions ?? []));
        $this->assertTrue(in_array('EDIT_PERMISSIONS', $permissions ?? []));

        $group = $this->objFromFixture("SilverStripe\\Security\\Group", "access");

        Permission::deny($group->ID, "CMS_ACCESS_MyAdmin");
        $permissions = Permission::permissions_for_member($member->ID);
        $this->assertEquals(3, count($permissions ?? []));
        $this->assertFalse(in_array('CMS_ACCESS_MyAdmin', $permissions ?? []));
    }

    public function testRolesAndPermissionsFromParentGroupsAreInherited()
    {
        $member = $this->objFromFixture(Member::class, 'globalauthor');

        // Check that permissions applied to the group are there
        $this->assertTrue(Permission::checkMember($member, "SITETREE_EDIT_ALL"));

        // Check that roles from parent groups are there
        $this->assertTrue(Permission::checkMember($member, "CMS_ACCESS_MyAdmin"));
        $this->assertTrue(Permission::checkMember($member, "CMS_ACCESS_AssetAdmin"));

        // Check that permissions from parent groups are there
        $this->assertTrue(Permission::checkMember($member, "SITETREE_VIEW_ALL"));

        // Check that a random permission that shouldn't be there isn't
        $this->assertFalse(Permission::checkMember($member, "CMS_ACCESS_SecurityAdmin"));
    }
    /**
     * Ensure the the get_*_by_permission functions are permission role aware
     */
    public function testGettingMembersByPermission()
    {
        $accessMember = $this->objFromFixture(Member::class, 'access');
        $accessAuthor = $this->objFromFixture(Member::class, 'author');

        $result = Permission::get_members_by_permission(['CMS_ACCESS_SecurityAdmin']);
        $resultIDs = $result ? $result->column() : [];

        $this->assertContains(
            $accessMember->ID,
            $resultIDs,
            'Member is found via a permission attached to a role'
        );
        $this->assertNotContains($accessAuthor->ID, $resultIDs);
    }


    public function testHiddenPermissions()
    {
        $permissionCheckboxSet = new PermissionCheckboxSetField('Permissions', 'Permissions', Permission::class, 'GroupID');
        $this->assertStringContainsString('CMS_ACCESS_LeftAndMain', $permissionCheckboxSet->Field());

        Config::modify()->merge(Permission::class, 'hidden_permissions', ['CMS_ACCESS_LeftAndMain']);

        $this->assertStringNotContainsString('CMS_ACCESS_LeftAndMain', $permissionCheckboxSet->Field());

        Config::inst()->remove(Permission::class, 'hidden_permissions');
        Config::inst()->/** @scrutinizer ignore-call */ remove(Permission::class, 'hidden_permissions');
        $this->assertStringContainsString('CMS_ACCESS_LeftAndMain', $permissionCheckboxSet->Field());
    }

    public function testEmptyMemberFails()
    {
        $member = new Member();
        $this->assertFalse($member->exists());

        $this->logInWithPermission('ADMIN');

        $this->assertFalse(Permission::checkMember($member, 'ADMIN'));
        $this->assertFalse(Permission::checkMember($member, 'CMS_ACCESS_LeftAndMain'));
    }

    public function testGrantPermission()
    {
        $group = $this->objFromFixture(Group::class, 'testpermissiongroup');
        $id = $group->ID;

        Permission::grant($id, 'CMS_ACCESS_CMSMain');
        Permission::grant($id, 'CMS_ACCESS_AssetAdmin');
        Permission::grant($id, 'CMS_ACCESS_ReportAdmin');

        $groupPermission = Permission::get()->filter(['GroupID' => $id]);

        $this->assertEquals(3, $groupPermission->count());
        $this->assertEquals(0, $groupPermission->first()->Arg);

        $this->assertEquals(1, $groupPermission->first()->Type);



        Permission::grant($id, 'CMS_ACCESS_CMSMain', 'all');
        Permission::grant($id, 'CMS_ACCESS_AssetAdmin', 'all');
        Permission::grant($id, 'CMS_ACCESS_ReportAdmin', 'all');

        $groupPermission = Permission::get()->filter(['GroupID' => $id]);

        $this->assertEquals(3, $groupPermission->count());
        $this->assertEquals(-1, $groupPermission->first()->Arg);
        $this->assertEquals(1, $groupPermission->first()->Type);

        Permission::grant($id, 'CMS_ACCESS_CMSMain', 'any');
        Permission::grant($id, 'CMS_ACCESS_AssetAdmin', 'any');
        Permission::grant($id, 'CMS_ACCESS_ReportAdmin', 'any');

        $groupPermission = Permission::get()->filter(['GroupID' => $id]);

        $this->assertEquals(3, $groupPermission->count());
        $this->assertEquals(-1, $groupPermission->first()->Arg);
        $this->assertEquals(1, $groupPermission->first()->Type);
    }

    public function testDenyPermission()
    {
        $group = $this->objFromFixture(Group::class, 'testpermissiongroup');
        $id = $group->ID;

        Permission::deny($id, 'CMS_ACCESS_CMSMain');
        Permission::deny($id, 'CMS_ACCESS_AssetAdmin');
        Permission::deny($id, 'CMS_ACCESS_ReportAdmin');

        $groupPermission = Permission::get()->filter(['GroupID' => $id]);

        $this->assertEquals(3, $groupPermission->count());
        $this->assertEquals(0, $groupPermission->first()->Arg);

        $this->assertEquals(-1, $groupPermission->first()->Type);


        Permission::deny($id, 'CMS_ACCESS_CMSMain', 'all');
        Permission::deny($id, 'CMS_ACCESS_AssetAdmin', 'all');
        Permission::deny($id, 'CMS_ACCESS_ReportAdmin', 'all');

        $groupPermission = Permission::get()->filter(['GroupID' => $id]);

        $this->assertEquals(3, $groupPermission->count());
        $this->assertEquals(-1, $groupPermission->first()->Arg);
        $this->assertEquals(-1, $groupPermission->first()->Type);

        Permission::deny($id, 'CMS_ACCESS_CMSMain', 'any');
        Permission::deny($id, 'CMS_ACCESS_AssetAdmin', 'any');
        Permission::deny($id, 'CMS_ACCESS_ReportAdmin', 'any');

        $groupPermission = Permission::get()->filter(['GroupID' => $id]);

        $this->assertEquals(3, $groupPermission->count());
        $this->assertEquals(-1, $groupPermission->first()->Arg);
        $this->assertEquals(-1, $groupPermission->first()->Type);
    }

    public function testDenyThenGrantPermission()
    {
        $member = $this->objFromFixture(Member::class, 'testcmseditormember');
        $group = $this->objFromFixture(Group::class, 'testcmseditorgroup');
        $id = $group->ID;

        $this->logInAs($member);

        Permission::grant($id, 'TEST_CMS_EDITOR');
        $groupPermission = Permission::get()->filter(['GroupID' => $id]);

        $this->assertEquals(1, $groupPermission->count());
        $this->assertEquals(1, $groupPermission->first()->Type);

        $this->assertTrue(Permission::check('TEST_CMS_EDITOR'));

        Permission::deny($id, 'TEST_CMS_EDITOR');
        $groupPermission = Permission::get()->filter(['GroupID' => $id]);

        $this->assertEquals(1, $groupPermission->count());
        $this->assertEquals(-1, $groupPermission->last()->Type);
        $this->assertFalse(Permission::check('TEST_CMS_EDITOR'));

        Permission::grant($id, 'TEST_CMS_EDITOR');
        $groupPermission = Permission::get()->filter(['GroupID' => $id]);

        $this->assertEquals(1, $groupPermission->count());
        $this->assertEquals(1, $groupPermission->first()->Type);
        $this->assertTrue(Permission::check('TEST_CMS_EDITOR'));

        Permission::grant($id, 'CMS_ACCESS_AssetAdmin');
        $groupPermission = Permission::get()->filter(['GroupID' => $id]);
        $this->assertEquals(2, $groupPermission->count());

        $groupPermissionAssetAdmin = Permission::get()->filter(
            [
                'GroupID' => $id,
                'Code' => 'CMS_ACCESS_AssetAdmin',
            ]
        );
        $this->assertEquals(1, $groupPermissionAssetAdmin->count());
        $this->assertEquals(1, $groupPermissionAssetAdmin->first()->Type);

        $this->assertTrue(Permission::check('CMS_ACCESS_AssetAdmin'));

        $this->logOut();
    }
}

silverstripe / silverstripe-framework

Pull Request — 4 (#10330)

testPermissionAreInheritedFromOneRole() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like
