silverstripe / silverstripe-framework

tests/filesystem/AssetStoreTest.php

Doc Comments +11 added lines

@@ -487,15 +487,26 @@
 		return parent::cleanFilename($filename);
 	}
 	
+	/**
+	 * @param string $filename
+	 * @param string $hash
+	 * @param string $variant
+	 */
 	public function getFileID($filename, $hash, $variant = null) {
 		return parent::getFileID($filename, $hash, $variant);
 	}
 
 
+	/**
+	 * @param string $fileID
+	 */
 	public function getOriginalFilename($fileID, &$variant = '') {
 		return parent::getOriginalFilename($fileID, $variant);
 	}
 
+	/**
+	 * @param null|string $variant
+	 */
 	public function getDefaultConflictResolution($variant) {
 		return parent::getDefaultConflictResolution($variant);
 	}

tests/filesystem/FileFinderTest.php

Doc Comments +5 added lines

@@ -98,6 +98,11 @@
 			'The finder respects the max depth setting.');
 	}
 
+	/**
+	 * @param SS_FileFinder $finder
+	 * @param string[] $expect
+	 * @param string $message
+	 */
 	public function assertFinderFinds($finder, $expect, $message = null) {
 		$found = $finder->find($this->base);
 

tests/forms/EmailFieldTest.php

Doc Comments +5 added lines

@@ -23,6 +23,11 @@
 		$this->internalCheck("domain.but.no.user", "Invalid, no user part", false);
 	}
 
+	/**
+	 * @param string $email
+	 * @param string $checkText
+	 * @param boolean $expectSuccess
+	 */
 	public function internalCheck($email, $checkText, $expectSuccess) {
 		$field = new EmailField("MyEmail");
 		$field->setValue($email);

tests/forms/gridfield/GridField_URLHandlerTest.php

Doc Comments +3 added lines

@@ -111,6 +111,9 @@
 
 	protected $id;
 
+	/**
+	 * @param string $link
+	 */
 	public function __construct($gridField, $id, $link) {
 		$this->gridField = $gridField;
 		$this->id = $id;

tests/forms/MemberDatetimeOptionsetFieldTest.php

Doc Comments +6 added lines

@@ -7,6 +7,9 @@ 
 
 	protected static $fixture_file = 'MemberDatetimeOptionsetFieldTest.yml';
 
+	/**
+	 * @param DataObject|null $member
+	 */
 	protected function createDateFormatFieldForMember($member) {
 		require_once 'Zend/Date.php';
 		$defaultDateFormat = Zend_Locale_Format::getDateFormat($member->Locale);
@@ -26,6 +29,9 @@ 
 		return $field;
 	}
 
+	/**
+	 * @param DataObject|null $member
+	 */
 	protected function createTimeFormatFieldForMember($member) {
 		require_once 'Zend/Date.php';
 		$defaultTimeFormat = Zend_Locale_Format::getTimeFormat($member->Locale);

tests/forms/NumericFieldTest.php

Doc Comments +3 added lines

@@ -21,6 +21,9 @@
 		return str_replace(' ', $nbsp, trim($input));
 	}
 
+	/**
+	 * @param string $locale
+	 */
 	protected function checkInputValidation($locale, $tests) {
 		i18n::set_locale($locale);
 		$field = new NumericField('Number');

tests/forms/uploadfield/AssetFieldTest.php

Doc Comments +4 added lines, -2 removed lines

@@ -298,7 +298,6 @@ 
 	 * Simulates a form post to the test controller with the specified file tuple (Filename, Hash, Variant)
 	 *
 	 * @param string $fileField Name of field to assign ids to
-	 * @param array $ids list of file IDs
 	 * @return boolean Array with key 'errors'
 	 */
 	protected function mockUploadFileSave($fileField, $filename, $hash, $variant = null) {
@@ -328,7 +327,7 @@ 
 	 * Simulates a file upload
 	 *
 	 * @param string $fileField Name of the field to mock upload for
-	 * @param array $tmpFileName Name of temporary file to upload
+	 * @param string $tmpFileName Name of temporary file to upload
 	 * @return SS_HTTPResponse form response
 	 */
 	protected function mockFileUpload($fileField, $tmpFileName) {
@@ -360,6 +359,9 @@ 
 		return $this->record;
 	}
 
+	/**
+	 * @param AssetFieldTest_Controller $controller
+	 */
 	function __construct($controller = null, $name = 'Form') {
 		if(empty($controller)) {
 			$controller = new AssetFieldTest_Controller();

tests/forms/uploadfield/UploadFieldTest.php

Doc Comments +7 added lines, -1 removed lines

@@ -936,7 +936,7 @@ 
 	 * Simulates a file upload
 	 *
 	 * @param string $fileField Name of the field to mock upload for
-	 * @param array $tmpFileName Name of temporary file to upload
+	 * @param string $tmpFileName Name of temporary file to upload
 	 * @return SS_HTTPResponse form response
 	 */
 	protected function mockFileUpload($fileField, $tmpFileName) {
@@ -948,6 +948,9 @@ 
 		);
 	}
 
+	/**
+	 * @param string $fileField
+	 */
 	protected function mockFileExists($fileField, $fileName) {
 		return $this->get(
 			"UploadFieldTest_Controller/Form/field/{$fileField}/fileexists?filename=".urlencode($fileName)
@@ -1075,6 +1078,9 @@ 
 		return $this->record;
 	}
 
+	/**
+	 * @param UploadFieldTest_Controller $controller
+	 */
 	function __construct($controller = null, $name = 'Form') {
 		if(empty($controller)) {
 			$controller = new UploadFieldTest_Controller();

tests/i18n/i18nTextCollectorTest.php

Doc Comments +7 added lines

@@ -827,6 +827,10 @@ 
  * Assist with testing of specific protected methods
  */
 class i18nTextCollectorTest_Collector extends i18nTextCollector implements TestOnly {
+
+	/**
+	 * @param string $directory
+	 */
 	public function getModules_Test($directory) {
 		return $this->getModules($directory);
 	}
@@ -835,6 +839,9 @@ 
 		return $this->resolveDuplicateConflicts($entitiesByModule);
 	}
 
+	/**
+	 * @param string $module
+	 */
 	public function getFileListForModule_Test($module) {
 		return parent::getFileListForModule($module);
 	}