Completed
Pull Request — master (#5771)
by Florian
11:17
created
tests/dev/DevAdminControllerTest.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -47,6 +47,9 @@  discard block
 block discarded – undo
47 47
 
48 48
 
49 49
 
50
+	/**
51
+	 * @param string $url
52
+	 */
50 53
 	protected function getCapture($url){
51 54
 		$this->logInWithPermission('ADMIN');
52 55
 
@@ -58,6 +61,9 @@  discard block
 block discarded – undo
58 61
 		return $r;
59 62
 	}
60 63
 
64
+	/**
65
+	 * @param string $url
66
+	 */
61 67
 	protected function getAndCheckForError($url){
62 68
 		$this->logInWithPermission('ADMIN');
63 69
 
Please login to merge, or discard this patch.
tests/forms/EmailFieldTest.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -23,6 +23,11 @@
 block discarded – undo
23 23
 		$this->internalCheck("domain.but.no.user", "Invalid, no user part", false);
24 24
 	}
25 25
 
26
+	/**
27
+	 * @param string $email
28
+	 * @param string $checkText
29
+	 * @param boolean $expectSuccess
30
+	 */
26 31
 	public function internalCheck($email, $checkText, $expectSuccess) {
27 32
 		$field = new EmailField("MyEmail");
28 33
 		$field->setValue($email);
Please login to merge, or discard this patch.
tests/forms/gridfield/GridField_URLHandlerTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -111,6 +111,9 @@
 block discarded – undo
111 111
 
112 112
 	protected $id;
113 113
 
114
+	/**
115
+	 * @param string $link
116
+	 */
114 117
 	public function __construct($gridField, $id, $link) {
115 118
 		$this->gridField = $gridField;
116 119
 		$this->id = $id;
Please login to merge, or discard this patch.
tests/forms/NumericFieldTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -21,6 +21,9 @@
 block discarded – undo
21 21
 		return str_replace(' ', $nbsp, trim($input));
22 22
 	}
23 23
 
24
+	/**
25
+	 * @param string $locale
26
+	 */
24 27
 	protected function checkInputValidation($locale, $tests) {
25 28
 		i18n::set_locale($locale);
26 29
 		$field = new NumericField('Number');
Please login to merge, or discard this patch.
tests/forms/uploadfield/AssetFieldTest.php 1 patch
Doc Comments   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -298,7 +298,6 @@  discard block
 block discarded – undo
298 298
 	 * Simulates a form post to the test controller with the specified file tuple (Filename, Hash, Variant)
299 299
 	 *
300 300
 	 * @param string $fileField Name of field to assign ids to
301
-	 * @param array $ids list of file IDs
302 301
 	 * @return boolean Array with key 'errors'
303 302
 	 */
304 303
 	protected function mockUploadFileSave($fileField, $filename, $hash, $variant = null) {
@@ -328,7 +327,7 @@  discard block
 block discarded – undo
328 327
 	 * Simulates a file upload
329 328
 	 *
330 329
 	 * @param string $fileField Name of the field to mock upload for
331
-	 * @param array $tmpFileName Name of temporary file to upload
330
+	 * @param string $tmpFileName Name of temporary file to upload
332 331
 	 * @return SS_HTTPResponse form response
333 332
 	 */
334 333
 	protected function mockFileUpload($fileField, $tmpFileName) {
@@ -360,6 +359,9 @@  discard block
 block discarded – undo
360 359
 		return $this->record;
361 360
 	}
362 361
 
362
+	/**
363
+	 * @param AssetFieldTest_Controller $controller
364
+	 */
363 365
 	function __construct($controller = null, $name = 'Form') {
364 366
 		if(empty($controller)) {
365 367
 			$controller = new AssetFieldTest_Controller();
Please login to merge, or discard this patch.
tests/forms/uploadfield/UploadFieldTest.php 1 patch
Doc Comments   +7 added lines, -1 removed lines patch added patch discarded remove patch
@@ -936,7 +936,7 @@  discard block
 block discarded – undo
936 936
 	 * Simulates a file upload
937 937
 	 *
938 938
 	 * @param string $fileField Name of the field to mock upload for
939
-	 * @param array $tmpFileName Name of temporary file to upload
939
+	 * @param string $tmpFileName Name of temporary file to upload
940 940
 	 * @return SS_HTTPResponse form response
941 941
 	 */
942 942
 	protected function mockFileUpload($fileField, $tmpFileName) {
@@ -948,6 +948,9 @@  discard block
 block discarded – undo
948 948
 		);
949 949
 	}
950 950
 
951
+	/**
952
+	 * @param string $fileField
953
+	 */
951 954
 	protected function mockFileExists($fileField, $fileName) {
952 955
 		return $this->get(
953 956
 			"UploadFieldTest_Controller/Form/field/{$fileField}/fileexists?filename=".urlencode($fileName)
@@ -1075,6 +1078,9 @@  discard block
 block discarded – undo
1075 1078
 		return $this->record;
1076 1079
 	}
1077 1080
 
1081
+	/**
1082
+	 * @param UploadFieldTest_Controller $controller
1083
+	 */
1078 1084
 	function __construct($controller = null, $name = 'Form') {
1079 1085
 		if(empty($controller)) {
1080 1086
 			$controller = new UploadFieldTest_Controller();
Please login to merge, or discard this patch.
tests/injector/InjectorTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -933,6 +933,9 @@
 block discarded – undo
933 933
 class SSObjectCreator extends InjectionCreator {
934 934
 	private $injector;
935 935
 
936
+	/**
937
+	 * @param Injector $injector
938
+	 */
936 939
 	public function __construct($injector) {
937 940
 		$this->injector = $injector;
938 941
 	}
Please login to merge, or discard this patch.
tests/model/ArrayListTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -802,6 +802,10 @@
 block discarded – undo
802 802
 	public $First;
803 803
 	public $Second;
804 804
 
805
+	/**
806
+	 * @param string $first
807
+	 * @param string $second
808
+	 */
805 809
 	public function __construct($first, $second) {
806 810
 		$this->First  = $first;
807 811
 		$this->Second = $second;
Please login to merge, or discard this patch.
tests/model/DataObjectTest.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -1111,6 +1111,10 @@
 block discarded – undo
1111 1111
 		);
1112 1112
 	}
1113 1113
 
1114
+	/**
1115
+	 * @param DataObjectTest_Team $object
1116
+	 * @param string $method
1117
+	 */
1114 1118
 	protected function makeAccessible($object, $method) {
1115 1119
 		$reflectionMethod = new ReflectionMethod($object, $method);
1116 1120
 		$reflectionMethod->setAccessible(true);
Please login to merge, or discard this patch.