silverstripe / silverstripe-framework

src/Forms/SelectionGroup_Item.php

Doc Comments +6 added lines

@@ -37,6 +37,9 @@ 
         return $this->title;
     }
 
+    /**
+     * @param string $title
+     */
     function setTitle($title)
     {
         $this->title = $title;
@@ -48,6 +51,9 @@ 
         return $this->value;
     }
 
+    /**
+     * @param string $Value
+     */
     function setValue($Value, $data = null)
     {
         $this->value = $Value;

src/i18n/i18n.php

Doc Comments -6 removed lines

@@ -141,12 +141,6 @@
      * @param string $entity Entity that identifies the string. It must be in the form
      * "Namespace.Entity" where Namespace will be usually the class name where this
      * string is used and Entity identifies the string inside the namespace.
-     * @param mixed $arg,... Additional arguments are parsed as such:
-     *  - Next string argument is a default. Pass in a `|` pipe-delimited value with `{count}`
-     *    to do pluralisation.
-     *  - Any other string argument after default is context for i18nTextCollector
-     *  - Any array argument in any order is an injection parameter list. Pass in a `count`
-     *    injection parameter to pluralise.
      * @return string
      */
     public static function _t($entity, $arg = null)

src/ORM/FieldType/DBDatetime.php

Doc Comments +1 added lines, -1 removed lines

@@ -85,7 +85,7 @@
      * Return a date and time formatted as per a CMS user's settings.
      *
      * @param Member $member
-     * @return boolean | string A time and date pair formatted as per user-defined settings.
+     * @return null|string | string A time and date pair formatted as per user-defined settings.
      */
     public function FormatFromSettings($member = null)
     {

src/ORM/FieldType/DBTime.php

Doc Comments +3 added lines

@@ -26,6 +26,9 @@
      */
     const ISO_TIME = 'HH:mm:ss';
 
+    /**
+     * @param string $value
+     */
     public function setValue($value, $record = null, $markChanged = true)
     {
         $value = $this->parseTime($value);

src/ORM/FieldType/DBDate.php

Doc Comments +2 added lines, -2 removed lines

@@ -245,7 +245,7 @@ 
      * Return a date formatted as per a CMS user's settings.
      *
      * @param Member $member
-     * @return boolean | string A date formatted as per user-defined settings.
+     * @return null|string | string A date formatted as per user-defined settings.
      */
     public function FormatFromSettings($member = null)
     {
@@ -551,7 +551,7 @@ 
      * Attempt to split date string into year, month, day, and timestamp components.
      *
      * @param string $value
-     * @return array
+     * @return string[]
      */
     protected function explodeDateString($value)
     {

tests/php/View/SSViewerCacheBlockTest.php

Doc Comments +3 added lines

@@ -31,6 +31,9 @@
         Injector::inst()->get(CacheInterface::class . '.cacheblock')->clear();
     }
 
+    /**
+     * @param string $template
+     */
     protected function _runtemplate($template, $data = null)
     {
         if ($data === null) {

src/Core/Cache/CacheFactory.php

Doc Comments -2 removed lines

@@ -12,8 +12,6 @@
      * Note: While the returned object is used as a singleton (by the originating Injector->get() call),
      * this cache object shouldn't be a singleton itself - it has varying constructor args for the same service name.
      *
-     * @param string $class
-     * @param array $args
      * @return CacheInterface
      */
     public function create($service, array $params = array());

admin/code/LeftAndMain.php

Doc Comments +2 added lines, -2 removed lines

@@ -1002,7 +1002,7 @@ 
      * {@link SSViewer::get_templates_by_class()}
      *
      * @param string $suffix
-     * @return array
+     * @return string
      */
     public function getTemplatesWithSuffix($suffix)
     {
@@ -2154,7 +2154,7 @@ 
     }
 
     /**
-     * @return String
+     * @return DBField
      */
     public function Locale()
     {

src/Control/Director.php

Doc Comments +2 added lines, -2 removed lines

@@ -925,7 +925,7 @@ 
     /**
      * Returns true if the given file exists. Filename should be relative to the site root.
      *
-     * @param $file
+     * @param string $file
      *
      * @return bool
      */
@@ -1153,7 +1153,7 @@ 
      * Can also be checked with {@link Director::isDev()}, {@link Director::isTest()}, and
      * {@link Director::isLive()}.
      *
-     * @return bool
+     * @return string
      */
     public static function get_environment_type()
     {