silverstripe / silverstripe-framework

admin/code/GroupImportForm.php

Doc Comments +4 added lines

@@ -24,6 +24,10 @@
      */
     protected $group;
 
+    /**
+     * @param SecurityAdmin $controller
+     * @param string $name
+     */
     public function __construct($controller, $name, $fields = null, $actions = null, $validator = null)
     {
         if (!$fields) {

admin/code/MemberImportForm.php

Doc Comments +5 added lines, -1 removed lines

@@ -25,6 +25,10 @@ 
      */
     protected $group;
 
+    /**
+     * @param SecurityAdmin $controller
+     * @param string $name
+     */
     public function __construct($controller, $name, $fields = null, $actions = null, $validator = null)
     {
         if (!$fields) {
@@ -127,7 +131,7 @@ 
     }
 
     /**
-     * @param $group Group
+     * @param Group $group Group
      */
     public function setGroup($group)
     {

admin/code/SecurityAdmin.php

Doc Comments +2 added lines, -2 removed lines

@@ -260,7 +260,7 @@ 
     /**
      * @see SecurityAdmin_MemberImportForm
      *
-     * @return Form
+     * @return null|MemberImportForm
      */
     public function MemberImportForm()
     {
@@ -297,7 +297,7 @@ 
      * @see SecurityAdmin_MemberImportForm
      *
      * @skipUpgrade
-     * @return Form
+     * @return null|GroupImportForm
      */
     public function GroupImportForm()
     {

tests/behat/features/bootstrap/SilverStripe/Framework/Test/Behaviour/CmsFormsContext.php

Doc Comments +1 added lines

@@ -38,6 +38,7 @@
 
     /**
      * Get Mink session from MinkContext
+     * @return \Behat\Mink\Session
      */
     public function getSession($name = null)
     {

tests/php/Core/ObjectTest/Extending.php

Doc Comments +17 added lines

@@ -12,11 +12,22 @@ 
         Extending_Extension::class,
     );
 
+    /**
+     * @param integer $first
+     * @param integer $second
+     * @param integer $third
+     */
     public function getResults(&$first, &$second, &$third)
     {
         // Before extending should be invoked second
         $this->beforeExtending(
             'updateResult',
+
+            /**
+             * @param integer $first
+             * @param integer $second
+             * @param integer $third
+             */
             function (&$first, &$second, &$third) {
                 if ($first === 1 && $second === 2 && $third === 3) {
                     $first = 11;
@@ -31,6 +42,12 @@ 
         // After extending should be invoked fourth
         $this->afterExtending(
             'updateResult',
+
+            /**
+             * @param integer $first
+             * @param integer $second
+             * @param integer $third
+             */
             function (&$first, &$second, &$third) {
                 if ($first === 21 && $second === 22 && $third = 23) {
                     $first = 31;

tests/php/Core/Startup/ErrorControlChainTest/ErrorControlChainTest_Chain.php

Doc Comments +5 added lines, -1 removed lines

@@ -31,7 +31,7 @@ 
     /**
      * Modify method visibility to public for testing
      *
-     * @param mixed $errors
+     * @param string $errors
      */
     public function setDisplayErrors($errors)
     {
@@ -40,6 +40,10 @@ 
     }
 
     // Change function visibility to be testable directly
+
+    /**
+     * @param string $memstring
+     */
     public function translateMemstring($memstring)
     {
         return parent::translateMemstring($memstring);

tests/php/Dev/CsvBulkLoaderTest.php

Doc Comments +3 added lines

@@ -271,6 +271,9 @@
     }
 
 
+    /**
+     * @param resource $file
+     */
     protected function getLineCount(&$file)
     {
         $i = 0;

tests/php/Forms/AssetFieldTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -385,7 +385,7 @@
      * Simulates a file upload
      *
      * @param  string $fileField   Name of the field to mock upload for
-     * @param  array  $tmpFileName Name of temporary file to upload
+     * @param  string  $tmpFileName Name of temporary file to upload
      * @return HTTPResponse form response
      */
     protected function mockFileUpload($fileField, $tmpFileName)

tests/php/Forms/AssetFieldTest/TestForm.php

Doc Comments +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
 
     /**
      * @skipUpgrade
-     * @param null   $controller
+     * @param TestController   $controller
      * @param string $name
      */
     public function __construct($controller = null, $name = 'Form')