| Conditions | 26 |
| Paths | 240 |
| Total Lines | 99 |
| Code Lines | 53 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 166 | public function generateExportFileData($gridField) |
||
| 167 | { |
||
| 168 | $csvColumns = $this->getExportColumnsForGridField($gridField); |
||
| 169 | |||
| 170 | $csvWriter = Writer::createFromFileObject(new \SplTempFileObject()); |
||
| 171 | $csvWriter->setDelimiter($this->getCsvSeparator()); |
||
| 172 | $csvWriter->setEnclosure($this->getCsvEnclosure()); |
||
| 173 | $csvWriter->setNewline("\r\n"); //use windows line endings for compatibility with some csv libraries |
||
| 174 | $csvWriter->setOutputBOM(Writer::BOM_UTF8); |
||
| 175 | |||
| 176 | if (!Config::inst()->get(get_class($this), 'xls_export_disabled')) { |
||
| 177 | $csvWriter->addFormatter(function (array $row) { |
||
| 178 | foreach ($row as &$item) { |
||
| 179 | // [SS-2017-007] Sanitise XLS executable column values with a leading tab |
||
| 180 | if (preg_match('/^[-@=+].*/', $item)) { |
||
| 181 | $item = "\t" . $item; |
||
| 182 | } |
||
| 183 | } |
||
| 184 | return $row; |
||
| 185 | }); |
||
| 186 | } |
||
| 187 | |||
| 188 | if ($this->csvHasHeader) { |
||
| 189 | $headers = []; |
||
| 190 | |||
| 191 | // determine the CSV headers. If a field is callable (e.g. anonymous function) then use the |
||
| 192 | // source name as the header instead |
||
| 193 | foreach ($csvColumns as $columnSource => $columnHeader) { |
||
| 194 | if (is_array($columnHeader) && array_key_exists('title', $columnHeader)) { |
||
| 195 | $headers[] = $columnHeader['title']; |
||
| 196 | } else { |
||
| 197 | $headers[] = (!is_string($columnHeader) && is_callable($columnHeader)) ? $columnSource : $columnHeader; |
||
| 198 | } |
||
| 199 | } |
||
| 200 | |||
| 201 | $csvWriter->insertOne($headers); |
||
| 202 | unset($headers); |
||
| 203 | } |
||
| 204 | |||
| 205 | //Remove GridFieldPaginator as we're going to export the entire list. |
||
| 206 | $gridField->getConfig()->removeComponentsByType(GridFieldPaginator::class); |
||
| 207 | |||
| 208 | $items = $gridField->getManipulatedList(); |
||
| 209 | |||
| 210 | // @todo should GridFieldComponents change behaviour based on whether others are available in the config? |
||
| 211 | foreach ($gridField->getConfig()->getComponents() as $component) { |
||
| 212 | if ($component instanceof GridFieldFilterHeader || $component instanceof GridFieldSortableHeader) { |
||
| 213 | $items = $component->getManipulatedData($gridField, $items); |
||
| 214 | } |
||
| 215 | } |
||
| 216 | |||
| 217 | /** @var GridFieldDataColumns|null $gridFieldColumnsComponent */ |
||
| 218 | $gridFieldColumnsComponent = $gridField->getConfig()->getComponentByType(GridFieldDataColumns::class); |
||
| 219 | $columnsHandled = ($gridFieldColumnsComponent) |
||
| 220 | ? $gridFieldColumnsComponent->getColumnsHandled($gridField) |
||
| 221 | : []; |
||
| 222 | |||
| 223 | /** @var DataObject $item */ |
||
| 224 | foreach ($items->limit(null) as $item) { |
||
| 225 | if (!$item->hasMethod('canView') || $item->canView()) { |
||
| 226 | $columnData = []; |
||
| 227 | |||
| 228 | foreach ($csvColumns as $columnSource => $columnHeader) { |
||
| 229 | if (!is_string($columnHeader) && is_callable($columnHeader)) { |
||
| 230 | if ($item->hasMethod($columnSource)) { |
||
| 231 | $relObj = $item->{$columnSource}(); |
||
| 232 | } else { |
||
| 233 | $relObj = $item->relObject($columnSource); |
||
| 234 | } |
||
| 235 | |||
| 236 | $value = $columnHeader($relObj); |
||
| 237 | } elseif ($gridFieldColumnsComponent && array_key_exists($columnSource, $columnsHandled)) { |
||
| 238 | $value = strip_tags( |
||
| 239 | $gridFieldColumnsComponent->getColumnContent($gridField, $item, $columnSource) |
||
| 240 | ); |
||
| 241 | } else { |
||
| 242 | $value = $gridField->getDataFieldValue($item, $columnSource); |
||
| 243 | |||
| 244 | if ($value === null) { |
||
| 245 | $value = $gridField->getDataFieldValue($item, $columnHeader); |
||
| 246 | } |
||
| 247 | } |
||
| 248 | |||
| 249 | $columnData[] = $value; |
||
| 250 | } |
||
| 251 | |||
| 252 | $csvWriter->insertOne($columnData); |
||
| 253 | } |
||
| 254 | |||
| 255 | if ($item->hasMethod('destroy')) { |
||
| 256 | $item->destroy(); |
||
| 257 | } |
||
| 258 | } |
||
| 259 | |||
| 260 | if (method_exists($csvWriter, 'getContent')) { |
||
| 261 | return $csvWriter->getContent(); |
||
| 262 | } |
||
| 263 | |||
| 264 | return (string)$csvWriter; |
||
| 265 | } |
||
| 343 |