Completed
Pull Request — master (#6829)
by Simon
09:38
created
src/Security/MemberAuthenticator/ChangePasswordHandler.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -169,7 +169,7 @@
 block discarded – undo
169 169
     /**
170 170
      * Return a link to this request handler.
171 171
      * The link returned is supplied in the constructor
172
-     * @param null $action
172
+     * @param string $action
173 173
      * @return string
174 174
      */
175 175
     public function link($action = null)
Please login to merge, or discard this patch.
src/Forms/Form.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -596,6 +596,7 @@  discard block
 block discarded – undo
596 596
      * Set actions that are exempt from validation
597 597
      *
598 598
      * @param array
599
+     * @param string[] $actions
599 600
      * @return $this
600 601
      */
601 602
     public function setValidationExemptActions($actions)
@@ -1045,7 +1046,7 @@  discard block
 block discarded – undo
1045 1046
      * If set to false then the form method is only used to construct the default
1046 1047
      * form.
1047 1048
      *
1048
-     * @param $bool boolean
1049
+     * @param boolean $bool boolean
1049 1050
      * @return $this
1050 1051
      */
1051 1052
     public function setStrictFormMethodCheck($bool)
Please login to merge, or discard this patch.
src/Security/MemberAuthenticator/MemberAuthenticator.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -53,6 +53,7 @@
 block discarded – undo
53 53
      * @param array $data Form submitted data
54 54
      * @param ValidationResult $result
55 55
      * @param Member|null This third parameter is used in the CMSAuthenticator(s)
56
+     * @param Member $member
56 57
      * @return Member Found member, regardless of successful login
57 58
      */
58 59
     protected function authenticateMember($data, &$result = null, $member = null)
Please login to merge, or discard this patch.
src/Security/Security.php 1 patch
Doc Comments   +5 added lines, -4 removed lines patch added patch discarded remove patch
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
222 222
     protected static $currentUser;
223 223
 
224 224
     /**
225
-     * @return array
225
+     * @return Authenticator[]
226 226
      */
227 227
     public function getAuthenticators()
228 228
     {
@@ -287,7 +287,7 @@  discard block
 block discarded – undo
287 287
      * Get all registered authenticators
288 288
      *
289 289
      * @param int $service The type of service that is requested
290
-     * @return array Return an array of Authenticator objects
290
+     * @return Authenticator[] Return an array of Authenticator objects
291 291
      */
292 292
     public function getApplicableAuthenticators($service = Authenticator::LOGIN)
293 293
     {
@@ -621,7 +621,7 @@  discard block
 block discarded – undo
621 621
      * Combine the given forms into a formset with a tabbed interface
622 622
      *
623 623
      * @param array|Form[] $forms
624
-     * @return string
624
+     * @return DBHTMLText
625 625
      */
626 626
     protected function generateLoginFormSet($forms)
627 627
     {
@@ -1200,6 +1200,7 @@  discard block
 block discarded – undo
1200 1200
 
1201 1201
     /**
1202 1202
      * For the database_is_ready call to return a certain value - used for testing
1203
+     * @param boolean $isReady
1203 1204
      */
1204 1205
     public static function force_database_is_ready($isReady)
1205 1206
     {
@@ -1220,7 +1221,7 @@  discard block
 block discarded – undo
1220 1221
     /**
1221 1222
      * Set to true to ignore access to disallowed actions, rather than returning permission failure
1222 1223
      * Note that this is just a flag that other code needs to check with Security::ignore_disallowed_actions()
1223
-     * @param $flag True or false
1224
+     * @param boolean $flag True or false
1224 1225
      */
1225 1226
     public static function set_ignore_disallowed_actions($flag)
1226 1227
     {
Please login to merge, or discard this patch.