silverstripe / silverstripe-framework

tests/php/Security/SecurityTest.php

Doc Comments +4 added lines

@@ -577,6 +577,8 @@ 
 	/**
 	 * Execute a log-in form using Director::test().
 	 * Helper method for the tests above
+	 * @param string $email
+	 * @param string $password
 	 */
 	public function doTestLoginForm($email, $password, $backURL = 'test/link') {
 		$this->get(Config::inst()->get('Security', 'logout_url'));
@@ -597,6 +599,8 @@ 
 
 	/**
 	 * Helper method to execute a change password form
+	 * @param string $oldPassword
+	 * @param string $newPassword
 	 */
 	public function doTestChangepasswordForm($oldPassword, $newPassword) {
 		return $this->submitForm(

tests/php/View/SSViewerCacheBlockTest/VersionedModel.php

Doc Comments +3 added lines

@@ -16,6 +16,9 @@
 		Versioned::class
 	);
 
+	/**
+	 * @param string $entropy
+	 */
 	public function setEntropy($entropy)
 	{
 		$this->entropy = $entropy;

tests/php/View/SSViewerTest.php

Doc Comments +13 added lines

@@ -156,6 +156,10 @@ 
 		));
 	}
 
+	/**
+	 * @param \SilverStripe\ORM\FieldType\DBHTMLText $result
+	 * @param string[] $expected
+	 */
 	private function assertExpectedStrings($result, $expected) {
 		foreach ($expected as $expectedStr) {
 			$this->assertTrue(
@@ -820,6 +824,10 @@ 
 		$this->assertEquals('A A1 A1 i A1 ii A2 A3', $rationalisedResult);
 	}
 
+	/**
+	 * @param string $a
+	 * @param string $b
+	 */
 	public function assertEqualIgnoringWhitespace($a, $b, $message = '') {
 		$this->assertEquals(preg_replace('/\s+/', '', $a), preg_replace('/\s+/', '', $b), $message);
 	}
@@ -1434,6 +1442,11 @@ 
 			$this->_renderWithSourceFileComments('SSViewerTestComments/'.$template['name'], $template['expected']);
 		}
 	}
+
+	/**
+	 * @param string $name
+	 * @param string $expected
+	 */
 	private function _renderWithSourceFileComments($name, $expected) {
 		$viewer = new SSViewer(array($name));
 		$data = new ArrayData(array());

src/Assets/File.php

Doc Comments +5 added lines, -5 removed lines

@@ -423,7 +423,7 @@ 
      * Check if this file can be modified
      *
      * @param Member $member
-     * @return boolean
+     * @return boolean|string
      */
     public function canEdit($member = null)
     {
@@ -444,7 +444,7 @@ 
      *
      * @param Member $member
      * @param array $context
-     * @return boolean
+     * @return boolean|string
      */
     public function canCreate($member = null, $context = array())
     {
@@ -464,7 +464,7 @@ 
      * Check if this file can be deleted
      *
      * @param Member $member
-     * @return boolean
+     * @return boolean|string
      */
     public function canDelete($member = null)
     {
@@ -697,7 +697,7 @@ 
      *
      * @param string $condition The PHP condition to be evaluated.  The page will be called $item
      * @param array $collator An array, passed by reference, to collect all of the matching descendants.
-     * @return true|null
+     * @return boolean|null
      */
     public function collateDescendants($condition, &$collator)
     {
@@ -1089,6 +1089,7 @@ 
      *
      * @param String File extension, without dot prefix. Use an asterisk ('*')
      * to specify a generic fallback if no mapping is found for an extension.
+     * @param string $ext
      * @return String Classname for a subclass of {@link File}
      */
     public static function get_class_for_file_extension($ext)
@@ -1248,7 +1249,6 @@ 
      * Note that the result will not have a leading slash, and should not be used
      * with local file paths.
      *
-     * @param string $part,... Parts
      * @return string
      */
     public static function join_paths($part = null)

src/Assets/Flysystem/AssetAdapter.php

Doc Comments +3 added lines

@@ -41,6 +41,9 @@
         ]
     );
 
+    /**
+     * @param string $root
+     */
     public function __construct($root = null, $writeFlags = LOCK_EX, $linkHandling = self::DISALLOW_LINKS)
     {
         // Get root path

src/Assets/Folder.php

Doc Comments +1 added lines, -1 removed lines

@@ -62,7 +62,7 @@
      * Find the given folder or create it as a database record
      *
      * @param string $folderPath Directory path relative to assets root
-     * @return Folder|null
+     * @return null|\SilverStripe\ORM\DataObject
      */
     public static function find_or_make($folderPath)
     {

src/Assets/GDBackend.php

Doc Comments +3 added lines, -4 removed lines

@@ -198,7 +198,7 @@ 
      * Check if this image has previously crashed GD when attempting to open it - if it's opened
      * successfully, the manipulation's cache key is removed.
      *
-     * @param string $arg,... Any number of args that identify this image
+     * @param string $arg
      * @return bool True if failed
      */
     public function failedResample($arg = null)
@@ -210,7 +210,7 @@ 
     /**
      * Mark a file as failed
      *
-     * @param string $arg,... Any number of args that identify this image
+     * @param string $arg
      */
     protected function markFailed($arg = null)
     {
@@ -221,7 +221,6 @@ 
     /**
      * Mark a file as succeeded
      *
-     * @param string $arg,... Any number of args that identify this image
      */
     protected function markSucceeded($arg = null)
     {
@@ -378,7 +377,7 @@ 
      * using built-in function. Used when imagerotate function is not available(i.e. Ubuntu)
      *
      * @param float $angle Angle in degrees
-     * @return static
+     * @return null|resource
      */
     public function rotatePixelByPixel($angle)
     {

src/Assets/ImageManipulation.php

Doc Comments -1 removed lines

@@ -804,7 +804,6 @@
      * Name a variant based on a format with arbitrary parameters
      *
      * @param string $format The format name.
-     * @param mixed $arg,... Additional arguments
      * @return string
      * @throws InvalidArgumentException
      */

src/Assets/Upload.php

Doc Comments +2 added lines, -2 removed lines

@@ -128,7 +128,7 @@ 
      * Set a different instance than {@link Upload_Validator}
      * for this upload session.
      *
-     * @param object $validator
+     * @param Upload_Validator $validator
      */
     public function setValidator($validator)
     {
@@ -393,7 +393,7 @@ 
     /**
      * Determines wether previous operations caused an error.
      *
-     * @return boolean
+     * @return integer
      */
     public function isError()
     {