silverstripe / silverstripe-framework

src/ORM/FieldType/DBDatetime.php

Doc Comments +1 added lines, -1 removed lines

@@ -85,7 +85,7 @@
      * Return a date and time formatted as per a CMS user's settings.
      *
      * @param Member $member
-     * @return boolean | string A time and date pair formatted as per user-defined settings.
+     * @return null|string | string A time and date pair formatted as per user-defined settings.
      */
     public function FormatFromSettings($member = null)
     {

src/ORM/FieldType/DBTime.php

Doc Comments +3 added lines

@@ -26,6 +26,9 @@
      */
     const ISO_TIME = 'HH:mm:ss';
 
+    /**
+     * @param string $value
+     */
     public function setValue($value, $record = null, $markChanged = true)
     {
         $value = $this->parseTime($value);

src/ORM/FieldType/DBDate.php

Doc Comments +2 added lines, -2 removed lines

@@ -245,7 +245,7 @@ 
      * Return a date formatted as per a CMS user's settings.
      *
      * @param Member $member
-     * @return boolean | string A date formatted as per user-defined settings.
+     * @return null|string | string A date formatted as per user-defined settings.
      */
     public function FormatFromSettings($member = null)
     {
@@ -551,7 +551,7 @@ 
      * Attempt to split date string into year, month, day, and timestamp components.
      *
      * @param string $value
-     * @return array
+     * @return string[]
      */
     protected function explodeDateString($value)
     {

src/Core/Cache/CacheFactory.php

Doc Comments -2 removed lines

@@ -12,8 +12,6 @@
      * Note: While the returned object is used as a singleton (by the originating Injector->get() call),
      * this cache object shouldn't be a singleton itself - it has varying constructor args for the same service name.
      *
-     * @param string $class
-     * @param array $args
      * @return CacheInterface
      */
     public function create($service, array $params = array());

admin/code/LeftAndMain.php

Doc Comments +2 added lines, -2 removed lines

@@ -1002,7 +1002,7 @@ 
      * {@link SSViewer::get_templates_by_class()}
      *
      * @param string $suffix
-     * @return array
+     * @return string
      */
     public function getTemplatesWithSuffix($suffix)
     {
@@ -2154,7 +2154,7 @@ 
     }
 
     /**
-     * @return String
+     * @return DBField
      */
     public function Locale()
     {

src/Control/Director.php

Doc Comments +2 added lines, -2 removed lines

@@ -925,7 +925,7 @@ 
     /**
      * Returns true if the given file exists. Filename should be relative to the site root.
      *
-     * @param $file
+     * @param string $file
      *
      * @return bool
      */
@@ -1153,7 +1153,7 @@ 
      * Can also be checked with {@link Director::isDev()}, {@link Director::isTest()}, and
      * {@link Director::isLive()}.
      *
-     * @return bool
+     * @return string
      */
     public static function get_environment_type()
     {

src/Core/Manifest/Module.php

Doc Comments +4 added lines

@@ -28,6 +28,10 @@
      */
     protected $composerData = null;
 
+    /**
+     * @param string $path
+     * @param string $base
+     */
     public function __construct($path, $base)
     {
         $this->path = rtrim($path, '/\\');

src/Dev/FunctionalTest.php

Doc Comments +2 added lines, -2 removed lines

@@ -226,7 +226,7 @@ 
      * Find an attribute in a SimpleXMLElement object by name.
      * @param SimpleXMLElement $object
      * @param string $attribute Name of attribute to find
-     * @return SimpleXMLElement object of the attribute
+     * @return boolean object of the attribute
      */
     public function findAttribute($object, $attribute)
     {
@@ -260,7 +260,7 @@ 
      * Note:   characters are stripped from the content; make sure that your assertions take this into account.
      *
      * @param string $selector A basic CSS selector, e.g. 'li.jobs h3'
-     * @param array|string $expectedMatches The content of at least one of the matched tags
+     * @param string[] $expectedMatches The content of at least one of the matched tags
      * @param string $message
      * @throws PHPUnit_Framework_AssertionFailedError
      */

src/Dev/SapphireTest.php

Doc Comments +7 added lines, -4 removed lines

@@ -184,6 +184,9 @@ 
         return self::$is_running_test;
     }
 
+    /**
+     * @param boolean $bool
+     */
     public static function set_is_running_test($bool)
     {
         self::$is_running_test = $bool;
@@ -658,10 +661,10 @@ 
     /**
      * Assert that the matching email was sent since the last call to clearEmails()
      * All of the parameters can either be a string, or, if they start with "/", a PREG-compatible regular expression.
-     * @param $to
+     * @param string $to
      * @param $from
-     * @param $subject
-     * @param $content
+     * @param string $subject
+     * @param string $content
      * @return array Contains the keys: 'type', 'to', 'from', 'subject', 'content', 'plainContent', 'attachedFiles',
      *               'customHeaders', 'htmlContent', inlineImages'
      */
@@ -894,7 +897,7 @@ 
      * @param string $expectedSQL
      * @param string $actualSQL
      * @param string $message
-     * @param float|int $delta
+     * @param integer $delta
      * @param integer $maxDepth
      * @param boolean $canonicalize
      * @param boolean $ignoreCase