silverstripe / silverstripe-framework

tests/php/Core/ObjectTest/Extending.php

Doc Comments +17 added lines

@@ -12,11 +12,22 @@ 
         Extending_Extension::class,
     );
 
+    /**
+     * @param integer $first
+     * @param integer $second
+     * @param integer $third
+     */
     public function getResults(&$first, &$second, &$third)
     {
         // Before extending should be invoked second
         $this->beforeExtending(
             'updateResult',
+
+            /**
+             * @param integer $first
+             * @param integer $second
+             * @param integer $third
+             */
             function (&$first, &$second, &$third) {
                 if ($first === 1 && $second === 2 && $third === 3) {
                     $first = 11;
@@ -31,6 +42,12 @@ 
         // After extending should be invoked fourth
         $this->afterExtending(
             'updateResult',
+
+            /**
+             * @param integer $first
+             * @param integer $second
+             * @param integer $third
+             */
             function (&$first, &$second, &$third) {
                 if ($first === 21 && $second === 22 && $third = 23) {
                     $first = 31;

tests/php/Core/Startup/ErrorControlChainTest/ErrorControlChainTest_Chain.php

Doc Comments +5 added lines, -1 removed lines

@@ -31,7 +31,7 @@ 
     /**
      * Modify method visibility to public for testing
      *
-     * @param mixed $errors
+     * @param string $errors
      */
     public function setDisplayErrors($errors)
     {
@@ -40,6 +40,10 @@ 
     }
 
     // Change function visibility to be testable directly
+
+    /**
+     * @param string $memstring
+     */
     public function translateMemstring($memstring)
     {
         return parent::translateMemstring($memstring);

tests/php/Dev/CsvBulkLoaderTest.php

Doc Comments +3 added lines

@@ -271,6 +271,9 @@
     }
 
 
+    /**
+     * @param resource $file
+     */
     protected function getLineCount(&$file)
     {
         $i = 0;

tests/php/Forms/DropdownFieldTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -399,7 +399,7 @@
      * string of HTML.
      *
      * @param  string $html HTML to scan for elements
-     * @return SimpleXMLElement
+     * @return \SimpleXMLElement
      */
     public function findOptionElements($html)
     {

tests/php/Forms/GridField/GridField_URLHandlerTest/TestComponent_ItemRequest.php

Doc Comments +3 added lines

@@ -20,6 +20,9 @@
 
     protected $id;
 
+    /**
+     * @param string $link
+     */
     public function __construct($gridField, $id, $link)
     {
         $this->gridField = $gridField;

tests/php/ORM/ChangeSetTest/Permissions.php

Doc Comments +3 added lines

@@ -39,6 +39,9 @@
         return $this->can(__FUNCTION__, $member, $context);
     }
 
+    /**
+     * @param string $perm
+     */
     public function can($perm, $member = null, $context = array())
     {
         $perms = [

tests/php/ORM/HierarchyTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -670,7 +670,7 @@
      * Get the HTML class attribute from a node in the sitetree
      *
      * @param  $html
-     * @param  $node
+     * @param  DataObject|null $node
      * @return string
      */
     protected function getNodeClassFromTree($html, $node)

src/Control/Email/Email.php

Doc Comments +14 added lines, -14 removed lines

@@ -135,12 +135,12 @@ 
 
     /**
      * Email constructor.
-     * @param string|array|null $from
-     * @param string|array|null $to
+     * @param string $from
+     * @param string $to
      * @param string|null $subject
      * @param string|null $body
-     * @param string|array|null $cc
-     * @param string|array|null $bcc
+     * @param string $cc
+     * @param string $bcc
      * @param string|null $returnPath
      */
     public function __construct(
@@ -226,7 +226,7 @@ 
     }
 
     /**
-     * @param string|array $address
+     * @param string $address
      * @param string|null $name
      * @return $this
      */
@@ -238,7 +238,7 @@ 
     }
 
     /**
-     * @return array
+     * @return string
      */
     public function getSender()
     {
@@ -303,7 +303,7 @@ 
     }
 
     /**
-     * @param string|array $address
+     * @param string $address
      * @param string|null $name
      * @return $this
      */
@@ -335,7 +335,7 @@ 
     }
 
     /**
-     * @param string|array $address
+     * @param string $address
      * @param string|null $name
      * @return $this
      */
@@ -367,7 +367,7 @@ 
     }
 
     /**
-     * @param string|array $address
+     * @param string $address
      * @param string|null $name
      * @return $this
      */
@@ -384,7 +384,7 @@ 
     }
 
     /**
-     * @param string|array $address
+     * @param string $address
      * @param string|null $name
      * @return $this
      */
@@ -396,7 +396,7 @@ 
     }
 
     /**
-     * @param string|array $address
+     * @param string $address
      * @param string|null $name
      * @return $this
      */
@@ -502,7 +502,7 @@ 
     }
 
     /**
-     * @param string|array $name The data name to add or array to names => value
+     * @param string $name The data name to add or array to names => value
      * @param string|null $value The value of the data to add
      * @return $this
      */
@@ -672,7 +672,7 @@ 
     }
 
     /**
-     * @return array|bool
+     * @return boolean
      */
     public function sendPlain()
     {
@@ -728,7 +728,7 @@ 
     }
 
     /**
-     * @return Swift_MimePart|false
+     * @return \Swift_Mime_MimeEntity
      */
     public function findPlainPart()
     {

src/Security/Member.php

Doc Comments +5 added lines, -5 removed lines

@@ -889,9 +889,9 @@ 
      * });
      * </code>
      *
-     * @param Member|null|int $member Member or member ID to log in as.
+     * @param null|Member $member Member or member ID to log in as.
      * Set to null or 0 to act as a logged out user.
-     * @param $callback
+     * @param \Closure $callback
      */
     public static function actAs($member, $callback)
     {
@@ -1661,7 +1661,7 @@ 
      * This is likely to be customized for social sites etc. with a looser permission model.
      *
      * @param Member $member
-     * @return bool
+     * @return boolean|string
      */
     public function canView($member = null)
     {
@@ -1692,7 +1692,7 @@ 
      * Otherwise they'll need ADMIN or CMS_ACCESS_SecurityAdmin permissions
      *
      * @param Member $member
-     * @return bool
+     * @return boolean|string
      */
     public function canEdit($member = null)
     {
@@ -1727,7 +1727,7 @@ 
      * Otherwise they'll need ADMIN or CMS_ACCESS_SecurityAdmin permissions
      *
      * @param Member $member
-     * @return bool
+     * @return boolean|string
      */
     public function canDelete($member = null)
     {