silverstripe / silverstripe-framework

tests/php/Security/SecurityTest.php

Doc Comments +4 added lines

@@ -676,6 +676,8 @@ 
     /**
      * Execute a log-in form using Director::test().
      * Helper method for the tests above
+     * @param string $email
+     * @param string $password
      */
     public function doTestLoginForm($email, $password, $backURL = 'test/link')
     {
@@ -697,6 +699,8 @@ 
 
     /**
      * Helper method to execute a change password form
+     * @param string $oldPassword
+     * @param string $newPassword
      */
     public function doTestChangepasswordForm($oldPassword, $newPassword)
     {

tests/php/View/SSViewerCacheBlockTest/VersionedModel.php

Doc Comments +3 added lines

@@ -16,6 +16,9 @@
         Versioned::class
     );
 
+    /**
+     * @param string $entropy
+     */
     public function setEntropy($entropy)
     {
         $this->entropy = $entropy;

src/Forms/GridField/GridFieldAddExistingAutocompleter.php

Doc Comments +3 added lines, -3 removed lines

@@ -155,7 +155,7 @@ 
     /**
      *
      * @param GridField $gridField
-     * @return array
+     * @return string[]
      */
     public function getActions($gridField)
     {
@@ -219,7 +219,7 @@ 
      *
      * @param GridField $gridField
      * @param HTTPRequest $request
-     * @return string
+     * @return HTTPResponse
      */
     public function doSearch($gridField, $request)
     {
@@ -299,7 +299,7 @@ 
     }
 
     /**
-     * @param array $fields
+     * @param string[] $fields
      * @return $this
      */
     public function setSearchFields($fields)

src/ORM/ListDecorator.php

Doc Comments +1 added lines

@@ -41,6 +41,7 @@
      * Useful for keeping a decorator/paginated list configuration intact while modifying
      * the underlying list.
      *
+     * @param SS_List $list
      * @return SS_List
      */
     public function setList($list)

src/View/SSViewer_DataPresenter.php

Doc Comments +7 added lines

@@ -33,6 +33,10 @@ 
      */
     protected $underlay;
 
+    /**
+     * @param ViewableData $item
+     * @param ViewableData $inheritedScope
+     */
     public function __construct($item, $overlay = null, $underlay = null, $inheritedScope = null)
     {
         parent::__construct($item, $inheritedScope);
@@ -65,6 +69,9 @@ 
         $this->underlay = $underlay ? $underlay : array();
     }
 
+    /**
+     * @param string $variableMethod
+     */
     protected function createCallableArray(&$extraArray, $interfaceToQuery, $variableMethod, $createObject = false)
     {
         $implementers = ClassInfo::implementorsOf($interfaceToQuery);

thirdparty/php-peg/Parser.php

Doc Comments +28 added lines

@@ -9,6 +9,10 @@ 
  *  the bracket if a failed match + restore has moved the current position backwards - so we have to check that too.
  */
 class ParserRegexp {
+
+	/**
+	 * @param Parser $parser
+	 */
 	function __construct( $parser, $rx ) {
 		$this->parser = $parser ;
 		$this->rx = $rx . 'Sx' ;
@@ -83,6 +87,9 @@ 
 		return FALSE ;
 	}
 
+ 	/**
+ 	 * @param string $token
+ 	 */
  	function literal( $token ) {
  		/* Debugging: * / print( "Looking for token '$token' @ '" . substr( $this->string, $this->pos ) . "'\n" ) ; /* */
  		$toklen = strlen( $token ) ;
@@ -94,11 +101,17 @@ 
 		return FALSE ;
 	}
 
+	/**
+	 * @param string $rx
+	 */
 	function rx( $rx ) {
 		if ( !isset( $this->regexps[$rx] ) ) $this->regexps[$rx] = new ParserRegexp( $this, $rx ) ;
 		return $this->regexps[$rx]->match() ;
 	}
 
+	/**
+	 * @param string $value
+	 */
 	function expression( $result, $stack, $value ) {
 		$stack[] = $result; $rv = false;
 		
@@ -120,14 +133,26 @@ 
 		return is_array($rv) ? $rv['text'] : ($rv ? $rv : '');
 	}
 	
+	/**
+	 * @param string $key
+	 * @param integer $pos
+	 */
 	function packhas( $key, $pos ) {
 		return false ;
 	}
 
+	/**
+	 * @param string $key
+	 * @param integer $pos
+	 */
 	function packread( $key, $pos ) {
 		throw new \Exception('PackRead after PackHas=>false in Parser.php');
 	}
 
+	/**
+	 * @param string $key
+	 * @param integer $pos
+	 */
 	function packwrite( $key, $pos, $res ) {
 		return $res ;
 	}
@@ -164,6 +189,9 @@ 
 		return $result ;
 	}
 
+	/**
+	 * @param string $storetag
+	 */
 	function store ( &$result, $subres, $storetag = NULL ) {
 		$result['text'] .= $subres['text'] ;
 

src/Core/Core.php

Doc Comments +4 added lines, -7 removed lines

@@ -136,6 +136,9 @@ 
     return Injector::inst()->get($className);
 }
 
+/**
+ * @return string
+ */
 function project()
 {
     global $project;
@@ -152,12 +155,6 @@ 
      * @param string $entity Entity that identifies the string. It must be in the form
      * "Namespace.Entity" where Namespace will be usually the class name where this
      * string is used and Entity identifies the string inside the namespace.
-     * @param mixed $arg,... Additional arguments are parsed as such:
-     *  - Next string argument is a default. Pass in a `|` pipe-delimeted value with `{count}`
-     *    to do pluralisation.
-     *  - Any other string argument after default is context for i18nTextCollector
-     *  - Any array argument in any order is an injection parameter list. Pass in a `count`
-     *    injection parameter to pluralise.
      * @return string
      */
 function _t($entity, $arg = null)
@@ -171,7 +168,7 @@ 
  * Only increases up to the maximum defined in {@link set_increase_memory_limit_max()},
  * and defaults to the 'memory_limit' setting in the PHP configuration.
  *
- * @param string|int $memoryLimit A memory limit string, such as "64M".  If omitted, unlimited memory will be set.
+ * @param integer $memoryLimit A memory limit string, such as "64M".  If omitted, unlimited memory will be set.
  * @return Boolean TRUE indicates a successful change, FALSE a denied change.
  */
 function increase_memory_limit_to($memoryLimit = -1)

src/Forms/FieldList.php

Doc Comments +6 added lines, -2 removed lines

@@ -89,6 +89,9 @@ 
         $this->sequentialSaveableSet = null;
     }
 
+    /**
+     * @param FormField[] $list
+     */
     protected function collateDataFields(&$list, $saveableOnly = false)
     {
         if (!isset($list)) {
@@ -198,7 +201,7 @@ 
      * Removes a number of fields from a Tab/TabSet within this FieldList.
      *
      * @param string $tabName The name of the Tab or TabSet field
-     * @param array $fields A list of fields, e.g. array('Name', 'Email')
+     * @param string[] $fields A list of fields, e.g. array('Name', 'Email')
      */
     public function removeFieldsFromTab($tabName, $fields)
     {
@@ -625,7 +628,7 @@ 
     }
 
     /**
-     * @param $field
+     * @param CompositeField $field
      * @return $this
      */
     public function setContainerField($field)
@@ -707,6 +710,7 @@ 
      * the children collection. Doesn't work recursively.
      *
      * @param string|FormField
+     * @param string $field
      * @return int Position in children collection (first position starts with 0).
      * Returns FALSE if the field can't be found.
      */

src/Forms/GridField/GridFieldPrintButton.php

Doc Comments +1 added lines, -1 removed lines

@@ -77,7 +77,7 @@
      *
      * @param GridField
      *
-     * @return array
+     * @return string[]
      */
     public function getActions($gridField)
     {