Completed
Push — master ( af5a53...6e68f3 )
by Sam
10:43
created
Security/Security.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -507,7 +507,7 @@  discard block
 block discarded – undo
507 507
 	 * Combine the given forms into a formset with a tabbed interface
508 508
 	 *
509 509
 	 * @param array $forms List of LoginForm instances
510
-	 * @return string
510
+	 * @return \SilverStripe\ORM\FieldType\DBHTMLText
511 511
 	 */
512 512
 	protected function generateLoginFormSet($forms) {
513 513
 		$viewData = new ArrayData(array(
@@ -795,7 +795,7 @@  discard block
 block discarded – undo
795 795
 	 * For use in any subclass.
796 796
 	 *
797 797
 	 * @param string $name
798
-	 * @return array Returns the template(s) for rendering
798
+	 * @return string[] Returns the template(s) for rendering
799 799
 	 */
800 800
 	public function getIncludeTemplate($name) {
801 801
 		return array('Security_' . $name);
@@ -883,7 +883,7 @@  discard block
 block discarded – undo
883 883
 	 *
884 884
 	 * @param string $username The user name
885 885
 	 * @param string $password The password (in cleartext)
886
-	 * @return bool
886
+	 * @return false|null
887 887
 	 */
888 888
 	public static function setDefaultAdmin($username, $password) {
889 889
 		// don't overwrite if already set
@@ -970,7 +970,7 @@  discard block
 block discarded – undo
970 970
 	 * @deprecated 4.0 Use the "Security.password_encryption_algorithm" config setting instead
971 971
 	 * @param string $algorithm One of the available password encryption
972 972
 	 *  algorithms determined by {@link Security::get_encryption_algorithms()}
973
-	 * @return bool Returns TRUE if the passed algorithm was valid, otherwise FALSE.
973
+	 * @return boolean|null Returns TRUE if the passed algorithm was valid, otherwise FALSE.
974 974
 	 */
975 975
 	public static function set_password_encryption_algorithm($algorithm) {
976 976
 		Deprecation::notice('4.0', 'Use the "Security.password_encryption_algorithm" config setting instead');
@@ -1138,7 +1138,7 @@  discard block
 block discarded – undo
1138 1138
 	/**
1139 1139
 	 * Set to true to ignore access to disallowed actions, rather than returning permission failure
1140 1140
 	 * Note that this is just a flag that other code needs to check with Security::ignore_disallowed_actions()
1141
-	 * @param $flag True or false
1141
+	 * @param boolean $flag True or false
1142 1142
 	 */
1143 1143
 	public static function set_ignore_disallowed_actions($flag) {
1144 1144
 		self::$ignore_disallowed_actions = $flag;
Please login to merge, or discard this patch.
thirdparty/jsmin/jsmin.php 1 patch
Doc Comments   +14 added lines patch added patch discarded remove patch
@@ -59,6 +59,9 @@  discard block
 block discarded – undo
59 59
 
60 60
   // -- Public Static Methods --------------------------------------------------
61 61
 
62
+  /**
63
+   * @param string $js
64
+   */
62 65
   public static function minify($js) {
63 66
     $jsmin = new JSMin($js);
64 67
     return $jsmin->min();
@@ -82,6 +85,10 @@  discard block
 block discarded – undo
82 85
      action treats a string as a single character. Wow!
83 86
      action recognizes a regular expression if it is preceded by ( or , or =.
84 87
   */
88
+
89
+  /**
90
+   * @param integer $d
91
+   */
85 92
   protected function action($d) {
86 93
     switch($d) {
87 94
       case 1:
@@ -160,6 +167,9 @@  discard block
 block discarded – undo
160 167
     }
161 168
   }
162 169
 
170
+  /**
171
+   * @return string
172
+   */
163 173
   protected function get() {
164 174
     $c = $this->lookAhead;
165 175
     $this->lookAhead = null;
@@ -187,6 +197,10 @@  discard block
 block discarded – undo
187 197
   /* isAlphanum -- return true if the character is a letter, digit, underscore,
188 198
         dollar sign, or non-ASCII character.
189 199
   */
200
+
201
+  /**
202
+   * @param string $c
203
+   */
190 204
   protected function isAlphaNum($c) {
191 205
     return ord($c) > 126 || $c === '\\' || preg_match('/^[\w\$]$/', $c) === 1;
192 206
   }
Please login to merge, or discard this patch.
forms/DropdownField.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@
 block discarded – undo
12 12
 
13 13
 	/**
14 14
 	 * @param array $properties
15
-	 * @return string
15
+	 * @return DBHTMLText
16 16
 	 */
17 17
 	public function FieldHolder($properties = array()) {
18 18
 		return $this->Field($properties);
Please login to merge, or discard this patch.
forms/ListboxField.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
 	 *
25 25
 	 * @param array $properties
26 26
 	 *
27
-	 * @return string
27
+	 * @return SilverStripe\ORM\FieldType\DBHTMLText
28 28
 	 */
29 29
 	public function Field($properties = array()) {
30 30
 		$source = ArrayLib::flatten($this->getSource());
Please login to merge, or discard this patch.
forms/ReadonlyField.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -95,7 +95,7 @@
 block discarded – undo
95 95
 	 * If $dontEscape is false the returned value will be safely encoded,
96 96
 	 * but should not be escaped by the frontend.
97 97
 	 *
98
-	 * @return mixed|string
98
+	 * @return string
99 99
 	 */
100 100
 	public function Value() {
101 101
 		// Get raw value
Please login to merge, or discard this patch.