The expression $node->implements of type PhpParser\Node\Name[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.
This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an
empty array is considered to be equal (but not identical) to false, this is not always apparent.
Consider making the comparison explicit by using empty(..) or !empty(...) instead.
The property namespacedName does not seem to exist in PhpParser\Node\Stmt\Class_.
An attempt at access to an undefined property has been detected. This may either be a typographical error
or the property has been renamed but there are still references to its old name.
If you really want to allow access to undefined properties, you can define magic methods
to allow access. See the php core documentation on Overloading.
The property namespacedName does not seem to exist in PhpParser\Node\Stmt\Trait_.
An attempt at access to an undefined property has been detected. This may either be a typographical error
or the property has been renamed but there are still references to its old name.
If you really want to allow access to undefined properties, you can define magic methods
to allow access. See the php core documentation on Overloading.
The expression $node->extends of type null|object<PhpParser\Node\Name> is not guaranteed to be traversable. How about adding an additional type check?
There are different options of fixing this problem.
If you want to be on the safe side, you can add an additional type-check:
$collection=json_decode($data,true);if(!is_array($collection)){thrownew\RuntimeException('$collection must be an array.');}foreach($collectionas$item){/** ... */}
If you are sure that the expression is traversable, you might want to add a
doc comment cast to improve IDE auto-completion and static analysis:
The property namespacedName does not seem to exist in PhpParser\Node\Stmt\Interface_.
An attempt at access to an undefined property has been detected. This may either be a typographical error
or the property has been renamed but there are still references to its old name.
If you really want to allow access to undefined properties, you can define magic methods
to allow access. See the php core documentation on Overloading.
Loading history...
58
'extends' => $extends,
59
];
60
}
61
if (!$node instanceof Node\Stmt\Namespace_) {
62
//break out of traversal as we only need highlevel information here!
silverstripe /
silverstripe-framework
Loading history...
This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.
Consider making the comparison explicit by using
empty(..)or! empty(...)instead.