ClassManifestVisitor::enterNode() - Code Metrics - Inspection of "Merge pull request #5567 from dhensby/classmanifes..." - silverstripe/silverstripe-framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 03a881...28de70 )

by Damian

created 2017-03-06 21:16 UTC

ClassManifestVisitor::enterNode() D

↳ Parent: ClassManifestVisitor

Complexity

Conditions	9
Paths	14

Size

Total Lines	36
Code Lines	22

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	9
eloc	22
nc	14
nop	1
dl	0
loc	36
rs	4.909
c	0
b	0
f	0

<?php

namespace SilverStripe\Core\Manifest;

use PhpParser\Node;
use PhpParser\NodeTraverser;
use PhpParser\NodeVisitorAbstract;

class ClassManifestVisitor extends NodeVisitorAbstract
{

    private $classes = [];

    private $traits = [];

    private $interfaces = [];

    public function resetState()
    {
        $this->classes = [];
        $this->traits = [];
        $this->interfaces = [];
    }

    public function beforeTraverse(array $nodes)
    {
        $this->resetState();
    }

    public function enterNode(Node $node)
    {
        if ($node instanceof Node\Stmt\Class_) {
            $extends = '';
            $interfaces = [];

            if ($node->extends) {
                $extends = array((string)$node->extends);
            }

            if ($node->implements) {

                foreach ($node->implements as $interface) {
                    $interfaces[] = (string)$interface;
                }
            }

            $this->classes[(string)$node->namespacedName] = [

                'extends' => $extends,
                'interfaces' => $interfaces,
            ];
        } elseif ($node instanceof Node\Stmt\Trait_) {
            $this->traits[(string)$node->namespacedName] = array();

        } elseif ($node instanceof Node\Stmt\Interface_) {
            $extends = array();
            foreach ($node->extends as $ancestor) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
                $extends[] = (string)$ancestor;
            }
            $this->interfaces[(string)$node->namespacedName] = [

                'extends' => $extends,
            ];
        }
        if (!$node instanceof Node\Stmt\Namespace_) {
            //break out of traversal as we only need highlevel information here!
            return NodeTraverser::DONT_TRAVERSE_CHILDREN;
        }
    }

    public function getClasses()
    {
        return $this->classes;
    }

    public function getTraits()
    {
        return $this->traits;
    }

    public function getInterfaces()
    {
        return $this->interfaces;
    }
}


1			<?php
2
3			namespace SilverStripe\Core\Manifest;
4
5			use PhpParser\Node;
6			use PhpParser\NodeTraverser;
7			use PhpParser\NodeVisitorAbstract;
8
9			class ClassManifestVisitor extends NodeVisitorAbstract
10			{
11
12			private $classes = [];
13
14			private $traits = [];
15
16			private $interfaces = [];
17
18			public function resetState()
19			{
20			$this->classes = [];
21			$this->traits = [];
22			$this->interfaces = [];
23			}
24
25			public function beforeTraverse(array $nodes)
26			{
27			$this->resetState();
28			}
29
30			public function enterNode(Node $node)
31			{
32			if ($node instanceof Node\Stmt\Class_) {
33			$extends = '';
34			$interfaces = [];
35
36			if ($node->extends) {
37			$extends = array((string)$node->extends);
38			}
39
40			if ($node->implements) {
			0 ignored issues – show Bug Best Practice introduced 2017-03-02 13:45 UTC by Report Bug Copy Issue Report The expression `$node->implements` of type `PhpParser\Node\Name[]` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
41			foreach ($node->implements as $interface) {
42			$interfaces[] = (string)$interface;
43			}
44			}
45
46			$this->classes[(string)$node->namespacedName] = [
			0 ignored issues – show Bug introduced 2017-03-02 13:45 UTC by Report Bug Copy Issue Report The property `namespacedName` does not seem to exist in `PhpParser\Node\Stmt\Class_`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
47			'extends' => $extends,
48			'interfaces' => $interfaces,
49			];
50			} elseif ($node instanceof Node\Stmt\Trait_) {
51			$this->traits[(string)$node->namespacedName] = array();
			0 ignored issues – show Bug introduced 2017-03-02 13:45 UTC by Report Bug Copy Issue Report The property `namespacedName` does not seem to exist in `PhpParser\Node\Stmt\Trait_`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
52			} elseif ($node instanceof Node\Stmt\Interface_) {
53			$extends = array();
54			foreach ($node->extends as $ancestor) {
			0 ignored issues – show Bug introduced 2017-03-02 13:45 UTC by Report Bug Copy Issue Report The expression `$node->extends` of type `null\|object<PhpParser\Node\Name>` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
55			$extends[] = (string)$ancestor;
56			}
57			$this->interfaces[(string)$node->namespacedName] = [
			0 ignored issues – show Bug introduced 2017-03-02 13:45 UTC by Report Bug Copy Issue Report The property `namespacedName` does not seem to exist in `PhpParser\Node\Stmt\Interface_`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
58			'extends' => $extends,
59			];
60			}
61			if (!$node instanceof Node\Stmt\Namespace_) {
62			//break out of traversal as we only need highlevel information here!
63			return NodeTraverser::DONT_TRAVERSE_CHILDREN;
64			}
65			}
66
67			public function getClasses()
68			{
69			return $this->classes;
70			}
71
72			public function getTraits()
73			{
74			return $this->traits;
75			}
76
77			public function getInterfaces()
78			{
79			return $this->interfaces;
80			}
81			}
82

silverstripe / silverstripe-framework

Push — master ( 03a881...28de70 )

ClassManifestVisitor::enterNode() D

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like