Completed
Push — master ( a596bd...196c21 )
by Loz
10:53
created
model/DataQuery.php 1 patch
Doc Comments   +9 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,6 +45,7 @@  discard block
 block discarded – undo
45 45
 	 * Create a new DataQuery.
46 46
 	 *
47 47
 	 * @param String The name of the DataObject class that you wish to query
48
+	 * @param string $dataClass
48 49
 	 */
49 50
 	public function __construct($dataClass) {
50 51
 		$this->dataClass = $dataClass;
@@ -167,7 +168,7 @@  discard block
 block discarded – undo
167 168
 	/**
168 169
 	 * Ensure that the query is ready to execute.
169 170
 	 *
170
-	 * @param array|null $queriedColumns Any columns to filter the query by
171
+	 * @param string[] $queriedColumns Any columns to filter the query by
171 172
 	 * @return SQLSelect The finalised sql query
172 173
 	 */
173 174
 	public function getFinalisedQuery($queriedColumns = null) {
@@ -924,6 +925,7 @@  discard block
 block discarded – undo
924 925
 
925 926
 	/**
926 927
 	 * Set an arbitrary query parameter, that can be used by decorators to add additional meta-data to the query.
928
+	 * @param string $key
927 929
 	 */
928 930
 	public function getQueryParam($key) {
929 931
 		if(isset($this->queryParams[$key])) return $this->queryParams[$key];
@@ -956,6 +958,9 @@  discard block
 block discarded – undo
956 958
 	 */
957 959
 	protected $whereQuery;
958 960
 
961
+	/**
962
+	 * @param string $connective
963
+	 */
959 964
 	public function __construct(DataQuery $base, $connective) {
960 965
 		$this->dataClass = $base->dataClass;
961 966
 		$this->query = $base->query;
@@ -965,6 +970,9 @@  discard block
 block discarded – undo
965 970
 		$base->where($this);
966 971
 	}
967 972
 
973
+	/**
974
+	 * @param string $filter
975
+	 */
968 976
 	public function where($filter) {
969 977
 		if($filter) {
970 978
 			$this->whereQuery->addWhere($filter);
Please login to merge, or discard this patch.
model/UnsavedRelationList.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -146,7 +146,7 @@
 block discarded – undo
146 146
 	 * Add a number of items to the relation.
147 147
 	 *
148 148
 	 * @param array $items Items to add, as either DataObjects or IDs.
149
-	 * @return DataList
149
+	 * @return UnsavedRelationList
150 150
 	 */
151 151
 	public function addMany($items) {
152 152
 		foreach($items as $item) {
Please login to merge, or discard this patch.
forms/htmleditor/HTMLEditorConfig.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -138,7 +138,7 @@
 block discarded – undo
138 138
 	 * Get the current value of an option
139 139
      *
140 140
 	 * @param string $key The key of the option to get
141
-	 * @return mixed The value of the specified option
141
+	 * @return string The value of the specified option
142 142
 	 */
143 143
 	abstract public function getOption($key);
144 144
 
Please login to merge, or discard this patch.
forms/htmleditor/HTMLEditorField.php 1 patch
Doc Comments   +12 added lines, -5 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
 	/**
58 58
 	 * Assign a new configuration instance or identifier
59 59
 	 *
60
-	 * @param string|HTMLEditorConfig $config
60
+	 * @param string $config
61 61
 	 * @return $this
62 62
 	 */
63 63
 	public function setEditorConfig($config) {
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
 	 *
72 72
 	 * @param string $name The internal field name, passed to forms.
73 73
 	 * @param string $title The human-readable field label.
74
-	 * @param mixed $value The value of the field.
74
+	 * @param integer $value The value of the field.
75 75
 	 * @param string $config HTMLEditorConfig identifier to be used. Default to the active one.
76 76
 	 */
77 77
 	public function __construct($name, $title = null, $value = '', $config = null) {
@@ -112,6 +112,9 @@  discard block
 block discarded – undo
112 112
 		$record->{$this->name} = $htmlValue->getContent();
113 113
 	}
114 114
 
115
+	/**
116
+	 * @param string|null $value
117
+	 */
115 118
 	public function setValue($value) {
116 119
 		// Regenerate links prior to preview, so that the editor can see them.
117 120
 		$value = Image::regenerate_html_links($value);
@@ -179,6 +182,10 @@  discard block
 block discarded – undo
179 182
 
180 183
 	protected $controller, $name;
181 184
 
185
+	/**
186
+	 * @param Controller|null $controller
187
+	 * @param string $name
188
+	 */
182 189
 	public function __construct($controller, $name) {
183 190
 		parent::__construct();
184 191
 
@@ -197,7 +204,7 @@  discard block
 block discarded – undo
197 204
 	/**
198 205
 	 * Searches the SiteTree for display in the dropdown
199 206
 	 *
200
-	 * @return callback
207
+	 * @return DataList
201 208
 	 */
202 209
 	public function siteTreeSearchCallback($sourceObject, $labelField, $search) {
203 210
 		return DataObject::get($sourceObject)->filterAny(array(
@@ -577,7 +584,7 @@  discard block
 block discarded – undo
577 584
 	/**
578 585
 	 * Find all anchors available on the given page.
579 586
 	 *
580
-	 * @return array
587
+	 * @return string
581 588
 	 * @throws SS_HTTPResponse_Exception
582 589
 	 */
583 590
 	public function getanchors() {
@@ -1136,7 +1143,7 @@  discard block
 block discarded – undo
1136 1143
 	/**
1137 1144
 	 * Get OEmbed type
1138 1145
 	 *
1139
-	 * @return string
1146
+	 * @return boolean
1140 1147
 	 */
1141 1148
 	public function getType() {
1142 1149
 		return $this->oembed->type;
Please login to merge, or discard this patch.
forms/HTMLEditorSanitiser.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
 	/**
40 40
 	 * Given a TinyMCE pattern (close to unix glob style), create a regex that does the match
41 41
 	 *
42
-	 * @param $str - The TinyMCE pattern
42
+	 * @param string|null $str - The TinyMCE pattern
43 43
 	 * @return string - The equivalent regex
44 44
 	 */
45 45
 	protected function patternToRegex($str) {
@@ -180,6 +180,7 @@  discard block
 block discarded – undo
180 180
 	/**
181 181
 	 * Given an attribute name, return the rule structure for that attribute
182 182
 	 * @param string $name - The attribute name
183
+	 * @param stdClass $elementRule
183 184
 	 * @return stdClass - The attribute rule
184 185
 	 */
185 186
 	protected function getRuleForAttribute($elementRule, $name) {
Please login to merge, or discard this patch.