DataObjectDuplicationTest::testDuplicateUnsaved() - Code Metrics - Inspection of "Merge pull request #6169 from open-sausages/pulls/..." - silverstripe/silverstripe-framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 797960...471166 )

by Loz

created 2017-05-17 08:31 UTC

DataObjectDuplicationTest::testDuplicateUnsaved() A

↳ Parent: DataObjectDuplicationTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	19
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	14
nc	1
nop	0
dl	0
loc	19
rs	9.4285
c	0
b	0
f	0

<?php

namespace SilverStripe\ORM\Tests;

use SilverStripe\ORM\DataObject;
use SilverStripe\Dev\SapphireTest;
use SilverStripe\ORM\FieldType\DBDatetime;

class DataObjectDuplicationTest extends SapphireTest
{

    protected $usesDatabase = true;

    protected static $extra_dataobjects = array(
        DataObjectDuplicationTest\Class1::class,
        DataObjectDuplicationTest\Class2::class,
        DataObjectDuplicationTest\Class3::class,
        DataObjectDuplicationTest\Class4::class,
    );

    public function testDuplicate()
    {
        DBDatetime::set_mock_now('2016-01-01 01:01:01');
        $orig = new DataObjectDuplicationTest\Class1();
        $orig->text = 'foo';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $orig->write();
        DBDatetime::set_mock_now('2016-01-02 01:01:01');
        $duplicate = $orig->duplicate();
        $this->assertInstanceOf(
            DataObjectDuplicationTest\Class1::class,
            $duplicate,
            'Creates the correct type'
        );
        $this->assertNotEquals(
            $duplicate->ID,
            $orig->ID,
            'Creates a unique record'
        );
        $this->assertEquals(
            'foo',
            $duplicate->text,
            'Copies fields'
        );
        $this->assertEquals(
            2,
            DataObjectDuplicationTest\Class1::get()->Count(),
            'Only creates a single duplicate'
        );
        $this->assertEquals(DBDatetime::now()->Nice(), $duplicate->dbObject('Created')->Nice());
        $this->assertNotEquals($orig->dbObject('Created')->Nice(), $duplicate->dbObject('Created')->Nice());
    }

    public function testDuplicateHasOne()
    {
        $relationObj = new DataObjectDuplicationTest\Class1();
        $relationObj->text = 'class1';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $relationObj->write();

        $orig = new DataObjectDuplicationTest\Class2();
        $orig->text = 'class2';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $orig->oneID = $relationObj->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $orig->write();

        $duplicate = $orig->duplicate();
        $this->assertEquals(
            $relationObj->ID,
            $duplicate->oneID,
            'Copies has_one relationship'
        );
        $this->assertEquals(
            2,
            DataObjectDuplicationTest\Class2::get()->Count(),
            'Only creates a single duplicate'
        );
        $this->assertEquals(
            1,
            DataObjectDuplicationTest\Class1::get()->Count(),
            'Does not create duplicate of has_one relationship'
        );
    }


    public function testDuplicateManyManyClasses()
    {
        //create new test classes below
        $one = new DataObjectDuplicationTest\Class1();
        $two = new DataObjectDuplicationTest\Class2();
        $three = new DataObjectDuplicationTest\Class3();

        //set some simple fields
        $text1 = "Test Text 1";
        $text2 = "Test Text 2";
        $text3 = "Test Text 3";
        $one->text = $text1;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $two->text = $text2;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $three->text = $text3;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        //write the to DB
        $one->write();
        $two->write();
        $three->write();

        //create relations
        $one->twos()->add($two);
        $one->threes()->add($three);

        $one = DataObject::get_by_id(DataObjectDuplicationTest\Class1::class, $one->ID);
        $two = DataObject::get_by_id(DataObjectDuplicationTest\Class2::class, $two->ID);
        $three = DataObject::get_by_id(DataObjectDuplicationTest\Class3::class, $three->ID);

        //test duplication
        $oneCopy = $one->duplicate(true, true);
        $twoCopy = $two->duplicate(true, true);
        $threeCopy = $three->duplicate(true, true);

        $oneCopy = DataObject::get_by_id(DataObjectDuplicationTest\Class1::class, $oneCopy->ID);
        $twoCopy = DataObject::get_by_id(DataObjectDuplicationTest\Class2::class, $twoCopy->ID);
        $threeCopy = DataObject::get_by_id(DataObjectDuplicationTest\Class3::class, $threeCopy->ID);

        $this->assertNotNull($oneCopy, "Copy of 1 exists");
        $this->assertNotNull($twoCopy, "Copy of 2 exists");
        $this->assertNotNull($threeCopy, "Copy of 3 exists");

        $this->assertEquals($text1, $oneCopy->text);
        $this->assertEquals($text2, $twoCopy->text);
        $this->assertEquals($text3, $threeCopy->text);

        $this->assertNotEquals(
            $one->twos()->Count(),
            $oneCopy->twos()->Count(),
            "Many-to-one relation not copied (has_many)"
        );
        $this->assertEquals(
            $one->threes()->Count(),
            $oneCopy->threes()->Count(),
            "Object has the correct number of relations"
        );
        $this->assertEquals(
            $three->ones()->Count(),
            $threeCopy->ones()->Count(),
            "Object has the correct number of relations"
        );

        $this->assertEquals(
            $one->ID,
            $twoCopy->one()->ID,
            "Match between relation of copy and the original"
        );
        $this->assertEquals(
            0,
            $oneCopy->twos()->Count(),
            "Many-to-one relation not copied (has_many)"
        );
        $this->assertEquals(
            $three->ID,
            $oneCopy->threes()->First()->ID,
            "Match between relation of copy and the original"
        );
        $this->assertEquals(
            $one->ID,
            $threeCopy->ones()->First()->ID,
            "Match between relation of copy and the original"
        );
    }

    public function testDuplicateManyManyFiltered()
    {
        $parent = new DataObjectDuplicationTest\Class4();
        $parent->Title = 'Parent';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $parent->write();

        $child = new DataObjectDuplicationTest\Class4();
        $child->Title = 'Child';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $child->write();

        $grandChild = new DataObjectDuplicationTest\Class4();
        $grandChild->Title = 'GrandChild';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $grandChild->write();

        $parent->Children()->add($child);
        $child->Children()->add($grandChild);

        // Duplcating $child should only duplicate grandchild
        $childDuplicate = $child->duplicate(true, 'many_many');
        $this->assertEquals(0, $childDuplicate->Parents()->count());
        $this->assertDOSEquals(
            [['Title' => 'GrandChild']],
            $childDuplicate->Children()
        );

        // Duplicate belongs_many_many only
        $belongsDuplicate = $child->duplicate(true, 'belongs_many_many');
        $this->assertEquals(0, $belongsDuplicate->Children()->count());
        $this->assertDOSEquals(
            [['Title' => 'Parent']],
            $belongsDuplicate->Parents()
        );

        // Duplicate all
        $allDuplicate = $child->duplicate(true, true);
        $this->assertDOSEquals(
            [['Title' => 'Parent']],
            $allDuplicate->Parents()
        );
        $this->assertDOSEquals(
            [['Title' => 'GrandChild']],
            $allDuplicate->Children()
        );
    }

    /**
     * Test duplication of UnsavedRelations
     */
    public function testDuplicateUnsaved()
    {
        $one = new DataObjectDuplicationTest\Class1();
        $one->text = "Test Text 1";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $three = new DataObjectDuplicationTest\Class3();
        $three->text = "Test Text 3";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $one->threes()->add($three);
        $this->assertDOSEquals(
            [['text' => 'Test Text 3']],
            $one->threes()
        );
        // Test duplicate
        $dupe = $one->duplicate(false, true);
        $this->assertEquals('Test Text 1', $dupe->text);
        $this->assertDOSEquals(
            [['text' => 'Test Text 3']],
            $dupe->threes()
        );
    }
}


1			<?php
2
3			namespace SilverStripe\ORM\Tests;
4
5			use SilverStripe\ORM\DataObject;
6			use SilverStripe\Dev\SapphireTest;
7			use SilverStripe\ORM\FieldType\DBDatetime;
8
9			class DataObjectDuplicationTest extends SapphireTest
10			{
11
12			protected $usesDatabase = true;
13
14			protected static $extra_dataobjects = array(
15			DataObjectDuplicationTest\Class1::class,
16			DataObjectDuplicationTest\Class2::class,
17			DataObjectDuplicationTest\Class3::class,
18			DataObjectDuplicationTest\Class4::class,
19			);
20
21			public function testDuplicate()
22			{
23			DBDatetime::set_mock_now('2016-01-01 01:01:01');
24			$orig = new DataObjectDuplicationTest\Class1();
25			$orig->text = 'foo';
			0 ignored issues – show Documentation introduced 2016-11-15 05:42 UTC by Report Bug Copy Issue Report The property `text` does not exist on `object<SilverStripe\ORM\...DuplicationTest\Class1>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
26			$orig->write();
27			DBDatetime::set_mock_now('2016-01-02 01:01:01');
28			$duplicate = $orig->duplicate();
29			$this->assertInstanceOf(
30			DataObjectDuplicationTest\Class1::class,
31			$duplicate,
32			'Creates the correct type'
33			);
34			$this->assertNotEquals(
35			$duplicate->ID,
36			$orig->ID,
37			'Creates a unique record'
38			);
39			$this->assertEquals(

silverstripe / silverstripe-framework

Push — master ( 797960...471166 )

DataObjectDuplicationTest::testDuplicateUnsaved() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like