Completed
Pull Request — master (#5846)
by Hamish
19:13 queued 08:18
created
filesystem/GDBackend.php 1 patch
Doc Comments   +1 added lines, -4 removed lines patch added patch discarded remove patch
@@ -184,7 +184,6 @@  discard block
 block discarded – undo
184 184
 	 * Check if this image has previously crashed GD when attempting to open it - if it's opened
185 185
 	 * successfully, the manipulation's cache key is removed.
186 186
 	 *
187
-	 * @param string $args,... Any number of args that identify this image
188 187
 	 * @return bool True if failed
189 188
 	 */
190 189
 	public function failedResample() {
@@ -195,7 +194,6 @@  discard block
 block discarded – undo
195 194
 	/**
196 195
 	 * Mark a file as failed
197 196
 	 *
198
-	 * @param string $args,... Any number of args that identify this image
199 197
 	 */
200 198
 	protected function markFailed() {
201 199
 		$key = sha1(implode('|', func_get_args()));
@@ -205,7 +203,6 @@  discard block
 block discarded – undo
205 203
 	/**
206 204
 	 * Mark a file as succeeded
207 205
 	 *
208
-	 * @param string $args,... Any number of args that identify this image
209 206
 	 */
210 207
 	protected function markSucceeded() {
211 208
 		$key = sha1(implode('|', func_get_args()));
@@ -347,7 +344,7 @@  discard block
 block discarded – undo
347 344
 	 * using built-in function. Used when imagerotate function is not available(i.e. Ubuntu)
348 345
 	 *
349 346
 	 * @param float $angle Angle in degrees
350
-	 * @return static
347
+	 * @return null|resource
351 348
 	 */
352 349
 	public function rotatePixelByPixel($angle) {
353 350
 		if(!$this->gd) {
Please login to merge, or discard this patch.
forms/DateField.php 1 patch
Doc Comments   +9 added lines, -1 removed lines patch added patch discarded remove patch
@@ -90,6 +90,11 @@  discard block
 block discarded – undo
90 90
 	 */
91 91
 	protected $valueObj = null;
92 92
 
93
+	/**
94
+	 * @param string $name
95
+	 * @param string $title
96
+	 * @param string $value
97
+	 */
93 98
 	public function __construct($name, $title = null, $value = null) {
94 99
 		if(!$this->locale) {
95 100
 			$this->locale = i18n::get_locale();
@@ -288,6 +293,9 @@  discard block
 block discarded – undo
288 293
 		return $field;
289 294
 	}
290 295
 
296
+	/**
297
+	 * @param string $class
298
+	 */
291 299
 	public function castedCopy($class) {
292 300
 		$copy = new $class($this->name);
293 301
 		if($copy->hasMethod('setConfig')) {
@@ -326,7 +334,7 @@  discard block
 block discarded – undo
326 334
 	 * @deprecated 4.0 Use the "DateField.default_config" config setting instead
327 335
 	 * @param String $k
328 336
 	 * @param mixed $v
329
-	 * @return boolean
337
+	 * @return boolean|null
330 338
 	 */
331 339
 	public static function set_default_config($k, $v) {
332 340
 		Deprecation::notice('4.0', 'Use the "DateField.default_config" config setting instead');
Please login to merge, or discard this patch.
forms/FormScaffolder.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,6 @@
 block discarded – undo
49 49
 
50 50
 	/**
51 51
 	 * @param DataObject $obj
52
-	 * @param array $params
53 52
 	 */
54 53
 	public function __construct($obj) {
55 54
 		$this->obj = $obj;
Please login to merge, or discard this patch.
forms/gridfield/GridFieldAddExistingAutocompleter.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -129,7 +129,7 @@
 block discarded – undo
129 129
 	/**
130 130
 	 *
131 131
 	 * @param GridField $gridField
132
-	 * @return array
132
+	 * @return string[]
133 133
 	 */
134 134
 	public function getActions($gridField) {
135 135
 		return array('addto');
Please login to merge, or discard this patch.
forms/gridfield/GridFieldComponent.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -33,6 +33,7 @@  discard block
 block discarded – undo
33 33
 	 * If you attempt to return HTML for a fragment that doesn't exist, an
34 34
 	 * exception will be thrown when the {@link GridField} is rendered.
35 35
 	 *
36
+	 * @param GridField $gridField
36 37
 	 * @return array
37 38
 	 */
38 39
 	public function getHTMLFragments($gridField);
@@ -57,6 +58,7 @@  discard block
 block discarded – undo
57 58
 	 * @param GridField $gridField
58 59
 	 * @param arary $columns List of columns
59 60
 	 * @param array - List reference of all column names.
61
+	 * @return void
60 62
 	 */
61 63
 	public function augmentColumns($gridField, &$columns);
62 64
 
@@ -139,6 +141,7 @@  discard block
 block discarded – undo
139 141
 	 * @param String Action identifier, see {@link getActions()}.
140 142
 	 * @param Array Arguments relevant for this
141 143
 	 * @param Array All form data
144
+	 * @param string $actionName
142 145
 	 */
143 146
 	public function handleAction(GridField $gridField, $actionName, $arguments, $data);
144 147
 }
@@ -189,6 +192,7 @@  discard block
 block discarded – undo
189 192
 	 *
190 193
 	 * Handler methods will be called on the component, rather than the
191 194
 	 * {@link GridField}.
195
+	 * @param GridField $gridField
192 196
 	 */
193 197
 	public function getURLHandlers($gridField);
194 198
 }
@@ -205,7 +209,6 @@  discard block
 block discarded – undo
205 209
 	/**
206 210
 	 * Called when a grid field is saved - i.e. the form is submitted.
207 211
 	 *
208
-	 * @param GridField $field
209 212
 	 * @param DataObjectInterface $record
210 213
 	 */
211 214
 	public function handleSave(GridField $grid, DataObjectInterface $record);
Please login to merge, or discard this patch.
forms/gridfield/GridFieldConfig.php 1 patch
Doc Comments   +2 added lines patch added patch discarded remove patch
@@ -78,6 +78,7 @@  discard block
 block discarded – undo
78 78
 
79 79
 	/**
80 80
 	 * @param String Class name or interface
81
+	 * @param string $type
81 82
 	 * @return GridFieldConfig $this
82 83
 	 */
83 84
 	public function removeComponentsByType($type) {
@@ -116,6 +117,7 @@  discard block
 block discarded – undo
116 117
 	 * Returns the first available component with the given class or interface.
117 118
 	 *
118 119
 	 * @param String ClassName
120
+	 * @param string $type
119 121
 	 * @return GridFieldComponent
120 122
 	 */
121 123
 	public function getComponentByType($type) {
Please login to merge, or discard this patch.
forms/gridfield/GridFieldDataColumns.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -70,6 +70,7 @@  discard block
 block discarded – undo
70 70
 	/**
71 71
 	 * Get the DisplayFields
72 72
 	 *
73
+	 * @param GridField $gridField
73 74
 	 * @return array
74 75
 	 * @see GridFieldDataColumns::setDisplayFields
75 76
 	 */
@@ -174,7 +175,7 @@  discard block
 block discarded – undo
174 175
 	 * e.g. to set a title for a search column header.
175 176
 	 *
176 177
 	 * @param GridField $gridField
177
-	 * @param string $columnName
178
+	 * @param string $column
178 179
 	 * @return array - Map of arbitrary metadata identifiers to their values.
179 180
 	 */
180 181
 	public function getColumnMetadata($gridField, $column) {
Please login to merge, or discard this patch.
forms/gridfield/GridFieldExportButton.php 1 patch
Doc Comments   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -86,6 +86,7 @@  discard block
 block discarded – undo
86 86
 
87 87
 	/**
88 88
 	 * Handle the export, for both the action button and the URL
89
+ 	 * @param GridField $gridField
89 90
  	 */
90 91
 	public function handleExport($gridField, $request = null) {
91 92
 		$now = Date("d-m-Y-H-i");
@@ -100,7 +101,7 @@  discard block
 block discarded – undo
100 101
 	 * Generate export fields for CSV.
101 102
 	 *
102 103
 	 * @param GridField $gridField
103
-	 * @return array
104
+	 * @return string
104 105
 	 */
105 106
 	public function generateExportFileData($gridField) {
106 107
 		$csvColumns = ($this->exportColumns)
@@ -227,6 +228,7 @@  discard block
 block discarded – undo
227 228
 
228 229
 	/**
229 230
 	 * @param boolean
231
+	 * @param boolean $bool
230 232
 	 */
231 233
 	public function setCsvHasHeader($bool) {
232 234
 		$this->csvHasHeader = $bool;
Please login to merge, or discard this patch.
forms/gridfield/GridFieldFilterHeader.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -23,6 +23,7 @@
 block discarded – undo
23 23
 	 *
24 24
 	 * By default, this is set to true so that it's clearer what's happening, but the predefined
25 25
 	 * {@link GridFieldConfig} subclasses set this to false for flexibility.
26
+	 * @param boolean $throwExceptionOnBadDataType
26 27
 	 */
27 28
 	public function setThrowExceptionOnBadDataType($throwExceptionOnBadDataType) {
28 29
 		$this->throwExceptionOnBadDataType = $throwExceptionOnBadDataType;
Please login to merge, or discard this patch.