Completed
Pull Request — master (#5846)
by Hamish
19:13 queued 08:18
created
control/HTTPRequest.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -385,9 +385,9 @@  discard block
 block discarded – undo
385 385
 	 * it's only advisable to send small files through this method.
386 386
 	 *
387 387
 	 * @static
388
-	 * @param $fileData
388
+	 * @param string $fileData
389 389
 	 * @param $fileName
390
-	 * @param null $mimeType
390
+	 * @param string $mimeType
391 391
 	 * @return SS_HTTPResponse
392 392
 	 */
393 393
 	public static function send_file($fileData, $fileName, $mimeType = null) {
@@ -605,7 +605,7 @@  discard block
 block discarded – undo
605 605
 	 * This is used by the request handler to prevent infinite parsing loops.
606 606
 	 *
607 607
 	 * @param $pattern
608
-	 * @return bool
608
+	 * @return boolean|null
609 609
 	 */
610 610
 	public function isEmptyPattern($pattern) {
611 611
 		if(preg_match('/^([A-Za-z]+) +(.*)$/', $pattern, $matches)) {
Please login to merge, or discard this patch.
control/HTTPResponse.php 1 patch
Doc Comments   +7 added lines, -6 removed lines patch added patch discarded remove patch
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
 	 *  No newlines are allowed in the description.
110 110
 	 *  If omitted, will default to the standard HTTP description
111 111
 	 *  for the given $code value (see {@link $status_codes}).
112
-	 * @return SS_HTTPRequest $this
112
+	 * @return SS_HTTPResponse $this
113 113
 	 */
114 114
 	public function setStatusCode($code, $description = null) {
115 115
 		if(isset(self::$status_codes[$code])) $this->statusCode = $code;
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
 	 * Caution: Will be overwritten by {@link setStatusCode()}.
126 126
 	 *
127 127
 	 * @param string $description
128
-	 * @return SS_HTTPRequest $this
128
+	 * @return SS_HTTPResponse $this
129 129
 	 */
130 130
 	public function setStatusDescription($description) {
131 131
 		$this->statusDescription = $description;
@@ -157,7 +157,7 @@  discard block
 block discarded – undo
157 157
 
158 158
 	/**
159 159
 	 * @param string $body
160
-	 * @return SS_HTTPRequest $this
160
+	 * @return SS_HTTPResponse $this
161 161
 	 */
162 162
 	public function setBody($body) {
163 163
 		$this->body = $body ? (string) $body : $body; // Don't type-cast false-ish values, eg null is null not ''
@@ -176,7 +176,7 @@  discard block
 block discarded – undo
176 176
 	 *
177 177
 	 * @param string $header Example: "Content-Type"
178 178
 	 * @param string $value Example: "text/xml"
179
-	 * @return SS_HTTPRequest $this
179
+	 * @return SS_HTTPResponse $this
180 180
 	 */
181 181
 	public function addHeader($header, $value) {
182 182
 		$this->headers[$header] = $value;
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
 	 * e.g. "Content-Type".
207 207
 	 *
208 208
 	 * @param string $header
209
-	 * @return SS_HTTPRequest $this
209
+	 * @return SS_HTTPResponse $this
210 210
 	 */
211 211
 	public function removeHeader($header) {
212 212
 		if(isset($this->headers[$header])) unset($this->headers[$header]);
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
216 216
 	/**
217 217
 	 * @param string $dest
218 218
 	 * @param int $code
219
-	 * @return SS_HTTPRequest $this
219
+	 * @return SS_HTTPResponse $this
220 220
 	 */
221 221
 	public function redirect($dest, $code=302) {
222 222
 		if(!in_array($code, self::$redirect_codes)) $code = 302;
@@ -316,6 +316,7 @@  discard block
 block discarded – undo
316 316
 	 * @param string|SS_HTTPResponse body Either the plaintext content of the error message, or an SS_HTTPResponse
317 317
 	 *                                     object representing it.  In either case, the $statusCode and
318 318
 	 *                                     $statusDescription will be the HTTP status of the resulting response.
319
+	 * @param string $statusDescription
319 320
 	 * @see SS_HTTPResponse::__construct();
320 321
 	 */
321 322
 	public function __construct($body = null, $statusCode = null, $statusDescription = null) {
Please login to merge, or discard this patch.
forms/TextField.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@
 block discarded – undo
12 12
 
13 13
 	/**
14 14
 	 * @param array $properties
15
-	 * @return string
15
+	 * @return DBHTMLText
16 16
 	 */
17 17
 	public function FieldHolder($properties = array()) {
18 18
 		return $this->Field($properties);
Please login to merge, or discard this patch.
ORM/Connect/Database.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -718,7 +718,7 @@  discard block
 block discarded – undo
718 718
 	 * @param boolean $create Flag indicating whether the database should be created
719 719
 	 * if it doesn't exist. If $create is false and the database doesn't exist
720 720
 	 * then an error will be raised
721
-	 * @param int|boolean $errorLevel The level of error reporting to enable for the query, or false if no error
721
+	 * @param boolean $errorLevel The level of error reporting to enable for the query, or false if no error
722 722
 	 * should be raised
723 723
 	 * @return boolean Flag indicating success
724 724
 	 */
@@ -883,6 +883,7 @@  discard block
 block discarded – undo
883 883
 
884 884
 	/**
885 885
 	 * @deprecated since version 4.0 Use DB::field_list instead
886
+	 * @param string $table
886 887
 	 */
887 888
 	public function fieldList($table) {
888 889
 		Deprecation::notice('4.0', 'Use DB::field_list instead');
Please login to merge, or discard this patch.
ORM/FieldType/DBField.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -477,7 +477,7 @@
 block discarded – undo
477 477
 	}
478 478
 
479 479
 	/**
480
-	 * @param array $value
480
+	 * @param string $value
481 481
 	 * @return $this
482 482
 	 */
483 483
 	public function setArrayValue($value) {
Please login to merge, or discard this patch.
parsers/URLSegmentFilter.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -89,6 +89,7 @@
 block discarded – undo
89 89
 	 * Determines if the field should render open or closed by default.
90 90
 	 * 
91 91
 	 * @param boolean
92
+	 * @param boolean $bool
92 93
 	 */
93 94
 	public function startClosed($bool) {
94 95
 		($bool) ? $this->addExtraClass('startClosed') : $this->removeExtraClass('startClosed');
Please login to merge, or discard this patch.
thirdparty/Zend/Cache/Backend/BlackHole.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
      * Test if a cache is available or not (for the given id)
57 57
      *
58 58
      * @param  string $id cache id
59
-     * @return mixed false (a cache is not available) or "last modified" timestamp (int) of the available cache record
59
+     * @return boolean false (a cache is not available) or "last modified" timestamp (int) of the available cache record
60 60
      */
61 61
     public function test($id)
62 62
     {
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
192 192
      * - mtime : timestamp of last modification time
193 193
      *
194 194
      * @param  string $id cache id
195
-     * @return array array of metadatas (false if the cache id is not found)
195
+     * @return boolean array of metadatas (false if the cache id is not found)
196 196
      */
197 197
     public function getMetadatas($id)
198 198
     {
Please login to merge, or discard this patch.
thirdparty/Zend/Loader/Autoloader/Resource.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -136,7 +136,7 @@
 block discarded – undo
136 136
      * Helper method to calculate the correct class path
137 137
      *
138 138
      * @param string $class
139
-     * @return False if not matched other wise the correct path
139
+     * @return false|string if not matched other wise the correct path
140 140
      */
141 141
     public function getClassPath($class)
142 142
     {
Please login to merge, or discard this patch.
thirdparty/Zend/Loader/PluginLoader.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -283,7 +283,7 @@
 block discarded – undo
283 283
      * Whether or not a Plugin by a specific name is loaded
284 284
      *
285 285
      * @param string $name
286
-     * @return Zend_Loader_PluginLoader
286
+     * @return boolean
287 287
      */
288 288
     public function isLoaded($name)
289 289
     {
Please login to merge, or discard this patch.