Completed
Pull Request — master (#5846)
by Hamish
19:13 queued 08:18
created
ORM/DataQuery.php 1 patch
Doc Comments   +9 added lines, -3 removed lines patch added patch discarded remove patch
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
 	/**
101 101
 	 * Remove a filter from the query
102 102
 	 *
103
-	 * @param string|array $fieldExpression The predicate of the condition to remove
103
+	 * @param string|null $fieldExpression The predicate of the condition to remove
104 104
 	 * (ignoring parameters). The expression will be considered a match if it's
105 105
 	 * contained within any other predicate.
106 106
 	 * @return DataQuery Self reference
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
 	/**
180 180
 	 * Ensure that the query is ready to execute.
181 181
 	 *
182
-	 * @param array|null $queriedColumns Any columns to filter the query by
182
+	 * @param string[] $queriedColumns Any columns to filter the query by
183 183
 	 * @return SQLSelect The finalised sql query
184 184
 	 */
185 185
 	public function getFinalisedQuery($queriedColumns = null) {
@@ -387,7 +387,7 @@  discard block
 block discarded – undo
387 387
 	/**
388 388
 	 * Execute the query and return the result as {@link SS_Query} object.
389 389
 	 *
390
-	 * @return SS_Query
390
+	 * @return Connect\SS_Query
391 391
 	 */
392 392
 	public function execute() {
393 393
 		return $this->getFinalisedQuery()->execute();
@@ -1039,6 +1039,9 @@  discard block
 block discarded – undo
1039 1039
 	 */
1040 1040
 	protected $whereQuery;
1041 1041
 
1042
+	/**
1043
+	 * @param string $connective
1044
+	 */
1042 1045
 	public function __construct(DataQuery $base, $connective) {
1043 1046
 		parent::__construct($base->dataClass);
1044 1047
 		$this->query = $base->query;
@@ -1048,6 +1051,9 @@  discard block
 block discarded – undo
1048 1051
 		$base->where($this);
1049 1052
 	}
1050 1053
 
1054
+	/**
1055
+	 * @param string $filter
1056
+	 */
1051 1057
 	public function where($filter) {
1052 1058
 		if($filter) {
1053 1059
 			$this->whereQuery->addWhere($filter);
Please login to merge, or discard this patch.
ORM/FieldType/DBClassName.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -186,6 +186,9 @@
 block discarded – undo
186 186
 		return $classNames;
187 187
 	}
188 188
 
189
+	/**
190
+	 * @param \DBClassNameTest_ObjectSubClass $record
191
+	 */
189 192
 	public function setValue($value, $record = null, $markChanged = true) {
190 193
 		parent::setValue($value, $record, $markChanged);
191 194
 
Please login to merge, or discard this patch.
ORM/FieldType/DBComposite.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -205,6 +205,9 @@
 block discarded – undo
205 205
 		return null;
206 206
 	}
207 207
 
208
+	/**
209
+	 * @param string $field
210
+	 */
208 211
 	public function hasField($field) {
209 212
 		$fields = $this->compositeDatabaseFields();
210 213
 		return isset($fields[$field]);
Please login to merge, or discard this patch.
ORM/FieldType/DBCurrency.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -23,6 +23,9 @@  discard block
 block discarded – undo
23 23
 	 */
24 24
 	private static $currency_symbol = '$';
25 25
 
26
+	/**
27
+	 * @param string $name
28
+	 */
26 29
 	public function __construct($name = null, $wholeSize = 9, $decimalSize = 2, $defaultValue = 0) {
27 30
 		parent::__construct($name, $wholeSize, $decimalSize, $defaultValue);
28 31
 	}
@@ -46,6 +49,9 @@  discard block
 block discarded – undo
46 49
 		else return $val;
47 50
 	}
48 51
 
52
+	/**
53
+	 * @param string $value
54
+	 */
49 55
 	public function setValue($value, $record = null, $markChanged = true) {
50 56
 		$matches = null;
51 57
 		if(is_numeric($value)) {
Please login to merge, or discard this patch.
ORM/FieldType/DBDatetime.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -108,7 +108,7 @@
 block discarded – undo
108 108
 	 * Return a date and time formatted as per a CMS user's settings.
109 109
 	 *
110 110
 	 * @param Member $member
111
-	 * @return boolean | string A time and date pair formatted as per user-defined settings.
111
+	 * @return false|string | string A time and date pair formatted as per user-defined settings.
112 112
 	 */
113 113
 	public function FormatFromSettings($member = null) {
114 114
 		require_once 'Zend/Date.php';
Please login to merge, or discard this patch.
ORM/FieldType/DBPrimaryKey.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -20,6 +20,9 @@
 block discarded – undo
20 20
 	 */
21 21
 	protected $autoIncrement = true;
22 22
 
23
+	/**
24
+	 * @param boolean $autoIncrement
25
+	 */
23 26
 	public function setAutoIncrement($autoIncrement) {
24 27
 		$this->autoIncrement = $autoIncrement;
25 28
 		return $this;
Please login to merge, or discard this patch.
ORM/FieldType/DBTime.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -55,6 +55,9 @@
 block discarded – undo
55 55
 		if($this->value) return date($format, strtotime($this->value));
56 56
 	}
57 57
 
58
+	/**
59
+	 * @param string[] $parts
60
+	 */
58 61
 	public function TwelveHour( $parts ) {
59 62
 		$hour = $parts[1];
60 63
 		$min = $parts[2];
Please login to merge, or discard this patch.
ORM/FieldType/DBYear.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -18,6 +18,9 @@
 block discarded – undo
18 18
 		DB::require_field($this->tableName, $this->name, $values);
19 19
 	}
20 20
 
21
+	/**
22
+	 * @param string $title
23
+	 */
21 24
 	public function scaffoldFormField($title = null, $params = null) {
22 25
 		$selectBox = new DropdownField($this->name, $title);
23 26
 		$selectBox->setSource($this->getDefaultOptions());
Please login to merge, or discard this patch.
ORM/Hierarchy/Hierarchy.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -419,7 +419,7 @@  discard block
 block discarded – undo
419 419
 	/**
420 420
 	 * Return the IDs of all the marked nodes.
421 421
 	 *
422
-	 * @return array
422
+	 * @return integer[]
423 423
 	 */
424 424
 	public function markedNodeIDs() {
425 425
 		return array_keys($this->markedNodes);
@@ -636,7 +636,7 @@  discard block
 block discarded – undo
636 636
 	/**
637 637
 	 * Return all the children that this page had, including pages that were deleted from both stage & live.
638 638
 	 *
639
-	 * @return DataList
639
+	 * @return \SilverStripe\ORM\DataList
640 640
 	 * @throws Exception
641 641
 	 */
642 642
 	public function AllHistoricalChildren() {
@@ -826,7 +826,7 @@  discard block
 block discarded – undo
826 826
 	 * Get the next node in the tree of the type. If there is no instance of the className descended from this node,
827 827
 	 * then search the parents.
828 828
 	 * @param string     $className Class name of the node to find.
829
-	 * @param string|int $root      ID/ClassName of the node to limit the search to
829
+	 * @param integer $root      ID/ClassName of the node to limit the search to
830 830
 	 * @param DataObject $afterNode Used for recursive calls to this function
831 831
 	 * @return DataObject
832 832
 	 */
Please login to merge, or discard this patch.