Completed
Pull Request — master (#5157)
by Damian
11:28
created
forms/NestedForm.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -11,7 +11,7 @@
 block discarded – undo
11 11
 
12 12
 	/**
13 13
 	 * Represent the given form in a tabular style
14
-	 * @param form The form to decorate.
14
+	 * @param form Form form to decorate.
15 15
 	 */
16 16
 	public function __construct(Form $form) {
17 17
 		$this->form = $form;
Please login to merge, or discard this patch.
forms/PhoneNumberField.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
 
30 30
 	/**
31 31
 	 * @param array $properties
32
-	 * @return FieldGroup|HTMLText
32
+	 * @return FieldGroup
33 33
 	 */
34 34
 	public function Field($properties = array()) {
35 35
 		$fields = new FieldGroup( $this->name );
@@ -73,6 +73,9 @@  discard block
 block discarded – undo
73 73
 		return $this;
74 74
 	}
75 75
 
76
+	/**
77
+	 * @return string
78
+	 */
76 79
 	public static function joinPhoneNumber( $value ) {
77 80
 		if( is_array( $value ) ) {
78 81
 			$completeNumber = '';
Please login to merge, or discard this patch.
forms/RequiredFields.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -176,6 +176,7 @@
 block discarded – undo
176 176
 	 * Add {@link RequiredField} objects together
177 177
 	 *
178 178
 	 * @param RequiredFields
179
+	 * @param RequiredFields $requiredFields
179 180
 	 *
180 181
 	 * @return RequiredFields
181 182
 	 */
Please login to merge, or discard this patch.
forms/SelectionGroup.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -134,7 +134,7 @@
 block discarded – undo
134 134
 
135 135
 	/**
136 136
 	 * @param String $value Form field identifier
137
-	 * @param FormField $field Contents of the option
137
+	 * @param FormField $fields Contents of the option
138 138
 	 * @param String $title Title to show for the radio button option
139 139
 	 */
140 140
 	function __construct($value, $fields = null, $title = null) {
Please login to merge, or discard this patch.
forms/Tab.php 1 patch
Doc Comments   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -23,8 +23,6 @@  discard block
 block discarded – undo
23 23
 	 * @uses FormField::name_to_label()
24 24
 	 *
25 25
 	 * @param string $name Identifier of the tab, without characters like dots or spaces
26
-	 * @param string $title Natural language title of the tab. If its left out,
27
-	 *  the class uses {@link FormField::name_to_label()} to produce a title from the {@link $name} parameter.
28 26
 	 * @param FormField All following parameters are inserted as children to this tab
29 27
 	 */
30 28
 	public function __construct($name) {
@@ -54,6 +52,9 @@  discard block
 block discarded – undo
54 52
 		return $this->children;
55 53
 	}
56 54
 
55
+	/**
56
+	 * @param TabSet $val
57
+	 */
57 58
 	public function setTabSet($val) {
58 59
 		$this->tabSet = $val;
59 60
 		return $this;
Please login to merge, or discard this patch.
forms/TabSet.php 1 patch
Doc Comments   -2 removed lines patch added patch discarded remove patch
@@ -29,8 +29,6 @@
 block discarded – undo
29 29
 
30 30
 	/**
31 31
 	 * @param string $name Identifier
32
-	 * @param string $title (Optional) Natural language title of the tabset
33
-	 * @param Tab|TabSet $unknown All further parameters are inserted as children into the TabSet
34 32
 	 */
35 33
 	public function __construct($name) {
36 34
 		$args = func_get_args();
Please login to merge, or discard this patch.
forms/TextField.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@
 block discarded – undo
45 45
 	}
46 46
 
47 47
 	/**
48
-	 * @return null|int
48
+	 * @return integer
49 49
 	 */
50 50
 	public function getMaxLength() {
51 51
 		return $this->maxLength;
Please login to merge, or discard this patch.
forms/TimeField.php 1 patch
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -50,6 +50,10 @@  discard block
 block discarded – undo
50 50
 	 */
51 51
 	protected $valueObj = null;
52 52
 
53
+	/**
54
+	 * @param string $name
55
+	 * @param string $title
56
+	 */
53 57
 	public function __construct($name, $title = null, $value = ""){
54 58
 		if(!$this->locale) {
55 59
 			$this->locale = i18n::get_locale();
@@ -228,6 +232,9 @@  discard block
 block discarded – undo
228 232
 		return $this->castedCopy('TimeField_Readonly');
229 233
 	}
230 234
 
235
+	/**
236
+	 * @param string $class
237
+	 */
231 238
 	public function castedCopy($class) {
232 239
 		$copy = parent::castedCopy($class);
233 240
 		if($copy->hasMethod('setConfig')) {
Please login to merge, or discard this patch.
forms/TreeDropdownField.php 1 patch
Doc Comments   +2 added lines, -3 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
 	 *
77 77
 	 * @param string $name the field name
78 78
 	 * @param string $title the field label
79
-	 * @param string|array $sourceObject The object-type to list in the tree. This could
79
+	 * @param string $sourceObject The object-type to list in the tree. This could
80 80
 	 * be one of the following:
81 81
 	 * - A DataObject class name with the {@link Hierarchy} extension.
82 82
 	 * - An array of key/value pairs, like a {@link DropdownField} source. In
@@ -385,7 +385,7 @@  discard block
 block discarded – undo
385 385
 	 * If a filter function has been set, that will be called. And if search text is set,
386 386
 	 * filter on that too. Return true if all applicable conditions are true, false otherwise.
387 387
 	 * @param $node
388
-	 * @return unknown_type
388
+	 * @return boolean
389 389
 	 */
390 390
 	public function filterMarking($node) {
391 391
 		if ($this->filterCallback && !call_user_func($this->filterCallback, $node)) return false;
@@ -436,7 +436,6 @@  discard block
 block discarded – undo
436 436
 	}
437 437
 
438 438
 	/**
439
-	 * @param String $field
440 439
 	 */
441 440
 	public function setSourceObject($class) {
442 441
 		$this->sourceObject = $class;
Please login to merge, or discard this patch.