Completed
Push — 3.1 ( 730512...76ce9f )
by Damian
16s
created
forms/gridfield/GridState.php 1 patch
Doc Comments   +2 added lines, -3 removed lines patch added patch discarded remove patch
@@ -24,8 +24,7 @@  discard block
 block discarded – undo
24 24
 	
25 25
 	/**
26 26
 	 *
27
-	 * @param GridField $name
28
-	 * @param string $data - json encoded string
27
+	 * @param GridField $grid
29 28
 	 */
30 29
 	public function __construct($grid, $value = null) {
31 30
 		$this->grid = $grid;
@@ -108,7 +107,7 @@  discard block
 block discarded – undo
108 107
 
109 108
 	/**
110 109
 	 *
111
-	 * @return type 
110
+	 * @return string 
112 111
 	 */
113 112
 	public function __toString() {
114 113
 		return $this->Value();
Please login to merge, or discard this patch.
forms/HtmlEditorField.php 1 patch
Doc Comments   +12 added lines, -2 removed lines patch added patch discarded remove patch
@@ -57,6 +57,7 @@  discard block
 block discarded – undo
57 57
 	
58 58
 	/**
59 59
 	 * @see TextareaField::__construct()
60
+	 * @param string $name
60 61
 	 */
61 62
 	public function __construct($name, $title = null, $value = '') {
62 63
 		parent::__construct($name, $title, $value);
@@ -234,7 +235,7 @@  discard block
 block discarded – undo
234 235
 	/**
235 236
 	 * Searches the SiteTree for display in the dropdown
236 237
 	 *  
237
-	 * @return callback
238
+	 * @return DataList
238 239
 	 */	
239 240
 	public function siteTreeSearchCallback($sourceObject, $labelField, $search) {
240 241
 		return DataObject::get($sourceObject, "\"MenuTitle\" LIKE '%$search%' OR \"Title\" LIKE '%$search%'");
@@ -529,7 +530,7 @@  discard block
 block discarded – undo
529 530
 	/**
530 531
 	 * Find all anchors available on the given page.
531 532
 	 *
532
-	 * @return array
533
+	 * @return string
533 534
 	 */
534 535
 	public function getanchors() {
535 536
 		$id = (int)$this->request->getVar('PageID');
@@ -567,6 +568,7 @@  discard block
 block discarded – undo
567 568
 	 * not the "master record" in the database - hence there's no form or saving logic.
568 569
 	 * 
569 570
 	 * @param String Relative or absolute URL to file
571
+	 * @param HtmlEditorField_File $file
570 572
 	 * @return FieldList
571 573
 	 */
572 574
 	protected function getFieldsForFile($url, $file) {
@@ -588,6 +590,7 @@  discard block
 block discarded – undo
588 590
 	}
589 591
 
590 592
 	/**
593
+	 * @param HtmlEditorField_Embed $file
591 594
 	 * @return FieldList
592 595
 	 */
593 596
 	protected function getFieldsForOembed($url, $file) {
@@ -797,6 +800,7 @@  discard block
 block discarded – undo
797 800
 
798 801
 	/**
799 802
 	 * @param Int
803
+	 * @param integer $parentID
800 804
 	 * @return DataList
801 805
 	 */
802 806
 	protected function getFiles($parentID = null) {
@@ -923,6 +927,9 @@  discard block
 block discarded – undo
923 927
 
924 928
 	protected $oembed;
925 929
 
930
+	/**
931
+	 * @param DataObject $file
932
+	 */
926 933
 	public function __construct($url, $file = null) {
927 934
 		parent::__construct($url, $file);
928 935
 		$this->oembed = Oembed::get_oembed_from_url($url);
@@ -1015,6 +1022,9 @@  discard block
 block discarded – undo
1015 1022
 
1016 1023
 	protected $height;
1017 1024
 
1025
+	/**
1026
+	 * @param DataObject $file
1027
+	 */
1018 1028
 	public function __construct($url, $file = null) {
1019 1029
 		parent::__construct($url, $file);
1020 1030
 
Please login to merge, or discard this patch.
forms/ListboxField.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -204,6 +204,7 @@
 block discarded – undo
204 204
 
205 205
 	/**
206 206
 	 * Load a value into this CheckboxSetField
207
+	 * @param DataObject $obj
207 208
 	 */
208 209
 	public function setValue($val, $obj = null) {
209 210
 		// If we're not passed a value directly, 
Please login to merge, or discard this patch.
forms/LookupField.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -95,7 +95,7 @@
 block discarded – undo
95 95
 	/**
96 96
 	 * Override parent behavior by not merging arrays.
97 97
 	 *
98
-	 * @return array
98
+	 * @return boolean
99 99
 	 */
100 100
 	public function getSource() {
101 101
 		return $this->source;
Please login to merge, or discard this patch.
forms/SelectionGroup.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
 	/**
30 30
 	 * Create a new selection group.
31 31
 	 * 
32
-	 * @param name The field name of the selection group.
32
+	 * @param name string field name of the selection group.
33 33
 	 * @param items The list of {@link SelectionGroup_Item}
34 34
 	 */
35 35
 	public function __construct($name, $items) {
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
 
129 129
 	/**
130 130
 	 * @param String $value Form field identifier
131
-	 * @param FormField $field Contents of the option
131
+	 * @param FormField $fields Contents of the option
132 132
 	 * @param String $title Title to show for the radio button option
133 133
 	 */
134 134
 	function __construct($value, $fields = null, $title = null) {
Please login to merge, or discard this patch.
forms/TabSet.php 1 patch
Doc Comments   +6 added lines, -4 removed lines patch added patch discarded remove patch
@@ -29,8 +29,6 @@  discard block
 block discarded – undo
29 29
 	
30 30
 	/**
31 31
 	 * @param string $name Identifier
32
-	 * @param string $title (Optional) Natural language title of the tabset
33
-	 * @param Tab|TabSet $unknown All further parameters are inserted as children into the TabSet
34 32
 	 */
35 33
 	public function __construct($name) {
36 34
 		$args = func_get_args();
@@ -148,8 +146,8 @@  discard block
 block discarded – undo
148 146
 	/**
149 147
 	 * Inserts a field before a particular field in a FieldList.
150 148
 	 *
151
-	 * @param FormField $item The form field to insert
152
-	 * @param string $name Name of the field to insert before
149
+	 * @param TextField $field
150
+	 * @param string $insertBefore
153 151
 	 */
154 152
 	public function insertBefore($field, $insertBefore) {
155 153
 		parent::insertBefore($field, $insertBefore);
@@ -157,6 +155,10 @@  discard block
 block discarded – undo
157 155
 		$this->sequentialSet = null;
158 156
 	}
159 157
 	
158
+	/**
159
+	 * @param TextField $field
160
+	 * @param string $insertAfter
161
+	 */
160 162
 	public function insertAfter($field, $insertAfter) {
161 163
 		parent::insertAfter($field, $insertAfter);
162 164
 		if($field instanceof Tab) $field->setTabSet($this);
Please login to merge, or discard this patch.
forms/TreeDropdownField.php 1 patch
Doc Comments   +3 added lines, -4 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
 	 *
76 76
 	 * @param string $name the field name
77 77
 	 * @param string $title the field label
78
-	 * @param string|array $sourceObject The object-type to list in the tree. This could
78
+	 * @param string $sourceObject The object-type to list in the tree. This could
79 79
 	 * be one of the following:
80 80
 	 * - A DataObject class name with the {@link Hierarchy} extension.
81 81
 	 * - An array of key/value pairs, like a {@link DropdownField} source. In
@@ -203,7 +203,7 @@  discard block
 block discarded – undo
203 203
 	}
204 204
 
205 205
 	/**
206
-	 * @return string
206
+	 * @return HTMLText
207 207
 	 */
208 208
 	public function Field($properties = array()) {
209 209
 		Requirements::add_i18n_javascript(FRAMEWORK_DIR . '/javascript/lang');
@@ -384,7 +384,7 @@  discard block
 block discarded – undo
384 384
 	 * If a filter function has been set, that will be called. And if search text is set,
385 385
 	 * filter on that too. Return true if all applicable conditions are true, false otherwise.
386 386
 	 * @param $node
387
-	 * @return unknown_type
387
+	 * @return boolean
388 388
 	 */
389 389
 	public function filterMarking($node) {
390 390
 		if ($this->filterCallback && !call_user_func($this->filterCallback, $node)) return false;
@@ -435,7 +435,6 @@  discard block
 block discarded – undo
435 435
 	}
436 436
 
437 437
 	/**
438
-	 * @param String $field
439 438
 	 */
440 439
 	public function setSourceObject($class) {
441 440
 		$this->sourceObject = $class;
Please login to merge, or discard this patch.
forms/UploadField.php 1 patch
Doc Comments   +3 added lines, -5 removed lines patch added patch discarded remove patch
@@ -194,7 +194,6 @@  discard block
 block discarded – undo
194 194
 	 * @param string $title The field label.
195 195
 	 * @param SS_List $items If no items are defined, the field will try to auto-detect an existing relation on
196 196
 	 *                       @link $record}, with the same name as the field name.
197
-	 * @param Form $form Reference to the container form
198 197
 	 */
199 198
 	public function __construct($name, $title = null, SS_List $items = null) {
200 199
 		
@@ -600,7 +599,6 @@  discard block
 block discarded – undo
600 599
 	 * for each of these categories
601 600
 	 * 
602 601
 	 * @param string $category Category name
603
-	 * @param string,... $categories Additional category names
604 602
 	 * @return UploadField Self reference
605 603
 	 */
606 604
 	public function setAllowedFileCategories($category) {
@@ -1086,7 +1084,7 @@  discard block
 block discarded – undo
1086 1084
 
1087 1085
 	/**
1088 1086
 	 * @param SS_HTTPRequest $request
1089
-	 * @return UploadField_ItemHandler
1087
+	 * @return UploadField_SelectHandler
1090 1088
 	 */
1091 1089
 	public function handleSelect(SS_HTTPRequest $request) {
1092 1090
 		if(!$this->canAttachExisting()) return $this->httpError(403);
@@ -1380,7 +1378,7 @@  discard block
 block discarded – undo
1380 1378
 
1381 1379
 	/**
1382 1380
 	 * @param UploadFIeld $parent
1383
-	 * @param int $item
1381
+	 * @param int $itemID
1384 1382
 	 */
1385 1383
 	public function __construct($parent, $itemID) {
1386 1384
 		$this->parent = $parent;
@@ -1449,7 +1447,7 @@  discard block
 block discarded – undo
1449 1447
 	 * Action to handle editing of a single file
1450 1448
 	 * 
1451 1449
 	 * @param SS_HTTPRequest $request
1452
-	 * @return ViewableData_Customised
1450
+	 * @return HTMLText
1453 1451
 	 */
1454 1452
 	public function edit(SS_HTTPRequest $request) {
1455 1453
 		// Check form field state
Please login to merge, or discard this patch.
forms/Validator.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -109,6 +109,7 @@
 block discarded – undo
109 109
 	 * Used by FormField to return a value for FormField::Required(), to do things like show *s on the form template.
110 110
 	 *
111 111
 	 * By default, it always returns false.
112
+	 * @param string $fieldName
112 113
 	 */
113 114
 	public function fieldIsRequired($fieldName) {
114 115
 		return false;
Please login to merge, or discard this patch.