Completed
Pull Request — 3.6 (#7662)
by Daniel
08:33
created
model/Aggregate.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,6 +47,7 @@  discard block
 block discarded – undo
47 47
 	/**
48 48
 	 * Clear the aggregate cache for a given type, or pass nothing to clear all aggregate caches.
49 49
 	 * {@link $class} is just effective if the cache backend supports tags.
50
+	 * @param string $class
50 51
 	 */
51 52
 	public static function flushCache($class=null) {
52 53
 		$cache = self::cache();
@@ -85,7 +86,7 @@  discard block
 block discarded – undo
85 86
 	 * Build the SQLSelect to calculate the aggregate
86 87
 	 * This is a seperate function so that subtypes of Aggregate can change just this bit
87 88
 	 * @param string $attr - the SQL field statement for selection (i.e. "MAX(LastUpdated)")
88
-	 * @return SQLSelect
89
+	 * @return DataList
89 90
 	 */
90 91
 	protected function query($attr) {
91 92
 		$query = DataList::create($this->type)->where($this->filter);
Please login to merge, or discard this patch.
model/DataQuery.php 1 patch
Doc Comments   +10 added lines, -2 removed lines patch added patch discarded remove patch
@@ -44,6 +44,7 @@  discard block
 block discarded – undo
44 44
 	 * Create a new DataQuery.
45 45
 	 *
46 46
 	 * @param String The name of the DataObject class that you wish to query
47
+	 * @param string $dataClass
47 48
 	 */
48 49
 	public function __construct($dataClass) {
49 50
 		$this->dataClass = $dataClass;
@@ -166,7 +167,7 @@  discard block
 block discarded – undo
166 167
 	/**
167 168
 	 * Ensure that the query is ready to execute.
168 169
 	 *
169
-	 * @param array|null $queriedColumns Any columns to filter the query by
170
+	 * @param string[] $queriedColumns Any columns to filter the query by
170 171
 	 * @return SQLQuery The finalised sql query
171 172
 	 */
172 173
 	public function getFinalisedQuery($queriedColumns = null) {
@@ -664,7 +665,7 @@  discard block
 block discarded – undo
664 665
 	 * mappings to the query object state. This has to be called
665 666
 	 * in any overloaded {@link SearchFilter->apply()} methods manually.
666 667
 	 *
667
-	 * @param String|array $relation The array/dot-syntax relation to follow
668
+	 * @param string $relation The array/dot-syntax relation to follow
668 669
 	 * @return The model class of the related item
669 670
 	 */
670 671
 	public function applyRelation($relation) {
@@ -844,6 +845,7 @@  discard block
 block discarded – undo
844 845
 
845 846
 	/**
846 847
 	 * Set an arbitrary query parameter, that can be used by decorators to add additional meta-data to the query.
848
+	 * @param string $key
847 849
 	 */
848 850
 	public function getQueryParam($key) {
849 851
 		if(isset($this->queryParams[$key])) return $this->queryParams[$key];
@@ -878,6 +880,9 @@  discard block
 block discarded – undo
878 880
 	 */
879 881
 	protected $whereQuery;
880 882
 
883
+	/**
884
+	 * @param string $connective
885
+	 */
881 886
 	public function __construct(DataQuery $base, $connective) {
882 887
 		$this->dataClass = $base->dataClass;
883 888
 		$this->query = $base->query;
@@ -887,6 +892,9 @@  discard block
 block discarded – undo
887 892
 		$base->where($this);
888 893
 	}
889 894
 
895
+	/**
896
+	 * @param string $filter
897
+	 */
890 898
 	public function where($filter) {
891 899
 		if($filter) {
892 900
 			$this->whereQuery->addWhere($filter);
Please login to merge, or discard this patch.
model/fieldtypes/Currency.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -23,6 +23,9 @@  discard block
 block discarded – undo
23 23
 	 */
24 24
 	private static $currency_symbol = '$';
25 25
 
26
+	/**
27
+	 * @param string $name
28
+	 */
26 29
 	public function __construct($name = null, $wholeSize = 9, $decimalSize = 2, $defaultValue = 0) {
27 30
 		parent::__construct($name, $wholeSize, $decimalSize, $defaultValue);
28 31
 	}
@@ -46,6 +49,9 @@  discard block
 block discarded – undo
46 49
 		else return $val;
47 50
 	}
48 51
 
52
+	/**
53
+	 * @param string $value
54
+	 */
49 55
 	public function setValue($value, $record = null) {
50 56
 		$matches = null;
51 57
 		if(is_numeric($value)) {
Please login to merge, or discard this patch.
model/fieldtypes/Date.php 1 patch
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -28,6 +28,9 @@  discard block
 block discarded – undo
28 28
 	private static $nice_format = 'd/m/Y';
29 29
 
30 30
 
31
+	/**
32
+	 * @param string|null $value
33
+	 */
31 34
 	public function setValue($value, $record = null) {
32 35
 		if($value === false || $value === null || (is_string($value) && !strlen($value))) {
33 36
 			// don't try to evaluate empty values with strtotime() below, as it returns "1970-01-01" when it should be
@@ -110,7 +113,7 @@  discard block
 block discarded – undo
110 113
 
111 114
 	/**
112 115
 	 * Returns the day of the month.
113
-	 * @param boolean $includeOrdinals Include ordinal suffix to day, e.g. "th" or "rd"
116
+	 * @param boolean $includeOrdinal Include ordinal suffix to day, e.g. "th" or "rd"
114 117
 	 * @return string
115 118
 	 */
116 119
 	public function DayOfMonth($includeOrdinal = false) {
@@ -164,7 +167,7 @@  discard block
 block discarded – undo
164 167
 	 * Return a date formatted as per a CMS user's settings.
165 168
 	 *
166 169
 	 * @param Member $member
167
-	 * @return boolean | string A date formatted as per user-defined settings.
170
+	 * @return false|string | string A date formatted as per user-defined settings.
168 171
 	 */
169 172
 	public function FormatFromSettings($member = null) {
170 173
 		require_once 'Zend/Date.php';
Please login to merge, or discard this patch.
model/fieldtypes/DBField.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -209,6 +209,9 @@
 block discarded – undo
209 209
 
210 210
 	}
211 211
 
212
+	/**
213
+	 * @param string $tableName
214
+	 */
212 215
 	public function setTable($tableName) {
213 216
 		$this->tableName = $tableName;
214 217
 	}
Please login to merge, or discard this patch.
model/URLSegmentFilter.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -129,6 +129,7 @@
 block discarded – undo
129 129
 
130 130
 	/**
131 131
 	 * @param boolean
132
+	 * @param boolean $bool
132 133
 	 */
133 134
 	public function setAllowMultibyte($bool) {
134 135
 		$this->allowMultibyte = $bool;
Please login to merge, or discard this patch.
thirdparty/jstree/_demo/_inc/class._database_i.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -92,6 +92,9 @@
 block discarded – undo
92 92
 		return $return;
93 93
 	}
94 94
 
95
+	/**
96
+	 * @param boolean $index
97
+	 */
95 98
 	function f($index) {
96 99
 		return stripslashes($this->row[$index]);
97 100
 	}
Please login to merge, or discard this patch.
view/Requirements.php 1 patch
Doc Comments   +6 added lines, -4 removed lines patch added patch discarded remove patch
@@ -63,6 +63,7 @@  discard block
 block discarded – undo
63 63
 	 * while automatically busting this cache every time the file is changed.
64 64
 	 *
65 65
 	 * @param bool
66
+	 * @param boolean $var
66 67
 	 */
67 68
 	public static function set_suffix_requirements($var) {
68 69
 		self::backend()->set_suffix_requirements($var);
@@ -123,7 +124,7 @@  discard block
 block discarded – undo
123 124
 	/**
124 125
 	 * Return all registered custom scripts
125 126
 	 *
126
-	 * @return array
127
+	 * @return string
127 128
 	 */
128 129
 	public static function get_custom_scripts() {
129 130
 		return self::backend()->get_custom_scripts();
@@ -531,7 +532,7 @@  discard block
 block discarded – undo
531 532
 	/**
532 533
 	 * Enable or disable the combination of CSS and JavaScript files
533 534
 	 *
534
-	 * @param $enable
535
+	 * @param boolean $enable
535 536
 	 */
536 537
 	public function set_combined_files_enabled($enable) {
537 538
 		$this->combined_files_enabled = (bool) $enable;
@@ -599,6 +600,7 @@  discard block
 block discarded – undo
599 600
 	 * Forces the JavaScript requirements to the end of the body, right before the closing tag
600 601
 	 *
601 602
 	 * @param bool
603
+	 * @param boolean $var
602 604
 	 */
603 605
 	public function set_force_js_to_bottom($var) {
604 606
 		$this->force_js_to_bottom = $var;
@@ -638,7 +640,7 @@  discard block
 block discarded – undo
638 640
 	/**
639 641
 	 * Return all registered custom scripts
640 642
 	 *
641
-	 * @return array
643
+	 * @return string
642 644
 	 */
643 645
 	public function get_custom_scripts() {
644 646
 		$requirements = "";
@@ -1051,7 +1053,7 @@  discard block
 block discarded – undo
1051 1053
 	 * @param array  $files            Array of filenames relative to docroot
1052 1054
 	 * @param string $media
1053 1055
 	 *
1054
-	 * @return bool|void
1056
+	 * @return false|null
1055 1057
 	 */
1056 1058
 	public function combine_files($combinedFileName, $files, $media = null) {
1057 1059
 		// duplicate check
Please login to merge, or discard this patch.
core/Config.php 1 patch
Doc Comments   +23 added lines, -9 removed lines patch added patch discarded remove patch
@@ -470,11 +470,17 @@  discard block
 block discarded – undo
470 470
 
471 471
 	protected $extraConfigSources = array();
472 472
 
473
+	/**
474
+	 * @param string $class
475
+	 */
473 476
 	public function extraConfigSourcesChanged($class) {
474 477
 		unset($this->extraConfigSources[$class]);
475 478
 		$this->cache->clean("__{$class}");
476 479
 	}
477 480
 
481
+	/**
482
+	 * @param integer $sourceOptions
483
+	 */
478 484
 	protected function getUncached($class, $name, $sourceOptions, &$result, $suppress, &$tags) {
479 485
 		$tags[] = "__{$class}";
480 486
 		$tags[] = "__{$class}__{$name}";
@@ -648,15 +654,6 @@  discard block
 block discarded – undo
648 654
 	 *
649 655
 	 * @param string $class The class to remove a configuration value from
650 656
 	 * @param string $name The configuration name
651
-	 * @param mixed $key An optional key to filter against.
652
-	 *   If referenced config value is an array, only members of that array that match this key will be removed
653
-	 *   Must also match value if provided to be removed
654
-	 * @param mixed $value And optional value to filter against.
655
-	 *   If referenced config value is an array, only members of that array that match this value will be removed
656
-	 *   If referenced config value is not an array, value will be removed only if it matches this argument
657
-	 *   Must also match key if provided and referenced config value is an array to be removed
658
-	 *
659
-	 * Matching is always by "==", not by "==="
660 657
 	 */
661 658
 	public function remove($class, $name /*,$key = null*/ /*,$value = null*/) {
662 659
 		$argc = func_num_args();
@@ -735,6 +732,10 @@  discard block
 block discarded – undo
735 732
 		$this->cache = $cloned;
736 733
 	}
737 734
 
735
+	/**
736
+	 * @param integer $key
737
+	 * @param integer $val
738
+	 */
738 739
 	public function set($key, $val, $tags = array()) {
739 740
 		// Find an index to set at
740 741
 		$replacing = null;
@@ -803,6 +804,9 @@  discard block
 block discarded – undo
803 804
 		}
804 805
 	}
805 806
 
807
+	/**
808
+	 * @param string $tag
809
+	 */
806 810
 	public function clean($tag = null) {
807 811
 		if ($tag) {
808 812
 			foreach ($this->cache as $i => $v) {
@@ -834,6 +838,10 @@  discard block
 block discarded – undo
834 838
 		$this->cache = array();
835 839
 	}
836 840
 
841
+	/**
842
+	 * @param integer $key
843
+	 * @param integer $val
844
+	 */
837 845
 	public function set($key, $val, $tags = array()) {
838 846
 		foreach($tags as $t) {
839 847
 			if(!isset($this->tags[$t])) {
@@ -852,6 +860,9 @@  discard block
 block discarded – undo
852 860
 		return $this->miss ? ($this->hit / $this->miss) : 0;
853 861
 	}
854 862
 
863
+	/**
864
+	 * @param integer $key
865
+	 */
855 866
 	public function get($key) {
856 867
 		list($hit, $result) = $this->checkAndGet($key);
857 868
 		return $hit ? $result : false;
@@ -871,6 +882,9 @@  discard block
 block discarded – undo
871 882
 		}
872 883
 	}
873 884
 
885
+	/**
886
+	 * @param string $tag
887
+	 */
874 888
 	public function clean($tag = null) {
875 889
 		if($tag) {
876 890
 			if(isset($this->tags[$tag])) {
Please login to merge, or discard this patch.