ShortcodeParserTest - Code Metrics - Inspection of "Merge 3.4.3 into 3.4" - silverstripe/silverstripe-framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 3.4 ( fd9b87...94c3bc )

by Damian

created 2016-12-22 00:28 UTC

ShortcodeParserTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	300
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
dl	0
loc	300
rs	10
c	0
b	0
f	0
wmc	25
lcom	1
cbo	2

23 Methods

Rating	Name	Size	Complexity
A	setUp()	6	1
B	testNotRegisteredShortcode()	38	1
A	testSimpleTag()	15	2
A	testOneArgument()	15	2
A	testMultipleArguments()	7	1
A	testEnclosing()	7	1
A	testEnclosingWithArguments()	7	1
B	testShortcodeEscaping()	37	1
A	testUnquotedArguments()	4	1
A	testSpacesForDelimiter()	4	1
A	testSelfClosingTag()	9	1
A	testConsecutiveTags()	3	1
A	assertEqualsIgnoringWhitespace()	3	1
A	tearDown()	5	1
A	testtExtractBefore()	14	1
A	testExtractSplit()	18	1
A	testExtractNone()	7	1
A	testShortcodesInsideScriptTag()	6	1
A	testFalseyArguments()	7	1
B	testNumericShortcodes()	25	1
A	testExtraContext()	7	1
A	testNoParseAttemptIfNoCode()	11	1
A	shortcodeSaver()	8	1

<?php
/**
 * @package framework
 * @subpackage tests
 */
class ShortcodeParserTest extends SapphireTest {

	protected $arguments, $contents, $tagName, $parser;

	protected $extra = array();

	public function setUp() {
		ShortcodeParser::get('test')->register('test_shortcode', array($this, 'shortcodeSaver'));
		$this->parser = ShortcodeParser::get('test');

		parent::setUp();
	}

	public function tearDown() {
		ShortcodeParser::get('test')->unregister('test_shortcode');

		parent::tearDown();
	}

	/**
	 * Tests that valid short codes that have not been registered are not replaced.
	 */
	public function testNotRegisteredShortcode() {
		ShortcodeParser::$error_behavior = ShortcodeParser::STRIP;

		$this->assertEquals(

			'',
			$this->parser->parse('[not_shortcode]')
		);

		$this->assertEquals(

			'<img class="">',
			$this->parser->parse('<img class="[not_shortcode]">')
		);

		ShortcodeParser::$error_behavior = ShortcodeParser::WARN;

		$this->assertEquals(

			'<strong class="warning">[not_shortcode]</strong>',
			$this->parser->parse('[not_shortcode]')
		);

		ShortcodeParser::$error_behavior = ShortcodeParser::LEAVE;

		$this->assertEquals('[not_shortcode]',

			$this->parser->parse('[not_shortcode]'));
		$this->assertEquals('[not_shortcode /]',

			$this->parser->parse('[not_shortcode /]'));
		$this->assertEquals('[not_shortcode,foo="bar"]',

			$this->parser->parse('[not_shortcode,foo="bar"]'));
		$this->assertEquals('[not_shortcode]a[/not_shortcode]',

			$this->parser->parse('[not_shortcode]a[/not_shortcode]'));
		$this->assertEquals('[/not_shortcode]',

			$this->parser->parse('[/not_shortcode]'));

		$this->assertEquals(

			'<img class="[not_shortcode]">',
			$this->parser->parse('<img class="[not_shortcode]">')
		);
	}

	public function testSimpleTag() {
		$tests = array(
			'[test_shortcode]',
			'[test_shortcode ]', '[test_shortcode,]', '[test_shortcode, ]'.
			'[test_shortcode/]', '[test_shortcode /]', '[test_shortcode,/]', '[test_shortcode, /]'
		);

		foreach($tests as $test) {
			$this->parser->parse($test);

			$this->assertEquals(array(), $this->arguments, $test);

			$this->assertEquals('', $this->contents, $test);

			$this->assertEquals('test_shortcode', $this->tagName, $test);

		}
	}

	public function testOneArgument() {
		$tests = array (
			'[test_shortcode foo="bar"]', '[test_shortcode,foo="bar"]',
			"[test_shortcode foo='bar']", "[test_shortcode,foo='bar']",
			'[test_shortcode  foo  =  "bar"  /]', '[test_shortcode,  foo  =  "bar"  /]'
		);

		foreach($tests as $test) {
			$this->parser->parse($test);

			$this->assertEquals(array('foo' => 'bar'), $this->arguments, $test);

			$this->assertEquals('', $this->contents, $test);

			$this->assertEquals('test_shortcode', $this->tagName, $test);

		}
	}

	public function testMultipleArguments() {
		$this->parser->parse('[test_shortcode foo = "bar",bar=\'foo\', baz="buz"]');

		$this->assertEquals(array('foo' => 'bar', 'bar' => 'foo', 'baz' => 'buz'), $this->arguments);

		$this->assertEquals('', $this->contents);

		$this->assertEquals('test_shortcode', $this->tagName);

	}

	public function testEnclosing() {
		$this->parser->parse('[test_shortcode]foo[/test_shortcode]');

		$this->assertEquals(array(), $this->arguments);

		$this->assertEquals('foo', $this->contents);

		$this->assertEquals('test_shortcode', $this->tagName);

	}

	public function testEnclosingWithArguments() {
		$this->parser->parse('[test_shortcode,foo = "bar",bar=\'foo\',baz="buz"]foo[/test_shortcode]');

		$this->assertEquals(array('foo' => 'bar', 'bar' => 'foo', 'baz' => 'buz'), $this->arguments);

		$this->assertEquals('foo', $this->contents);

		$this->assertEquals('test_shortcode', $this->tagName);

	}

	public function testShortcodeEscaping() {
		$this->assertEquals(

			'[test_shortcode]',
			$this->parser->parse('[[test_shortcode]]')
		);

		$this->assertEquals(

			'[test_shortcode /]',
			$this->parser->parse('[[test_shortcode /]]')
		);

		$this->assertEquals(

			'[test_shortcode]content[/test_shortcode]',
			$this->parser->parse('[[test_shortcode]content[/test_shortcode]]'
		));

		$this->assertEquals(

			'[test_shortcode]content',
			$this->parser->parse('[[test_shortcode]][test_shortcode]content[/test_shortcode]')
		);

		$this->assertEquals(

			'[test_shortcode]content[/test_shortcode]content2',
			$this->parser->parse('[[test_shortcode]content[/test_shortcode]][test_shortcode]content2[/test_shortcode]'
		));

		$this->assertEquals(

			'[[Doesnt strip double [ character if not a shortcode',
			$this->parser->parse('[[Doesnt strip double [ character if not a [test_shortcode]shortcode[/test_shortcode]'
		));

		$this->assertEquals(

			'[[Doesnt shortcode get confused by double ]] characters',
			$this->parser->parse(
				'[[Doesnt [test_shortcode]shortcode[/test_shortcode] get confused by double ]] characters')
		);
	}

	public function testUnquotedArguments() {
		$this->assertEquals('', $this->parser->parse('[test_shortcode,foo=bar!,baz = buz123]'));

		$this->assertEquals(array('foo' => 'bar!', 'baz' => 'buz123'), $this->arguments);

	}

	public function testSpacesForDelimiter() {
		$this->assertEquals('', $this->parser->parse('[test_shortcode foo=bar! baz = buz123]'));

		$this->assertEquals(array('foo' => 'bar!', 'baz' => 'buz123'), $this->arguments);

	}

	public function testSelfClosingTag() {
		$this->assertEquals (

			'morecontent',
			$this->parser->parse('[test_shortcode,id="1"/]more[test_shortcode,id="2"]content[/test_shortcode]'),
			'Assert that self-closing tags are respected during parsing.'
		);

		$this->assertEquals(2, $this->arguments['id']);

	}

	public function testConsecutiveTags() {
		$this->assertEquals('', $this->parser->parse('[test_shortcode][test_shortcode]'));

	}

	protected function assertEqualsIgnoringWhitespace($a, $b, $message = null) {
		$this->assertEquals(preg_replace('/\s+/', '', $a), preg_replace('/\s+/', '', $b), $message);

	}

	public function testtExtractBefore()
	{
		// Left extracts to before the current block
		$this->assertEqualsIgnoringWhitespace(
			'Code<div>FooBar</div>',
			$this->parser->parse('<div>Foo[test_shortcode class=left]Code[/test_shortcode]Bar</div>')
		);

		// Even if the immediate parent isn't a the current block
		$this->assertEqualsIgnoringWhitespace(
			'Code<div>Foo<b>BarBaz</b>Qux</div>',
			$this->parser->parse('<div>Foo<b>Bar[test_shortcode class=left]Code[/test_shortcode]Baz</b>Qux</div>')
		);
	}

	public function testExtractSplit()
	{
		$this->markTestSkipped(
			'Feature disabled due to https://github.com/silverstripe/silverstripe-framework/issues/5987'
		);

		// Center splits the current block
		$this->assertEqualsIgnoringWhitespace(
			'<div>Foo</div>Code<div>Bar</div>',
			$this->parser->parse('<div>Foo[test_shortcode class=center]Code[/test_shortcode]Bar</div>')
		);

		// Even if the immediate parent isn't a the current block
		$this->assertEqualsIgnoringWhitespace(
			'<div>Foo<b>Bar</b></div>Code<div><b>Baz</b>Qux</div>',
			$this->parser->parse('<div>Foo<b>Bar[test_shortcode class=center]Code[/test_shortcode]Baz</b>Qux</div>')
		);
	}

	public function testExtractNone() {
		// No class means don't extract
		$this->assertEqualsIgnoringWhitespace(
			'<div>FooCodeBar</div>',
			$this->parser->parse('<div>Foo[test_shortcode]Code[/test_shortcode]Bar</div>')
		);
	}

	public function testShortcodesInsideScriptTag() {
		$this->assertEqualsIgnoringWhitespace(
			'<script>hello</script>',
			$this->parser->parse('<script>[test_shortcode]hello[/test_shortcode]</script>')
		);
	}

	public function testFalseyArguments() {
		$this->parser->parse('<p>[test_shortcode falsey=0]');

		$this->assertEquals(array(

			'falsey' => '',
		), $this->arguments);
	}

	public function testNumericShortcodes() {
		$this->assertEqualsIgnoringWhitespace(
			'[2]',
			$this->parser->parse('[2]')
		);
		$this->assertEqualsIgnoringWhitespace(
			'<script>[2]</script>',
			$this->parser->parse('<script>[2]</script>')
		);

		$this->parser->register('2', function($attributes, $content, $this, $tag, $extra) {

			return 'this is 2';
		});

		$this->assertEqualsIgnoringWhitespace(
			'this is 2',
			$this->parser->parse('[2]')
		);
		$this->assertEqualsIgnoringWhitespace(
			'<script>this is 2</script>',
			$this->parser->parse('<script>[2]</script>')
		);

		$this->parser->unregister('2');
	}

	public function testExtraContext() {
		$this->parser->parse('<a href="[test_shortcode]">Test</a>');

		$this->assertInstanceOf('DOMNode', $this->extra['node']);
		$this->assertInstanceOf('DOMElement', $this->extra['element']);
		$this->assertEquals($this->extra['element']->tagName, 'a');

	}

	public function testNoParseAttemptIfNoCode() {
		$stub = $this->getMock('ShortcodeParser', array('replaceElementTagsWithMarkers'));
		$stub->register('test', function() {
			return '';
		});

		$stub->expects($this->never())
			->method('replaceElementTagsWithMarkers')->will($this->returnValue(array('', '')));

		$stub->parse('<p>test</p>');
	}

	// -----------------------------------------------------------------------------------------------------------------

	/**
	 * Stores the result of a shortcode parse in object properties for easy testing access.
	 */
	public function shortcodeSaver($arguments, $content, $parser, $tagName, $extra) {
		$this->arguments = $arguments;
		$this->contents = $content;
		$this->tagName = $tagName;
		$this->extra = $extra;

		return $content;
	}

}


1			<?php
2			/**
3			* @package framework
4			* @subpackage tests
5			*/
6			class ShortcodeParserTest extends SapphireTest {
7
8			protected $arguments, $contents, $tagName, $parser;
			0 ignored issues – show Coding Style introduced 2015-11-25 21:50 UTC by Report Bug Copy Issue Report It is generally advisable to only define one property per statement. Only declaring a single property per statement allows you to later on add doc comments more easily. It is also recommended by PSR2, so it is a common style that many people expect. Loading history...
9			protected $extra = array();
10
11			public function setUp() {
12			ShortcodeParser::get('test')->register('test_shortcode', array($this, 'shortcodeSaver'));
13			$this->parser = ShortcodeParser::get('test');
14
15			parent::setUp();
16			}
17
18			public function tearDown() {
19			ShortcodeParser::get('test')->unregister('test_shortcode');
20
21			parent::tearDown();
22			}
23
24			/**
25			* Tests that valid short codes that have not been registered are not replaced.
26			*/
27			public function testNotRegisteredShortcode() {
28			ShortcodeParser::$error_behavior = ShortcodeParser::STRIP;
29
30			$this->assertEquals(
			0 ignored issues – show Bug introduced 2016-09-13 22:09 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not exist on `ShortcodeParserTest`. Did you maybe mean `assertEqualsIgnoringWhitespace()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
31			'',
32			$this->parser->parse('[not_shortcode]')
33			);
34
35			$this->assertEquals(
			0 ignored issues – show Bug introduced 2016-09-13 22:09 UTC by Report Bug Copy Issue Report The method `assertEquals()` does not exist on `ShortcodeParserTest`. Did you maybe mean `assertEqualsIgnoringWhitespace()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
36			'<img class="">',
37			$this->parser->parse('<img class="[not_shortcode]">')

silverstripe / silverstripe-framework

Push — 3.4 ( fd9b87...94c3bc )

ShortcodeParserTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

23 Methods

Duplication Side-by-Side

Filter issues like