MySQLQuery::keyedColumn() - Code Metrics - Inspection of "Revert "Optimised keyedColumn() and map() for MySQ..." - silverstripe/silverstripe-framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#6435)

by Damian

created 2016-12-21 01:48 UTC

MySQLQuery::keyedColumn() A

↳ Parent: Project

Complexity

Conditions	3
Paths	2

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	7
nc	2
nop	0
dl	0
loc	11
rs	9.4285
c	0
b	0
f	0

<?php

namespace SilverStripe\ORM\Connect;

/**
 * A result-set from a MySQL database (using MySQLiConnector)
 */
class MySQLQuery extends Query
{

    /**
     * The internal MySQL handle that points to the result set.
     * Select queries will have mysqli_result as a value.
     * Non-select queries will not
     *
     * @var mixed
     */
    protected $handle;

    /**
     * Hook the result-set given into a Query class, suitable for use by SilverStripe.
     *
     * @param MySQLiConnector $database The database object that created this query.
     * @param mixed $handle the internal mysql handle that is points to the resultset.
     * Non-mysqli_result values could be given for non-select queries (e.g. true)
     */
    public function __construct($database, $handle)

    {
        $this->handle = $handle;
    }

    public function __destruct()
    {
        if (is_object($this->handle)) {
            $this->handle->free();
        }
    }

    public function seek($row)
    {
        if (is_object($this->handle)) {
            return $this->handle->data_seek($row);
        }
        return null;
    }

    public function numRecords()
    {
        if (is_object($this->handle)) {
            return $this->handle->num_rows;
        }
        return null;
    }

    public function nextRecord()
    {
        if (is_object($this->handle) && ($data = $this->handle->fetch_assoc())) {
            return $data;
        } else {
            return false;
        }
    }
}


1			<?php
2
3			namespace SilverStripe\ORM\Connect;
4
5			/**
6			* A result-set from a MySQL database (using MySQLiConnector)
7			*/
8			class MySQLQuery extends Query
9			{
10
11			/**
12			* The internal MySQL handle that points to the result set.
13			* Select queries will have mysqli_result as a value.
14			* Non-select queries will not
15			*
16			* @var mixed
17			*/
18			protected $handle;
19
20			/**
21			* Hook the result-set given into a Query class, suitable for use by SilverStripe.
22			*
23			* @param MySQLiConnector $database The database object that created this query.
24			* @param mixed $handle the internal mysql handle that is points to the resultset.
25			* Non-mysqli_result values could be given for non-select queries (e.g. true)
26			*/
27			public function __construct($database, $handle)
			0 ignored issues – show Unused Code introduced 2016-11-01 00:55 UTC by Report Bug Copy Issue Report The parameter `$database` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
28			{
29			$this->handle = $handle;
30			}
31
32			public function __destruct()
33			{
34			if (is_object($this->handle)) {
35			$this->handle->free();
36			}
37			}
38
39			public function seek($row)
40			{
41			if (is_object($this->handle)) {
42			return $this->handle->data_seek($row);
43			}
44			return null;
45			}
46
47			public function numRecords()
48			{
49			if (is_object($this->handle)) {
50			return $this->handle->num_rows;
51			}
52			return null;
53			}
54
55			public function nextRecord()
56			{
57			if (is_object($this->handle) && ($data = $this->handle->fetch_assoc())) {
58			return $data;
59			} else {
60			return false;
61			}
62			}
63			}
64

silverstripe / silverstripe-framework

Pull Request — master (#6435)

MySQLQuery::keyedColumn() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like