Completed
Pull Request — master (#5258)
by Sean
11:38
created
forms/MoneyField.php 1 patch
Doc Comments   +6 added lines, -1 removed lines patch added patch discarded remove patch
@@ -36,6 +36,10 @@  discard block
 block discarded – undo
36 36
 	 */
37 37
 	protected $fieldCurrency = null;
38 38
 
39
+	/**
40
+	 * @param string $name
41
+	 * @param string $title
42
+	 */
39 43
 	public function __construct($name, $title = null, $value = "") {
40 44
 		// naming with underscores to prevent values from actually being saved somewhere
41 45
 		$this->fieldAmount = new NumericField("{$name}[Amount]", _t('MoneyField.FIELDLABELAMOUNT', 'Amount'));
@@ -46,7 +50,7 @@  discard block
 block discarded – undo
46 50
 
47 51
 	/**
48 52
 	 * @param array
49
-	 * @return HTMLText
53
+	 * @return DBField
50 54
 	 */
51 55
 	public function Field($properties = array()) {
52 56
 		return DBField::create_field('HTMLText',
@@ -139,6 +143,7 @@  discard block
 block discarded – undo
139 143
 	/**
140 144
 	 * @todo Implement removal of readonly state with $bool=false
141 145
 	 * @todo Set readonly state whenever field is recreated, e.g. in setAllowedCurrencies()
146
+	 * @param boolean $bool
142 147
 	 */
143 148
 	public function setReadonly($bool) {
144 149
 		parent::setReadonly($bool);
Please login to merge, or discard this patch.
filesystem/File.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -248,7 +248,7 @@  discard block
 block discarded – undo
248 248
 	 *
249 249
 	 * @param array $args Array of input shortcode arguments
250 250
 	 * @param int $errorCode If the file is not found, or is inaccessible, this will be assigned to a HTTP error code.
251
-	 * @return File|null The File DataObject, if it can be found.
251
+	 * @return null|DataObject The File DataObject, if it can be found.
252 252
 	 */
253 253
 	public static function find_shortcode_record($args, &$errorCode = null) {
254 254
 		// Validate shortcode
@@ -617,7 +617,7 @@  discard block
 block discarded – undo
617 617
 	 *
618 618
 	 * @param string $condition The PHP condition to be evaluated.  The page will be called $item
619 619
 	 * @param array $collator An array, passed by reference, to collect all of the matching descendants.
620
-	 * @return true|null
620
+	 * @return boolean|null
621 621
 	 */
622 622
 	public function collateDescendants($condition, &$collator) {
623 623
 		if($children = $this->Children()) {
@@ -978,6 +978,7 @@  discard block
 block discarded – undo
978 978
 	 *
979 979
 	 * @param String File extension, without dot prefix. Use an asterisk ('*')
980 980
 	 * to specify a generic fallback if no mapping is found for an extension.
981
+	 * @param string $ext
981 982
 	 * @return String Classname for a subclass of {@link File}
982 983
 	 */
983 984
 	public static function get_class_for_file_extension($ext) {
@@ -1115,7 +1116,6 @@  discard block
 block discarded – undo
1115 1116
 	 * Note that the result will not have a leading slash, and should not be used
1116 1117
 	 * with local file paths.
1117 1118
 	 *
1118
-	 * @param string $part,... Parts
1119 1119
 	 * @return string
1120 1120
 	 */
1121 1121
 	public static function join_paths() {
Please login to merge, or discard this patch.
core/Extension.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@
 block discarded – undo
59 59
 	/**
60 60
 	 * Set the owner of this extension.
61 61
 	 *
62
-	 * @param Object $owner The owner object,
62
+	 * @param null|DataObject $owner The owner object,
63 63
 	 * @param string $ownerBaseClass The base class that the extension is applied to; this may be
64 64
 	 * the class of owner, or it may be a parent.  For example, if Versioned was applied to SiteTree,
65 65
 	 * and then a Page object was instantiated, $owner would be a Page object, but $ownerBaseClass
Please login to merge, or discard this patch.
model/DataObject.php 1 patch
Doc Comments   +9 added lines, -4 removed lines patch added patch discarded remove patch
@@ -551,8 +551,8 @@  discard block
 block discarded – undo
551 551
 
552 552
 	/**
553 553
 	 * Helper function to duplicate relations from one object to another
554
-	 * @param $sourceObject the source object to duplicate from
555
-	 * @param $destinationObject the destination object to populate with the duplicated relations
554
+	 * @param DataObject $sourceObject the source object to duplicate from
555
+	 * @param DataObject $destinationObject the destination object to populate with the duplicated relations
556 556
 	 * @param $name the name of the relation to duplicate (e.g. members)
557 557
 	 */
558 558
 	private function duplicateRelations($sourceObject, $destinationObject, $name) {
@@ -932,6 +932,7 @@  discard block
 block discarded – undo
932 932
 	 * @param $includeRelations Boolean Merge any existing relations (optional)
933 933
 	 * @param $overwriteWithEmpty Boolean Overwrite existing left values with empty right values.
934 934
 	 *                            Only applicable with $priority='right'. (optional)
935
+	 * @param DataObject|null $rightObj
935 936
 	 * @return Boolean
936 937
 	 */
937 938
 	public function merge($rightObj, $priority = 'right', $includeRelations = true, $overwriteWithEmpty = false) {
@@ -2201,6 +2202,7 @@  discard block
 block discarded – undo
2201 2202
 	 *
2202 2203
 	 * This is experimental, and is currently only a Postgres-specific enhancement.
2203 2204
 	 *
2205
+	 * @param string $class
2204 2206
 	 * @return array or false
2205 2207
 	 */
2206 2208
 	public function database_extensions($class){
@@ -3009,7 +3011,7 @@  discard block
 block discarded – undo
3009 3011
 	 * Traverses to a field referenced by relationships between data objects, returning the value
3010 3012
 	 * The path to the related field is specified with dot separated syntax (eg: Parent.Child.Child.FieldName)
3011 3013
 	 *
3012
-	 * @param $fieldName string
3014
+	 * @param string $fieldName string
3013 3015
 	 * @return string | null - will return null on a missing value
3014 3016
 	 */
3015 3017
 	public function relField($fieldName) {
@@ -3078,7 +3080,7 @@  discard block
 block discarded – undo
3078 3080
 	 * @param string $callerClass The class of objects to be returned
3079 3081
 	 * @param string|array $filter A filter to be inserted into the WHERE clause.
3080 3082
 	 * Supports parameterised queries. See SQLSelect::addWhere() for syntax examples.
3081
-	 * @param string|array $sort A sort expression to be inserted into the ORDER
3083
+	 * @param string $sort A sort expression to be inserted into the ORDER
3082 3084
 	 * BY clause.  If omitted, self::$default_sort will be used.
3083 3085
 	 * @param string $join Deprecated 3.0 Join clause. Use leftJoin($table, $joinClause) instead.
3084 3086
 	 * @param string|array $limit A limit expression to be inserted into the LIMIT clause.
@@ -3288,6 +3290,8 @@  discard block
 block discarded – undo
3288 3290
 	/**
3289 3291
 	 * @see $sourceQueryParams
3290 3292
 	 * @param array
3293
+	 * @param string $key
3294
+	 * @param string $value
3291 3295
 	 */
3292 3296
 	public function setSourceQueryParam($key, $value) {
3293 3297
 		$this->sourceQueryParams[$key] = $value;
@@ -3295,6 +3299,7 @@  discard block
 block discarded – undo
3295 3299
 
3296 3300
 	/**
3297 3301
 	 * @see $sourceQueryParams
3302
+	 * @param string $key
3298 3303
 	 * @return Mixed
3299 3304
 	 */
3300 3305
 	public function getSourceQueryParam($key) {
Please login to merge, or discard this patch.
view/ViewableData.php 1 patch
Doc Comments   +6 added lines, -4 removed lines patch added patch discarded remove patch
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
 	/**
145 145
 	 * Get the current failover object if set
146 146
 	 *
147
-	 * @return ViewableData|null
147
+	 * @return ViewableData
148 148
 	 */
149 149
 	public function getFailover() {
150 150
 		return $this->failover;
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
 	 *  - castingHelper: the casting helper for casting the field (e.g. "return new Varchar($fieldName)")
248 248
 	 *
249 249
 	 * @param string $field
250
-	 * @return array
250
+	 * @return string
251 251
 	 */
252 252
 	public function castingHelperPair($field) {
253 253
 		Deprecation::notice('2.5', 'use castingHelper() instead');
@@ -339,7 +339,7 @@  discard block
 block discarded – undo
339 339
 	 *
340 340
 	 * @param string|array|SSViewer $template the template to render into
341 341
 	 * @param array $customFields fields to customise() the object with before rendering
342
-	 * @return HTMLText
342
+	 * @return DBField
343 343
 	 */
344 344
 	public function renderWith($template, $customFields = null) {
345 345
 		if(!is_object($template)) {
@@ -499,6 +499,7 @@  discard block
 block discarded – undo
499 499
 	
500 500
 	/**
501 501
 	 * Return the value of a field in an SQL-safe format.
502
+	 * @param string $field
502 503
 	 */
503 504
 	public function SQL_val($field, $arguments = null, $cache = true) {
504 505
 		return Convert::raw2sql($this->RAW_val($field, $arguments, $cache));
@@ -506,6 +507,7 @@  discard block
 block discarded – undo
506 507
 	
507 508
 	/**
508 509
 	 * Return the value of a field in a JavaScript-save format.
510
+	 * @param string $field
509 511
 	 */
510 512
 	public function JS_val($field, $arguments = null, $cache = true) {
511 513
 		return Convert::raw2js($this->RAW_val($field, $arguments, $cache));
@@ -513,6 +515,7 @@  discard block
 block discarded – undo
513 515
 	
514 516
 	/**
515 517
 	 * Return the value of a field escaped suitable to be inserted into an XML node attribute.
518
+	 * @param string $field
516 519
 	 */
517 520
 	public function ATT_val($field, $arguments = null, $cache = true) {
518 521
 		return Convert::raw2att($this->RAW_val($field, $arguments, $cache));
@@ -523,7 +526,6 @@  discard block
 block discarded – undo
523 526
 	/**
524 527
 	 * Get an array of XML-escaped values by field name
525 528
 	 *
526
-	 * @param array $elements an array of field names
527 529
 	 * @return array
528 530
 	 */
529 531
 	public function getXMLValues($fields) {
Please login to merge, or discard this patch.
forms/FormField.php 1 patch
Doc Comments   +4 added lines, -3 removed lines patch added patch discarded remove patch
@@ -587,6 +587,7 @@  discard block
 block discarded – undo
587 587
 	 *
588 588
 	 * Caution: this doesn't work on all fields, see {@link setAttribute()}.
589 589
 	 *
590
+	 * @param string $name
590 591
 	 * @return null|string
591 592
 	 */
592 593
 	public function getAttribute($name) {
@@ -698,7 +699,6 @@  discard block
 block discarded – undo
698 699
 	 * Set the field value.
699 700
 	 *
700 701
 	 * @param mixed $value
701
-	 * @param null|array|DataObject $data {@see Form::loadDataFrom}
702 702
 	 *
703 703
 	 * @return $this
704 704
 	 */
@@ -1179,6 +1179,7 @@  discard block
 block discarded – undo
1179 1179
 	 * @todo Make this abstract.
1180 1180
 	 *
1181 1181
 	 * @param Validator
1182
+	 * @param RequiredFields $validator
1182 1183
 	 *
1183 1184
 	 * @return bool
1184 1185
 	 */
@@ -1248,7 +1249,7 @@  discard block
 block discarded – undo
1248 1249
 	 *
1249 1250
 	 * @param FieldList $containerFieldList
1250 1251
 	 *
1251
-	 * @return FieldList
1252
+	 * @return FormField
1252 1253
 	 */
1253 1254
 	public function setContainerFieldList($containerFieldList) {
1254 1255
 		$this->containerFieldList = $containerFieldList;
@@ -1433,7 +1434,7 @@  discard block
 block discarded – undo
1433 1434
 	 * Any passed keys that are not defined in {@link getSchemaDataDefaults()} are ignored.
1434 1435
 	 * If you want to pass around ad hoc data use the `data` array e.g. pass `['data' => ['myCustomKey' => 'yolo']]`.
1435 1436
 	 *
1436
-	 * @param array $schemaData - The data to be merged with $this->schemaData.
1437
+	 * @param array $schemaState - The data to be merged with $this->schemaData.
1437 1438
 	 * @return FormField
1438 1439
 	 *
1439 1440
 	 * @todo Add deep merging of arrays like `data` and `attributes`.
Please login to merge, or discard this patch.
admin/code/LeftAndMain.php 1 patch
Doc Comments   +8 added lines, -3 removed lines patch added patch discarded remove patch
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
 	/**
183 183
 	 * Gets the combined configuration of all LeafAndMain subclasses required by the client app.
184 184
 	 *
185
-	 * @return array
185
+	 * @return string
186 186
 	 *
187 187
 	 * WARNING: Experimental API
188 188
 	 */
@@ -675,6 +675,7 @@  discard block
 block discarded – undo
675 675
 	 * Returns the menu title for the given LeftAndMain subclass.
676 676
 	 * Implemented static so that we can get this value without instantiating an object.
677 677
 	 * Menu title is *not* internationalised.
678
+	 * @return string
678 679
 	 */
679 680
 	public static function menu_title_for_class($class) {
680 681
 		$title = Config::inst()->get($class, 'menu_title', Config::FIRST_SET);
@@ -840,6 +841,7 @@  discard block
 block discarded – undo
840 841
 	 * Return a list of appropriate templates for this class, with the given suffix using
841 842
 	 * {@link SSViewer::get_templates_by_class()}
842 843
 	 *
844
+	 * @param string $suffix
843 845
 	 * @return array
844 846
 	 */
845 847
 	public function getTemplatesWithSuffix($suffix) {
@@ -1684,7 +1686,7 @@  discard block
 block discarded – undo
1684 1686
 	 * The controller might not have any previewable content, in which case
1685 1687
 	 * this method returns FALSE.
1686 1688
 	 *
1687
-	 * @return String|boolean
1689
+	 * @return boolean
1688 1690
 	 */
1689 1691
 	public function LinkPreview() {
1690 1692
 		return false;
@@ -1868,7 +1870,7 @@  discard block
 block discarded – undo
1868 1870
 	}
1869 1871
 
1870 1872
 	/**
1871
-	 * @return String
1873
+	 * @return DBField
1872 1874
 	 */
1873 1875
 	public function Locale() {
1874 1876
 		return DBField::create_field('Locale', i18n::get_locale());
@@ -2034,6 +2036,9 @@  discard block
 block discarded – undo
2034 2036
 		return (parent::isFinished() || $this->isFinished);
2035 2037
 	}
2036 2038
 
2039
+	/**
2040
+	 * @param boolean $bool
2041
+	 */
2037 2042
 	public function setIsFinished($bool) {
2038 2043
 		$this->isFinished = $bool;
2039 2044
 	}
Please login to merge, or discard this patch.
thirdparty/tinymce/tinymce.gzip.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -73,7 +73,6 @@  discard block
 block discarded – undo
73 73
 	/**
74 74
 	 * Adds a file to the concatenation/compression process.
75 75
 	 *
76
-	 * @param String $path Path to the file to include in the compressed package/output.
77 76
 	 */
78 77
 	public function &addFile($file) {
79 78
 		$this->files .= ($this->files ? "," : "") . $file;
@@ -218,7 +217,7 @@  discard block
 block discarded – undo
218 217
 	/**
219 218
 	 * Renders a script tag that loads the TinyMCE script.
220 219
 	 *
221
-	 * @param Array $settings Name/value array with settings for the script tag.
220
+	 * @param Array $tagSettings Name/value array with settings for the script tag.
222 221
 	 * @param Bool  $return   The script tag is return instead of being output if true
223 222
 	 * @return String the tag is returned if $return is true  
224 223
 	 */
Please login to merge, or discard this patch.