SilverStripe\Security\MemberAuthenticator\LogoutHandler

Complexity

Total Complexity

3

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	logout()	0	6	1
A	doLogOut()	0	8	2

<?php

namespace SilverStripe\Security\MemberAuthenticator;

use SilverStripe\Control\RequestHandler;
use SilverStripe\Core\Injector\Injector;
use SilverStripe\Security\IdentityStore;
use SilverStripe\Security\Member;
use SilverStripe\Security\Security;

/**
 * Class LogoutHandler handles logging out Members from their session and/or cookie.
 * The logout process destroys all traces of the member on the server (not the actual computer user
 * at the other end of the line, don't worry)
 *
 */
class LogoutHandler extends RequestHandler
{
    /**
     * @var array
     */
    private static $url_handlers = [
        '' => 'logout'
    ];

    /**
     * @var array
     */
    private static $allowed_actions = [
        'logout'
    ];


    /**
     * Log out form handler method
     *
     * This method is called when the user clicks on "logout" on the form
     * created when the parameter <i>$checkCurrentUser</i> of the
     * {@link __construct constructor} was set to TRUE and the user was
     * currently logged in.
     *
     * @return bool|Member
     */
    public function logout()
    {
        $member = Security::getCurrentUser();

        return $this->doLogOut($member);

It seems like $member defined by \SilverStripe\Security\Security::getCurrentUser() on line 46 can be null; however, SilverStripe\Security\MemberAuthenticator\LogoutHandler::doLogOut() does not accept null, maybe add an additional type check?

    }

    /**
     *
     * @param Member $member
     * @return bool|Member Return a member if something goes wrong
     */
    public function doLogOut($member)
    {
        if ($member instanceof Member) {
            Injector::inst()->get(IdentityStore::class)->logOut($this->getRequest());
        }

        return true;
    }
}