silverstripe / silverstripe-framework

src/Dev/CsvBulkLoader.php

Doc Comments +1 added lines, -1 removed lines

@@ -100,7 +100,7 @@
      * @param string $path Path to large file to split
      * @param int $lines Number of lines per file
      *
-     * @return array List of file paths
+     * @return string[] List of file paths
      */
     protected function splitFile($path, $lines = null)
     {

src/Dev/FixtureBlueprint.php

Doc Comments +6 added lines

@@ -304,6 +304,9 @@ 
         return $this;
     }
 
+    /**
+     * @param string $type
+     */
     protected function invokeCallbacks($type, $args = array())
     {
         foreach ($this->callbacks[$type] as $callback) {
@@ -346,6 +349,9 @@ 
         $obj->$name = $this->parseValue($value, $fixtures);
     }
 
+    /**
+     * @param string $fieldName
+     */
     protected function overrideField($obj, $fieldName, $value, $fixtures = null)
     {
         $class = get_class($obj);

src/Dev/SapphireTestReporter.php

Doc Comments +4 added lines, -1 removed lines

@@ -368,7 +368,7 @@ 
      *
      * @param PHPUnit_Framework_Test $test current test that is being run
      * @param Exception $e PHPUnit error
-     * @return array
+     * @return string
      */
     private function getTestException(PHPUnit_Framework_Test $test, Exception $e)
     {
@@ -483,6 +483,9 @@ 
         echo "</div>";
     }
 
+    /**
+     * @param string $name
+     */
     protected function testNameToPhrase($name)
     {
         return ucfirst(preg_replace("/([a-z])([A-Z])/", "$1 $2", $name));

src/Forms/CompositeField.php

Doc Comments +14 added lines

@@ -261,6 +261,9 @@ 
 
 
 
+    /**
+     * @param boolean $disabled
+     */
     public function setDisabled($disabled)
     {
         parent::setDisabled($disabled);
@@ -270,6 +273,9 @@ 
         return $this;
     }
 
+    /**
+     * @param boolean $readonly
+     */
     public function setReadonly($readonly)
     {
         parent::setReadonly($readonly);
@@ -362,6 +368,10 @@ 
         $this->children->removeByName($fieldName, $dataFieldOnly);
     }
 
+    /**
+     * @param string $fieldName
+     * @param FormField $newField
+     */
     public function replaceField($fieldName, $newField)
     {
         return $this->children->replaceField($fieldName, $newField);
@@ -437,6 +447,9 @@ 
         return $clone;
     }
 
+    /**
+     * @return boolean
+     */
     public function IsReadonly()
     {
         return $this->readonly;
@@ -447,6 +460,7 @@ 
      * the children collection. Doesn't work recursively.
      *
      * @param string|FormField
+     * @param string $field
      * @return int Position in children collection (first position starts with 0). Returns FALSE if the field can't
      *             be found.
      */

src/Forms/FormAction.php

Doc Comments +1 added lines

@@ -214,6 +214,7 @@
      * Enable or disable the rendering of this action as a <button />
      *
      * @param boolean
+     * @param boolean $bool
      * @return $this
      */
     public function setUseButtonTag($bool)

src/Forms/GridField/GridField.php

Doc Comments +1 added lines, -1 removed lines

@@ -228,7 +228,7 @@
      *
      * @todo refactor this into GridFieldComponent
      *
-     * @param mixed $value
+     * @param string $value
      * @param string|array $castingDefinition
      *
      * @return mixed

src/Forms/GridField/GridFieldDetailForm_ItemRequest.php

Doc Comments +9 added lines

@@ -92,6 +92,9 @@ 
         parent::__construct();
     }
 
+    /**
+     * @param string $action
+     */
     public function Link($action = null)
     {
         return Controller::join_links(
@@ -341,6 +344,9 @@ 
         return $c;
     }
 
+    /**
+     * @return string
+     */
     protected function getBackLink()
     {
         // TODO Coupling with CMS
@@ -448,6 +454,9 @@ 
         }
     }
 
+    /**
+     * @param integer $errorCode
+     */
     public function httpError($errorCode, $errorMessage = null)
     {
         $controller = $this->getToplevelController();

src/Forms/GridField/GridFieldEditButton.php

Doc Comments +2 added lines, -2 removed lines

@@ -65,7 +65,7 @@ 
      * Which columns are handled by this component
      *
      * @param GridField $gridField
-     * @return array
+     * @return string[]
      */
     public function getColumnsHandled($gridField)
     {
@@ -87,7 +87,7 @@ 
      * @param GridField $gridField
      * @param DataObject $record
      * @param string $columnName
-     * @return string The HTML for the column
+     * @return \SilverStripe\ORM\FieldType\DBHTMLText The HTML for the column
      */
     public function getColumnContent($gridField, $record, $columnName)
     {

src/Forms/GridField/GridFieldExportButton.php

Doc Comments +2 added lines, -2 removed lines

@@ -75,7 +75,7 @@ 
      * export is an action button
      *
      * @param GridField $gridField
-     * @return array
+     * @return string[]
      */
     public function getActions($gridField)
     {
@@ -149,7 +149,7 @@ 
      * Generate export fields for CSV.
      *
      * @param GridField $gridField
-     * @return array
+     * @return string
      */
     public function generateExportFileData($gridField)
     {