Completed
Pull Request — master (#6434)
by Will
08:33
created
src/Forms/HTMLEditor/HTMLEditorSanitiser.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
     /**
53 53
      * Given a TinyMCE pattern (close to unix glob style), create a regex that does the match
54 54
      *
55
-     * @param $str - The TinyMCE pattern
55
+     * @param string|null $str - The TinyMCE pattern
56 56
      * @return string - The equivalent regex
57 57
      */
58 58
     protected function patternToRegex($str)
Please login to merge, or discard this patch.
src/Forms/MoneyField.php 1 patch
Doc Comments   +11 added lines, -1 removed lines patch added patch discarded remove patch
@@ -61,6 +61,10 @@  discard block
 block discarded – undo
61 61
         return $this->fieldAmount;
62 62
     }
63 63
 
64
+    /**
65
+     * @param string $name
66
+     * @param string $title
67
+     */
64 68
     public function __construct($name, $title = null, $value = "")
65 69
     {
66 70
         $this->setName($name);
@@ -136,7 +140,7 @@  discard block
 block discarded – undo
136 140
      *
137 141
      * (see @link MoneyFieldTest_CustomSetter_Object for more information)
138 142
      *
139
-     * @param DataObjectInterface|Object $dataObject
143
+     * @param DataObjectInterface $dataObject
140 144
      */
141 145
     public function saveInto(DataObjectInterface $dataObject)
142 146
     {
@@ -167,6 +171,9 @@  discard block
 block discarded – undo
167 171
         return $clone;
168 172
     }
169 173
 
174
+    /**
175
+     * @param boolean $bool
176
+     */
170 177
     public function setReadonly($bool)
171 178
     {
172 179
         parent::setReadonly($bool);
@@ -211,6 +218,9 @@  discard block
 block discarded – undo
211 218
         return $this->allowedCurrencies;
212 219
     }
213 220
 
221
+    /**
222
+     * @param string $locale
223
+     */
214 224
     public function setLocale($locale)
215 225
     {
216 226
         $this->_locale = $locale;
Please login to merge, or discard this patch.
src/Forms/PrintableTransformation_TabSet.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -8,7 +8,7 @@
 block discarded – undo
8 8
 class PrintableTransformation_TabSet extends TabSet
9 9
 {
10 10
     /**
11
-     * @param array $tabs
11
+     * @param FieldList $tabs
12 12
      */
13 13
     public function __construct($tabs)
14 14
     {
Please login to merge, or discard this patch.
src/Forms/ReadonlyField.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@
 block discarded – undo
83 83
      * If $dontEscape is false the returned value will be safely encoded,
84 84
      * but should not be escaped by the frontend.
85 85
      *
86
-     * @return mixed|string
86
+     * @return string
87 87
      */
88 88
     public function Value()
89 89
     {
Please login to merge, or discard this patch.
src/Forms/SelectionGroup_Item.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -37,6 +37,9 @@  discard block
 block discarded – undo
37 37
         return $this->title;
38 38
     }
39 39
 
40
+    /**
41
+     * @param string $title
42
+     */
40 43
     function setTitle($title)
41 44
     {
42 45
         $this->title = $title;
@@ -48,6 +51,9 @@  discard block
 block discarded – undo
48 51
         return $this->value;
49 52
     }
50 53
 
54
+    /**
55
+     * @param string $Value
56
+     */
51 57
     function setValue($Value)
52 58
     {
53 59
         $this->value = $Value;
Please login to merge, or discard this patch.
src/Forms/TimeField.php 1 patch
Doc Comments   +8 added lines, -1 removed lines patch added patch discarded remove patch
@@ -57,6 +57,10 @@  discard block
 block discarded – undo
57 57
 
58 58
     protected $schemaDataType = FormField::SCHEMA_DATA_TYPE_TIME;
59 59
 
60
+    /**
61
+     * @param string $name
62
+     * @param string $title
63
+     */
60 64
     public function __construct($name, $title = null, $value = "")
61 65
     {
62 66
         if (!$this->locale) {
@@ -231,7 +235,7 @@  discard block
 block discarded – undo
231 235
 
232 236
     /**
233 237
      * @param String $name Optional, returns the whole configuration array if empty
234
-     * @return mixed|array
238
+     * @return string|null
235 239
      */
236 240
     public function getConfig($name = null)
237 241
     {
@@ -250,6 +254,9 @@  discard block
 block discarded – undo
250 254
         return $this->castedCopy('SilverStripe\\Forms\\TimeField_Readonly');
251 255
     }
252 256
 
257
+    /**
258
+     * @param string $class
259
+     */
253 260
     public function castedCopy($class)
254 261
     {
255 262
         $copy = parent::castedCopy($class);
Please login to merge, or discard this patch.
src/Forms/TreeDropdownField.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -238,7 +238,7 @@
 block discarded – undo
238 238
 
239 239
     /**
240 240
      * @param array $properties
241
-     * @return string
241
+     * @return \SilverStripe\ORM\FieldType\DBHTMLText
242 242
      */
243 243
     public function Field($properties = array())
244 244
     {
Please login to merge, or discard this patch.
src/Forms/UploadField.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -304,7 +304,7 @@  discard block
 block discarded – undo
304 304
     /**
305 305
      * Determine if the target folder for new uploads in is visible the field UI.
306 306
      *
307
-     * @return boolean
307
+     * @return boolean|string
308 308
      */
309 309
     public function canPreviewFolder()
310 310
     {
@@ -581,7 +581,7 @@  discard block
 block discarded – undo
581 581
      * Customises a file with additional details suitable for rendering in the
582 582
      * UploadField.ss template
583 583
      *
584
-     * @param ViewableData|AssetContainer $file
584
+     * @param AssetContainer $file
585 585
      * @return ViewableData_Customised
586 586
      */
587 587
     protected function customiseFile(AssetContainer $file)
@@ -690,7 +690,7 @@  discard block
 block discarded – undo
690 690
     /**
691 691
      * Determine if the user has permission to upload.
692 692
      *
693
-     * @return boolean
693
+     * @return boolean|string
694 694
      */
695 695
     public function canUpload()
696 696
     {
@@ -718,7 +718,7 @@  discard block
 block discarded – undo
718 718
      * Determine if the user has permission to attach existing files
719 719
      * By default returns true if the user has the CMS_ACCESS_AssetAdmin permission
720 720
      *
721
-     * @return boolean
721
+     * @return boolean|string
722 722
      */
723 723
     public function canAttachExisting()
724 724
     {
Please login to merge, or discard this patch.
src/i18n/i18n.php 1 patch
Doc Comments   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -2171,6 +2171,7 @@  discard block
 block discarded – undo
2171 2171
 
2172 2172
     /**
2173 2173
      * @param String
2174
+     * @param string $name
2174 2175
      * @return Zend_Translate
2175 2176
      */
2176 2177
     public static function get_translator($name)
@@ -2212,6 +2213,7 @@  discard block
 block discarded – undo
2212 2213
 
2213 2214
     /**
2214 2215
      * @param String
2216
+     * @param string $name
2215 2217
      */
2216 2218
     public static function unregister_translator($name)
2217 2219
     {
@@ -2323,7 +2325,7 @@  discard block
 block discarded – undo
2323 2325
      *
2324 2326
      * @see get_locale_name()
2325 2327
      *
2326
-     * @param mixed $code Language code
2328
+     * @param string $code Language code
2327 2329
      * @param boolean $native If true, the native name will be returned
2328 2330
      * @return string Name of the language
2329 2331
      */
Please login to merge, or discard this patch.