silverstripe / silverstripe-framework

src/Forms/FileField.php

Doc Comments +1 added lines, -1 removed lines

@@ -238,7 +238,7 @@
 
     /**
      * @param array $properties
-     * @return string
+     * @return \SilverStripe\ORM\FieldType\DBHTMLText
      */
     public function Field($properties = array())
     {

src/Forms/UploadReceiver.php

Doc Comments -1 removed lines

@@ -97,7 +97,6 @@
      * for each of these categories
      *
      * @param string $category Category name
-     * @param string,... $categories Additional category names
      * @return $this
      */
     public function setAllowedFileCategories($category)

admin/code/CMSMenu.php

Doc Comments +3 added lines, -3 removed lines

@@ -116,7 +116,7 @@ 
      *                          left.
      * @param array $attributes an array of attributes to include on the link.
      *
-     * @return boolean The result of the operation.
+     * @return boolean|null The result of the operation.
      */
     public static function add_link($code, $menuTitle, $url, $priority = -1, $attributes = null)
     {
@@ -137,7 +137,7 @@ 
      *                    have the rights to access some other part of the admin area.
      * @param int $priority
      * @param array $attributes an array of attributes to include on the link.
-     * @return bool Success
+     * @return boolean|null Success
      */
     public static function add_menu_item(
         $code,
@@ -308,7 +308,7 @@ 
      *                    have the rights to access some other part of the admin area.
      * @param int $priority
      * @param array $attributes an array of attributes to include on the link.
-     * @return bool Success
+     * @return boolean|null Success
      */
     public static function replace_menu_item(
         $code,

admin/code/GroupImportForm.php

Doc Comments +4 added lines

@@ -24,6 +24,10 @@
      */
     protected $group;
 
+    /**
+     * @param SecurityAdmin $controller
+     * @param string $name
+     */
     public function __construct($controller, $name, $fields = null, $actions = null, $validator = null)
     {
         if (!$fields) {

admin/code/MemberImportForm.php

Doc Comments +5 added lines, -1 removed lines

@@ -25,6 +25,10 @@ 
      */
     protected $group;
 
+    /**
+     * @param SecurityAdmin $controller
+     * @param string $name
+     */
     public function __construct($controller, $name, $fields = null, $actions = null, $validator = null)
     {
         if (!$fields) {
@@ -127,7 +131,7 @@ 
     }
 
     /**
-     * @param $group Group
+     * @param Group $group Group
      */
     public function setGroup($group)
     {

admin/code/SecurityAdmin.php

Doc Comments +2 added lines, -2 removed lines

@@ -260,7 +260,7 @@ 
     /**
      * @see SecurityAdmin_MemberImportForm
      *
-     * @return Form
+     * @return null|MemberImportForm
      */
     public function MemberImportForm()
     {
@@ -297,7 +297,7 @@ 
      * @see SecurityAdmin_MemberImportForm
      *
      * @skipUpgrade
-     * @return Form
+     * @return null|GroupImportForm
      */
     public function GroupImportForm()
     {

tests/behat/features/bootstrap/SilverStripe/Framework/Test/Behaviour/CmsFormsContext.php

Doc Comments +1 added lines

@@ -38,6 +38,7 @@
 
     /**
      * Get Mink session from MinkContext
+     * @return \Behat\Mink\Session
      */
     public function getSession($name = null)
     {

tests/php/Assets/Storage/AssetStoreTest/TestStore.php

Doc Comments +6 added lines

@@ -163,6 +163,9 @@ 
     }
 
 
+    /**
+     * @param string $fileID
+     */
     public function getOriginalFilename($fileID)
     {
         return parent::getOriginalFilename($fileID);
@@ -173,6 +176,9 @@ 
         return parent::removeVariant($fileID);
     }
 
+    /**
+     * @param null|string $variant
+     */
     public function getDefaultConflictResolution($variant)
     {
         return parent::getDefaultConflictResolution($variant);

tests/php/Core/Manifest/ConfigManifestTest.php

Doc Comments +2 added lines, -1 removed lines

@@ -25,6 +25,7 @@ 
 
     /**
      * This is a helper method for displaying a relevant message about a parsing failure
+     * @param string $path
      */
     protected function getParsedAsMessage($path)
     {
@@ -50,7 +51,7 @@ 
     /**
      * A helper method to return a mock of the manifest in order to test expectations and reduce dependency
      *
-     * @param  $methods
+     * @param  string[] $methods
      * @return ConfigManifest
      */
     protected function getManifestMock($methods)